- 13 Apr, 2012 2 commits
-
-
Jongmin Kim authored
R=golang-dev, r CC=golang-dev, gri https://golang.org/cl/6010051
-
Gustavo Niemeyer authored
R=golang-dev, remyoudompheng, dsymonds, gustavo, dchest, r, rsc CC=golang-dev https://golang.org/cl/5985059
-
- 12 Apr, 2012 6 commits
-
-
Rob Pike authored
The buffer had 64 bytes but needs one more for the sign. Fixes #3510. R=golang-dev, dave, dsymonds CC=golang-dev https://golang.org/cl/6011057
-
Adam Langley authored
When SNI based certificate selection is enabled, we previously used the default private key even if we selected a non-default certificate. Fixes #3367. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5987058
-
Adam Langley authored
Fixes #3502. R=bradfitz CC=golang-dev https://golang.org/cl/6011046
-
Dmitriy Vyukov authored
benchmark old ns/op new ns/op delta garbage.BenchmarkParser 4370050250 3779668750 -13.51% garbage.BenchmarkParser-2 3713087000 3628771500 -2.27% garbage.BenchmarkParser-4 3519755250 3406349750 -3.22% garbage.BenchmarkParser-8 3386627750 3319144000 -1.99% garbage.BenchmarkTree 493585529 408102411 -17.32% garbage.BenchmarkTree-2 500487176 402285176 -19.62% garbage.BenchmarkTree-4 473238882 361484058 -23.61% garbage.BenchmarkTree-8 486977823 368334823 -24.36% garbage.BenchmarkTree2 31446600 31203200 -0.77% garbage.BenchmarkTree2-2 21469000 21077900 -1.82% garbage.BenchmarkTree2-4 11007600 10899100 -0.99% garbage.BenchmarkTree2-8 7692400 7032600 -8.58% garbage.BenchmarkParserPause 241863263 163249450 -32.50% garbage.BenchmarkParserPause-2 120135418 112981575 -5.95% garbage.BenchmarkParserPause-4 83411552 64580700 -22.58% garbage.BenchmarkParserPause-8 51870697 42207244 -18.63% garbage.BenchmarkTreePause 20940474 13147011 -37.22% garbage.BenchmarkTreePause-2 20115124 11146715 -44.59% garbage.BenchmarkTreePause-4 17217584 7486327 -56.52% garbage.BenchmarkTreePause-8 18258845 7400871 -59.47% garbage.BenchmarkTree2Pause 174067190 172674190 -0.80% garbage.BenchmarkTree2Pause-2 131175809 130615761 -0.43% garbage.BenchmarkTree2Pause-4 95406666 93972047 -1.50% garbage.BenchmarkTree2Pause-8 86056095 85334952 -0.84% garbage.BenchmarkParserLastPause 329932000 324790000 -1.56% garbage.BenchmarkParserLastPause-2 209383000 210456000 +0.51% garbage.BenchmarkParserLastPause-4 113981000 112921000 -0.93% garbage.BenchmarkParserLastPause-8 77967000 76625000 -1.72% garbage.BenchmarkTreeLastPause 29752000 18444000 -38.01% garbage.BenchmarkTreeLastPause-2 24274000 14766000 -39.17% garbage.BenchmarkTreeLastPause-4 19565000 8726000 -55.40% garbage.BenchmarkTreeLastPause-8 21956000 10530000 -52.04% garbage.BenchmarkTree2LastPause 314411000 311945000 -0.78% garbage.BenchmarkTree2LastPause-2 214641000 210836000 -1.77% garbage.BenchmarkTree2LastPause-4 110024000 108943000 -0.98% garbage.BenchmarkTree2LastPause-8 76873000 70263000 -8.60% R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5991049
-
Dmitriy Vyukov authored
This is factored out part of the: https://golang.org/cl/5279048/ (parallel GC) R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5993043
-
Rob Pike authored
It's a common error to reference unexported field names in templates, especially for newcomers. This catches the error at parse time rather than execute time so the rare few who check errors will notice right away. These were always an error, so the net behavior is unchanged. Should break no existing code, just identify the error earlier. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6009048
-
- 11 Apr, 2012 8 commits
-
-
David Symonds authored
adg removed some now-unwanted fields in Package a while ago, but there are still datastore entities with those fields, so we must explicitly check for ErrFieldMismatch and ignore it. R=golang-dev, rsc CC=adg, golang-dev https://golang.org/cl/6007043
-
Nigel Tao authored
below do not support '. This makes package html consistent with package text/template's HTMLEscape function. Fixes #3489. R=rsc, mikesamuel, dsymonds CC=golang-dev https://golang.org/cl/5992071
-
Adam Langley authored
The least common multiple is not totient/gcd. R=remyoudompheng CC=golang-dev https://golang.org/cl/5990045
-
Adam Langley authored
crypto/tls is tested, in part, by replaying recorded TLS connections and checking that the bytes sent by the Go code haven't changed. Previously we used GnuTLS's debug output and extracted the bytes of the TLS connection using a Python script. That wasn't great, and I think GnuTLS removed that level of debugging in a more current release. This change records the connection with Go code and adds a test for ECDHE-AES clients generating using this method. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5988048
-
Marcel van Lohuizen authored
For completeness, we also expose the Canonical Combining Class of a rune. This does not increase the data size. R=r CC=golang-dev https://golang.org/cl/5931043
-
Dave Cheney authored
2011 Mac Mini, Core i5 @ 2.3Ghz BenchmarkConvT2E 50000000 40.4 ns/op BenchmarkConvT2EBig 20000000 107 ns/op BenchmarkConvT2I 100000000 28.9 ns/op BenchmarkConvI2E 500000000 5.93 ns/op BenchmarkConvI2I 100000000 19.0 ns/op BenchmarkAssertE2T 100000000 14.1 ns/op BenchmarkAssertE2TBig 100000000 17.8 ns/op BenchmarkAssertE2I 100000000 21.3 ns/op BenchmarkAssertI2T 100000000 14.3 ns/op BenchmarkAssertI2I 100000000 20.8 ns/op BenchmarkAssertI2E 500000000 5.58 ns/op Pandaboard, 2 x Omap4 @ 1.2Ghz BenchmarkConvT2E 10000000 215 ns/op BenchmarkConvT2EBig 1000000 3697 ns/op BenchmarkConvT2I 5000000 666 ns/op BenchmarkConvI2E 50000000 42.4 ns/op BenchmarkConvI2I 5000000 489 ns/op BenchmarkAssertE2T 20000000 90.0 ns/op BenchmarkAssertE2TBig 20000000 91.6 ns/op BenchmarkAssertE2I 5000000 515 ns/op BenchmarkAssertI2T 20000000 124 ns/op BenchmarkAssertI2I 5000000 517 ns/op BenchmarkAssertI2E 50000000 47.2 ns/op BenchmarkAssertE2E 50000000 42.7 ns/op R=minux.ma, rsc, fullung, bsiegert, dsymonds CC=golang-dev https://golang.org/cl/5777048
-
Joel Sing authored
Update the threxit and thrsleep syscalls to match the ABI of the OpenBSD 5.1 kernel. These changes are backwards compatible with older kernels. Fixes #3311. R=golang-dev, rsc, devon.odell CC=golang-dev https://golang.org/cl/5777079
-
Dave Cheney authored
Fixes #3478. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5986074
-
- 10 Apr, 2012 16 commits
-
-
Shenghou Ma authored
This leads to ~30kB improvement on code size for ARM machines with VFP/NEON. Example: go test -c math GOARM=5 GOARM=6 Old: 1884200 1839144 New: 1884165 1805245 -: 35 33899 R=rsc, bradfitz, dave, kai.backman CC=golang-dev https://golang.org/cl/5975060
-
Shenghou Ma authored
Supported in ARMv5TE and above, excluding ARMv5TExP. For CL 5990066. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5999044
-
Pascal S. de Kloe authored
Feed append the complete content at once. BenchmarkAdler32KB 1000000 2534 ns/op 404.05 MB/s BenchmarkCrc32KB 500000 4757 ns/op 215.26 MB/s BenchmarkCrc64KB 500000 4769 ns/op 214.70 MB/s BenchmarkFnv32KB 1000000 2417 ns/op 423.64 MB/s BenchmarkFnv32aKB 1000000 2408 ns/op 425.23 MB/s BenchmarkFnv64KB 500000 4262 ns/op 240.21 MB/s BenchmarkFnv64aKB 500000 4234 ns/op 241.83 MB/s R=iant, rsc, r, minux.ma CC=golang-dev https://golang.org/cl/5937053
-
Akshat Kumar authored
Change 5660047 moved an FLDCW instruction that disables invalid operand traps into runtime·asminit, which is called from runtime·mstart. Thus, runtime·check is being called prior to setting the appropriate control bits, which on any QNaN comparison will cause Plan 9 to take an invalid operand trap. This change loads the control bits (for Plan 9) prior to runtime·check. Ideally, this should be done before the QNaN checks on any system, but possibly other kernels simply don't ever trap on invalid operands. R=golang-dev, rminnich CC=golang-dev, john, rsc https://golang.org/cl/5939045
-
Russ Cox authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6004043
-
Quan Yong Zhai authored
Part of issue 3381 R=rsc, minux.ma, dave CC=golang-dev https://golang.org/cl/5969064
-
Russ Cox authored
Without an explicit signal for a truncation, copy propagation will sometimes propagate a 32-bit truncation and end up overwriting uses of the original 64-bit value. The case that arose in practice is in C but I believe that the same could plausibly happen in Go. The main reason we didn't run into the same in Go is that I (perhaps incorrectly?) drop MOVL AX, AX during gins, so the truncation was never generated, so it didn't confuse the optimizer. Fixes #1315. Fixes #3488. R=ken2 CC=golang-dev https://golang.org/cl/6002043
-
Russ Cox authored
This is a pointer being copied; MOVL can't possibly be right. R=ken2 CC=golang-dev https://golang.org/cl/5999043
-
Russ Cox authored
Assignment of a computed uint64 value to an address derived with a function call was executing the call after computing the value, which trashed the value (held in registers). long long *f(void) { return 0; } void g(int x, int y) { *f() = (long long)x | (long long)y<<32; } Before: (x.c:3) TEXT g+0(SB),(gok(71)) ... (x.c:4) ORL AX,DX (x.c:4) ORL CX,BX (x.c:4) CALL ,f+0(SB) (x.c:4) MOVL DX,(AX) (x.c:4) MOVL BX,4(AX) After: (x.c:3) TEXT g+0(SB),(gok(71)) (x.c:4) CALL ,f+0(SB) ... (x.c:4) ORL CX,BX (x.c:4) ORL DX,BP (x.c:4) MOVL BX,(AX) (x.c:4) MOVL BP,4(AX) Fixes #3501. R=ken2 CC=golang-dev https://golang.org/cl/5998043
-
Shenghou Ma authored
Fixes #3379. R=golang-dev, alex.brainman, rsc, bradfitz CC=golang-dev https://golang.org/cl/5909043
-
Shenghou Ma authored
R=bradfitz, rsc CC=golang-dev https://golang.org/cl/5991081
-
Russ Cox authored
R=ken2 CC=golang-dev https://golang.org/cl/5992082
-
Russ Cox authored
R=ken2 CC=golang-dev https://golang.org/cl/5989073
-
Joel Sing authored
Block signals during thread creation, otherwise the new thread can receive a signal prior to initialisation completing. Fixes #3102. R=golang-dev, rsc, devon.odell, minux.ma CC=golang-dev https://golang.org/cl/5757064
-
Rob Pike authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5989063
-
Alex Brainman authored
Fixes #3482. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5987070
-
- 09 Apr, 2012 8 commits
-
-
Rob Pike authored
It is a bug that Caller and Callers disagree about the offset of the skip parameter. Document the bug. R=rsc, dsymonds, r, iant CC=golang-dev https://golang.org/cl/5976064
-
Alexey Borzenkov authored
On windows Mercurial installed with easy_install typically creates an hg.bat batch file in Python Scripts directory, which cannot be used with CreateProcess unless full path is specified. Work around by launching hg via cmd.exe /c. Additionally, fix a rare FormatMessageW crash. Fixes #3093. R=golang-dev, rsc, alex.brainman, aram, jdpoirier, mattn.jp CC=golang-dev https://golang.org/cl/5937043
-
Benny Siegert authored
* sort imports * use runtime.GOROOT * fix some typos R=golang-dev, dave, rsc CC=golang-dev https://golang.org/cl/5987054
-
Brad Fitzpatrick authored
This fixes all.bash on shared machines. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5992078
-
Shenghou Ma authored
Fixes #3445. R=golang-dev, rsc, mtj CC=golang-dev https://golang.org/cl/5975061
-
Shenghou Ma authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5989065
-
Shenghou Ma authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5986063
-
Dmitriy Vyukov authored
make MHeap.allspans an array instead on a linked-list, it's required for parallel for benchmark old ns/op new ns/op delta garbage.BenchmarkTree 494435529 487962705 -1.31% garbage.BenchmarkTree-2 499652705 485358000 -2.86% garbage.BenchmarkTree-4 468482117 454093117 -3.07% garbage.BenchmarkTree-8 488533235 471872470 -3.41% garbage.BenchmarkTree-16 507835176 492558470 -3.01% garbage.BenchmarkTree2 31453900 31404300 -0.16% garbage.BenchmarkTree2-2 21440600 21477000 +0.17% garbage.BenchmarkTree2-4 10982000 11117400 +1.23% garbage.BenchmarkTree2-8 7544700 7456700 -1.17% garbage.BenchmarkTree2-16 7049500 6805700 -3.46% garbage.BenchmarkParser 4448988000 4453264000 +0.10% garbage.BenchmarkParser-2 4086045000 4057948000 -0.69% garbage.BenchmarkParser-4 3677365000 3661246000 -0.44% garbage.BenchmarkParser-8 3517253000 3540190000 +0.65% garbage.BenchmarkParser-16 3506562000 3463478000 -1.23% garbage.BenchmarkTreePause 20969784 21100238 +0.62% garbage.BenchmarkTreePause-2 20215875 20139572 -0.38% garbage.BenchmarkTreePause-4 17240709 16683624 -3.23% garbage.BenchmarkTreePause-8 18196386 17639306 -3.06% garbage.BenchmarkTreePause-16 20621158 20215056 -1.97% garbage.BenchmarkTree2Pause 173992142 173872380 -0.07% garbage.BenchmarkTree2Pause-2 131281904 131366666 +0.06% garbage.BenchmarkTree2Pause-4 93484952 95109619 +1.74% garbage.BenchmarkTree2Pause-8 88950523 86533333 -2.72% garbage.BenchmarkTree2Pause-16 86071238 84089190 -2.30% garbage.BenchmarkParserPause 135815000 135255952 -0.41% garbage.BenchmarkParserPause-2 92691523 91451428 -1.34% garbage.BenchmarkParserPause-4 53392190 51611904 -3.33% garbage.BenchmarkParserPause-8 36059523 35116666 -2.61% garbage.BenchmarkParserPause-16 30174300 27340600 -9.39% garbage.BenchmarkTreeLastPause 28420000 29142000 +2.54% garbage.BenchmarkTreeLastPause-2 23514000 26779000 +13.89% garbage.BenchmarkTreeLastPause-4 21773000 18660000 -14.30% garbage.BenchmarkTreeLastPause-8 24072000 21276000 -11.62% garbage.BenchmarkTreeLastPause-16 25149000 28541000 +13.49% garbage.BenchmarkTree2LastPause 314491000 313982000 -0.16% garbage.BenchmarkTree2LastPause-2 214363000 214715000 +0.16% garbage.BenchmarkTree2LastPause-4 109778000 111115000 +1.22% garbage.BenchmarkTree2LastPause-8 75390000 74522000 -1.15% garbage.BenchmarkTree2LastPause-16 70333000 67880000 -3.49% garbage.BenchmarkParserLastPause 327247000 326815000 -0.13% garbage.BenchmarkParserLastPause-2 217039000 212529000 -2.08% garbage.BenchmarkParserLastPause-4 119722000 111535000 -6.84% garbage.BenchmarkParserLastPause-8 70806000 69613000 -1.68% garbage.BenchmarkParserLastPause-16 62813000 48009000 -23.57% R=rsc, r CC=golang-dev https://golang.org/cl/5992055
-