- 14 May, 2016 5 commits
-
-
Konstantin Shaposhnikov authored
Updates #14047 Change-Id: I4b150533393bfb90e840497095ac32bcca4f04c2 Reviewed-on: https://go-review.googlesource.com/23114 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Austin Clements authored
Currently the heapBitsSetType documentation says that there are no races on the heap bitmap, but that isn't exactly true. There are no *write-write* races, but there are read-write races. Expand the documentation to explain this and why it's okay. Change-Id: Ibd92b69bcd6524a40a9dd4ec82422b50831071ed Reviewed-on: https://go-review.googlesource.com/23092Reviewed-by:
Rick Hudson <rlh@golang.org>
-
Austin Clements authored
Currently we only execute a publication barrier for scan objects (and skip it for noscan objects). This used to be okay because GC would never consult the object itself (so it wouldn't observe uninitialized memory even if it found a pointer to a noscan object), and the heap bitmap was pre-initialized to noscan. However, now we explicitly initialize the heap bitmap for noscan objects when we allocate them. While the GC will still never consult the contents of a noscan object, it does need to see the initialized heap bitmap. Hence, we need to execute a publication barrier to make the bitmap visible before user code can expose a pointer to the newly allocated object even for noscan objects. Change-Id: Ie4133c638db0d9055b4f7a8061a634d970627153 Reviewed-on: https://go-review.googlesource.com/23043 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Mikio Hara authored
Fixes #6879. Change-Id: I9ed2460cf14cb9322d9521e7af910efa48abdaf0 Reviewed-on: https://go-review.googlesource.com/23112 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Tom Bergan authored
This fixes change https://go-review.googlesource.com/#/c/23069/, which assumes all DNS requests are UDP. This is not true -- DNS requests can be TCP in some cases. See: https://tip.golang.org/src/net/dnsclient_unix.go#L154 https://en.wikipedia.org/wiki/Domain_Name_System#Protocol_transport Also, the test code added by the above change doesn't actually test anything because the test uses a faked DNS resolver that doesn't actually make any DNS queries. I fixed that by adding another test that uses the system DNS resolver. Updates #12580 Change-Id: I6c24c03ebab84d437d3ac610fd6eb5353753c490 Reviewed-on: https://go-review.googlesource.com/23101Reviewed-by:
-
- 13 May, 2016 5 commits
-
-
David Crawshaw authored
By picking up a spurious tFlagExtraStar, the method type was printing as unc instead of func. Updates #15673 Change-Id: I0c2c189b99bdd4caeb393693be7520b8e3f342bf Reviewed-on: https://go-review.googlesource.com/23103Reviewed-by:
-
Mikio Hara authored
This reverts commit 7af2ce3f. The commit had a wrong prefix in the description line, probably misreconginized something. As a result it broke golang.org/x/tools/godoc and golang.org/x/tools/cmd/godoc like the following: --- FAIL: TestCLI (10.90s) --- FAIL: TestWeb (13.74s) FAIL FAIL golang.org/x/tools/cmd/godoc 36.428s --- FAIL: TestCommandLine (0.00s) FAIL FAIL golang.org/x/tools/godoc 0.068s Change-Id: I362a862a4ded8592dec7488a28e7a256adee148f Reviewed-on: https://go-review.googlesource.com/23076 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Dmitry Vyukov authored
Change-Id: Iaf455d1a2863ff752e0c398e1c364373b4d36614 Reviewed-on: https://go-review.googlesource.com/23084Reviewed-by:
Dmitry Vyukov <dvyukov@google.com>
-
Brad Fitzpatrick authored
The httptrace.ConnectStart and ConnectDone hooks are just about the post-DNS connection to the host. We were accidentally also firing on the UDP dials to DNS. Exclude those for now. We can add them back later as separate hooks if desired. (but they'd only work for pure Go DNS) This wasn't noticed earlier because I was developing on a Mac at the time, which always uses cgo for DNS. When running other tests on Linux, I started seeing UDP dials. Updates #12580 Change-Id: I2b2403f2483e227308fe008019f1100f6300250b Reviewed-on: https://go-review.googlesource.com/23069Reviewed-by:
-
Alex Brainman authored
Change-Id: I6610b872578d161e535565258039d9f064f01456 Reviewed-on: https://go-review.googlesource.com/23070Reviewed-by:
Nigel Tao <nigeltao@golang.org> Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 12 May, 2016 11 commits
-
-
Andrew Gerrand authored
Return an error message instead of eating memory and eventually triggering a stack overflow. Fixes #15618 Change-Id: I3dcf1d669104690a17847a20fbfeb6d7e39e8751 Reviewed-on: https://go-review.googlesource.com/23091Reviewed-by:
Rob Pike <r@golang.org>
-
Mohit Agarwal authored
Change-Id: Iae4855c52c4da9755277251d22121226507ea26a Reviewed-on: https://go-review.googlesource.com/23074Reviewed-by:
-
Emmanuel Odeke authored
Re-apply @adg's CL https://golang.org/cl/7129048 that was previously disabled in https://golang.org/cl/7235052 because it broke `godoc net/http` for go1.1. Currently `godoc net/http` seems to work fine with this CL. Fixes #3428. Change-Id: I7df06df02fd62dededac6ec60bea62561be59cf1 Reviewed-on: https://go-review.googlesource.com/23013 Run-TryBot: Andrew Gerrand <adg@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Dmitry Vyukov authored
Trace viewer cannot handle traces larger than 256MB (limit on js string size): https://github.com/catapult-project/catapult/issues/627 And even that is problematic (chrome hangs and crashes). Split large traces into 100MB parts. Somewhat clumsy, but I don't see any other solution (other than rewriting trace viewer). At least it works reliably now. Fixes #15482 Change-Id: I993b5f43d22072c6f5bd041ab5888ce176f272b2 Reviewed-on: https://go-review.googlesource.com/22731Reviewed-by:
Hyang-Ah Hana Kim <hyangah@gmail.com>
-
Aliaksandr Valialkin authored
Updates #11041 Change-Id: I4e1c670d2b7fc04927d77c6f933cee39b7d48b6e Reviewed-on: https://go-review.googlesource.com/23083Reviewed-by:
-
Michael Munday authored
Step 5 was deleted in f3575a95 however the numbering of the other steps wasn't adjusted accordingly. While we're here: clean up the whitespace, add curly braces where appropriate and delete semicolons. Change-Id: I4e77b2d3ee8460abe4bfb993674f83e35be8ff17 Reviewed-on: https://go-review.googlesource.com/23066Reviewed-by:
-
Aliaksandr Valialkin authored
Updates #11041 Change-Id: I32a381854e6a4fd791db380150efab57e6dfc38c Reviewed-on: https://go-review.googlesource.com/23081Reviewed-by:
-
Aliaksandr Valialkin authored
Updates #11041 Change-Id: I7f2583d08f344d6622027c5e8a5de1f5d2f2881c Reviewed-on: https://go-review.googlesource.com/23082Reviewed-by:
-
Aliaksandr Valialkin authored
Updated #11041 Change-Id: I4a110ba8fefb367a1049b4a65dd20c39eb890ea2 Reviewed-on: https://go-review.googlesource.com/23080Reviewed-by:
-
Joel Sing authored
In future releases of OpenBSD, the sigreturn syscall will no longer exist. As such, stop using sigreturn on openbsd/386 and just return from the signal trampoline (as we already do for openbsd/amd64 and openbsd/arm). Change-Id: Ic4de1795bbfbfb062a685832aea0d597988c6985 Reviewed-on: https://go-review.googlesource.com/23024Reviewed-by:
-
Alex Brainman authored
Updates #15167 Change-Id: I826f67e75011ba79325a1294ac0d70d7c6a3e32f Reviewed-on: https://go-review.googlesource.com/23022Reviewed-by:
-
- 11 May, 2016 17 commits
-
-
Robert Griesemer authored
Minor cleanup. Each of these cases appears both during export and import when running all.bash and thus is tested by all.bash. Change-Id: Iaa4a5a5b163cefe33e43d08d396e02a02e5c22a5 Reviewed-on: https://go-review.googlesource.com/23060Reviewed-by:
Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Brad Fitzpatrick authored
Fixes #15647 Change-Id: I588bfa4eb336d1da1fcda8d06e32ed13c0b51c70 Reviewed-on: https://go-review.googlesource.com/23061 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
-
Johan Sageryd authored
Change-Id: I4ccfaa16e153aad001d670891b3848264e63cf6f Reviewed-on: https://go-review.googlesource.com/23031Reviewed-by:
-
Robert Griesemer authored
This is addressing feedback given on golang.org/cl/23052; we do it in a separate CL to separate the functional from the rename change. ONAME was not used in the export data, but it's the natural node op where we used OPACK instead. Renamed. Furthermore, OPACK and ONONAME nodes are replaced by the type checker with ONAME nodes, so OPACK nodes cannot occur when exporting type-checked code. Removed a special-case for OPACK nodes since they don't appear. Change-Id: I78b01a1badbf60e9283eaadeca2578a65d28cbd2 Reviewed-on: https://go-review.googlesource.com/23053 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Robert Griesemer authored
Fixes #15646. Change-Id: Ic13d1adc0a358149209195cdb03811eeee506fb8 Reviewed-on: https://go-review.googlesource.com/23052 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Joe Tsai authored
The pprof tools properly cleans up all files it creates, but forgets to clean up the temporary directory itself. This CL fixes that. Fixes #13863 Change-Id: I1151c36cdad5ace7cc97e7e04001cf0149ef0f63 Reviewed-on: https://go-review.googlesource.com/23019Reviewed-by:
-
Marc-Antoine Ruel authored
Include integration test. Confirmed that without the fix, the test case TestDeleteReadOnly fails. This permits to revert "cmd/go: reset read-only flag during TestIssue10952" This reverts commit 3b7841b3. Fixes #9606 Change-Id: Ib55c151a8cf1a1da02ab18c34a9b58f615c34254 Reviewed-on: https://go-review.googlesource.com/18235Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #14981 Change-Id: I39b906d119ca96815801a0fbef2dbe524a3246ff Reviewed-on: https://go-review.googlesource.com/23009Reviewed-by:
-
Ian Lance Taylor authored
The //extern comments are incorrect and cause undefined symbol errorswhen building cgo code with -compiler=gccgo. The code is already designed to use weak references, and that support relies on the cgo check functions being treated as local functions. Change-Id: Ib38a640cc4ce6eba74cfbf41ba7147ec88769ec0 Reviewed-on: https://go-review.googlesource.com/23014 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Summary: Go's HTTP/1.x server closes the request body once writes are flushed. Go's HTTP/2 server supports concurrent read & write. Added a TODO to make the HTTP/1.x server also support concurrent read+write. But for now, document it. Updates #15527 Change-Id: I81f7354923d37bfc1632629679c75c06a62bb584 Reviewed-on: https://go-review.googlesource.com/23011Reviewed-by:
-
Hiroshi Ioka authored
Change-Id: Ia2f61427b1cc09064ac4c0563bccbd9b98767a0e Reviewed-on: https://go-review.googlesource.com/18118Reviewed-by:
-
Mikio Hara authored
Change-Id: I323231f31c4e1e7415661ebd943a90b2f1e9da1c Reviewed-on: https://go-review.googlesource.com/23020Reviewed-by:
-
Mikio Hara authored
This change reorganizes test cases for surveying network interfaces and address prefixes to make sure which part of the functionality is broken. Updates #7849. Change-Id: If6918075802eef69a7f1ee040010b3c46f4f4b97 Reviewed-on: https://go-review.googlesource.com/22990Reviewed-by:
-
David du Colombier authored
This reverts commit a677724e. Change-Id: I6a54ac26a6deca5b2a39ec9f899469a88b543d3d Reviewed-on: https://go-review.googlesource.com/22980Reviewed-by:
-
Alex Brainman authored
Also run "go generate" in internal/syscall/windows and internal/syscall/windows/registry Updates #15167 Change-Id: I0109226962f81857fe11d308b869d561ea8ed9f9 Reviewed-on: https://go-review.googlesource.com/23021Reviewed-by:
-
Robert Griesemer authored
The importer uses a global (shared) package map across multiple imports to determine if a package was imported before. That package map is usually indexed by package (import) path ('id' in this code). However, the binary importer was using the incoming (possibly unclean) path. Fixes #15517. Change-Id: I0c32a708dfccf345e0353fbda20ad882121e437c Reviewed-on: https://go-review.googlesource.com/23012 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: -
Alex Brainman authored
The -systemdll and -xsys flags generate broken code in some situations (see issue for details). Fix all that. This CL only fixes bugs in existing code, but I have more changes comming: golang.org/x/sys/windows is not the only package that uses mksyscall_windows.go. golang.org/x/exp/shiny and github.com/derekparker/delve do too. I also have few personal packages that use mksyscall_windows.go. None of those packages are aware of new -xsys flag. I would like to change mksyscall_windows.go, so external packages do not need to use -xsys flag. I would love to get rid of -xsys flag altogether, but I don't see how it is possible. So I will, probably, replace -xsys with a flag that means opposite to -xsys, and use new flag everywhere in standard libraries. Flag name suggestions are welcome. -systemdll flag makes users code more "secure". I would like to make -systemdll behaviour a default for all mksyscall_windows.go users. We use that already in standard library. If we think "secure" is important, we should encourage it in all users code. If mksyscall_windows.go user insist on using old code, provide -use_old_loaddll (need good name here) flag for that. So -systemdll flag will be replaced with -use_old_loaddll. Fixes #15167 Change-Id: I516369507867358ba1b66aabe00a17a7b477016e Reviewed-on: https://go-review.googlesource.com/21645Reviewed-by:
-
- 10 May, 2016 2 commits
-
-
Brad Fitzpatrick authored
Noticed and fix by Alex Brainman. Tested in https://golang.org/cl/23005 (which makes all compiler warnings fatal during development) Fixes #15623 Change-Id: Ic19999fce8bb8640d963965cc328574efadd7855 Reviewed-on: https://go-review.googlesource.com/23010Reviewed-by:
Alex Brainman <alex.brainman@gmail.com>
-
Ian Lance Taylor authored
Instead of exporting the C function mygetgrouplist as a global symbol to conflict with other symbols of the same name, use trivial Go code and a static C function. Change-Id: I98dd667814d0a0ed8f7b1d4cfc6483d5a6965b26 Reviewed-on: https://go-review.googlesource.com/23008 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
