- 06 Aug, 2014 4 commits
-
-
Matthew Dempsky authored
Instead of immediately completing pointer type mappings, add them to a queue to allow them to be completed later. This fixes issues caused by Type() returning arbitrary in-progress type mappings. Fixes #8368. Fixes #8441. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/122850043
-
Matthew Dempsky authored
Instead of including <sys/types.h> to get size_t, instead include the ISO C standard <stddef.h> header, which defines fewer additional types at risk of colliding with the user code. In particular, this prevents collisions between <sys/types.h>'s userspace definitions with the kernel definitions needed by defs_linux.go. Also, -cdefs mode uses #pragma pack, so we can keep misaligned fields. Fixes #8477. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/120610043
-
Mikio Hara authored
Before fixing issue 6579 this CL separates DNS transport from DNS message interaction to make it easier to add builtin DNS resolver control logic. Update #6579 LGTM=alex, kevlar R=golang-codereviews, alex, gobot, iant, minux, kevlar CC=golang-codereviews https://golang.org/cl/101220044
-
Ian Lance Taylor authored
Update #6677 When a struct contains an anonymous union, use the type and name of the first field in the union. This should make the glibc <sys/resource.h> file work; in that file struct rusage has fields like __extension__ union { long int ru_maxrss; __syscall_slong_t __ru_maxrss_word; }; in which the field that matters is ru_maxrss and __ru_maxrss_word just exists to advance to the next field on systems where the kernel uses long long fields but userspace expects long fields. LGTM=mikioh.mikioh R=golang-codereviews, mikioh.mikioh CC=golang-codereviews https://golang.org/cl/106260044
-
- 05 Aug, 2014 16 commits
-
-
Dmitriy Vyukov authored
We call scanblock for lots of small root pieces e.g. for every stack frame args and locals area. Every scanblock invocation calls getempty/putempty, which accesses lock-free stack shared among all worker threads. One-element local cache allows most scanblock calls to proceed without accessing the shared stack. LGTM=rsc R=golang-codereviews, rlh CC=golang-codereviews, khr, rsc https://golang.org/cl/121250043
-
Rui Ueyama authored
If the process exits before the spawned goroutine completes, it'll miss the data race. LGTM=bradfitz R=bradfitz CC=dvyukov, golang-codereviews https://golang.org/cl/122120043
-
Adam Langley authored
CC=golang-codereviews https://golang.org/cl/116710043
-
Brad Fitzpatrick authored
Camlistore uses this pattern to do streaming writes, as do others I imagine, and it was broken by the lazy boundary change. LGTM=dvyukov, ruiu R=ruiu, dvyukov CC=golang-codereviews, mathieu.lonjaret https://golang.org/cl/116690043
-
Brad Fitzpatrick authored
Breaks Camlistore by introducing a datarace. See comments on https://golang.org/cl/95760043/ for details. I'll add a new test to lock-in the current behavior in a subsequent CL. I don't think Camlistore is particularly unique here: it's doing the obvious thing to stream a multipart body to a server using a goroutine feeding the multipart writer. ««« original CL description mime/multipart: delay reading random source If a user sets his/her own boundary string with SetBoundary, we don't need to call randomBoundary at all. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/95760043 »»» LGTM=ruiu R=ruiu CC=golang-codereviews, mathieu.lonjaret https://golang.org/cl/117600043
-
Adam Langley authored
Fixes #6736. LGTM=mikioh.mikioh R=bradfitz, mikioh.mikioh CC=golang-codereviews https://golang.org/cl/108710046
-
Dmitriy Vyukov authored
We have an autogenerated version in zruntime_defs. I am not sure what are the consequences as gdb never printed any values for me. But it looks unnecessary to manually duplicate it. LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews, iant, khr https://golang.org/cl/115660043
-
Robert Griesemer authored
Technically a language change, this cleanup is a completely backward compatible change that brings the boolean results of comma-ok expressions in line with the boolean results of comparisons: they are now all untyped booleans. The implementation effort should be minimal (less than a handfull lines of code, depending how well factored the implementation of comma-ok expressions is). Fixes #8189. LGTM=iant, r, rsc R=r, rsc, iant, ken CC=golang-codereviews https://golang.org/cl/112320045
-
Adam Langley authored
Generated by a+c. R=gobot CC=golang-codereviews https://golang.org/cl/121240043
-
Dmitriy Vyukov authored
With the recent GC changes large objects are handled somewhat differently. LGTM=khr R=khr CC=golang-codereviews https://golang.org/cl/114600043
-
Dmitriy Vyukov authored
LGTM=bradfitz, khr R=khr, bradfitz CC=golang-codereviews https://golang.org/cl/120400043
-
Ian Lance Taylor authored
For consistency with other code, as that was the only use of memcopy outside of alg.goc. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/122030044
-
Ian Lance Taylor authored
LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/120570043
-
Ian Lance Taylor authored
LGTM=minux, dave R=golang-codereviews, minux, dave CC=golang-codereviews https://golang.org/cl/122030043
-
Ian Lance Taylor authored
The gccgo version of USED only accepts a single variable, so this simplifies merging. LGTM=minux, dave R=golang-codereviews, minux, dave CC=golang-codereviews https://golang.org/cl/115630043
-
Ian Lance Taylor authored
The gccgo compiler used to fail this test. This was the root cause of http://gcc.gnu.org/PR61308 . The fix for the gccgo compiler is https://golang.org/cl/122020043 . LGTM=dave, bradfitz R=golang-codereviews, dave, bradfitz CC=golang-codereviews https://golang.org/cl/121200043
-
- 04 Aug, 2014 2 commits
-
-
Brad Fitzpatrick authored
Popular tools both add incorrect trailing zeroes to the zip extras, and popular tools accept trailing zeros. We seemed to be the only ones being strict here. Stop being strict. :( Fixes #8186 LGTM=ruiu, adg, dave R=adg, ruiu, dave CC=frohrweck, golang-codereviews https://golang.org/cl/117550044
-
Mikio Hara authored
This CL removes sockaddrToAddr functions from socket creation operations to avoid the bug like issue 7183. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/105100046
-
- 03 Aug, 2014 1 commit
-
-
Rob Pike authored
Avoid some pressure on the global mutex by lifting the call to userType out of the closure. TOTH to Matt Harden. LGTM=crawshaw, ruiu R=golang-codereviews, crawshaw, ruiu CC=golang-codereviews https://golang.org/cl/117520043
-
- 02 Aug, 2014 1 commit
-
-
Brad Fitzpatrick authored
LGTM=r R=golang-codereviews, r CC=adg, golang-codereviews https://golang.org/cl/118550043
-
- 01 Aug, 2014 5 commits
-
-
Peter Collingbourne authored
LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/117470043
-
Keith Randall authored
A good cleanup anyway, and it makes some room for an additional field needed for issue 8412. Update #8412 LGTM=iant R=iant, khr CC=golang-codereviews https://golang.org/cl/112700043
-
David du Colombier authored
LGTM=josharian, r R=golang-codereviews, josharian, r CC=golang-codereviews https://golang.org/cl/120160043
-
Josh Bleecher Snyder authored
6a and 8a rearrange memmove such that the fallthrough from move_1or2 to move_0 ends up being a JMP to a RET. Insert an explicit RET to prevent such silliness. Do the same for memclr as prophylaxis. benchmark old ns/op new ns/op delta BenchmarkMemmove1 4.59 4.13 -10.02% BenchmarkMemmove2 4.58 4.13 -9.83% LGTM=khr R=golang-codereviews, dvyukov, minux, ruiu, bradfitz, khr CC=golang-codereviews https://golang.org/cl/120930043
-
Alex Brainman authored
Update #6007. LGTM=minux, dvyukov R=golang-codereviews, dvyukov, patrick, aram.h, minux CC=golang-codereviews https://golang.org/cl/108700045
-
- 31 Jul, 2014 11 commits
-
-
Keith Randall authored
TBR=dvyukov CC=golang-codereviews https://golang.org/cl/122740044
-
Keith Randall authored
Create proper closures so hash functions can be called directly from Go. Rearrange calling convention so return value is directly accessible. LGTM=dvyukov R=golang-codereviews, dvyukov, dave, khr CC=golang-codereviews https://golang.org/cl/119360043
-
Rui Ueyama authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/119340043
-
Keith Randall authored
Fixes #8297 LGTM=bradfitz R=golang-codereviews, bradfitz, khr, dave, dvyukov CC=golang-codereviews https://golang.org/cl/119240043
-
Keith Randall authored
int(maxMem) is negative on 32 bits. Need to use unsigned arithmetic. TBR=bradfitz CC=golang-codereviews https://golang.org/cl/121000045
-
Keith Randall authored
LGTM=bradfitz, dvyukov R=golang-codereviews, bradfitz, dvyukov CC=golang-codereviews https://golang.org/cl/120190044
-
Josh Bleecher Snyder authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/118480044
-
Keith Randall authored
Cleanup from recent malloc changes. LGTM=dvyukov R=dvyukov CC=golang-codereviews https://golang.org/cl/120960043
-
Dmitriy Vyukov authored
Several reasons: 1. Significantly simplifies runtime. 2. This code proved to be buggy. 3. Free is incompatible with bump-the-pointer allocation. 4. We want to write runtime in Go, Go does not have free. 5. Too much code to free env strings on startup. LGTM=khr R=golang-codereviews, josharian, tracey.brendan, khr CC=bradfitz, golang-codereviews, r, rlh, rsc https://golang.org/cl/116390043
-
Nigel Tao authored
LGTM=dsymonds R=dsymonds CC=golang-codereviews https://golang.org/cl/120980043
-
Keith Randall authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/121920043
-