Commits · 0eb42fa6e45b09e650a0abca24da7916a3e23384 · go / golang

13 Nov, 2012 9 commits

cmd/api: use one token.FileSet for all contexts · 0eb42fa6
Brad Fitzpatrick authored Nov 13, 2012
```
Prep for future CL.

R=gri
CC=golang-dev
https://golang.org/cl/6843048
```
0eb42fa6

runtime: allow up to 128 GB of allocated memory · 9799a5a4

Russ Cox authored Nov 13, 2012

Incorporates code from CL 6828055.

Fixes #2142.

R=golang-dev, iant, devon.odell
CC=golang-dev
https://golang.org/cl/6826088

9799a5a4

syscall: regenerate z-files for openbsd/amd64 · fc5e64cb

Joel Sing authored Nov 13, 2012

Regenerate z-files for OpenBSD/amd64 on OpenBSD 5.2.

R=golang-dev, bradfitz, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/6843045

fc5e64cb

doc: link to Go coding screencast · 6f9609ab
Andrew Gerrand authored Nov 13, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6849046
```
6f9609ab

net: consolidate common socket functions for Plan 9 · 306afc77

Mikio Hara authored Nov 13, 2012

This CL extends changeset 13126:fc4a62e14aba to Plan 9.

R=ality, golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6820124

306afc77

cmd/8g: eliminate obviously useless temps before regopt. · fa316ba4

Rémy Oudompheng authored Nov 13, 2012

This patch introduces a sort of pre-regopt peephole optimization.
When a temporary is introduced that just holds a value for the
duration of the next instruction and is otherwise unused, we
elide it to make the job of regopt easier.

Since x86 has very few registers, this situation happens very
often. The result is large savings in stack variables for
arithmetic-heavy functions.

crypto/aes

benchmark                 old ns/op    new ns/op    delta
BenchmarkEncrypt               1301          392  -69.87%
BenchmarkDecrypt               1309          368  -71.89%
BenchmarkExpand                2913         1036  -64.44%
benchmark                  old MB/s     new MB/s  speedup
BenchmarkEncrypt              12.29        40.74    3.31x
BenchmarkDecrypt              12.21        43.37    3.55x

crypto/md5

benchmark                 old ns/op    new ns/op    delta
BenchmarkHash8Bytes            1761          914  -48.10%
BenchmarkHash1K               16912         5570  -67.06%
BenchmarkHash8K              123895        38286  -69.10%
benchmark                  old MB/s     new MB/s  speedup
BenchmarkHash8Bytes            4.54         8.75    1.93x
BenchmarkHash1K               60.55       183.83    3.04x
BenchmarkHash8K               66.12       213.97    3.24x

bench/go1

benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17    8364835000   8303154000   -0.74%
BenchmarkFannkuch11      7511723000   6381729000  -15.04%
BenchmarkGobDecode         27764090     27103270   -2.38%
BenchmarkGobEncode         11240880     11184370   -0.50%
BenchmarkGzip            1470224000    856668400  -41.73%
BenchmarkGunzip           240660800    201697300  -16.19%
BenchmarkJSONEncode       155225800    185571900  +19.55%
BenchmarkJSONDecode       243347900    282123000  +15.93%
BenchmarkMandelbrot200     12240970     12201880   -0.32%
BenchmarkParse              8837445      8765210   -0.82%
BenchmarkRevcomp         2556310000   1868566000  -26.90%
BenchmarkTemplate         389298000    379792000   -2.44%
benchmark                  old MB/s     new MB/s  speedup
BenchmarkGobDecode            27.64        28.32    1.02x
BenchmarkGobEncode            68.28        68.63    1.01x
BenchmarkGzip                 13.20        22.65    1.72x
BenchmarkGunzip               80.63        96.21    1.19x
BenchmarkJSONEncode           12.50        10.46    0.84x
BenchmarkJSONDecode            7.97         6.88    0.86x
BenchmarkParse                 6.55         6.61    1.01x
BenchmarkRevcomp              99.43       136.02    1.37x
BenchmarkTemplate              4.98         5.11    1.03x

Fixes #4035.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6828056

fa316ba4

cmd/gc: fix typos in clearslim. · 0a47d2ef

Rémy Oudompheng authored Nov 13, 2012

Fixes build failure.

R=golang-dev, bradfitz, dave
CC=golang-dev
https://golang.org/cl/6847043

0a47d2ef

net: protocol specific listen functions return a proper local socket address · 677c6e6e

Mikio Hara authored Nov 13, 2012

When a nil listener address is passed to some protocol specific
listen function, it will create an unnamed, unbound socket because
of the nil listener address. Other listener functions may return
invalid address error.

This CL allows to pass a nil listener address to all protocol
specific listen functions to fix above inconsistency. Also make it
possible to return a proper local socket address in case of a nil
listner address.

Fixes #4190.
Fixes #3847.

R=rsc, iant
CC=golang-dev
https://golang.org/cl/6525048

677c6e6e

net: make LocalAddr on multicast UDPConn return a listening address · 0ae80785

Mikio Hara authored Nov 13, 2012

The package go.net/ipv4 allows to exist a single UDP listener
that join multiple different group addresses. That means that
LocalAddr on multicast UDPConn returns a first joined group
address is not desirable.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6822108

0ae80785

12 Nov, 2012 13 commits

net/textproto: faster header canonicalization with fewer allocations · 7e7b89f7

Jeff R. Allen authored Nov 12, 2012

By keeping a single copy of the strings that commonly show up
in headers, we can avoid one string allocation per header.

benchmark                  old ns/op    new ns/op    delta
BenchmarkReadMIMEHeader        19590        10824  -44.75%
BenchmarkUncommon               3168         1861  -41.26%

benchmark                 old allocs   new allocs    delta
BenchmarkReadMIMEHeader           32           25  -21.88%
BenchmarkUncommon                  5            5    0.00%

R=bradfitz, golang-dev, dave, rsc, jra
CC=golang-dev
https://golang.org/cl/6721055

7e7b89f7

net/http: handle 413 responses more robustly · 73c67606

Brad Fitzpatrick authored Nov 12, 2012

When HTTP bodies were too large and we didn't want to finish
reading them for DoS reasons, we previously found it necessary
to send a FIN and then pause before closing the connection
(which might send a RST) if we wanted the client to have a
better chance at receiving our error response. That was Issue 3595.

This issue adds the same fix to request headers which
are too large, which might fix the Windows flakiness
we observed on TestRequestLimit at:
http://build.golang.org/log/146a2a7d9b24441dc14602a1293918191d4e75f1

R=golang-dev, alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/6826084

73c67606

cmd/6g: extend componentgen to small arrays and structs. · 16072c74
Rémy Oudompheng authored Nov 12, 2012
```
Fixes #4092.

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6819083
```
16072c74

cmd/5g, cmd/6g: pass the full torture test. · eb4f4d16

Rémy Oudompheng authored Nov 12, 2012

The patch adds more cases to agenr to allocate registers later,
and makes 6g generate addresses for sgen in something else than
SI and DI. It avoids a complex save/restore sequence that
amounts to allocate a register before descending in subtrees.

Fixes #4207.

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6817080

eb4f4d16

exp/types: avoid init race in check_test.go. · 80f4ff22

David Symonds authored Nov 12, 2012

There was an init race between
	check_test.go:init
        universe.go:def
        use of Universe
and
	universe.go:init
        creation of Universe

The order in which init funcs are executed in a package is unspecified.
The test is not currently broken in the golang.org environment
because the go tool compiles the test with non-test sources before test sources,
but other environments may, say, sort the source files before compiling,
and thus trigger this race, causing a nil pointer panic.

R=gri
CC=golang-dev
https://golang.org/cl/6827076

80f4ff22

encoding/json: skip unexpected null values · c90739e4

Rick Arnold authored Nov 12, 2012

As discussed in issue 2540, nulls are allowed for any type in JSON so they should not result in an error during Unmarshal.
Fixes #2540.

R=rsc
CC=golang-dev
https://golang.org/cl/6759043

c90739e4

A+C: Rick Arnold (individual CLA) · 17623c0f
Russ Cox authored Nov 12, 2012
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/6821110
```
17623c0f

crypto/x509: implement EncryptPEMBlock · 791fb978

Roger Peppe authored Nov 12, 2012

Arbitrary decisions: order of the arguments and the
fact it takes a block-type argument (rather than
leaving to user to fill it in later); I'm happy whatever
colour we want to paint it.

We also change DecryptPEMBlock so that it won't
panic when the IV has the wrong size.

R=agl, agl
CC=golang-dev
https://golang.org/cl/6820114

791fb978

encoding/pem: write Proc-Type header first. · 1e1733a9
Roger Peppe authored Nov 12, 2012
```
See RFC 1421, section 4.6.1.1

R=agl, agl
CC=golang-dev
https://golang.org/cl/6814104
```
1e1733a9
faq: mention go vet in "What happens with closures running as goroutines?" · 89ed40c4
Christian Himpel authored Nov 12, 2012
```
R=r
CC=golang-dev
https://golang.org/cl/6822111
```
89ed40c4
archive/zip: Fix bounds check panic for ZIP files with a truncated extra header. · 20a18158
David McLeish authored Nov 12, 2012
```
R=adg, dave
CC=gobot, golang-dev
https://golang.org/cl/6811080
```
20a18158
C: add David McLeish (Google CLA) · 9876fd99
Andrew Gerrand authored Nov 12, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6814120
```
9876fd99
doc/install: document system requirements for the FreeBSD/ARM port · a8accda5
Shenghou Ma authored Nov 12, 2012
```
R=golang-dev, r, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/6816080
```
a8accda5

10 Nov, 2012 3 commits

cmd/5g: enable xtramodes optimisation · 3f26c5e1

Dave Cheney authored Nov 10, 2012

xtramodes' C_PBIT optimisation transforms:

MOVW          0(R3),R1
ADD           $4,R3,R3

into:

MOVW.P        4(R3),R1

and the AADD optimisation tranforms:

ADD          R0,R1
MOVBU        0(R1),R0

into:

MOVBU        R0<<0(R1),R0

5g does not appear to generate sequences that
can be transformed by xtramodes' AMOVW.

R=remyoudompheng, rsc
CC=golang-dev
https://golang.org/cl/6817085

3f26c5e1

runtime, runtime/cgo: track memory allocated by non-Go code · e9a3087e

Ian Lance Taylor authored Nov 10, 2012

Otherwise a poorly timed GC can collect the memory before it
is returned to the Go program.

R=golang-dev, dave, dvyukov, minux.ma
CC=golang-dev
https://golang.org/cl/6819119

e9a3087e

net: add more tests for protocol specific methods · 5612edb1
Mikio Hara authored Nov 10, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6821100
```
5612edb1

09 Nov, 2012 6 commits

cmd/6c, cmd/8c: use signed char explicitly in mul.c · cc224c00

Rémy Oudompheng authored Nov 09, 2012

On ARM, char is unsigned, and the code generation for
multiplication gets totally broken.

Fixes #4354.

R=golang-dev, dave, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6826079

cc224c00

cmd/go: fix selection of packages for testing · 4ef91fc8

Dmitriy Vyukov authored Nov 09, 2012

Currently it works incorrectly if user specifies own build tags
and with race detection (e.g. runtime/race is not selected,
because it contains only test files with +build race).

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6814107

4ef91fc8

runtime/pprof: fix typo in comment · 5e57954f
Ian Lance Taylor authored Nov 09, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6810102
```
5e57954f

runtime: use vDSO clock_gettime for time.now & runtime.nanotime on Linux/amd64 · 4022fc4e

Shenghou Ma authored Nov 09, 2012

Performance improvement aside, time.Now() now gets real nanosecond resolution
on supported systems.

Benchmark done on Core i7-2600 @ 3.40GHz with kernel 3.5.2-gentoo.
original vDSO gettimeofday:
BenchmarkNow    100000000               27.4 ns/op
new vDSO gettimeofday fallback:
BenchmarkNow    100000000               27.6 ns/op
new vDSO clock_gettime:
BenchmarkNow    100000000               24.4 ns/op

R=golang-dev, bradfitz, iant, iant
CC=golang-dev
https://golang.org/cl/6814103

4022fc4e

net: consolidate multiple init functions · f668e0a5
Mikio Hara authored Nov 09, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6819117
```
f668e0a5

runtime: re-enable crash test on FreeBSD · e245ae75

Mikio Hara authored Nov 09, 2012

It also passes on FreeBSD.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6812103

e245ae75

08 Nov, 2012 9 commits

test: change index.go to test size of int, not GOARCH == "amd64" · 3e50372f

Ian Lance Taylor authored Nov 08, 2012

Fixes the test to work correctly on other platforms with
64-bit ints, like Alpha.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6822099

3e50372f

archive/tar: accept binary format when reading numeric header fields. · 86b9e3e2
David Symonds authored Nov 08, 2012
```
Fixes #4358.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6840043
```
86b9e3e2

cmd/gc: fix export of inlined function body with type guard · 761830f4

Russ Cox authored Nov 08, 2012

When exporting a body containing
        x, ok := v.(Type)

the definition for Type was not being included, so when the body
was actually used, it would cause an "unknown type" compiler error.

Fixes #4370.

R=ken2
CC=golang-dev
https://golang.org/cl/6827064

761830f4

net: fix non-unixen build · 5451708d
Mikio Hara authored Nov 08, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6813101
```
5451708d
test: run some more tests by default · 6694f14b
Ian Lance Taylor authored Nov 08, 2012
```
R=golang-dev, remyoudompheng, iant, rsc
CC=golang-dev
https://golang.org/cl/6833043
```
6694f14b

runtime: re-enable crash test on NetBSD · 4e75d2c7

Joel Sing authored Nov 08, 2012

Re-enable the crash tests on NetBSD now that the issue has been
identified and fixed.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6813100

4e75d2c7

runtime: fix instrumentation of slice append for race detection · 3f7f030c
Dmitriy Vyukov authored Nov 08, 2012
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/6819107
```
3f7f030c

net: close fds eagerly in DialTimeout · ef6806fb

Brad Fitzpatrick authored Nov 08, 2012

Integrates with the pollserver now.

Uses the old implementation on windows and plan9.

Fixes #2631

R=paul, iant, adg, bendaglish, rsc
CC=golang-dev
https://golang.org/cl/6815049

ef6806fb

cmd/api: bug fix for goapi's lame type checker · a384b5b9

Brad Fitzpatrick authored Nov 08, 2012

This is blocking me submitting the net fd timeout
CL, since goapi chokes on my constant.

The much more extensive fix to goapi's type checker
in pending review in https://golang.org/cl/6742050

But I'd rather get this quick fix in first.

R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/6818104

a384b5b9