- 16 Dec, 2016 6 commits
-
-
Joe Tsai authored
Use the new "Deprecated:" syntax for all instances of HasPrefix. This is a follow-up to http://golang.org/cl/28413 which only modified path_unix.go. In this CL, we avoid mentioning that strings.HasPrefix should be used since that function is still subtly wrong in security applications. See http://golang.org/cl/5712045 for more information. Fixes #18355 Change-Id: I0d0306152cd0b0ea5110774c2c78117515b9f5cd Reviewed-on: https://go-review.googlesource.com/34554 Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Austin Clements authored
It takes me several minutes every time I want to find where the linker writes out the _func structures. Add some comments to make this easier. Change-Id: Ic75ce2786ca4b25726babe3c4fe9cd30c85c34e2 Reviewed-on: https://go-review.googlesource.com/34390Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Kevin Burke authored
Change-Id: Id10e41fe396156106f63a4b29d673b31bea5358f Reviewed-on: https://go-review.googlesource.com/34551Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
Fixes #18181. Change-Id: I5eed99dfb7b013aa4d4e668e95a97f5bb643d307 Reviewed-on: https://go-review.googlesource.com/34531 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Ian Lance Taylor authored
In the sampling tests, let the test pass if we get at least 10 samples. Fixes #18332. Change-Id: I8aad083d1a0ba179ad6663ff43f6b6b3ce1e18cd Reviewed-on: https://go-review.googlesource.com/34507Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Ian Lance Taylor authored
Confirm that a trivial executable can build and execute using -fsanitize=memory. Fixes #18335 (by skipping the tests when they don't work). Change-Id: Icb7a276ba7b57ea3ce31be36f74352cc68dc89d5 Reviewed-on: https://go-review.googlesource.com/34505 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 15 Dec, 2016 20 commits
-
-
Bryan C. Mills authored
This fixes Linux and the *BSD platforms on 386/amd64. A few OS/arch combinations were already saving registers and/or doing something that doesn't clearly resemble the SysV C ABI; those have been left alone. Fixes #18328. Change-Id: I6398f6c71020de108fc8b26ca5946f0ba0258667 Reviewed-on: https://go-review.googlesource.com/34501 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
I haven't been able to reproduce this one, but change a few suspect things in this test. Notably, using the global "Get" function and thus using the DefaultTransport was buggy in a parallel test. Then add some error checks and close a TCP connection. Hopefully the failure wasn't timing-related. Fixes #18036 (I hope) Change-Id: I4904e42e40b26d488cf82111424a1d4d46f42dae Reviewed-on: https://go-review.googlesource.com/34490 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Vladimir Stefanovic authored
Change-Id: I496bceacb6b3f417e36dc725d988b12c59a200d5 Reviewed-on: https://go-review.googlesource.com/34412Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Ian Lance Taylor authored
Change-Id: I0d990d494ee8eebfc804b526f5ced71944572b4d Reviewed-on: https://go-review.googlesource.com/34491 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Chris Broadfoot authored
Change-Id: I3ec00dac5e7d0e6dcafb7d65851bc53e0661c2b6 Reviewed-on: https://go-review.googlesource.com/34500Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Chris Broadfoot authored
Updates bundled x/net/http2 to git rev 1195a05d for: http2: fix incorrect panic https://golang.org/cl/34498 http2: fix race in writePushPromise https://golang.org/cl/34493 http2: speed up TestTransportFlowControl in short mode https://golang.org/cl/33241 http2: don't flush a stream's write queue in sc.resetStream https://golang.org/cl/34238 http2: allow Transport to connect to https://[v6literal]/ without port https://golang.org/cl/34143 http2: log Framer reads and writes when a server test fails https://golang.org/cl/34130 Updates #18326 Updates #18273 Updates #18111 Updates #18248 Updates #18235 Change-Id: I18c7a297fc94d6a843284efcfc43e0fdab9b5f41 Reviewed-on: https://go-review.googlesource.com/34495 Run-TryBot: Chris Broadfoot <cbro@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Chris Broadfoot authored
Change-Id: I5c8df05a25421489ec5122de85dbda756483c536 Reviewed-on: https://go-review.googlesource.com/34289Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Vladimir Stefanovic authored
Change-Id: I7d0bc5093943b0744d865e91517ff6292f3b2f89 Reviewed-on: https://go-review.googlesource.com/34510 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Vladimir Stefanovic authored
Change-Id: Ifcbd2ea19fc7fa832cd88aa857a5704c32eb4765 Reviewed-on: https://go-review.googlesource.com/34511Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Mikio Hara authored
In Go 1.8, almost all the platforms except NaCl provide network interface and address identification and applications can use IPv4 limited or directed broadcast addresses appropriately. Fixes #18176. Change-Id: Ie5de834d19c0aaeb4128a3ca655f6c4c9ae5e501 Reviewed-on: https://go-review.googlesource.com/34435Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Raul Silvera authored
Search the sample types in the profile being processed to map sample type options to indices in the profile sample type array. Previously these were hardcoded, which caused issues when the sample types for a profile type changed. For instance, this was triggered by the native generation of profiles in profile.proto format. This fixes #18230. A similar mechanism already exists on the upstream pprof. Change-Id: I945d8d842a0c2ca14299dabefe83124746ecd7e2 Reviewed-on: https://go-review.googlesource.com/34382Reviewed-by:
Michael Matloob <matloob@golang.org>
-
Mikio Hara authored
This change replaces the remaining use of "mask" with "prefix length" and uses IPv4 reserved address blocks for documentation. UPdates #15228. Updates #18175. Change-Id: I56c4f1205821c64f3195b023ad515b9d54e33f64 Reviewed-on: https://go-review.googlesource.com/34431 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
David Crawshaw authored
We are seeing a bad stack map in #18190. In a copystack, it is mistaking a slot for a pointer. Presumably this is caused either by our fledgling dynlink support on darwin, or a consequence of having two copies of the runtime in the process. But I have been unable to work out which in the 1.8 window, so pushing darwin support to 1.9 or later. Change-Id: I7fa4d2dede75033d9a428f24c1837a4613bd2639 Reviewed-on: https://go-review.googlesource.com/34391Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Kevin Burke authored
Change-Id: Icef8a21654a248666c684d5b10d0337c544ddb25 Reviewed-on: https://go-review.googlesource.com/34388Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Cherry Zhang authored
I meant to say ~7, instead of ^7, in the review. Fix build. Change-Id: I5060bbcd98b4ab6f00251fdb68b6b35767e5acf1 Reviewed-on: https://go-review.googlesource.com/34411 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Ian Lance Taylor authored
Update #17617. Change-Id: Ia0bc9954bb914b650b7c7af35ef714ca6b0740b4 Reviewed-on: https://go-review.googlesource.com/34376Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Vladimir Stefanovic authored
Change-Id: I7dd927be1e702e8fd469f4834ab918e0bcd9bafc Reviewed-on: https://go-review.googlesource.com/34318Reviewed-by:
Cherry Zhang <cherryyz@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Brad Fitzpatrick authored
Updates #18305 Change-Id: I63b28d511df1a6c54e32c8bfc7e2264f94e38cd7 Reviewed-on: https://go-review.googlesource.com/34386Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Vladimir Stefanovic authored
Change-Id: I00c97c36e8fdc79582eaed21877e4c8f44568666 Reviewed-on: https://go-review.googlesource.com/34316Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Vladimir Stefanovic authored
Updates #12559. Change-Id: I5e8f4cf7071d0d71618527a6b6096e771d5eeb28 Reviewed-on: https://go-review.googlesource.com/34317Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 14 Dec, 2016 13 commits
-
-
Vladimir Stefanovic authored
Change-Id: Ib425ead7b340672837d3cb983bd785488706bd6d Reviewed-on: https://go-review.googlesource.com/34314Reviewed-by:
Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Vladimir Stefanovic authored
Fixes #17792. Change-Id: If4f24455eec0edb3b221aef6777a681f6c768866 Reviewed-on: https://go-review.googlesource.com/34313Reviewed-by:
Cherry Zhang <cherryyz@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
David Crawshaw authored
Explicitly filter any C-only cgo functions out of pclntable, which allows them to be duplicated with the host binary. Updates #18190. Change-Id: I50d8706777a6133b3e95f696bc0bc586b84faa9e Reviewed-on: https://go-review.googlesource.com/34199Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
The client code was using time.Now() (wall time) to determine whether the cause of a non-nil error meant that a timeout had occured. But on Windows, the clock used for timers (time.After, time.Sleep, etc) is much more accurate than the time.Now clock, which doesn't update often. But it turns out that as of the recent https://golang.org/cl/32478 we already have the answer available easily. It just wasn't in scope. Instead of passing this information along by decorating the errors (risky this late in Go 1.8, especially with #15935 unresolved), just passing along the "didTimeout" func internally for now. We can remove that later in Go 1.9 if we overhaul Transport errors. Fixes #18287 (I hope) Change-Id: Icbbfceaf02de6c7ed04fe37afa4ca16374b58f3c Reviewed-on: https://go-review.googlesource.com/34381 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org> Reviewed-by:
Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Robert Griesemer authored
Fixes #18301. Change-Id: I990c105904ab62f2225d671bbc10209ec51b12e2 Reviewed-on: https://go-review.googlesource.com/34371 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org> Reviewed-by:
Than McIntosh <thanm@google.com>
-
Euan Kemp authored
Change-Id: I7d67c3d64be915f0be5932d2c068606d74f93c29 Reviewed-on: https://go-review.googlesource.com/34378 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Austin Clements <austin@google.com>
-
Daniel Theophanes authored
Drivers which previously supported tip will need to update to this revision before release. Fixes #18284 Change-Id: I70b8e7afff1558a8b5348885ce9f50e067c72ee9 Reviewed-on: https://go-review.googlesource.com/34330 Run-TryBot: Daniel Theophanes <kardianos@gmail.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Euan Kemp authored
Change-Id: I9e24a28b4daee5d6e1e4769547922a1a253b4ffc Reviewed-on: https://go-review.googlesource.com/34377Reviewed-by:
Michael Munday <munday@ca.ibm.com>
-
Matt Layher authored
Fixes #18175 Change-Id: I0074109fa885976b22c2be9fa39641d4d0657dee Reviewed-on: https://go-review.googlesource.com/34375Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Kaviraj authored
document about the consecutive dialing introduced in Go 1.5. If address is resolved to multiple addresses, Dial will try each address in order until one succeeds. Deadline is used to try each address (calculated based on total number of resolved addresses) Fixes: #17617 Change-Id: I56b6399edb640c8ef507675f98e0bd45a50d4e2d Reviewed-on: https://go-review.googlesource.com/34176Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Ian Lance Taylor authored
Change-Id: I9329738ec5dd6c12f72eea7de413d66617b7b5c2 Reviewed-on: https://go-review.googlesource.com/34373Reviewed-by:
Rob Pike <r@golang.org>
-
Ian Lance Taylor authored
Now that we try to handle qualifiers correctly (as of CL 33325), don't strip them from a void* pointer. Otherwise we break a case like "const void**", as the "const" qualifier is dropped and the resulting "void**" triggers a warning from the C compiler. Fixes #18298. Change-Id: If51df1889b0f6a907715298c152e6d4584747acb Reviewed-on: https://go-review.googlesource.com/34370 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Ian Lance Taylor authored
Doc change only. Fixes #18246. Change-Id: I2c7b181bcec81e124d30702f6fac5aa43bb57c04 Reviewed-on: https://go-review.googlesource.com/34230Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 13 Dec, 2016 1 commit
-
-
Vladimir Stefanovic authored
Change-Id: I1d6a2120a444d1ab9b9ecfdf27464325ad741d55 Reviewed-on: https://go-review.googlesource.com/34315Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-