Commits · 15dcdf751cfd9f075c3071b3ca1d5303334f2694 · go / golang

31 May, 2011 16 commits

gc: fix m[x], _ = y.(T) · 15dcdf75
Russ Cox authored May 31, 2011
```
Fixes #1900.

R=ken2
CC=golang-dev
https://golang.org/cl/4561053
```
15dcdf75
gc: disallow ... in type conversions · 5b62ba14
Anthony Martin authored May 31, 2011
```
Fixes #1866.

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4548073
```
5b62ba14
encoding/hex: don't try to print DEL. · c72dbaf3
Adam Langley authored May 31, 2011
```
R=agl
CC=golang-dev
https://golang.org/cl/4551081
```
c72dbaf3

gc: implement new shift rules · 5ab096d0

Russ Cox authored May 31, 2011

The change is that 1.0<<2 is now okay.

R=ken2
CC=golang-dev
https://golang.org/cl/4524084

5ab096d0

gc: elide call to runtime.closure for function literals called in-place. · 9b82408f

Luuk van Dijk authored May 31, 2011

before:
runtime_test.BenchmarkCallClosure        5000000               499 ns/op
runtime_test.BenchmarkCallClosure1       5000000               681 ns/op

after:
runtime_test.BenchmarkCallClosure       500000000                5 ns/op
runtime_test.BenchmarkCallClosure1       10000000              160 ns/op

R=rsc
CC=golang-dev
https://golang.org/cl/4515167

9b82408f

misc/cgo: remove reference to 'destroy' function · 6216307e
Russ Cox authored May 31, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4558042
```
6216307e

undo CL 4515163 / 42c3cfa4d64f · 2261021b

Russ Cox authored May 31, 2011

breaks Mac build

««« original CL description
runtime: use HOST_CC to compile mkversion

HOST_CC is set in Make.inc, so use that rather
than hardcoding quietgcc

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/4515163

»»»

R=iant
CC=golang-dev
https://golang.org/cl/4515168

2261021b

runtime: use HOST_CC to compile mkversion · fd0cf087

Dave Cheney authored May 31, 2011

HOST_CC is set in Make.inc, so use that rather
than hardcoding quietgcc

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/4515163

fd0cf087

gc: check parameter declarations in interface fields · 67b4db9e
Anthony Martin authored May 31, 2011
```
Fixes #1663.
Fixes #1871.

R=rsc, lstoakes
CC=golang-dev
https://golang.org/cl/4530084
```
67b4db9e

encoding/hex: add hex dumping. · de15f616

Adam Langley authored May 31, 2011

I found this useful, esp with an io.MultiWriter. But I fear that
it may be bloat in such a low-level package so please feel free to
decline if you feel likewise.

R=rsc, ality
CC=golang-dev
https://golang.org/cl/4530088

de15f616

http: have client set Content-Length when possible · 21980506

Brad Fitzpatrick authored May 31, 2011

Also some cleanup, removing redundant code. Make more
things use NewRequest. Add some tests, docs.

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/4561047

21980506

net: name-based destination address selection · 50effb65

Christopher Wedgwood authored May 31, 2011

getaddrinfo() orders the addresses according to RFC 3484.

This means when IPv6 is working on a host we get results like:
    []string = {"2001:4810::110", "66.117.47.214"}

and when it's not working we get:
    []string = {"66.117.47.214", "2001:4810::110"}

thus can drop firstFavoriteAddr.

This also means /etc/gai.conf works on relevant systems.

R=rsc, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/4557058

50effb65

runtime: reset GOMAXPROCS during tests · 91cc1e6b

Dmitriy Vyukov authored May 31, 2011

Fix the fact that the test leaves GOMAXPROCS=3
and a running goroutine behind.

R=golang-dev, rsc
CC=dvyukov, golang-dev
https://golang.org/cl/4517121

91cc1e6b

syscall : add ProcAttr field to pass an unescaped command line on windows · f18a4e96

Vincent Vanackere authored May 31, 2011

On windows, the command line is passed as a single null-terminated string. While the automatic parameter escaping done by syscall.StartProcess works fine with most Windows programs, some applications do their own custom parsing of the command line, in which case the automatic escaping becomes harmful.
This CL adds a new extra CmdLine field to syscall.ProcAttr that will be used as the raw/unescaped command line if not empty.
Fixes #1849.

R=golang-dev, alex.brainman, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4548050

f18a4e96

runtime: save cdecl registers in Windows SEH handler · c4206cb2
Alexey Borzenkov authored May 31, 2011
```
Fixes #1779

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4566041
```
c4206cb2

filepath: Abs must always return a clean path · 463f478d

Gustavo Niemeyer authored May 31, 2011

When I was first coding Abs, I wondered if people wouldn't
expect the path to be consistently clean, even if the path
passed in was already absolute.

CL 4524078 has a potential problem based on exactly that
assumption, so it feels like this behavior is indeed the
most useful and least surprising.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4548074

463f478d

30 May, 2011 12 commits
- unicode: make the tables smaller. · 0de328ed
  Rob Pike authored May 30, 2011
```
By splitting the ranges into 16-bit values and 32-bit values,
we can reduce about 3000 entries by 48 bits per entry, or about
16KB, at the cost of a little more complexity in the code.

R=iant, bradfitz, rsc, r
CC=golang-dev
https://golang.org/cl/4547066
```
  0de328ed
- goinstall: skip standard packages · 2c6a2a97
  Russ Cox authored May 30, 2011
```
R=adg, n13m3y3r
CC=golang-dev
https://golang.org/cl/4526084
```
  2c6a2a97
- template: fix and clean interaction between quotes and formatters · 87dbec54
  Gustavo Niemeyer authored May 30, 2011
```
Fixes issue #1897.

R=r, gustavo, r
CC=golang-dev
https://golang.org/cl/4561049
```
  87dbec54
- gobuilder: remove some windows-specificity · 55f8fd26
  Andrew Gerrand authored May 30, 2011
```
R=alex.brainman
CC=golang-dev
https://golang.org/cl/4528109
```
  55f8fd26
- pkg: spelling tweaks, I-Z · 3fbd478a
  Robert Hencke authored May 30, 2011
```
also, a few miscellaneous fixes to files outside pkg

R=golang-dev, dsymonds, mikioh.mikioh, r
CC=golang-dev
https://golang.org/cl/4517116
```
  3fbd478a
- goinstall: use bash to execute gomake · 9107b530
  Alex Brainman authored May 30, 2011
```
R=golang-dev, r, adg
CC=golang-dev
https://golang.org/cl/4551074
```
  9107b530
- src: Make.pkg don't create $(TARGDIR) with goinstall. · 10425725
  Yasuhiro Matsumoto authored May 30, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4548071
```
  10425725
- misc/vim: limit Fmt command to Go buffers. · c6fd1e01
  Yasuhiro Matsumoto authored May 30, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4548072
```
  c6fd1e01
- dashboard: send notification emails when the build breaks · 5784dcfd
  Andrew Gerrand authored May 30, 2011
```
R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4530061
```
  5784dcfd
- gobuilder: fixes for windows · 55dd63bb
  Alex Brainman authored May 30, 2011
```
R=r, devon.odell, iant, rsc, adg
CC=bradfitz, golang-dev, jdpoirier
https://golang.org/cl/4536053
```
  55dd63bb
- image/png: fix encoding of images that don't start at (0, 0). · a479bc8d
  Nigel Tao authored May 30, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4560049
```
  a479bc8d
- gob: fix documentation on Decoder.Decode. · 5d5d84f3
  David Symonds authored May 30, 2011
```
R=r, adg
CC=golang-dev
https://golang.org/cl/4515159
```
  5d5d84f3
29 May, 2011 5 commits

http: let Transport use a custom net.Dial function · da32ed7b

Brad Fitzpatrick authored May 29, 2011

Permits the use of SOCKS proxy dialer with
the transport.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4536091

da32ed7b

template: cosmetic cleanups. · 62943df8

Rob Pike authored May 29, 2011

Remove the idea of space being white.  Sometimes space is green.
Simplify a comment and remove the Latin.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4532096

62943df8

template: fix quote-handling with formatters · e11d94fc
Gustavo Niemeyer authored May 29, 2011
```
Fixes issue #1896.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4539093
```
e11d94fc

os: fix os.MkdirAll with backslash path separator. · 0f4510b3

Yasuhiro Matsumoto authored May 29, 2011

MkdirAll() need to use isSeparator().
Move primary defines of filepath.Separator/filepath.ListSeparator
 to os.PathSeparator/os.PathListSeparator.
Move filepath.isSeparator() to os.IsPathSeparator().
filepath package refer them from os package.
Fixes #1831.

R=rsc, alex.brainman
CC=golang-dev
https://golang.org/cl/4535100

0f4510b3

os: fix windows version of Readdir(0) · 505f0bb3
Alex Brainman authored May 29, 2011
```
Fixes #1893.

R=golang-dev
CC=bradfitz, golang-dev
https://golang.org/cl/4528106
```
505f0bb3

28 May, 2011 1 commit
- gotest, pkg/exec: use bash instead of sh to execute shell scripts on windows · b7582852
  Alex Brainman authored May 28, 2011
```
As suggested by dho, iant2.

R=golang-dev, rsc
CC=devon.odell, golang-dev, iant
https://golang.org/cl/4515147
```
  b7582852
27 May, 2011 6 commits

go/scanner: don't allow "0x" and "0X" as integers · f369fc09
Evan Shaw authored May 27, 2011
```
R=gri
CC=golang-dev
https://golang.org/cl/4560047
```
f369fc09

http: client+server benchmark · 399a311e

Brad Fitzpatrick authored May 27, 2011

baseline runs: (6g, gopher.mtv)

http_test.BenchmarkClientServer  5000  412588 ns/op
http_test.BenchmarkClientServer  5000  403346 ns/op
http_test.BenchmarkClientServer  5000  413936 ns/op
http_test.BenchmarkClientServer  5000  410287 ns/op
http_test.BenchmarkClientServer  5000  388037 ns/op
http_test.BenchmarkClientServer  5000  405545 ns/op
http_test.BenchmarkClientServer  5000  405179 ns/op
http_test.BenchmarkClientServer  5000  413827 ns/op
http_test.BenchmarkClientServer  5000  392723 ns/op

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4515155

399a311e

encoding/binary: add a non-reflect fast path for Write · f7a266a5

Brad Fitzpatrick authored May 27, 2011

before/after:
binary.BenchmarkWrite	  100000	     18312 ns/op
binary.BenchmarkWrite	  500000	      4468 ns/op

R=rsc, gri
CC=golang-dev
https://golang.org/cl/4515154

f7a266a5

big: make Int and Rat implement fmt.Scanner · 3b980579
Evan Shaw authored May 27, 2011
```
R=gri
CC=golang-dev
https://golang.org/cl/4552056
```
3b980579

time: midnight is 12AM. · 5a35757f

Rob Pike authored May 27, 2011

This is the other half of the problem fixed at noon by the previous change.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4515150

5a35757f

os: yet more Readdir tests and fix earlier regression · 685a8157
Brad Fitzpatrick authored May 27, 2011
```
R=golang-dev, fshahriar
CC=golang-dev
https://golang.org/cl/4548068
```
685a8157