- 09 Aug, 2012 3 commits
-
-
Rob Pike authored
The keyword reprents an untyped nil and is useful for passing nil values to methods and functions. The nil will be promoted to the appropriate type when used; if a type cannot be assigned, an error results. R=rsc, dsymonds CC=golang-dev https://golang.org/cl/6459056
-
Shenghou Ma authored
Although I don't use PAX enabled ARM kernels, PAX does have support for ARM, so we're better off add PT_PAX_FLAGS now in case people use PAX kernels. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6453092
-
Andrew Balholm authored
Pass 1 additional test. R=nigeltao CC=golang-dev https://golang.org/cl/6454124
-
- 08 Aug, 2012 10 commits
-
-
Andrew Balholm authored
Pass 1 additional test. R=nigeltao CC=golang-dev https://golang.org/cl/6459060
-
Charles L. Dorian authored
R=rsc, minux.ma, golang-dev, nigeltao CC=golang-dev https://golang.org/cl/6461047
-
Andrew Gerrand authored
(I also updated the wiki's GoTalks page with all the latest videos.) R=golang-dev, r CC=golang-dev https://golang.org/cl/6441113
-
Rob Pike authored
Surrogate halves are part of UTF-16 and should never appear in UTF-8. (The rune that two combined halves represent in UTF-16 should be encoded directly.) Encoding: encode as RuneError. Decoding: convert to RuneError, consume one byte. This requires changing: package unicode/utf8 runtime for range over string Also added utf8.ValidRune and fixed bug in utf.RuneLen. Fixes #3927. R=golang-dev, rsc, bsiegert CC=golang-dev https://golang.org/cl/6458099
-
Andrew Gerrand authored
R=r CC=golang-dev https://golang.org/cl/6458097
-
David Symonds authored
Also rename the testing CGI argument from "email" to "user". R=golang-dev, r CC=golang-dev https://golang.org/cl/6454117
-
Yves Junqueira authored
R=adg, remyoudompheng, rsc, r CC=golang-dev https://golang.org/cl/6457085
-
Russ Cox authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6443091
-
Robert Griesemer authored
Some browsers (e.g. IE9) ignore the case of 'id' attributes which can lead to conflicts. Prefix non-generated 'id's with "pkg-" to make them different from any generated attribute. Also: Added missing entry for "Other packages" to top-level index. Fixes #3851. R=adg, dsymonds CC=golang-dev https://golang.org/cl/6449105
-
Andrew Balholm authored
If a table contained whitespace, text nodes would not get foster parented correctly. Pass 1 additional test. R=nigeltao CC=golang-dev https://golang.org/cl/6459054
-
- 07 Aug, 2012 12 commits
-
-
Nigel Tao authored
Section B.2.3 of http://www.w3.org/Graphics/JPEG/itu-t81.pdf discusses the End of spectral selection (Se) byte. Apparently many JPEG decoders ignore the Se byte (or let it through with a warning), but some configurations reject them. For example, http://download.blender.org/source/chest/blender_2.03_tree/jpeg/jcmaster.c has these lines: if (Ss != 0 || Se != DCTSIZE2-1 || Ah != 0 || Al != 0) ERREXIT1(cinfo, JERR_BAD_PROG_SCRIPT, scanno); Fixes #3916. R=r CC=golang-dev https://golang.org/cl/6459052
-
Shenghou Ma authored
Depends on CL 6197045. Result obtained on Core i7 620M, Darwin/amd64: benchmark old ns/op new ns/op delta BenchmarkComplex128DivNormal 57 28 -50.78% BenchmarkComplex128DivNisNaN 49 15 -68.90% BenchmarkComplex128DivDisNaN 49 15 -67.88% BenchmarkComplex128DivNisInf 40 12 -68.50% BenchmarkComplex128DivDisInf 33 13 -61.06% Result obtained on Core i7 620M, Darwin/386: benchmark old ns/op new ns/op delta BenchmarkComplex128DivNormal 89 50 -44.05% BenchmarkComplex128DivNisNaN 307 802 +161.24% BenchmarkComplex128DivDisNaN 309 788 +155.02% BenchmarkComplex128DivNisInf 278 237 -14.75% BenchmarkComplex128DivDisInf 46 22 -52.46% Result obtained on 700MHz OMAP4460, Linux/ARM: benchmark old ns/op new ns/op delta BenchmarkComplex128DivNormal 1557 465 -70.13% BenchmarkComplex128DivNisNaN 1443 220 -84.75% BenchmarkComplex128DivDisNaN 1481 218 -85.28% BenchmarkComplex128DivNisInf 952 216 -77.31% BenchmarkComplex128DivDisInf 861 231 -73.17% The 386 version has a performance regression, but as we have decided to use SSE2 instead of x87 FPU for 386 too (issue 3912), I won't address this issue. R=dsymonds, mchaten, iant, dave, mtj, rsc, r CC=golang-dev https://golang.org/cl/6024045
-
Brad Fitzpatrick authored
Fixes #3711 R=golang-dev, adg CC=golang-dev https://golang.org/cl/6445083
-
Yves Junqueira authored
R=r CC=adg, gobot, golang-dev https://golang.org/cl/6449096
-
Andrew Balholm authored
The <title> element was getting removed from the stack of open elements, when its parent, the <head> element should have been removed instead. Pass 2 additional tests. R=nigeltao CC=golang-dev https://golang.org/cl/6449101
-
Alex Brainman authored
This is an attempt to fix windows build. Will restore once we know what the problem is. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6461046
-
Shenghou Ma authored
R=adg CC=golang-dev https://golang.org/cl/6458043
-
Shenghou Ma authored
Part of issue 3747. R=dave, lvd, rsc CC=golang-dev https://golang.org/cl/6084044
-
Shenghou Ma authored
Fixes #3748. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6357064
-
Shenghou Ma authored
our old choice is not working properly at least on VFPv2 in ARM1136JF-S (it's not preserved across float64->float32 conversions). Fixes #3745. R=dave, rsc CC=golang-dev https://golang.org/cl/6344078
-
Shenghou Ma authored
Introduced in CL 6452046. R=golang-dev, nigeltao, dave CC=golang-dev https://golang.org/cl/6459051
-
Shenghou Ma authored
Enhances test/run.go to support testing other directories Will enable stdio tests on Windows in a follow-up CL. R=golang-dev, alex.brainman, rsc CC=golang-dev https://golang.org/cl/6220049
-
- 06 Aug, 2012 5 commits
-
-
Andrew Balholm authored
When an element (like <nobr> or <p>) was implicitly closed by another start tag, it would keep foster parenting from working because the check for what was on top of the stack of open elements was in the wrong place. Move the check to addChild. Pass 2 additional tests. R=nigeltao CC=golang-dev https://golang.org/cl/6460045
-
Russ Cox authored
R=golang-dev, fullung CC=golang-dev https://golang.org/cl/6443085
-
Alexey Borzenkov authored
R=golang-dev, rsc CC=golang-dev, r, yarikos https://golang.org/cl/6454104
-
Alex Brainman authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6454091
-
Brad Fitzpatrick authored
Hold ForkLock during dup of fd + cloexec in the net pkg, per the locking policy documented in syscall/exec_unix.go. R=golang-dev, dsymonds, adg CC=golang-dev https://golang.org/cl/6457080
-
- 05 Aug, 2012 7 commits
-
-
Alexey Borzenkov authored
Since NUL usually terminates strings in underlying syscalls, allowing it when converting string arguments is a security risk, especially when dealing with filenames. For example, a program might reason that filename like "/root/..\x00/" is a subdirectory or "/root/" and allow access to it, while underlying syscall will treat "\x00" as an end of that string and the actual filename will be "/root/..", which might be unexpected. Returning EINVAL when string arguments have NUL in them makes sure this attack vector is unusable. R=golang-dev, r, bradfitz, fullung, rsc, minux.ma CC=golang-dev https://golang.org/cl/6458050
-
Benny Siegert authored
R=golang-dev CC=golang-dev https://golang.org/cl/6454100
-
Rémy Oudompheng authored
benchmark old ns/op new ns/op delta BenchmarkCompareStringEqual 51 35 -30.20% BenchmarkCompareStringIdentical 51 7 -85.71% BenchmarkCompareStringSameLength 25 18 -28.29% BenchmarkCompareStringDifferentLength 2 2 +1.46% R=golang-dev, rsc CC=golang-dev, remy https://golang.org/cl/6450092
-
Russ Cox authored
This line helps me to tell whether the CL is waiting for me or I'm waiting for the author. Also: - vertical-align table cells so buttons are always aligned with CL headers. - add email= to show front page for someone else. Demo at http://rsc.gocodereview.appspot.com/. Until this is deployed for real, some recently changed CLs may be missing the 'first line of last message' part. R=dsymonds CC=golang-dev https://golang.org/cl/6446065
-
Russ Cox authored
Too many people use it without reading what it does. Those people want ReadBytes or ReadString. Fixes #3906. R=golang-dev, iant, r CC=golang-dev https://golang.org/cl/6442087
-
Rémy Oudompheng authored
The improvement is obtained by eliminating the zero initialization of a large structure that is only needed when the fast path fails. Also add a missing roundtrip test for float32s. benchmark old ns/op new ns/op delta BenchmarkAppendFloatDecimal 301 180 -40.20% BenchmarkAppendFloat 486 388 -20.16% BenchmarkAppendFloatExp 492 383 -22.15% BenchmarkAppendFloatNegExp 478 370 -22.59% BenchmarkAppendFloatBig 650 541 -16.77% BenchmarkAppendFloat32Integer 308 180 -41.56% BenchmarkAppendFloat32ExactFraction 449 333 -25.84% BenchmarkAppendFloat32Point 494 390 -21.05% BenchmarkAppendFloat32Exp 488 387 -20.70% BenchmarkAppendFloat32NegExp 488 378 -22.54% R=r, rsc CC=golang-dev, remy https://golang.org/cl/6346081
-
Andrew Balholm authored
The content of an HTML <title> element is RCDATA, but the content of an SVG <title> element is parsed as tags. Now the parser doesn't go into RCDATA mode in foreign content. Pass 4 additional tests. R=nigeltao CC=golang-dev https://golang.org/cl/6448111
-
- 04 Aug, 2012 3 commits
-
-
Dmitriy Vyukov authored
I have C functions implemented in .syso file (rather than .so or inlined in .go file). W/o this change the gcc invocation fails with undefined symbols. R=minux.ma, rsc CC=golang-dev https://golang.org/cl/6352076
-
Dmitriy Vyukov authored
E.g. sync/atomic.LoadInt32() can be called as sync»atomic·LoadInt32() R=rsc CC=golang-dev https://golang.org/cl/6448057
-
Ian Lance Taylor authored
R=adg, rsc, franciscossouza, seb.binet, gen.battle CC=golang-dev https://golang.org/cl/5845071
-