Skip to content

G
golang
Switch branch/tag
  1. 04 Jan, 2018 2 commits
  3. 03 Jan, 2018 8 commits
  5. 02 Jan, 2018 4 commits
  7. 01 Jan, 2018 1 commit
  9. 31 Dec, 2017 2 commits
  11. 30 Dec, 2017 1 commit
  13. 27 Dec, 2017 1 commit
  15. 25 Dec, 2017 1 commit
  17. 22 Dec, 2017 1 commit
  19. 21 Dec, 2017 2 commits
  21. 20 Dec, 2017 4 commits
    • Robert Griesemer's avatar
      go/types: document Typ slice · 5ad3c1cd
      Robert Griesemer authored 
      Fixes #22628.

Change-Id: Ib7aff8043e477af18c448d6b778f159b23fb5a92
Reviewed-on: https://go-review.googlesource.com/85075Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      5ad3c1cd
    • Hana Kim's avatar
      cmd/trace: init goroutine info entries with GoCreate event · a58286c2
      Hana Kim authored 
      golang.org/cl/81315 attempted to distinguish system goroutines
by examining the function name in the goroutine stack. It assumes that
the information would be available when GoSysBlock or GoInSyscall
events are processed, but it turned out the stack information is
set too late (when the goroutine gets a chance to run).

This change initializes the goroutine information entry when
processing GoCreate event which should be one of the very first
events for the every goroutine in trace.

Fixes #22574

Change-Id: I1ed37087ce2e78ed27c9b419b7d942eb4140cc69
Reviewed-on: https://go-review.googlesource.com/83595Reviewed-by: 's avatarAustin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
      a58286c2
    • Than McIntosh's avatar
      cmd/compile: second attempt at fix for issue 23179 · 841d865a
      Than McIntosh authored 
      My previous fix for issue 23179 was incomplete; it turns out that if
an unnamed parameter is below a specific size threshold, it gets
register-promoted away by the compiler (hence not encountered during
some parts of DWARF inline info processing), but if it is sufficiently
large, it is allocated to the stack as a named variable and treated as
a regular parameter by DWARF generation. Interestingly, something in
the ppc64le build of k8s causes an unnamed parameter to be retained
(where on amd64 it is deleted), meaning that this wasn't caught in my
amd64 testing.

The fix is to insure that "_" params are treated in the same way that
"~r%d" return temps are when matching up post-optimization inlined
routine params with pre-inlining declarations. I've also updated the
test case to include a "_" parameter with a very large size, which
also triggers the bug on amd64.

Fixes #23179.

Change-Id: I961c84cc7a873ad3f8f91db098a5e13896c4856e
Reviewed-on: https://go-review.googlesource.com/84975
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: 's avatarDavid Chase <drchase@google.com>
Reviewed-by: 's avatarCherry Zhang <cherryyz@google.com>
Reviewed-by: 's avatarHeschi Kreinick <heschi@google.com>
      841d865a
    • elpinal's avatar
      cmd/doc: suppress the error message for *package.ident embedded in struct type · 0504cd68
      elpinal authored 
      The current implementation prints a log, "invalid program: unexpected
type for embedded field", when the form *package.ident is embedded in
a struct declaration.

Note that since valid qualified identifiers must be exported, the result
for a valid program does not change.

Change-Id: If8b9d7056c56b6a6c5482eb749168a63c65ef685
Reviewed-on: https://go-review.googlesource.com/84436Reviewed-by: 's avatarRobert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
      0504cd68
  23. 19 Dec, 2017 2 commits
  25. 18 Dec, 2017 2 commits
  27. 16 Dec, 2017 1 commit
  29. 15 Dec, 2017 8 commits