Commits · 1d3efd6533773138ac7c9d8ca1314459636d55d2 · go / golang

17 Aug, 2013 3 commits

net: limit number of concurrent cgo calls · 1d3efd65

Russ Cox authored Aug 17, 2013

The limit is 500. There is no way to change it.
This primarily affects name resolution.
If a million goroutines try to resolve DNS names,
only 500 will get to execute cgo calls at a time.
But in return the operating system will not crash.

Fixes #5625.

R=golang-dev, dan.kortschak, r, dvyukov
CC=bradfitz, golang-dev
https://golang.org/cl/13038043

1d3efd65

runtime: impose thread count limit · 665feeed

Russ Cox authored Aug 17, 2013

Actually working to stay within the limit could cause subtle deadlocks.
Crashing avoids the subtlety.

Fixes #4056.

R=golang-dev, r, dvyukov
CC=golang-dev
https://golang.org/cl/13037043

665feeed

cmd/gc: separate "has pointers" from "needs zeroing" in stack frame · 3b4d7926

Russ Cox authored Aug 17, 2013

When the new call site-specific frame bitmaps are available,
we can cut the zeroing to just those values that need it due
to scope escaping.

R=cshapiro, cshapiro
CC=golang-dev
https://golang.org/cl/13045043

3b4d7926

16 Aug, 2013 28 commits

doc: describe halt_on_error race detector parameter · a96d850a
Dmitriy Vyukov authored Aug 16, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13067043
```
a96d850a
runtime/race: add output tests for different GORACE params · 18f5ce85
Dmitriy Vyukov authored Aug 16, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13065043
```
18f5ce85
test: say that nilptr2.go requires 256+MB stack · eaa07044
Dmitriy Vyukov authored Aug 16, 2013
```
Fixes #6161.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13059043
```
eaa07044

runtime: fix goroutine stack accounting · 187b9c69

Dmitriy Vyukov authored Aug 16, 2013

Fixes #6166.
Fixes #6168.

R=golang-dev, bradfitz, remyoudompheng
CC=golang-dev
https://golang.org/cl/12927045

187b9c69

misc/emacs: godef: print the entire description, not just the first line · 29794b77

Dominik Honnef authored Aug 16, 2013

When identifying structs or interfaces we really want to know
their makeup, not just their name.

R=adonovan
CC=golang-dev
https://golang.org/cl/13042043

29794b77

runtime/race: update runtime to rev 188542 · fbf5fd5f

Dmitriy Vyukov authored Aug 16, 2013

Fixes #6107.
race: output goroutine 1 as main goroutine

Fixes #6130.
race: option to abort program on first detected error

R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/12968044

fbf5fd5f

net: fix bug in fdMutex · 727dd08c
Dmitriy Vyukov authored Aug 16, 2013
```
Fixes #6165.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/12984044
```
727dd08c
A+C: change Robert Dinu's email address · b6a8fa10
Robert Dinu authored Aug 16, 2013
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/12759043
```
b6a8fa10
doc/go1.2.txt: testing: add TB interface · 8814b4a4
Rob Pike authored Aug 16, 2013
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/12890044
```
8814b4a4
cmd/5g, cmd/6g, cmd/8g: update frame zeroing for new bitmap format · d3b04f46
Carl Shapiro authored Aug 16, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12740046
```
d3b04f46

time: fix time zones yet again. · 4c855f38

Rob Pike authored Aug 16, 2013

This time we're going for 5!
http://goo.gl/3ETYH7

Fixes #3790
Yeah, right.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/13002044

4c855f38

undo CL 12822043 / 96fefaa02ae3 · ea6cfc57

David Symonds authored Aug 16, 2013

Fixes #6160.

««« original CL description
go/doc: permit a package synopsis to end with ":\n".

R=gri, r
CC=golang-dev
https://golang.org/cl/12822043
»»»

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/13040043

ea6cfc57

misc/emacs: allow godef to work in coverage buffers · 0b25ba9c

Dominik Honnef authored Aug 16, 2013

Jumps to the same file will use the original buffer, not the
coverage buffer. Making it work for the coverage buffer isn't
worth the trouble, especially because it would break as soon as
you jump to a different file and back.

Use error instead of message so it actually terminates

R=adonovan
CC=golang-dev
https://golang.org/cl/13041043

0b25ba9c

misc/emacs: do not use any free variables · c320cf85
Dominik Honnef authored Aug 16, 2013
```
R=adonovan
CC=golang-dev
https://golang.org/cl/12744046
```
c320cf85
misc/emacs: when defining prog-mode, define it like GNU Emacs 24 would · 5f199f2d
Dominik Honnef authored Aug 16, 2013
```
Fixes #6156.

R=adonovan
CC=golang-dev
https://golang.org/cl/13035043
```
5f199f2d

misc/dist: don't copy godoc templates to lib/godoc · b1d64f20

Andrew Gerrand authored Aug 16, 2013

They're baked into the godoc binary now.

R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/12751047

b1d64f20

cmd/go: fix at least some instances of double compilation · f0fef323

Rob Pike authored Aug 16, 2013

When the packages the tested package depends on don't build,
we weren't getting out early. Added a simple check for a successful
build to an existing early out.

There may be other ways that double compilation arises, but
this fixes the one listed in the issue.
Fixes #5679

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13036043

f0fef323

cmd/gc: remove mentions of "ideal" from error messages. · 703b897f

Rob Pike authored Aug 16, 2013

        _ = complex("foo", 0)
        _ = complex(true, 0)
now trigger:
        x.go:4: invalid operation: complex("foo", 0) (mismatched types untyped string and untyped number)
        x.go:5: invalid operation: complex(true, 0) (mismatched types untyped bool and untyped number)

Fixes #4521

R=golang-dev, remyoudompheng, rsc
CC=golang-dev
https://golang.org/cl/12973043

703b897f

misc/emacs: Refactor coverage code into multiple functions · 3495aa29

Dominik Honnef authored Aug 16, 2013

Also fixes color gradient being calculated against the wrong maximum.

R=adonovan
CC=golang-dev
https://golang.org/cl/12968043

3495aa29

runtime: impose stack size limit · 757e0de8

Russ Cox authored Aug 16, 2013

The goal is to stop only those programs that would keep
going and run the machine out of memory, but before they do that.
1 GB on 64-bit, 250 MB on 32-bit.
That seems implausibly large, and it can be adjusted.

Fixes #2556.
Fixes #4494.
Fixes #5173.

R=khr, r, dvyukov
CC=golang-dev
https://golang.org/cl/12541052

757e0de8

image: Inline example image data to make it runnable on playground. · 205329aa

Dimitri Tcaciuc authored Aug 16, 2013

Use more compressed image to reduce source clutter.

Fixes #5983.

R=nigeltao, adg
CC=golang-dev
https://golang.org/cl/12513044

205329aa

A+C: Dimitri Tcaciuc (individual CLA) · c06303bb
Nigel Tao authored Aug 16, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/13024045
```
c06303bb

database/sql: make Rows.Next returning false always implicitly call · bc212650

Nigel Tao authored Aug 16, 2013

Rows.Close.

Previously, callers that followed the example code (but not call
rows.Close after "for rows.Next() { ... }") could leak statements if
the driver returned an error other than io.EOF.

R=bradfitz, alex.brainman
CC=golang-dev, rsc
https://golang.org/cl/12677050

bc212650

cmd/gc: ensure addable in checknil (fix race build) · b75a08d0
Russ Cox authored Aug 16, 2013
```
TBR=dvyukov
CC=golang-dev
https://golang.org/cl/12791044
```
b75a08d0

net/http: don't send an automatic Content-Length on a 304 Not Modified · 67a69bce

Brad Fitzpatrick authored Aug 16, 2013

Also start of some test helper unification, long overdue.
I refrained from cleaning up the rest in this CL.

Fixes #6157

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/13030043

67a69bce

doc/go1.2.txt: delete 'go doc' · 9c248e34

Rob Pike authored Aug 16, 2013

It's nearly useless and for plain 'go doc', 'godoc .' works fine.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/13004044

9c248e34

doc/go1.2.txt: three-index slices are going into 1.2 · de2cf511
Rob Pike authored Aug 16, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12931044
```
de2cf511

cmd/go: delete 'go doc' · 71eae5a4

Rob Pike authored Aug 16, 2013

It's next to useless and confusing as well. Let's make godoc better instead.

Fixes #4849.

R=golang-dev, dsymonds, adg, rogpeppe, rsc
CC=golang-dev
https://golang.org/cl/12974043

71eae5a4

15 Aug, 2013 9 commits

net/http: unify the confusingly-named serve_test and server_test · 95e0a8c2

Brad Fitzpatrick authored Aug 15, 2013

One was tiny. One was gigantic. Now one is gone and one is giganticer.

No code changes.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/13025043

95e0a8c2

cmd/gc: &x panics if x does · 999a36f9

Russ Cox authored Aug 15, 2013

See golang.org/s/go12nil.

This CL is about getting all the right checks inserted.
A followup CL will add an optimization pass to
remove redundant checks.

R=ken2
CC=golang-dev
https://golang.org/cl/12970043

999a36f9

spec: &x panics if x does · 5ce78b7c

Russ Cox authored Aug 15, 2013

See golang.org/s/go12nil for the extended version.

R=golang-dev, r, adonovan
CC=golang-dev
https://golang.org/cl/12964043

5ce78b7c

tests: remove two misuses of nil pointers · 08fdf009
Russ Cox authored Aug 15, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/12858044
```
08fdf009
runtime: fix wrong syscall numbers on freebsd/386, openbsd/386 · ff86d222
Mikio Hara authored Aug 15, 2013
```
R=golang-dev, jsing
CC=golang-dev
https://golang.org/cl/12876044
```
ff86d222

net: enable runtime-integrated network pollster on freebsd, openbsd · cb3b2922

Mikio Hara authored Aug 15, 2013

Fixes #5199.

Benchmark results on freebsd/amd64 (virtual machine):

benchmark old ns/op new ns/op delta
BenchmarkTCP4OneShot-2 184566 187164 +1.41%
BenchmarkTCP4OneShotTimeout-2 215558 187722 -12.91%
BenchmarkTCP4Persistent-2 59686 41294 -30.81%
BenchmarkTCP4PersistentTimeout-2 60692 39974 -34.14%
BenchmarkTCP6OneShot-2 226595 223688 -1.28%
BenchmarkTCP6OneShotTimeout-2 253144 225161 -11.05%
BenchmarkTCP6Persistent-2 69157 55605 -19.60%
BenchmarkTCP6PersistentTimeout-2 70426 53805 -23.60%
BenchmarkTCP4ConcurrentReadWrite-2 53878 56087 +4.10%
BenchmarkTCP6ConcurrentReadWrite-2 66538 68190 +2.48%

benchmark old allocs new allocs delta
BenchmarkTCP4OneShot-2 39 36 -7.69%
BenchmarkTCP4OneShotTimeout-2 42 36 -14.29%
BenchmarkTCP4Persistent-2 1 0 -100.00%
BenchmarkTCP4PersistentTimeout-2 1 0 -100.00%
BenchmarkTCP6OneShot-2 41 36 -12.20%
BenchmarkTCP6OneShotTimeout-2 43 36 -16.28%
BenchmarkTCP6Persistent-2 1 0 -100.00%
BenchmarkTCP6PersistentTimeout-2 1 0 -100.00%
BenchmarkTCP4ConcurrentReadWrite-2 0 0 n/a%
BenchmarkTCP6ConcurrentReadWrite-2 0 0 n/a%

benchmark old bytes new bytes delta
BenchmarkTCP4OneShot-2 3084 2544 -17.51%
BenchmarkTCP4OneShotTimeout-2 3129 2519 -19.50%
BenchmarkTCP4Persistent-2 30 0 -100.00%
BenchmarkTCP4PersistentTimeout-2 31 0 -100.00%
BenchmarkTCP6OneShot-2 3297 2660 -19.32%
BenchmarkTCP6OneShotTimeout-2 3306 2655 -19.69%
BenchmarkTCP6Persistent-2 31 0 -100.00%
BenchmarkTCP6PersistentTimeout-2 29 0 -100.00%
BenchmarkTCP4ConcurrentReadWrite-2 2 0 -100.00%
BenchmarkTCP6ConcurrentReadWrite-2 7 0 -100.00%

R=dvyukov, minux.ma, dave, bradfitz, alex.brainman
CC=golang-dev
https://golang.org/cl/8264043

cb3b2922

runtime: remove old preemption checks · f195ae94

Dmitriy Vyukov authored Aug 15, 2013

runtime.gcwaiting checks are not needed anymore

R=golang-dev, khr
CC=golang-dev
https://golang.org/cl/12934043

f195ae94

runtime: fix plan9 build · 67c79da8
Dmitriy Vyukov authored Aug 15, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/12986043
```
67c79da8
doc: update go1.2.txt · 826a7396
Rémy Oudompheng authored Aug 15, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/12960043
```
826a7396