1. 13 Jun, 2014 11 commits
  2. 12 Jun, 2014 15 commits
  3. 11 Jun, 2014 7 commits
  4. 10 Jun, 2014 4 commits
  5. 06 Jun, 2014 1 commit
    • Russ Cox's avatar
      runtime: fix panic stack during runtime.Goexit during panic · 4534fdb1
      Russ Cox authored
      A runtime.Goexit during a panic-invoked deferred call
      left the panic stack intact even though all the stack frames
      are gone when the goroutine is torn down.
      The next goroutine to reuse that struct will have a
      bogus panic stack and can cause the traceback routines
      to walk into garbage.
      
      Most likely to happen during tests, because t.Fatal might
      be called during a deferred func and uses runtime.Goexit.
      
      This "not enough cleared in Goexit" failure mode has
      happened to us multiple times now. Clear all the pointers
      that don't make sense to keep, not just gp->panic.
      
      Fixes #8158.
      
      LGTM=iant, dvyukov
      R=iant, dvyukov
      CC=golang-codereviews
      https://golang.org/cl/102220043
      4534fdb1
  6. 05 Jun, 2014 2 commits
    • Russ Cox's avatar
      cmd/6g: fix stack zeroing on native client · ac0e12d1
      Russ Cox authored
      I am not sure what the rounding here was
      trying to do, but it was skipping the first
      pointer on native client.
      
      The code above the rounding already checks
      that xoffset is widthptr-aligned, so the rnd
      was a no-op everywhere but on Native Client.
      And on Native Client it was wrong.
      
      Perhaps it was supposed to be rounding down,
      not up, but zerorange handles the extra 32 bits
      correctly, so the rnd does not seem to be necessary
      at all.
      
      This wouldn't be worth doing for Go 1.3 except
      that it can affect code on the playground.
      
      Fixes #8155.
      
      LGTM=r, iant
      R=golang-codereviews, r, iant
      CC=dvyukov, golang-codereviews, khr
      https://golang.org/cl/108740047
      ac0e12d1
    • Russ Cox's avatar
      codereview: do not add defaultcc for private CLs · 32a5c898
      Russ Cox authored
      LGTM=r
      R=r, 0xjnml, bradfitz, iant
      CC=golang-codereviews
      https://golang.org/cl/103070046
      32a5c898