Commits · 1e09031f7f9293ba032c88abb55b373d341f01bf · go / golang

26 Jan, 2012 1 commit
- math/big: return type of bitLen is an int; use MOVL on amd64. · 1e09031f
  David G. Andersen authored Jan 26, 2012
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5577050
```
  1e09031f
25 Jan, 2012 31 commits

gofix: handle xml.Unmarshal in xmlapi fix · 9d4ae0ae

Gustavo Niemeyer authored Jan 25, 2012

This improves the handling of xml.Unmarshal in
the xmlapi fix by guessing some of the common
types used on it.

This also fixes a bug in the partial typechecker.
In an expression such as f(&a), it'd mark a as
having &T rather than *T.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5572058

9d4ae0ae

math/big: assembly versions of bitLen for x86-64, 386, and ARM. · 316f81bb

David G. Andersen authored Jan 25, 2012

Roughly 2x speedup for the internal bitLen function in arith.go.  Added TestWordBitLen test.

Performance differences against the new version of
bitLen generic:

x86-64 Macbook pro (current tip):

benchmark                old ns/op    new ns/op    delta
big.BenchmarkBitLen0             6            4  -37.40%
big.BenchmarkBitLen1             6            2  -51.79%
big.BenchmarkBitLen2             6            2  -65.04%
big.BenchmarkBitLen3             6            2  -66.10%
big.BenchmarkBitLen4             6            2  -60.96%
big.BenchmarkBitLen5             6            2  -55.80%
big.BenchmarkBitLen8             6            2  -56.19%
big.BenchmarkBitLen9             6            2  -64.73%
big.BenchmarkBitLen16            7            2  -68.84%
big.BenchmarkBitLen17            6            2  -67.11%
big.BenchmarkBitLen31            7            2  -61.57%

386 Intel Atom (current tip):
benchmark                old ns/op    new ns/op    delta
big.BenchmarkBitLen0            23           20  -13.04%
big.BenchmarkBitLen1            23           20  -14.77%
big.BenchmarkBitLen2            24           20  -19.28%
big.BenchmarkBitLen3            25           20  -21.57%
big.BenchmarkBitLen4            24           20  -16.94%
big.BenchmarkBitLen5            25           20  -20.78%
big.BenchmarkBitLen8            24           20  -19.28%
big.BenchmarkBitLen9            25           20  -20.47%
big.BenchmarkBitLen16           26           20  -23.37%
big.BenchmarkBitLen17           26           20  -25.09%
big.BenchmarkBitLen31           32           20  -35.51%

ARM v5 SheevaPlug, previous weekly patched with bitLen:
benchmark                old ns/op    new ns/op    delta
big.BenchmarkBitLen0            50           29  -41.73%
big.BenchmarkBitLen1            51           29  -42.75%
big.BenchmarkBitLen2            59           29  -50.08%
big.BenchmarkBitLen3            60           29  -50.75%
big.BenchmarkBitLen4            59           29  -50.08%
big.BenchmarkBitLen5            60           29  -50.75%
big.BenchmarkBitLen8            59           29  -50.08%
big.BenchmarkBitLen9            60           29  -50.75%
big.BenchmarkBitLen16           69           29  -57.35%
big.BenchmarkBitLen17           70           29  -57.89%
big.BenchmarkBitLen31           95           29  -69.07%

R=golang-dev, minux.ma, gri
CC=golang-dev
https://golang.org/cl/5574054

316f81bb

net/http: fix Transport deadlock · d645adc3

Yoshiyuki Kanno authored Jan 25, 2012

This patch intend to fix following issues.
http://code.google.com/p/go/issues/detail?id=2616

Fixes #2616.

R=golang-dev, bradfitz, nekotaroh
CC=golang-dev
https://golang.org/cl/5532057

d645adc3

gc: fix order of evaluation · ee9bfb02

Russ Cox authored Jan 25, 2012

Pulling function calls out to happen before the
expression being evaluated was causing illegal
reorderings even without inlining; with inlining
it got worse.  This CL adds a separate ordering pass
to move things with a fixed order out of expressions
and into the statement sequence, where they will
not be reordered by walk.

Replaces lvd's CL 5534079.

Fixes #2740.

R=lvd
CC=golang-dev
https://golang.org/cl/5569062

ee9bfb02

regexp: remove vestigial Error type · 73ce14d0
Brad Fitzpatrick authored Jan 25, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5573069
```
73ce14d0
net: fix dialing google test · 9acea02d
Mikio Hara authored Jan 25, 2012
```
R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5573060
```
9acea02d
go/doc: test cases for sort order · dbce368e
Robert Griesemer authored Jan 25, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5569059
```
dbce368e
go1: sub-repositories · 7eaad5e6
Rob Pike authored Jan 25, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5569065
```
7eaad5e6
syscall: add NOTE_* constants on OS X · 82d06e8f
Robert Figueiredo authored Jan 25, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/5570043
```
82d06e8f
A+C: Robert Figueiredo (individual CLA) · 9f16d7fb
Russ Cox authored Jan 25, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5574067
```
9f16d7fb

build: fix build · bf67a7b9

Russ Cox authored Jan 25, 2012

I said rm, but not hg rm.
I never was good at Simon says.

TBR=bradfitz
CC=golang-dev
https://golang.org/cl/5574066

bf67a7b9

net/http: disabled test for Transport race / deadlock bug · cf09a9d3

Brad Fitzpatrick authored Jan 25, 2012

The real fix for Issue 2616 is in
https://golang.org/cl/5532057, to be submitted
following this CL, without the test there which doesn't work
reliably. This one seems to.

R=rsc
CC=golang-dev
https://golang.org/cl/5569063

cf09a9d3

build: remove code now in subrepositories · 0368ca13
Russ Cox authored Jan 25, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5569064
```
0368ca13
gofix: update go1pkgrename for subrepositories · b6f671b9
Russ Cox authored Jan 25, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5576044
```
b6f671b9
gofix: add -debug flag for quicker diagnosis of internal errors · 2355d18e
Robert Griesemer authored Jan 25, 2012
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/5564055
```
2355d18e

codereview: more fixes · ceb59b06

Russ Cox authored Jan 25, 2012

Python and Mercurial are a matched pair.

R=adg
CC=golang-dev
https://golang.org/cl/5570065

ceb59b06

codereview: support for subrepositories · 79d2c570
Russ Cox authored Jan 25, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5564054
```
79d2c570

go/printer: factor some frequently used code · 8efc020d

Robert Griesemer authored Jan 25, 2012

Added a cache to compensate for extra call overhead.
go test -bench=Print marginally faster (in the noise).

R=r
CC=golang-dev
https://golang.org/cl/5574061

8efc020d

go/printer, gofmt: respect line breaks in signatures · d665ea98

Robert Griesemer authored Jan 25, 2012

No changes when applying gofmt to src, misc.

Fixes #2597.

R=r
CC=golang-dev
https://golang.org/cl/5564056

d665ea98

go/doc: test case for corner case (override of predecl. type) · 57af5429
Robert Griesemer authored Jan 25, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/5575055
```
57af5429

go/doc: clean rewrite of go/doc internals · 6d68be46

Robert Griesemer authored Jan 25, 2012

The implementation is divided into 4 phases:
1) export filtering of an incoming AST if necessary (exports.go)
2) reading of a possibly filtered AST (reader.go: type reader)
3) method set computation (reader.go)
4) sorting and creation of final documentation (reader.go)

In contrast to the old implementation, the presentation data
(Names, Docs, Decls, etc.) are created immediately upon reading
the respective AST node. Also, all types are collected (embedded
or not) in a uniform way.

Once the entire AST has been processed, all methods and types
have been collected and the method sets for each type can be
computed (phase 3).

To produce the final documentation, the method sets and value
maps are sorted.

There are no API changes. Passes the existing test suite unchanged.

R=rsc, rogpeppe
CC=golang-dev
https://golang.org/cl/5554044

6d68be46

gofmt: fix test.sh · 6e3af46e
Robert Griesemer authored Jan 25, 2012
```
R=adg, iant
CC=golang-dev
https://golang.org/cl/5573062
```
6e3af46e
os: pass tests on Plan 9 again · c93ca600
Fazlul Shahriar authored Jan 25, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5563046
```
c93ca600
runtime: move NumCPU declaration into debug.go. · 0ae9d812
David Symonds authored Jan 25, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/5574060
```
0ae9d812

archive/tar: fix race in TestNonSeekable · e3e1804e

Joel Sing authored Jan 25, 2012

Reimplement the test based on code from adg@golang.org.

The previous version has a race since the file is closed via defer
rather than in the go routine. This meant that the file could be
closed before the go routine has actually received io.EOF. It then
receives EBADF and continues to do zero-byte writes to the pipe.

This addresses an issue seen on FreeBSD and OpenBSD, where the test
passes but exits with a SIGPIPE, resulting in a failure.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5554083

e3e1804e

doc/go1: mime, filepath.Walk · dd442a55

Rob Pike authored Jan 25, 2012

R=golang-dev, gri, bradfitz, adg
CC=golang-dev
https://golang.org/cl/5571060

dd442a55

godoc: update metadata upon launch · 8eaf38cb

Andrew Gerrand authored Jan 25, 2012

Without this change it's possible to launch godoc,
immediately GET /, and see a directory listing instead of root.html

R=gri
CC=golang-dev
https://golang.org/cl/5575054

8eaf38cb

go/scanner: Use explicit scanner.Mode type. · 8b60613b
Robert Griesemer authored Jan 25, 2012
```
R=r, bradfitz
CC=golang-dev
https://golang.org/cl/5574059
```
8b60613b
net/http: parse CONNECT requests · c3b9650c
Andrew Balholm authored Jan 25, 2012
```
Fixes #2755

R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5571052
```
c3b9650c
doc/go1: add more info about hash and net changes, delete reference to html · 03ea8b1c
Rob Pike authored Jan 25, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5570060
```
03ea8b1c
go/parser: Use explicit parser.Mode type. · e7d513ea
Robert Griesemer authored Jan 25, 2012
```
R=r, bradfitz
CC=golang-dev
https://golang.org/cl/5574058
```
e7d513ea

24 Jan, 2012 8 commits

html: move the HTML parser to an exp/html package. The parser is a · 324513bc

Nigel Tao authored Jan 24, 2012

work in progress, and we are not ready to freeze its API for Go 1.

Package html still exists, containing just two functions: EscapeString
and UnescapeString.

Both the packages at exp/html and html are "package html". The former
is a superset of the latter.

At some point in the future, the exp/html code will move back into
html, once we have finalized the parser API.

R=rsc, dsymonds
CC=golang-dev
https://golang.org/cl/5571059

324513bc

encoding/xml: remove Marshaler support · 66599c40

Gustavo Niemeyer authored Jan 24, 2012

Marshaler has a number of open areas that need
further thought (e.g. it doesn't handle attributes,
it's supposed to handle tag names internally but has
no information to do so, etc).

We're removing it now and will bring it back with an
interface that covers these aspects, after Go 1.

Related to issue 2771, but doesn't fix it.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5574057

66599c40

math/big: add examples for Rat and Int's SetString and Scan methods · ddd67f2e
Andrew Gerrand authored Jan 24, 2012
```
R=golang-dev, bradfitz, rsc, r, gri, r
CC=golang-dev
https://golang.org/cl/5543047
```
ddd67f2e

encoding/xml: add docs for ignoring tag · e3ab30bb

Gustavo Niemeyer authored Jan 24, 2012

That was supposed to be in the original CL, but missed
the files.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5570052

e3ab30bb

text/template: add example for Template · 0bb8ce29
Andrew Gerrand authored Jan 24, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5564050
```
0bb8ce29
encoding/binary: document that PutVarint, PutUvarint may panic · 2c2c2022
Brad Fitzpatrick authored Jan 24, 2012
```
Fixes #2628

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5571058
```
2c2c2022
net: actually reset deadline when time is zero · fe30ed2d
Brad Fitzpatrick authored Jan 24, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5570056
```
fe30ed2d

build: do not build all C compilers · 0ae6084f

Shenghou Ma authored Jan 24, 2012

        In order to allow buildscript.sh to generate buildscripts for all
        $GOOS/$GOARCH combinations, we have to generate dummy files for cmd/go.
        Fixes #2586.

R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5557050

0ae6084f