Skip to content

G
golang
Switch branch/tag
  1. 25 Nov, 2012 1 commit
    • Dave Cheney's avatar
      time: add Now()/UnixNano() malloc tests · 1e9ab9e7
      Dave Cheney authored 
      The fix for issue 4403 may include more calls to time.Now().UnixNano(). I was concerned that if this function allocated it would cause additional garbage on the heap. It turns out that it doesn't, which is a nice surprise.

Also add benchmark for Now().UnixNano()

R=bradfitz, minux.ma
CC=golang-dev
https://golang.org/cl/6849097
      1e9ab9e7
  3. 24 Nov, 2012 7 commits
  5. 23 Nov, 2012 2 commits
  7. 21 Nov, 2012 9 commits
  9. 20 Nov, 2012 5 commits
  11. 19 Nov, 2012 7 commits
  13. 18 Nov, 2012 2 commits
    • Dave Cheney's avatar
      net: fix data race on fd.sysfd · c9856e7d
      Dave Cheney authored 
      Fixes #4369.

Remove the check for fd.sysfd < 0, the first line of fd.accept() tests if the fd is open correctly and will handle the fd being closed during accept.

R=dvyukov, bradfitz
CC=golang-dev
https://golang.org/cl/6843076
      c9856e7d
    • Dave Cheney's avatar
      net: remove unused nil check · 0bfece06
      Dave Cheney authored 
      This is part 1 of a series of proposals to fix issue 4369.

In resolving issue 3507 it was decided not to nil out the inner conn.fd field to avoid a race. This implies the checks for fd == nil inside incref/decref are never true.

Removing this logic removes one source of errClosing error values, which affects issue 4373 and moves towards bradfitz's request that fd.accept() return io.EOF when closed concurrently.

Update #4369.
Update #4373.

R=mikioh.mikioh, bradfitz, dvyukov, rsc
CC=golang-dev
https://golang.org/cl/6852057
      0bfece06
  15. 17 Nov, 2012 7 commits