- 12 Oct, 2012 5 commits
-
-
Shenghou Ma authored
Valgrind Massif result when linking godoc: On amd64: old new -/+ mem_heap_B 185844612 175358047 -5.7% mem_heap_extra_B 773404 773137 -0.0% On 386/ARM: old new -/+ mem_heap_B 141775701 131289941 -7.4% mem_heap_extra_B 737011 736955 -0.0% R=golang-dev, r, dave CC=golang-dev https://golang.org/cl/6655045
-
Shenghou Ma authored
Also, to aid debugging cmd/dist, make make.bat support --dist-tool flag. Fixes #3100. R=alex.brainman CC=golang-dev https://golang.org/cl/6637061
-
Rob Pike authored
Better explanation of width for floating-point values. Explain that scanning does not handle %#q etc. Fixes #4202. Fixes #4206. R=golang-dev, adg, rsc, iant CC=golang-dev https://golang.org/cl/6620074
-
Evan Shaw authored
Fixes #4031. R=golang-dev, bradfitz, remyoudompheng, r, dave CC=golang-dev https://golang.org/cl/6632046
-
Rob Pike authored
Fixes #4236. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6658051
-
- 11 Oct, 2012 11 commits
-
-
Andrew Gerrand authored
R=golang-dev, dsymonds, r CC=golang-dev https://golang.org/cl/6615078
-
Robert Griesemer authored
Minor performance impact running sequentially: benchmark old ns/op new ns/op delta BenchmarkString10Base2 389 391 +0.51% BenchmarkString100Base2 1530 1534 +0.26% BenchmarkString1000Base2 11789 11787 -0.02% BenchmarkString10000Base2 111443 112030 +0.53% BenchmarkString100000Base2 1017483 1015347 -0.21% BenchmarkString10Base8 339 344 +1.47% BenchmarkString100Base8 753 756 +0.40% BenchmarkString1000Base8 4618 4641 +0.50% BenchmarkString10000Base8 43217 43534 +0.73% BenchmarkString100000Base8 397518 400602 +0.78% BenchmarkString10Base10 630 630 +0.00% BenchmarkString100Base10 1975 1960 -0.76% BenchmarkString1000Base10 10179 10174 -0.05% BenchmarkString10000Base10 44527 44416 -0.25% BenchmarkString100000Base10 14404694 14425308 +0.14% BenchmarkString10Base16 283 288 +1.77% BenchmarkString100Base16 597 598 +0.17% BenchmarkString1000Base16 3189 3186 -0.09% BenchmarkString10000Base16 29403 29364 -0.13% BenchmarkString100000Base16 265657 265587 -0.03% Note that due to other improvements (faster assembly routines, better code generation by compiler), these benchmarks now run up to 37% faster than they used to at the last time measured (1/9/2012). Minor performance impact for StringPiParallel running in parallel: Current CL but with Lock/Unlock commented out (removed): BenchmarkStringPiParallel 5000 343581 ns/op BenchmarkStringPiParallel-2 10000 184511 ns/op BenchmarkStringPiParallel-3 10000 129768 ns/op BenchmarkStringPiParallel-4 10000 102326 ns/op Current CL: BenchmarkStringPiParallel 5000 345169 ns/op BenchmarkStringPiParallel-2 10000 185827 ns/op BenchmarkStringPiParallel-3 10000 131168 ns/op BenchmarkStringPiParallel-4 10000 102353 ns/op Fixes #4218. R=dvyukov, michael.jones, dave CC=golang-dev https://golang.org/cl/6643053
-
Adam Langley authored
I was an idiot and was thinking that a small base didn't matter because the exponentiation would quickly make the number the same size as the modulus. But, of course, the small base continues to make multiplications unrealistically cheap throughout the computation. R=golang-dev, r CC=golang-dev https://golang.org/cl/6649048
-
Dave Cheney authored
Fixes #4220. R=dvyukov, bradfitz CC=golang-dev https://golang.org/cl/6638053
-
Dave Cheney authored
Update #4191. Fixes unreported race failure at http://build.golang.org/log/61e43a328fb220801d3d5c88cd91916cfc5dc43c R=dvyukov, bradfitz CC=golang-dev https://golang.org/cl/6640057
-
Adam Langley authored
It was suggested that it's too easy to use crypto/hmac insecurely and I think that has some merit. This change adds a Equal function to make it obvious that MAC values should be compared in constant time. R=rsc, max CC=golang-dev https://golang.org/cl/6632044
-
Shenghou Ma authored
0. windows uses all.bat instead of ./all.bash 1. correct expected all.bash output 2. mention you need to use an application specific password if you're using 2-step verification 3. note you can edit files included in CL by 'hg change NNNN' or 'hg file' R=golang-dev, adg, r CC=golang-dev https://golang.org/cl/6615060
-
Andrew Gerrand authored
R=golang-dev CC=golang-dev https://golang.org/cl/6641058
-
Andrew Gerrand authored
Fixes #3948. R=golang-dev, r, dave, dsymonds CC=golang-dev https://golang.org/cl/6639064
-
Jimmy Zelinskie authored
Fixes #3733 Fixes #2149 Updated Syntax Added part3.go example program Added part3-errorhandling.go example program Improved wording in some places R=golang-dev, adg, minux.ma CC=golang-dev https://golang.org/cl/6636048
-
Andrew Gerrand authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/6642068
-
- 10 Oct, 2012 18 commits
-
-
Andrew Gerrand authored
Fixes #4225. R=golang-dev CC=golang-dev https://golang.org/cl/6640054
-
Shenghou Ma authored
R=adg CC=golang-dev https://golang.org/cl/6604062
-
Andrew Gerrand authored
R=golang-dev, skybrian CC=golang-dev https://golang.org/cl/6643062
-
Rémy Oudompheng authored
The other tests either need a complex procedure or are architecture- or OS-dependent. Update #4139. R=golang-dev, daniel.morsing, iant CC=golang-dev https://golang.org/cl/6618062
-
Taj Khattra authored
benchmark old ns/op new ns/op delta BenchmarkDup 3075682 609448 -80.18% R=gri CC=golang-dev https://golang.org/cl/6613064
-
Robert Griesemer authored
R=golang-dev, r, bradfitz CC=golang-dev https://golang.org/cl/6635061
-
Shenghou Ma authored
Fixes #4208. R=golang-dev, iant CC=golang-dev https://golang.org/cl/6635064
-
Dmitriy Vyukov authored
If source are not available, then the stack looks like: stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:15 (0x43fb11) stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:18 (0x43fb7a) stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:37 (0x43fbf4) stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/testing/bla-bla-bla/src/pkg/testing/testing.go:301 (0x43b5ba) stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/bla-bla-bla/src/pkg/runtime/proc.c:276 (0x410670) stack_test.go:40: which is 6 lines. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/6637060
-
Uriel Mangado authored
In recent Python versions .reason is a read-only property that simply gives you the msg value. Fixes #4024 R=golang-dev, adg CC=golang-dev https://golang.org/cl/6545052
-
Dmitriy Vyukov authored
The compiler is crashing on the following code: type TypeID int func (t *TypeID) encodeType(x int) (tt TypeID, err error) { switch x { case 0: return t.encodeType(x * x) } return 0, nil } The pass marks "return struct" {tt TypeID, err error} as used, and this causes internal check failure. I've added the test to: https://golang.org/cl/6525052/diff/7020/src/pkg/runtime/race/regression_test.go R=golang-dev, minux.ma, rsc CC=golang-dev https://golang.org/cl/6611049
-
Dmitriy Vyukov authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6632051
-
Rob Pike authored
It's already there but only in the "for instance" and so not clear enough: deferred functions run after the result parameters are updated. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6631058
-
Andrew Gerrand authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/6631059
-
Andrew Gerrand authored
R=golang-dev, edsrzf CC=golang-dev https://golang.org/cl/6633051
-
Andrew Gerrand authored
R=gri, dsymonds, skybrian CC=golang-dev https://golang.org/cl/6631057
-
Andrew Gerrand authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6633050
-
Robert Griesemer authored
Also: - Refactored testing framework to permit easier idempotency testing. - Applied gofmt -w src misc This CL depends on CL 6639044 being applied first. Formatting is not idempotent for all files: In those files the comment position has changed (due to missing precise location information) and/or the comment formatting cannot/is not aware of independent code re-formatting. In general it is very hard to make format idempotent when running it in one pass only. Leaving that aside for now. Fixes #1835. R=r, rsc CC=golang-dev https://golang.org/cl/6624051
-
Robert Griesemer authored
Preparation for forthcoming CL 6624051: Will make it easier to see if/what changes are incurred by it. The alignment changes in this CL are due to CL 6610051 (fix to alignment heuristic) where it appears that an old version of gofmt was run (and thus the correct alignment updates were not done). R=r CC=golang-dev https://golang.org/cl/6639044
-
- 09 Oct, 2012 6 commits
-
-
Ian Lance Taylor authored
Background on build ID: http://fedoraproject.org/wiki/RolandMcGrath/BuildID R=rsc CC=golang-dev https://golang.org/cl/6625072
-
Brad Fitzpatrick authored
R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/6632053
-
Shenghou Ma authored
R=golang-dev CC=golang-dev https://golang.org/cl/6631054
-
Adam Langley authored
I typoed the code and tried to parse all the way to the end of the message. Therefore it fails when NPN is not the last extension in the ServerHello. Fixes #4088. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6637052
-
Dmitriy Vyukov authored
Fixes #4212. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6641050
-
Shenghou Ma authored
1. correctly initialize .plt.got entries (point to the 1st entry) 2. add section .rel.plt (FreeBSD insists PLT relocs to be there) 3. put relocs of .got.plt into .rel.plt 4. set ELFOSABI_FREEBSD in ELF header R=rsc CC=golang-dev https://golang.org/cl/6643050
-