- 14 Jul, 2015 10 commits
-
-
Nevins Bartolomeo authored
Change-Id: Ifbab8203dea1eb0df4c834df22e12cb7c37c14fd Reviewed-on: https://go-review.googlesource.com/10683Reviewed-by:
Adam Langley <agl@golang.org> Run-TryBot: Russ Cox <rsc@golang.org>
-
David Crawshaw authored
Fixes #9769. Change-Id: I2959906c71d0ce62cdb750dab78eab631a26f229 Reviewed-on: https://go-review.googlesource.com/12080Reviewed-by:
Rob Pike <r@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Ian Lance Taylor authored
Fixes #10193. Change-Id: Ibbb747babb697a66b943e5da76b0ada41f1fb14f Reviewed-on: https://go-review.googlesource.com/12070 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Ian Lance Taylor authored
Fixes #11704. Change-Id: If103f8eca7e53b0120885e2ec086db12176ea078 Reviewed-on: https://go-review.googlesource.com/12155Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Nigel Tao authored
This rolls back most of golang.org/cl/8841, aka 2f98bac3, and makes a different fix. It keeps the TestTruncatedSOSDataDoesntPanic test introduced by that other CL, which obviously still passes after this CL. Fixes #11650, a regression (introduced by cl/8841) from Go 1.4. The original cl/8841 changed the image/jpeg not to panic on an input given in #10387. We still do not panic on that input, after this CL. I have a corpus of over 160,000 JPEG images, a sample of a web crawl. The image/jpeg code ran happily over that whole corpus both before and after this CL, although that corpus clearly didn't catch the regression in the first place. This code was otherwise tested manually. I don't think that it's trivial to synthesize a JPEG input that happens to run out of Huffman data at just the right place. The test image attached to #11650 obviously has that property, but I don't think we can simply add that test image to the repository: it's 227KiB, and I don't know its copyright status. I also looked back over the issue tracker for problematic JPEGs that people have filed. The Go code, after this CL, is still happy on these files in my directory: issue2362a.jpeg issue3916.jpeg issue3976.jpeg issue4084.jpeg issue4259.jpeg issue4291.jpeg issue4337.jpeg issue4500.jpeg issue4705.jpeg issue4975.jpeg issue5112.jpeg issue6767.jpeg issue9888.jpeg issue10133.jpeg issue10357.jpeg issue10447.jpeg issue11648.jpeg issue11650.jpeg There were other images attached in the issue tracker that aren't actually valid JPEGs. They failed both before and after this CL: broken-issue2362b.jpeg broken-issue6450.jpeg broken-issue8693.jpeg broken-issue10154.jpeg broken-issue10387.jpeg broken-issue10388.jpeg broken-issue10389.jpeg broken-issue10413.jpeg In summary, this CL fixes #11650 and, after some automated and manual testing, I don't think introduces new regressions. Change-Id: I30b67036e9b087f3051d57dac7ea05fb4fa36f66 Reviewed-on: https://go-review.googlesource.com/12163Reviewed-by:
Rob Pike <r@golang.org>
-
Rob Pike authored
Change-Id: I7ad90ab78abb8a39d56c837610d5c311a96b7039 Reviewed-on: https://go-review.googlesource.com/12162Reviewed-by:
Nigel Tao <nigeltao@golang.org>
-
Brad Fitzpatrick authored
Fixes build from https://golang.org/cl/12152 Plan 9 lacks syscall.EPIPE. I was misled by api/go1.txt and also forgot to use the trybots. :( Change-Id: I4982fe969ad4a8724090cb03009bfb21780d8aa7 Reviewed-on: https://go-review.googlesource.com/12153 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Rob Pike <r@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Ross Light authored
Add tests for isSecure function. Change-Id: I49de9d2846b75d4c7be745484f85d351a6fd851d Reviewed-on: https://go-review.googlesource.com/11514Reviewed-by:
Russ Cox <rsc@golang.org>
-
Russ Cox authored
Fixes #11656 (again). Change-Id: I170ff10bfbdb0f34e57c11de42b6ee5291837813 Reviewed-on: https://go-review.googlesource.com/12142Reviewed-by:
Russ Cox <rsc@golang.org>
-
Brad Fitzpatrick authored
Fixes #9173 Change-Id: I83530533db84b07cb88dbf6ec690be48a06a9d7d Reviewed-on: https://go-review.googlesource.com/12152Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
- 13 Jul, 2015 14 commits
-
-
Rob Pike authored
Still to do: ARM64 and PPC64. These architectures are woefully underdocumented. Change-Id: Iedcf767a7e0e1c931812351940bc08f0c3821212 Reviewed-on: https://go-review.googlesource.com/12110Reviewed-by:
Russ Cox <rsc@golang.org>
-
Rob Pike authored
The old numerical names like 6.out.go are a relic from the old tools. Easier to rename than explain. The anames.go files were modified by go generate; no changes beyond the explanatory comment at the top. Change-Id: I84742c75c60e47724baa9d49a91fef1f8581f021 Reviewed-on: https://go-review.googlesource.com/12069 Run-TryBot: Rob Pike <r@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Austin Clements authored
These memstats are currently being computed by gcMark, which was appropriate in Go 1.4, but gcMark is now just one part of a bigger picture. In particular, it can't account for the sweep termination pause time, it can't account for all of the mark termination pause time, and the reported "pause end" and "last GC" times will be slightly earlier than they really are. Lift computing of these statistics into func gc, which has the appropriate visibility into the process to compute them correctly. Fixes one of the issues in #10323. This does not add new statistics appropriate to the concurrent collector; it simply fixes existing statistics that are being misreported. Change-Id: I670cb16594a8641f6b27acf4472db15b6e8e086e Reviewed-on: https://go-review.googlesource.com/11794Reviewed-by:
Russ Cox <rsc@golang.org>
-
Austin Clements authored
Currently we report MemStats.PauseEnd in nanoseconds, but with no particular 0 time. On Linux, the 0 time is when the host started. On Darwin, it's the UNIX epoch. This is also inconsistent with the other absolute time in MemStats, LastGC, which is always reported in nanoseconds since 1970. Fix PauseEnd so it's always reported in nanoseconds since 1970, like LastGC. Fixes one of the issues raised in #10323. Change-Id: Ie2fe3169d45113992363a03b764f4e6c47e5c6a8 Reviewed-on: https://go-review.googlesource.com/11801 Run-TryBot: Austin Clements <austin@google.com> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Russ Cox authored
Fixes #11656. Change-Id: Ib81d583e4b004e67dc9d2f898fd798112434e7a9 Reviewed-on: https://go-review.googlesource.com/12026Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Russ Cox <rsc@golang.org>
-
Russ Cox authored
Fixes race detector build. Change-Id: I8bdc78d57487580e6b5b8c415df4653a1ba69e37 Reviewed-on: https://go-review.googlesource.com/12087Reviewed-by:
Austin Clements <austin@google.com>
-
Mikio Hara authored
This change does clean up as preparation for fixing #11081. - renames cfg to resolvConf for clarification - adds a new type resolverConfig and its methods: init, update, tryAcquireSema, releaseSema for mutual exclusion of resolv.conf data - deflakes, simplifies tests for resolv.conf data; previously the tests sometimes left some garbage in the data Change-Id: I277ced853fddc3791dde40ab54dbd5c78114b78c Reviewed-on: https://go-review.googlesource.com/10931Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Russ Cox authored
Fixes #11307. Fixes #11055. Change-Id: I8d6b04cb509e62e27d6935b91ffe35fdaea4ebcd Reviewed-on: https://go-review.googlesource.com/12028Reviewed-by:
Ian Lance Taylor <iant@golang.org> Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Russ Cox authored
Missed select case when adding the barrier last time. All the more reason to refactor this code in Go 1.6. Fixes #11643. Change-Id: Ib0d19d6e0939296c0a3e06dda5e9b76f813bbc7e Reviewed-on: https://go-review.googlesource.com/12086Reviewed-by:
Austin Clements <austin@google.com>
-
Alan Donovan authored
This is a copy of an upstream change to the tools repo: https://go-review.googlesource.com/#/c/8924/ This is a second attempt at CL 8954, with the necessary change to go/build's deps test. Change-Id: Ib798498cf85fea0baec5667e9324d11f6ae8ad64 Reviewed-on: https://go-review.googlesource.com/9173Reviewed-by:
Robert Griesemer <gri@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Nigel Tao authored
Fixes #11604 The gray-gradient.png image was created by a Go program: ---- package main import ( "image" "image/color" "image/png" "log" "os" ) func main() { f, err := os.Create("a.png") if err != nil { log.Fatal(err) } defer f.Close() m := image.NewGray(image.Rect(0, 0, 1, 16)) for i := 0; i < 16; i++ { m.SetGray(0, i, color.Gray{uint8(i * 0x11)}) } err = png.Encode(f, m) if err != nil { log.Fatal(err) } } ---- The equivalent gray-gradient.interlaced.png image was created via ImageMagick: $ convert -interlace PNG gray-gradient.png gray-gradient.interlaced.png As a sanity check: $ file gray-gradient.* gray-gradient.interlaced.png: PNG image data, 1 x 16, 4-bit grayscale, interlaced gray-gradient.png: PNG image data, 1 x 16, 8-bit grayscale, non-interlaced Change-Id: I7700284f74d1ea30073aede3bce4d7651787bdbc Reviewed-on: https://go-review.googlesource.com/12064Reviewed-by:
Rob Pike <r@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Michael Hudson-Doyle authored
This is clearly what was intended all along. ./all.bash passes with this change. Change-Id: I16996da11cf1e4d2dc2a4434b7611a724691e8dc Reviewed-on: https://go-review.googlesource.com/12068Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Fixes #10246 Change-Id: Ifa698232a09e1c37f3a9340ffdc1f2650c06fe4c Reviewed-on: https://go-review.googlesource.com/11900Reviewed-by:
Rob Pike <r@golang.org>
-
Rob Pike authored
Fixes #11662. Change-Id: I8839b48a1cd3da4c29b6def03cb0c74c1c12942e Reviewed-on: https://go-review.googlesource.com/12066Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
- 12 Jul, 2015 4 commits
-
-
Ian Lance Taylor authored
Fixes #11273. Change-Id: I409b6c4168711913076439036d65e8639ca3b06f Reviewed-on: https://go-review.googlesource.com/12073Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Alex Brainman authored
Update #11654 Change-Id: Ia199b8dd349542ad8b92b463dd2f3734dd7e66a4 Reviewed-on: https://go-review.googlesource.com/12060 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
The previous commit (git 2ae77376) just did golang.org. This one includes golang.org subdomains like blog, play, and build. Change-Id: I4469f7b307ae2a12ea89323422044e604c5133ae Reviewed-on: https://go-review.googlesource.com/12071Reviewed-by:
Rob Pike <r@golang.org>
-
Hariharan Srinath authored
Adds the clarification that these functions return empty string if the requested element is not available Added fullstops Fixes #11664 Change-Id: I84173862bc785240f7d3ee75a5023673264d172b Reviewed-on: https://go-review.googlesource.com/12061Reviewed-by:
Rob Pike <r@golang.org>
-
- 11 Jul, 2015 4 commits
-
-
Brad Fitzpatrick authored
The one in misc/makerelease/makerelease.go is particularly bad and probably warrants rotating our keys. I didn't update old weekly notes, and reverted some changes involving test code for now, since we're late in the Go 1.5 freeze. Otherwise, the rest are all auto-generated changes, and all manually reviewed. Change-Id: Ia2753576ab5d64826a167d259f48a2f50508792d Reviewed-on: https://go-review.googlesource.com/12048Reviewed-by:
Rob Pike <r@golang.org>
-
Brad Fitzpatrick authored
Fixes #11552 Change-Id: I87904e9e3fb4bd1fb4c7075a4e2d0151e5bd37df Reviewed-on: https://go-review.googlesource.com/11890 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Elias Naur authored
The default behaviour for fatal errors and runtime panics is to dump the goroutine stack traces and exit with code 2. However, when the process is owned by foreign code, it is suprising and inappropriate to suddenly exit the whole process, even on fatal errors. Instead, re-use the crash behaviour from GOTRACEBACK=crash and abort. The motivating use case is issue #11382, where an Android crash reporter is confused by an exiting process, but I believe the aborting behaviour is appropriate for all cases where Go does not own the process. The change is simple and contained and will enable reliable crash reporting for Android apps in Go 1.5, but I'll leave it to others to judge whether it is too late for Go 1.5. Fixes #11382 Change-Id: I477328e1092f483591c99da1fbb8bc4411911785 Reviewed-on: https://go-review.googlesource.com/12032Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Alex Brainman authored
Recent change (CL 10370) unexpectedly broke TestRaiseException on Windows XP amd64. I still do not know why. But reverting old CL 8165 fixes the problem. This effectively makes Windows XP amd64 use AddVectoredContinueHandler instead of SetUnhandledExceptionFilter for exception handling. That is what we do for all recent Windows versions too. Fixes #11481 Change-Id: If2e8037711f05bf97e3c69f5a8d86af67c58f6fc Reviewed-on: https://go-review.googlesource.com/11888 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> Reviewed-by:
Daniel Theophanes <kardianos@gmail.com> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
- 10 Jul, 2015 8 commits
-
-
Charlie Dorian authored
Fixes #11442 Change-Id: I2053fe752c6a122924d28565f1338f73e00ed417 Reviewed-on: https://go-review.googlesource.com/11791Reviewed-by:
David Chase <drchase@google.com> Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Robert Griesemer <gri@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Matthew Dempsky authored
Instead of silently truncating integers to their expected range, check that they're within range and emit errors if not. Intended to help narrow down the cause of issue #11617. Change-Id: Ia7b577270f8438ca7479262702371e26277f1ea7 Reviewed-on: https://go-review.googlesource.com/12050Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Ian Lance Taylor authored
When GOROOT_FINAL is set when running all.bash, the tests are run before the files are copied to GOROOT_FINAL. The tests are run with GOROOT set, so most work fine. This fixes two cases that do not. In cmd/go/go_test.go we were explicitly removing GOROOT from the environment, causing tests that did not themselves explicitly set GOROOT to fail. There was no need to explicitly remove GOROOT, so don't do it. If people choose to run "go test cmd/go" with a bad GOROOT, that is their own lookout. In the runtime GDB test, the linker has told gdb to find the support script in GOROOT_FINAL, which will fail. Check for that case, and skip the test when we see it. Fixes #11652. Change-Id: I4d3a32311e3973c30fd8a79551aaeab6789d0451 Reviewed-on: https://go-review.googlesource.com/12021 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Ian Lance Taylor authored
Update #11609. Change-Id: Ie363facf13f5e62f1af4a8bdc42a18fb36e16ebf Reviewed-on: https://go-review.googlesource.com/12022Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Mikio Hara authored
Don't treat IPv4-mapped link-local IP addresses as IPv6 link-local addresses, an IPv4 broadcast address as a global unicast IP address. Fixes #11585. Change-Id: I6a7a0c0601f18638f5c624ab63e12ee40f77b182 Reviewed-on: https://go-review.googlesource.com/11883Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Mikio Hara authored
Updates #6465. Change-Id: I5babbcf4c92dae47c823a41628b01e4ceb2332eb Reviewed-on: https://go-review.googlesource.com/11951 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Rob Pike authored
People use 80-column terminals because their grandparents used punched cards. When I last used a punched card, in 1978, it seemed antiquated even then. But today, people still set their terminal widths to 80 to honor the struggles their fallen ancestors made to endure this painful technology. We must all stand and salute the 80 column flag, or risk the opprobium of our peers. For Pete's sake, I don't even use a fixed-width font. I don't even believe in columns. Fixes #11639 with extreme reluctance. P.S. To avoid the horror of an automatically folded line of text, this commit message has been formatted to fit on an 80-column line, except for this postscript. Change-Id: Ia2eb2dcf293dabe804c22ee5abb4bbb703f45c33 Reviewed-on: https://go-review.googlesource.com/12011Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Alex Brainman authored
Section.Data returns disk section data, but those are rounded up to some predefined value. Processing these as is confuses dwarf parser because of garbage at the end. Truncate Section.Data as per memory section description. Sometimes dwarf sections have memory section size of 0 (for pe object files). Keep those to their disk size. Fixes #11608 Change-Id: I8de0a2271201a24aa9ac8dac44f1e9c8a9285183 Reviewed-on: https://go-review.googlesource.com/11950Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-