- 05 Sep, 2015 5 commits
-
-
Dave Cheney authored
This one of a set of changes to make the transition away from NodeList easier by removing cases in which NodeList doesn't act semi-trivially like a []*Node. This CL was originally prepared by Josh Bleecher Snyder <josharian@gmail.com>. This change passes go build -toolexec 'toolstash -cmp' -a std. Change-Id: I582ff8b077eb384b84721a1edb0c1efbc0c40059 Reviewed-on: https://go-review.googlesource.com/14304Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Dave Cheney <dave@cheney.net> Run-TryBot: Dave Cheney <dave@cheney.net> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Paul Marks authored
When running an experimental kernel with IPv4 disabled, Listen(":port") currently tries to create an AF_INET socket, and fails. Instead, it should see !supportsIPv4, and use an AF_INET6 socket. This sort of environment is quite esoteric at the moment, but I can force the tests to fail on regular Linux using the following tweaks: - net/net.go: supportsIPv4, supportsIPv6, supportsIPv4map = false, true, false - net/sockopt_linux.go: ipv6only=true - net/ipsock_posix.go: Revert this fix - ./make.bash && ../bin/go test net Also, make the arrows in server_test.go point to the left, because server<-client is easier to read. Fixes #12510 Change-Id: I0cc3b6b08d5e6908d2fbf8594f652ba19815aa4b Reviewed-on: https://go-review.googlesource.com/14334 Run-TryBot: Paul Marks <pmarks@google.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Dave Cheney authored
This is a first of a set of changes to make the transition away from NodeList easier by removing cases in which NodeList doesn't act semi-trivially like a []*Node. This CL was originally prepared by Josh Bleecher Snyder <josharian@gmail.com>. This change passes go build -toolexec 'toolstash -cmp' -a std. Change-Id: Iad10b75e42b5b24e1694407841282fa3bab2dc9f Reviewed-on: https://go-review.googlesource.com/14232 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Russ Cox authored
This is more correct with respect to garbage collection. I don't know of any specific failures it could cause today. Change-Id: I7eed6a06d2f281051199e79e4a9913aa8360ded7 Reviewed-on: https://go-review.googlesource.com/14137Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Robert Griesemer authored
Also go generate to update generated files. Change-Id: I049708db93455f0030ba5afc6f218fde6220958d Reviewed-on: https://go-review.googlesource.com/14331Reviewed-by:
Damien Neil <dneil@google.com>
-
- 04 Sep, 2015 17 commits
-
-
Shawn Walker-Salas authored
TestNoteReading fails on Solaris with linkmode=external due to some assumptions made about how ELF .note sections are written by some linkers. On current versions of Solaris and older derivatives, SHF_ALLOC is intentionally ignored for .note sections unless the .note section is assigned to the text segment via a mapfile. Also, if .note sections are assigned to the text segment, no PT_NOTE program header will be created thwarting Go's attempts at attempting to quickly find the .note. Furthermore, Go assumes that the relevant note segment will be placed early in the file while the Solaris linker currently places the note segment last in the file, additionally thwarting Go's optimisation attempts that read only the first 16KB of the file to find the buildid. The fix is to detect when the note section is outside of the first 16KB of the file and then fallback to additionally reading that section of the file. This way, in future versions of Solaris when this linking behaviour is changed, the fast path will always succeed and we'll only be slower if it fails; likewise, any other linker that does this will also just work. Fixes #12178 Change-Id: I61c1dc3f744ae3ad63938386d2ace8a432c0efe1 Reviewed-on: https://go-review.googlesource.com/14210 Run-TryBot: Aram Hăvărneanu <aram@mgk.ro> Reviewed-by:
Aram Hăvărneanu <aram@mgk.ro>
-
Dave Cheney authored
Revert "cmd/internal/ld: put read-only relocated data into .data.rel.ro when making a shared object" This reverts commit 2c2cbb69. Broke darwin/arm64 Change-Id: Ibd2dea475d6ce6a8b4b40e2da19a83fc0514025d Reviewed-on: https://go-review.googlesource.com/14301Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Dan Peterson authored
Fixes #8434 Change-Id: I323222b4160f3aba35cac1de7f6df93c524b72ec Reviewed-on: https://go-review.googlesource.com/14169Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Artyom Pervukhin authored
Optimize two calls of io.Copy which cannot make use of neither io.ReaderFrom nor io.WriterTo optimization tricks by replacing them with io.CopyBuffer with reusable buffers. First is fallback call to io.Copy when server misses the optimized case of using sendfile to copy from a regular file to net.TCPConn; second is use of io.Copy on piped reader/writer when handler implementation uses http.CloseNotifier interface. One of the notable users of http.CloseNotifier is httputil.ReverseProxy. benchmark old ns/op new ns/op delta BenchmarkCloseNotifier-4 309591 303388 -2.00% benchmark old allocs new allocs delta BenchmarkCloseNotifier-4 50 49 -2.00% benchmark old bytes new bytes delta BenchmarkCloseNotifier-4 36168 3140 -91.32% Fixes #12455 Change-Id: I512e6aa2f1aeed2ed00246afb3350c819b65b87e Reviewed-on: https://go-review.googlesource.com/14177 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Nodir Turakulov authored
Fixes #11000 Change-Id: Ic137e8a6c5c6b5b7eee213aca9acf78368e1d686 Reviewed-on: https://go-review.googlesource.com/14296Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Didier Spezia authored
Simplify slice/map literal expressions. Caught with gofmt -d -s, fixed with gofmt -w -s Checked that the result can still be compiled with Go 1.4. Change-Id: I5c58801c20919618d2ad52b8e2380d53df2783f1 Reviewed-on: https://go-review.googlesource.com/13831Reviewed-by:
Andrew Gerrand <adg@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Didier Spezia authored
Simplify slice/map literal expressions. Caught with gofmt -d -s, fixed with gofmt -w -s Change-Id: Iefd5f263c4f89a81da9427a7b9d97f13c35ab64f Reviewed-on: https://go-review.googlesource.com/13838Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Michael Hudson-Doyle authored
All the code was there to do this, it just wasn't hooked up. Fixes #10914 Change-Id: Ide8f9bbe50fecb5d11cd579915ee98d4c7efe403 Reviewed-on: https://go-review.googlesource.com/14142Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Michael Hudson-Doyle authored
This is generated during fp code when -shared is active. Change-Id: Ia1092299b9c3b63ff771ca4842158b42c34bd008 Reviewed-on: https://go-review.googlesource.com/14286Reviewed-by:
Ian Lance Taylor <iant@golang.org> Reviewed-by:
Dave Cheney <dave@cheney.net>
-
Shenghou Ma authored
Some symbols, for example, masks requires 16-byte alignment, and they are placed in the text section. Before this change, the text section is only aligned to 4-byte, and it's making masks unaligned. Fixes #12415. Change-Id: I7767778d1b4f7d3e74c2719a02848350782a4160 Reviewed-on: https://go-review.googlesource.com/14166 Run-TryBot: Minux Ma <minux@golang.org> Reviewed-by:
Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Michael Hudson-Doyle authored
Currently Go produces shared libraries that cannot be shared between processes because they have relocations against the text segment (not text section). This fixes this by moving some data to sections with magic names recognized by the static linker. Fixes #10914 Updates #9210 Change-Id: I7178daadc0ae87953d5a084aa3d580f4e3b46d47 Reviewed-on: https://go-review.googlesource.com/10300 Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Michael Hudson-Doyle authored
The lexer needs to process all #if[n]defs, even those found when processing is disabled by a preceding failed conditional, or the first #endif in something like: #ifdef <undefined> #ifdef whatever #endif #endif terminates the first #ifdef and the second causes an error. And then the processing of the inner #ifdefs needs to ignore their argument when they are disabled by an outer failed condition. Change-Id: Iba259498f1e16042f5b7580b9c000bb0599733d0 Reviewed-on: https://go-review.googlesource.com/14253Reviewed-by:
Rob Pike <r@golang.org>
-
Alex Brainman authored
Allow registry blobs to be as large as 500MB Update #12493 Change-Id: I1d0e5c10772d25f8e7e17fed6e2e7dd12ca4e7cf Reviewed-on: https://go-review.googlesource.com/14287Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Andrew Gerrand authored
Change-Id: Iab669b2a9dd0510c0e54f9ec1cbe2b83b991bceb Reviewed-on: https://go-review.googlesource.com/14283Reviewed-by:
Minux Ma <minux@golang.org>
-
Michael Hudson-Doyle authored
And do it properly so freebsd and nacl still work. Change-Id: I6f9f30e93ceae6dee59215ed608c6a158bdbdbb0 Reviewed-on: https://go-review.googlesource.com/14280 Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Shenghou Ma authored
Fixes #12454. Change-Id: I6406b0119bc4d6c3d1e6f1896b588b7d101448a3 Reviewed-on: https://go-review.googlesource.com/14274 Run-TryBot: Minux Ma <minux@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Joe Tsai authored
Explicitly say that *Table returned by MakeTable may not be modified. Otherwise, this leads to very subtle bugs that may or may not manifest themselves. Same comment was made on package crc64, to keep the future open to the caching tables that crc32 effectively does. Fixes: #12487. Change-Id: I2881bebb8b16f6f8564412172774c79c2593c6c1 Reviewed-on: https://go-review.googlesource.com/14258Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
- 03 Sep, 2015 11 commits
-
-
Michael Hudson-Doyle authored
This reverts commit bf99d8f8. Change-Id: Id4374ed35802cfbfe11e015ccd9526d3497dc8cc Reviewed-on: https://go-review.googlesource.com/14239Reviewed-by:
Dave Cheney <dave@cheney.net>
-
Rob Pike authored
The default implementation of Accept, which spins up a new server for every new connection, calls log.Fatal if the listener is closed, stopping any outstanding work. Change that to a non-fatal log call so work can continue. There is no programmatic signaling of the problem, just the log, but that should be enough. Fixes #11221. Change-Id: I7c7f6164a0a0143236729eb778d7638c51c34ed1 Reviewed-on: https://go-review.googlesource.com/14185Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Alexander Morozov authored
Change-Id: I39a2c4101e6c59f4cd693cb0368f3567ea37ca5b Reviewed-on: https://go-review.googlesource.com/14255Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Rob Pike authored
These instructions are special cases that were missed in the translation. The second argument must go into the Reg field not the To field. Fixes #12458 For Go 1.5.1 Change-Id: Iad57c60c7e38e3bcfafda483ed5037ce670e8816 Reviewed-on: https://go-review.googlesource.com/14183Reviewed-by:
Dave Cheney <dave@cheney.net> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Chris Hines authored
Previously Tx.close always passed a nil error to tx.db.putConn. As a result bad connections were reused, even if the driver returned driver.ErrBadConn. Adding an err parameter to Tx.close allows it to receive the driver error from Tx.Commit and Tx.Rollback and pass it to tx.db.putConn. Fixes #11264 Change-Id: I142b6b2509fa8d714bbc135cef7281a40803b3b8 Reviewed-on: https://go-review.googlesource.com/13912Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Michael Hudson-Doyle authored
Change-Id: Ia18984343ca4ced3671d967ff9a5b0e32874430c Reviewed-on: https://go-review.googlesource.com/14220Reviewed-by:
David Crawshaw <crawshaw@golang.org> Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Michael Hudson-Doyle authored
cmd/internal/obj: some platform independent bits of proper toolchain support for thread local storage Also simplifies some silliness around making the .tbss section wrt internal vs external linking. The "make TLS make sense" project has quite a few more steps to go. Issue #11270 Change-Id: Ia4fa135cb22d916728ead95bdbc0ebc1ae06f05c Reviewed-on: https://go-review.googlesource.com/13990Reviewed-by:
Ian Lance Taylor <iant@golang.org> Reviewed-by:
David Crawshaw <crawshaw@golang.org> Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Andrew Gerrand authored
Bring in the text from the proposal (with minor edits): https://github.com/golang/proposal/blob/master/design/11502-securitypolicy.md Fixes #11502 Change-Id: I92a987be66a0df60c1fad6c6c79f89bd8e9c12a8 Reviewed-on: https://go-review.googlesource.com/13955Reviewed-by:
Jason Buberel <jbuberel@google.com>
-
Michael Hudson-Doyle authored
Nothing uses it any more. Change-Id: I42ee7222b06b1a79b8b44894f3071752f9166d7a Reviewed-on: https://go-review.googlesource.com/14193 Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Dave Cheney <dave@cheney.net>
-
Joe Tsai authored
The flate library contains generator code, which is used to generate the fixed huffman table. This is done so that fixed blocks can be processed quicker since there is no need generate the decoder table for fixed codes. Instead, delete the precomputed table, and use sync.Once to generate it at runtime when used. Advantages: * Reduces duplicated logic in flate package * Reduces binary size by approximately 2KiB Disadvantages: * For the simplest possible program that simply decodes the fixed block "\x03\x00" once, the modified code takes 4.7% longer for the first decode. Compression performance for subsequent blocks afterwards has no noticeable slow down. Change-Id: I8f351218debf7d732118808859eda481b01011f6 Reviewed-on: https://go-review.googlesource.com/14181Reviewed-by:
Nigel Tao <nigeltao@golang.org>
-
Michael Hudson-Doyle authored
Building for shared libraries requires that all functions that are declared have an implementation and vice versa so make that so on arm64. It would be nicer to not require the stub sigreturn (it will never be called) but that seems a bit awkward. Change-Id: I3cec81697161b452af81fa35939f748bd1acf7fd Reviewed-on: https://go-review.googlesource.com/13995Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
- 02 Sep, 2015 5 commits
-
-
Didier Spezia authored
The parser tries to read as much information as possible, issuing some errors when needed. Errors generally do not stop the parsing. With some pathological input, it may result in various panics when the error message itself is built, or when the next operand is parsed. It happens while parsing pseudo-instructions. For instance, the following lines all generate a panic: TEXT TEXT% TEXT 1,1 TEXT $"toto", 0, $1 FUNCDATA DATA 0 DATA(0),1 FUNCDATA(SB GLOBL 0, 1 PCDATA 1 Added corresponding tests. Introduced a writer in the parser to capture error messages for testing purpose. It defaults to os.Stderr. Added an explicit check when symbol names cannot be displayed. Interrupted parsing early when the number of operands is wrong for pseudo-instructions. Note that the last point is a change of behavior, because some operands will not get parsed anymore in case of early error. IMO, it is acceptable, because only the first error of the line is considered anyway. If it is not acceptable, it can probably be improved at the price of a more verbose CL. Fixes #11765 Fixes #11760 Fixes #11759 Change-Id: I9602a848132e358a1bccad794d7555e0823970dd Reviewed-on: https://go-review.googlesource.com/13925Reviewed-by:
Rob Pike <r@golang.org>
-
Håvard Haugen authored
Change-Id: Ib3960321a4c8164f6b221bfd15977d2f34dbc65b Reviewed-on: https://go-review.googlesource.com/14175Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Rob Pike authored
Refine the documentation in cmd/doc and go help doc. Fixes #12377. Change-Id: I670c0a5cf18c9c9d5bb9bb222d8a3dd3722a3934 Reviewed-on: https://go-review.googlesource.com/14121Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Rob Pike authored
Printing a function value is nearly useless outside of debugging, but can occur by mistake when one forgets to call it. Diagnose this. I did this myself just the other day and it arose in cl/14031. Easy to fix and seems worthwhile. Fixes #12295. Change-Id: Ice125a84559f0394f7fa7272b5d31ae602b07f83 Reviewed-on: https://go-review.googlesource.com/14122Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Andrew Gerrand authored
Change-Id: I571965bc38a8b1060642a942b898797327f0c19c Reviewed-on: https://go-review.googlesource.com/14195Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
- 01 Sep, 2015 2 commits
-
-
Håvard Haugen authored
Change-Id: I021c95df24edbff24ff2922769ef2b2acd47016a Reviewed-on: https://go-review.googlesource.com/14081 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Dave Cheney <dave@cheney.net>
-
Håvard Haugen authored
See report in commit 3c9fa388. Change-Id: I74a5995a1c1ca62b8d01857e89b084502e7da928 Reviewed-on: https://go-review.googlesource.com/14170Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-