Commits · 22f71cde6a366b2a2db928ab743bef50a856ee35 · go / golang

27 Jul, 2011 11 commits
- A+C: John Asmuth · 22f71cde
  Andrew Gerrand authored Jul 27, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4827045
```
  22f71cde
- godoc: app engine configuration and updated documentation · d7a0e0e6
  Robert Griesemer authored Jul 27, 2011
```
Also: Fixed an error message in zip.go.

R=r, dsymonds
CC=golang-dev
https://golang.org/cl/4816053
```
  d7a0e0e6
- gc: use more Go-like names for methods · 1bd4b637
  Russ Cox authored Jul 27, 2011
```
Fixes #991.

R=ken2
CC=golang-dev
https://golang.org/cl/4819049
```
  1bd4b637
- gc: diagnose (x) := 0 · 112267d5
  Russ Cox authored Jul 27, 2011
```
Fixes #1756.

R=ken2
CC=golang-dev
https://golang.org/cl/4810057
```
  112267d5
- build: fix for noclobber users · db3088a3
  Russ Cox authored Jul 27, 2011
```
Fixes #2020.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4814056
```
  db3088a3
- gc: zero-width struct, zero-length array fixes · a84abbe5
  Russ Cox authored Jul 27, 2011
```
Fixes #1774.
Fixes #2095.
Fixes #2097.

R=ken2
CC=golang-dev
https://golang.org/cl/4826046
```
  a84abbe5
- gc: iota outside const · dec8009f
  Russ Cox authored Jul 27, 2011
```
Fixes #1662.

R=ken2
CC=golang-dev
https://golang.org/cl/4828045
```
  dec8009f
- gc: echo literal in error message · 49b70d01
  Russ Cox authored Jul 27, 2011
```
Fixes #1192.

R=ken2
CC=golang-dev
https://golang.org/cl/4794062
```
  49b70d01
- runtime: higher goroutine arg limit, clearer error · 100a0341
  Russ Cox authored Jul 27, 2011
```
Fixes #591.

R=ken2
CC=golang-dev
https://golang.org/cl/4803054
```
  100a0341
- reflect: rename new TestVariadic to TestVariadicType. · c913cb8b
  David Symonds authored Jul 27, 2011
```
R=nigeltao
CC=golang-dev
https://golang.org/cl/4825050
```
  c913cb8b
- reflect: doc fixes for obsolete types. · fc1cf588
  David Symonds authored Jul 27, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4802061
```
  fc1cf588
26 Jul, 2011 10 commits

goinstall: generate makefiles using exp/template · 2fc96269
Rob Pike authored Jul 26, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4809052
```
2fc96269
rpc: convert /debug/rpc handler to exp/template · 7e1101d4
Rob Pike authored Jul 26, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4819048
```
7e1101d4
http: set content type for fileserver directory listings · e21f6933
Robert Griesemer authored Jul 26, 2011
```
R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4815062
```
e21f6933
gc, runtime: fix range+panic line number bugs · 12a5774c
Russ Cox authored Jul 26, 2011
```
Fixes #1856.

R=ken2
CC=golang-dev
https://golang.org/cl/4810054
```
12a5774c
gc: fix select line number · cce10dac
Russ Cox authored Jul 26, 2011
```
Fixes #1393.

R=ken2
CC=golang-dev
https://golang.org/cl/4811054
```
cce10dac
gc: disallow [...][...]int{{1,2,3}} · bf899bef
Russ Cox authored Jul 26, 2011
```
Fixes #1600.

R=ken2
CC=golang-dev
https://golang.org/cl/4819045
```
bf899bef
runtime: fix freebsd build · e5437ab0
Mikio Hara authored Jul 26, 2011
```
Fixes #2078.

R=rsc
CC=golang-dev
https://golang.org/cl/4800052
```
e5437ab0

Russ Cox authored Jul 26, 2011

Undo CL 4254056 now that enough time has elapsed
that people with old trees have all built and removed
those files (which are no longer generated in that location).

Fixes #1581.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4802059

55dfdb64

http: implement MP4 sniffing. · e527d49e
David Symonds authored Jul 26, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4809044
```
e527d49e

net: fix memory corruption in windows *netFD.ReadFrom · 003d5411

Alex Brainman authored Jul 26, 2011

We must keep memory used by syscall.WSARecvFrom away from
garbage collector until after overlapped call is completed.

Fixes #2094.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4817050

003d5411

25 Jul, 2011 10 commits

goinstall: abort and warn when using any url scheme, not just 'http://' · 83305fec
Andrew Gerrand authored Jul 25, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4801053
```
83305fec

ld: fix build on Plan 9 · 75c918c1

Lucio De Re authored Jul 25, 2011

ld/data.c:
. Format specifier with corresponding cast to cater for all
  architectures (llux and vlong).

ld/ldelf.c:
ld/ldmacho.c:
. Missing "pn" argument in diag() calls.

ld/ldpe.c:
. Dropped "sym->sectnum" in diag() call.
. Typo in a comment.

ld/lib.h:
. Added varargck pragma for "O".

R=rsc
CC=golang-dev
https://golang.org/cl/4749042

75c918c1

build: define getcallerpc in u.h (fix for Plan 9 build) · eb3f2083

Lucio De Re authored Jul 25, 2011

. By defining getcallerpc(x) as __builtin_return_address(0)
  here, it becomes possible to use the Plan 9 compatible form
  when compiling using GCC.  The alternative is to add conditional
  compilation based on the compiler identity in "cmd/8g/gsubr.c"
  to distinguish between the two cases.

R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/4800048

eb3f2083

gc: fix mkbuiltin for Plan 9 build · 12995e2d

Lucio De Re authored Jul 25, 2011

. Replaced Posix #includes with u.h and libc.h.
. Replaced fprintf(stderr,...); exit(1); with sysfatal() calls.

R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/4823047

12995e2d

build: fixes for mingw-w64 · ee14fbdf
Wei Guangjing authored Jul 25, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4742042
```
ee14fbdf

ld: don't skip first 2 symbols in ldpe. · 0871af25

Wei Guangjing authored Jul 25, 2011

some object files don't has file name symbol.

R=golang-dev, lucio.dere, rsc
CC=golang-dev
https://golang.org/cl/4814051

0871af25

runtime: Plan 9, skip calling runtime·ldt0setup. · 2aa2ceb8
Yuval Pavel Zholkover authored Jul 25, 2011
```
R=golang-dev
CC=alex.brainman, golang-dev
https://golang.org/cl/4816049
```
2aa2ceb8
runtime: fix compilation of send select cases · 33ff947c
Dmitriy Vyukov authored Jul 25, 2011
```
Fixes #2102.

R=fullung, rsc
CC=golang-dev
https://golang.org/cl/4825043
```
33ff947c
syscall: remove unused windows code and comments · 77054310
Alex Brainman authored Jul 25, 2011
```
R=golang-dev, vcc.163, rsc
CC=golang-dev
https://golang.org/cl/4826042
```
77054310

runtime: remove rnd calls that pass a second argument of 1 · 3a07d516

Ian Lance Taylor authored Jul 25, 2011

When rnd is called with a second argument of 1, it simply
returns the first argument anyway.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4820045

3a07d516

24 Jul, 2011 3 commits

exp/regexp: implement regexp API using exp/regexp/syntax · a1e7cd97

Russ Cox authored Jul 24, 2011

Still need to write tests for new syntax
and fix bugs that the tests find, but this
is a good check point.

All tests pass.

Compared against existing regexp:

benchmark                                old ns/op    new ns/op    delta
regexp.BenchmarkLiteral                       1869          620  -66.83%
regexp.BenchmarkNotLiteral                    9489         7823  -17.56%
regexp.BenchmarkMatchClass                   10372         8386  -19.15%
regexp.BenchmarkMatchClass_InRange           10800         7750  -28.24%
regexp.BenchmarkReplaceAll                   13492         8519  -36.86%
regexp.BenchmarkAnchoredLiteralShortNonMatch   747          339  -54.62%
regexp.BenchmarkAnchoredLiteralLongNonMatch    599          335  -44.07%
regexp.BenchmarkAnchoredShortMatch            2137          917  -57.09%
regexp.BenchmarkAnchoredLongMatch             2029          917  -54.81%

R=r, r
CC=golang-dev, sam.thorogood
https://golang.org/cl/4820046

a1e7cd97

goinstall: write to goinstall.log in respective GOPATH · fc2480da

Andrew Gerrand authored Jul 24, 2011

goinstall: report every newly installed package to the dashboard

This makes "goinstall -a" work on systems with GOROOTs that are
not user-writable, as is the case with Debian's Go packages.

This also makes goinstall.log the canonical list of installed
packages, in that only packages new to goinstall.log are reported to
the dashboard.

A side-effect is that writing to goinstall.log is now mandatory.
(A bug in the original implementation meant this was the case, anyway.)

The principal benefit of this change is that multiple packages from the
same repository can now be reported to the dashboard.  It is also less
likely for a user to report multiple installations of the same package
to the dashboard (they would need to remove the package from
goinstall.log first).

R=rsc, n13m3y3r
CC=golang-dev
https://golang.org/cl/4786041

fc2480da

unicode: fix doc comment for Range32 · d56c8132
Andrew Balholm authored Jul 24, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4811050
```
d56c8132

23 Jul, 2011 6 commits

sort: fixed bug in (Float64Slice) Less; NaN less than anything else · 480ef72c

Florian Uekermann authored Jul 23, 2011

Previously comparisons with NaN led to contradictory results if it was
compared to anything not NaN, since Less always returned false, thus
breaking monotonicity of ordering.
This fix makes NaN less than anything else and adds NaN and (+-)Inf to
testcases.

Fixes #2092.

R=golang-dev, r, rsc, r
CC=golang-dev
https://golang.org/cl/4805051

480ef72c

runtime: replace byte-at-a-time zeroing loop with memclr · 47410a24
Quan Yong Zhai authored Jul 23, 2011
```
R=golang-dev, r, r, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/4813043
```
47410a24

runtime: faster entersyscall/exitsyscall · ba134539

Russ Cox authored Jul 23, 2011

Replace cas with xadd in scheduler.
Suggested by Dmitriy in last code review.
Verified with Promela model.

When there's actual contention for the atomic word,
this avoids the looping that compare-and-swap requires.

benchmark                            old ns/op    new ns/op    delta
runtime_test.BenchmarkSyscall               32           26  -17.08%
runtime_test.BenchmarkSyscall-2            155           59  -61.81%
runtime_test.BenchmarkSyscall-3            112           52  -52.95%
runtime_test.BenchmarkSyscall-4             94           48  -48.57%
runtime_test.BenchmarkSyscallWork          871          872   +0.11%
runtime_test.BenchmarkSyscallWork-2        481          477   -0.83%
runtime_test.BenchmarkSyscallWork-3        338          335   -0.89%
runtime_test.BenchmarkSyscallWork-4        263          256   -2.66%

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/4800047

ba134539

ld: fixes .bss for ldpe · 7ce1a4bd
Wei Guangjing authored Jul 23, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4794056
```
7ce1a4bd

exp/template: construct sets from plain template files · 2d972ad4

Rob Pike authored Jul 23, 2011

This is the last piece (I hope) of the set creation code.
These helpers create sets from files containing individual
template definitions, free of {{define}} clauses. This
design is helpful if the templates live one per file,
undecorated.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4801052

2d972ad4

fix build: clean up file end in an attempt to fix build · 3ddaa95d
Robert Griesemer authored Jul 23, 2011
```
R=r, iant
CC=golang-dev
https://golang.org/cl/4809050
```
3ddaa95d