- 30 Nov, 2012 9 commits
-
-
Anthony Martin authored
R=golang-dev, dave, mikioh.mikioh, bradfitz, rsc CC=golang-dev https://golang.org/cl/6674043
-
Shenghou Ma authored
`godoc net/http` used to complain "/target contains more than one package: http, main" R=golang-dev, bradfitz, rsc CC=golang-dev https://golang.org/cl/6852100
-
Shenghou Ma authored
also fix an annoying test that relies on $GOROOT be set. Fixes #3690. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6844086
-
Dave Cheney authored
64bit atomics are broken on 32bit systems. This is issue 599. linux/arm builders all broke with this change, I am concerned that the other 32bit builders are silently impacted. ««« original CL description net: fix data races on deadline vars Fixes #4434. R=mikioh.mikioh, bradfitz, dvyukov, alex.brainman CC=golang-dev https://golang.org/cl/6855110 »»» R=rsc, mikioh.mikioh, dvyukov, minux.ma CC=golang-dev https://golang.org/cl/6852105
-
Dave Cheney authored
Fixes #4434. R=mikioh.mikioh, bradfitz, dvyukov, alex.brainman CC=golang-dev https://golang.org/cl/6855110
-
Dmitriy Vyukov authored
When a race happens inside of runtime (chan, slice, etc), currently reports contain only user file:line. If the line contains a complex expression, it's difficult to figure out where the race exactly. This change adds one more top frame with exact runtime function (e.g. runtime.chansend, runtime.mapaccess). R=golang-dev CC=golang-dev https://golang.org/cl/6851125
-
Dmitriy Vyukov authored
W/o this change stack traces do not show from where sync.Once() or atomic.XXX was called. This change add funcenter/exit instrumentation to sync/sync.atomic packages. R=golang-dev CC=golang-dev https://golang.org/cl/6854112
-
Alex Brainman authored
Some have their system setup in a particular way, see http://golang.org/issue/4444#c3. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6851129
-
Brad Fitzpatrick authored
RFC 2616: "The 204 response MUST NOT include a message-body, and thus is always terminated by the first empty line after the header fields." Previously we'd trigger chunked encoding by default on responses, and then when finishing the request we'd write the chunk trailers, which counted as a message-body. Fixes #4454 R=golang-dev CC=golang-dev https://golang.org/cl/6782139
-
- 29 Nov, 2012 6 commits
-
-
Robert Griesemer authored
Fixes #4450. R=rsc, iant CC=golang-dev https://golang.org/cl/6845104
-
Russ Cox authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6854119
-
Robert Griesemer authored
1) Built-ins are restricted like for expression statements. This documents the status quo. 2) Calls cannot be parenthesized. The spec is not clear. gccgo permits it already, gc doesn't. Be explicit in the spec. Fixes #4462. R=rsc, iant, r, ken, lvd CC=golang-dev https://golang.org/cl/6861043
-
Brad Fitzpatrick authored
The new version of rietveld pushed 1.5 hours ago requires HTTPS now, otherwise it issues a 301 to HTTPS which we barfed on. R=golang-dev CC=golang-dev https://golang.org/cl/6782135
-
Robert Griesemer authored
- check indices of array/slice composite literals - handle [...]T - also: go/defer statements R=rsc CC=golang-dev https://golang.org/cl/6856107
-
Robert Griesemer authored
More lenient parsing with better error recovery. It's easier for the type check to pick up the slack. R=iant CC=golang-dev https://golang.org/cl/6856108
-
- 28 Nov, 2012 4 commits
-
-
Alex Brainman authored
Fixes #4444. R=golang-dev, minux.ma, rsc CC=golang-dev https://golang.org/cl/6858079
-
Alex Brainman authored
Fixes #4342. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6850080
-
Alex Brainman authored
Test creates 2 tcp connections for put and get. Make sure these are closed properly after test is over, otherwise server hangs waiting for connection to be closed. R=golang-dev, bradfitz, dave CC=golang-dev https://golang.org/cl/6842109
-
Dave Cheney authored
Update #4434. The proposal attempts to reduce the number of places where fd,{r,w}deadline is checked and updated in preparation for issue 4434. In doing so the deadline logic is simplified by letting the pollster return errTimeout from netFD.Wait{Read,Write} as part of the wakeup logic. The behaviour of setting n = 0 has been restored to match rev 2a55e349097f, which was the previous change to fd_unix.go before CL 6851096. R=jsing, bradfitz, mikioh.mikioh, rsc CC=fullung, golang-dev https://golang.org/cl/6850110
-
- 27 Nov, 2012 17 commits
-
-
Mikio Hara authored
Fixes misedit in CL 6842053. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6849115
-
Dave Cheney authored
A fix similar to CL 6859043 was effective in resolving the intermittent failure. Fixes #4423. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6854102
-
Mikio Hara authored
This CL continues with introducing IPv6 scoped addressing capability into the net package. Update #4234. R=rsc CC=golang-dev https://golang.org/cl/6842053
-
Rémy Oudompheng authored
Fixes #4448. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6855100
-
Robert Griesemer authored
Package format is a utility package that takes care of parsing, sorting of imports, and formatting of .go source using the canonical gofmt formatting parameters. Use go/format in various clients instead of the lower-level components. R=r, bradfitz, dave, rogpeppe, rsc CC=golang-dev https://golang.org/cl/6852075
-
Jan Ziak authored
Garbage collection code (to be merged later) is calling functions which have many local variables. This increases the probability that the stack capacity won't be big enough to hold the local variables. So, start gc() on a bigger stack to eliminate a potentially large number of calls to runtime·morestack(). R=rsc, remyoudompheng, dsymonds, minux.ma, iant, iant CC=golang-dev https://golang.org/cl/6846044
-
Dmitriy Vyukov authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6854103
-
Rick Arnold authored
As discussed in issue 2672 and on golang-nuts, this CL adds a Split() method to regexp. It is based on returning the "opposite" of FindAllString() so that the returned substrings are everything not matched by the expression. See: https://groups.google.com/forum/?fromgroups=#!topic/golang-nuts/xodBZh9Lh2E Fixes #2762. R=remyoudompheng, r, rsc CC=golang-dev https://golang.org/cl/6846048
-
Russ Cox authored
Fix suggested by serbaut. Fixes #4445. R=sameer CC=golang-dev, serbaut https://golang.org/cl/6842102
-
Volker Dobler authored
Update #4125 R=minux.ma, rsc CC=golang-dev https://golang.org/cl/6847107
-
John Graham-Cumming authored
The syslog implementation was not correctly implementing the traditional syslog format because it had a confused notion of 'priority'. syslog priority is not a single number but is, in fact, the combination of a facility number and a severity. The previous Go syslog implementation had a single Priority that appeared to be the syslog severity and no way of setting the facility. That meant that all syslog messages from Go programs appeared to have a facility of 0 (LOG_KERN) which meant they all appeared to come from the kernel. Also, the 'prefix' was in fact the syslog tag (changed the internal name for clarity as the term tag is more widely used) and the timestamp and hostname values were missing from messages. With this change syslog messages are generated in the correct format with facility and severity combined into a priority, the timestamp in RFC3339 format, the hostname, the tag (with the PID in [] appened) and the message. The format is now: <PRI>1 TIMESTAMP HOSTNAME TAG[PID]: MSG The TIMESTAMP, HOSTNAME and PID fields are filled in automatically by the package. The TAG and the MSG are supplied by the user. This is what rsyslogd calls TraditionalFormat and should be compatible with multiple systems. R=rsc, jgc, 0xjnml, mikioh.mikioh, bradfitz CC=golang-dev https://golang.org/cl/6782118
-
Dmitriy Vyukov authored
R=golang-dev, remyoudompheng, rsc CC=golang-dev https://golang.org/cl/6525052
-
Dmitriy Vyukov authored
The test failed on one of the builders with: timeout_test.go:594: ln.Accept: accept tcp 127.0.0.1:19373: use of closed network connection http://build.golang.org/log/e83f4a152b37071b9d079096e15913811ad296b5 R=golang-dev, bradfitz, dave, mikioh.mikioh, remyoudompheng, rsc CC=golang-dev https://golang.org/cl/6859043
-
Nigel Tao authored
This CL defines the API. Implementation will come in follow-up CLs. Update #1960. R=bradfitz, dr.volker.dobler, rsc CC=golang-dev https://golang.org/cl/6849092
-
Brad Fitzpatrick authored
Part of merging goprotobuf's A+C into Go's. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6844096
-
Robert Griesemer authored
It's better to use IsValid() then checking a (possibly partially set up) position against NoPos directly. R=dsymonds CC=golang-dev https://golang.org/cl/6855099
-
Anthony Martin authored
R=golang-dev, minux.ma, bradfitz CC=golang-dev https://golang.org/cl/6844088
-
- 26 Nov, 2012 4 commits
-
-
Anthony Martin authored
The API additions to syscall are in dir_plan9.go. R=seed, rsc, rminnich, mirtchovski, dave CC=golang-dev, lucio.dere https://golang.org/cl/6157045
-
Rémy Oudompheng authored
This allows 5g and 8g to benefit from the rewrite as shifts or magic multiplies. The 64-bit arithmetic is not handled there, and left in 6g. Update #2230. R=golang-dev, dave, mtj, iant, rsc CC=golang-dev https://golang.org/cl/6819123
-
Robert Griesemer authored
Fixes 386 build breakage. R=rsc CC=golang-dev https://golang.org/cl/6844091
-
Brad Fitzpatrick authored
Thanks to Dustin Sallings for exposing the most frustrating bug ever, and for providing repro cases (which formed the basis of the new tests in this CL), and to Dave Cheney and Dmitry Vyukov for help debugging and fixing. This CL depends on submited pollster CLs ffd1e075c260 (Unix) and 14b544194509 (Windows), as well as unsubmitted 6852085. Some operating systems (OpenBSD, NetBSD, ?) may still require more pollster work, fixing races (Issue 4434 and http://goo.gl/JXB6W). Tested on linux-amd64 and darwin-amd64, both with GOMAXPROCS 1 and 4 (all combinations of which previously failed differently) Fixes #4191 Update #4434 (related fallout from this bug) R=dave, bradfitz, dsallings, rsc, fullung CC=golang-dev https://golang.org/cl/6851061
-