Commits · 27e249049e9f303c994927a7ecb837cd5e85c512 · go / golang

03 Aug, 2010 19 commits

Nigel Tao authored Aug 03, 2010

I'll leave whether or not this obsoletes UnreadByte for a future CL.

R=r, rsc
CC=golang-dev
https://golang.org/cl/1912042

27e24904

os: change the type of permissions argument for Open etc. to uint32. · e45b58fe

Rob Pike authored Aug 03, 2010

Besides being more correct, it protects against people accidentally
exchanging the permission and open mode arguments to Open.

R=rsc
CC=golang-dev
https://golang.org/cl/1904045

e45b58fe

websocket: correct challenge response · 1badb463
Tarmigan Casebolt authored Aug 03, 2010
```
Tested against latest Chrome.

R=ukai, rsc
CC=golang-dev
https://golang.org/cl/1743053
```
1badb463
bikeshed: only output bug when we have a regression · d0b913fe
Kai Backman authored Aug 03, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1897046
```
d0b913fe
CONTRIBUTORS: Rietveld alias for brad@danga.com · 5960f835
Russ Cox authored Aug 03, 2010
```
R=adg
CC=bradfitz, golang-dev
https://golang.org/cl/1715060
```
5960f835
os: Null device · 12befd06
Peter Mundy authored Aug 03, 2010
```
R=rsc, cw
CC=golang-dev
https://golang.org/cl/1854042
```
12befd06
arm: remove old qemu dependency from gotest · 311973ea
Kai Backman authored Aug 03, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1678063
```
311973ea
test/run: diff old new · d4af41f5
Russ Cox authored Aug 03, 2010
```
R=r, iant
CC=golang-dev
https://golang.org/cl/1907046
```
d4af41f5

crypto/x509: unwrap Subject Key Identifier · 7748a7f1

Adam Langley authored Aug 03, 2010

RFC 5280, 4.2.1.2 says:
  SubjectKeyIdentifier ::= KeyIdentifier
  KeyIdentifier ::= OCTET STRING

Previously, we were failing to unwrap the second level of OCTET STRING
encoding.

Fixes #993.

R=rsc
CC=golang-dev
https://golang.org/cl/1917044

7748a7f1

gc: empty select · 3f19d8ae
Russ Cox authored Aug 03, 2010
```
R=ken2
CC=golang-dev
https://golang.org/cl/1871057
```
3f19d8ae

gc: bug301 · 585eae3b

Russ Cox authored Aug 03, 2010

Fixes #990.

R=ken2
CC=golang-dev
https://golang.org/cl/1742055

585eae3b

gc: bug299, bug300 · c6cb303a
Russ Cox authored Aug 03, 2010
```
R=ken2
CC=golang-dev
https://golang.org/cl/1731057
```
c6cb303a
A+C: Tarmigan Casebolt · b91c70ad
Russ Cox authored Aug 03, 2010
```
R=adg
CC=golang-dev, tarm
https://golang.org/cl/1923041
```
b91c70ad

gc: index bounds tests and fixes · 9bac9d23

Russ Cox authored Aug 03, 2010

move constant index checking to front end
x[2:1] is a compile-time error now too

R=ken2
CC=golang-dev
https://golang.org/cl/1848056

9bac9d23

strings: fix Split("", "", -1) · 0cd87772

Scott Lawrence authored Aug 03, 2010

Fixes #980.

Made it return an empty array, rather than crash.
Added relevant test cases to strings.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/1914041

0cd87772

Add Scott Lawrence to C&A · b6c2bf71
Rob Pike authored Aug 03, 2010
```
R=adg
CC=golang-dev
https://golang.org/cl/1899044
```
b6c2bf71
syscall: make sure go error numbers do not clash with windows system errors · a79a9098
Alex Brainman authored Aug 03, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1857049
```
a79a9098
builder: update script so it doesn't create tar-bombs · 5443bbe2
Andrew Gerrand authored Aug 03, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1857048
```
5443bbe2
image: introduce Gray and Gray16 types, and remove the named colors · 244b6583
Nigel Tao authored Aug 03, 2010
```
except for Black and White.

R=rsc
CC=golang-dev, mpl, r
https://golang.org/cl/1903049
```
244b6583

02 Aug, 2010 1 commit
- io: consolidate multi_reader and multi_writer into a single file, multi.go · 3f5966dc
  Rob Pike authored Aug 02, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1860046
```
  3f5966dc
01 Aug, 2010 1 commit
- image/png: use image-specific methods for checking opacity. · 55badd47
  Nigel Tao authored Aug 01, 2010
```
R=rsc
CC=golang-dev, mpl
https://golang.org/cl/1894047
```
  55badd47
30 Jul, 2010 14 commits

websocket: fix bug involving spaces in header keys · 6d37724c
Bill Neubauer authored Jul 30, 2010
```
R=rsc, ukai
CC=golang-dev
https://golang.org/cl/1669056
```
6d37724c
CONTRIBUTORS: add wcn@google.com alias to match with code review · 1c4d380b
Russ Cox authored Jul 30, 2010
```
R=wcn
CC=golang-dev
https://golang.org/cl/1902043
```
1c4d380b

runtime: do not fall through in SIGBUS/SIGSEGV · 68b0a879

Russ Cox authored Jul 30, 2010

Faults beyond the first page are not expected
and should fail loudly.  They are not subject to recover.

R=r
CC=golang-dev
https://golang.org/cl/1915042

68b0a879

arm: disable another flaky test. · a0368180

Kai Backman authored Jul 30, 2010

these tests work fine on n1 and gumstix. it's unclear
why they keep failing on the godashboard build.

R=rsc
CC=golang-dev
https://golang.org/cl/1664056

a0368180

fix build · c44f95ff
Kai Backman authored Jul 30, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1913042
```
c44f95ff

arm: bugfixes (stack clobbering, indices) · 8d76a151

Kai Backman authored Jul 30, 2010

also changed zerodivide to output "BUG"

R=rsc
CC=golang-dev
https://golang.org/cl/1871055

8d76a151

arm: add gdb support to android launcher script · 96ad9ade
Kai Backman authored Jul 30, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1742050
```
96ad9ade
tag release.2010-07-29 · fdbff04a
Andrew Gerrand authored Jul 30, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1896044
```
fdbff04a
release.2010-07-29 · b5d84bb0
Andrew Gerrand authored Jul 30, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1907045
```
b5d84bb0
misc/builder: support for uploading tarballs to googlecode · 3402c5e8
Andrew Gerrand authored Jul 30, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1784042
```
3402c5e8
cov and prof: implement windows version (just function stubs and build mods) · b57ffae0
Joe Poirier authored Jul 30, 2010
```
R=brainman, rsc
CC=golang-dev
https://golang.org/cl/1676054
```
b57ffae0

bug300: literal types must not be parenthesized · 500425ac

Robert Griesemer authored Jul 30, 2010

( This CL is dependent on acceptance of
https://golang.org/cl/1913041/show )

R=go-dev
CC=golang-dev
https://golang.org/cl/1860045

500425ac

go_spec: don't allow parens around the literal type of composite literals · 07cc6440

Robert Griesemer authored Jul 30, 2010

Background: The current spec is imprecise with respect to the parsing ambiguity
for composite literals: It says that the ambiguity arises when the TypeName form
of the LiteralType is used. The following code:

    if (B) {} ...

is not using the TypeName form (but the parenthesized TypeName form) and thus
could be interpreted as:

    if ((B){}) ...

instead of

    if B {} ...

Both compilers and gofmt choose the latter interpretation. One could fix the
spec by making the clause regarding the parsing ambiguity more precise ("...using
the _possibly parenthesized_ TypeName form of the LiteralType..."). The alternative
(chosen here) is to simply disallow parenthesized literal types. Except for a single
test case (test/parentype.go) there appears to be no Go code under $GOROOT containing
parenthesized literal types. Furthermore, parentheses are never needed around a
literal type for correct parsing.

R=golang-dev
CC=golang-dev
https://golang.org/cl/1913041

07cc6440

doc: update front page and go_learning.html · bab711b1

Andrew Gerrand authored Jul 30, 2010

This is a stop-gap change to give more current information visibility
before a more thorough reorganization.

R=r, rsc, gri
CC=golang-dev
https://golang.org/cl/1902042

bab711b1

29 Jul, 2010 5 commits
- mime: add AddExtensionType · c21e2f39
  Yuusei Kuwana authored Jul 29, 2010
```
For example:
mime.AddExtensionType(".m3u8", "application/x-mpegURL")
mime.AddExtensionType(".ts", "video/MP2T")

R=rsc, rsc1
CC=golang-dev
https://golang.org/cl/1698046
```
  c21e2f39
- A+C: Yuusei Kuwana (individual CLA) · 2ef1c6e2
  Russ Cox authored Jul 29, 2010
```
R=r
CC=golang-dev
https://golang.org/cl/1871054
```
  2ef1c6e2
- scanner: better comment · bc0a1c61
  Robert Griesemer authored Jul 29, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/1900044
```
  bc0a1c61
- bug299: parenthesized receiver types/anonymous fields are illegal · 7734ad51
  Robert Griesemer authored Jul 29, 2010
```
R=r
CC=golang-dev
https://golang.org/cl/1846051
```
  7734ad51
- fmt.Print: fix bug in placement of spaces introduced when ...T went in. · 2c0bbf99
  Rob Pike authored Jul 29, 2010
```
Fixes #976.

R=rsc, chris tighe, r
CC=golang-dev
https://golang.org/cl/1697057
```
  2c0bbf99