- 20 Jul, 2017 2 commits
-
-
Ian Lance Taylor authored
If we are using vfork, and if something (such as TSAN) is intercepting the sigaction function, then we must call the system call, not the libc function. Otherwise the intercepted sigaction call in the child may trash the data structures in the parent. Change-Id: Id9588bfeaa934f32c920bf829c5839be5cacf243 Reviewed-on: https://go-review.googlesource.com/50251Reviewed-by:
Joe Tsai <thebrokentoaster@gmail.com> Reviewed-by:
Austin Clements <austin@google.com>
-
Johnny Luo authored
Fixes #21075 Change-Id: Idfe5002dfe17943844d9427e27f82ce894b92e80 Reviewed-on: https://go-review.googlesource.com/50270Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 19 Jul, 2017 4 commits
-
-
yansal authored
Fixes #21089 Change-Id: Idd65c7185b3e19f33958eb165cb5b09c06db3d56 Reviewed-on: https://go-review.googlesource.com/50110Reviewed-by:
-
Jaana Burcu Dogan authored
The Go ecosystem provides many tools to make Go development more productive and seamless. Document the availability of the editor plugins and IDEs, add an overview of feature support and screencasts. Updates #20398. Updates #20402. Updates #20399. Updates #20401. Updates #20569. Change-Id: I0c6cb48eb4e3848807aaad78390493e14f097916 Reviewed-on: https://go-review.googlesource.com/45772Reviewed-by:
Steve Francia <spf@golang.org>
-
Austin Clements authored
Currently we trace mark assists even if they're satisfied entirely by stealing. This means even if background marking is keeping up with allocation, we'll still emit a trace event every N bytes of allocation. The event will be a few microseconds, if that, but they're frequent enough that, when zoomed out in the trace view, it looks like all of the time is spent in mark assists even if almost none is. Change this so we only emit a trace event if the assist actually has to do assisting. This makes the traces of these events far more useful. Change-Id: If4aed1c413b814341ef2fba61d2f10751d00451b Reviewed-on: https://go-review.googlesource.com/50030 Run-TryBot: Austin Clements <austin@google.com> Reviewed-by:
Rick Hudson <rlh@golang.org>
-
Michael Munday authored
Load/store-merging and move optimizations can result in unaligned memory accesses. This is fine so long as the load/store instruction used does not take a relative offset. In the SSA rules this means we must not merge (MOVDaddr (SB)) ops into loads/stores unless we can guarantee the alignment of the target. Fixes #21048. Change-Id: I70f13a62a148d5f0a56e704e8f76e36b4a4226d9 Reviewed-on: https://go-review.googlesource.com/49250 Run-TryBot: Michael Munday <mike.munday@ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
- 18 Jul, 2017 5 commits
-
-
Ian Lance Taylor authored
Fixes #21077 Change-Id: Ic61d7313907f58ff4027fd2eee1ddb8c1656304d Reviewed-on: https://go-review.googlesource.com/49712Reviewed-by:
Dmitri Shuralyov <shurcool@gmail.com>
-
Austin Clements authored
tSweepTerm and pauseStart are supposed to be when STW was triggered, but right now they're captured a bit before STW. Move these down to immediately before we trigger STW. Fixes #19590. Change-Id: Icd48a5c4d45c9b36187ff986e4f178b5064556c1 Reviewed-on: https://go-review.googlesource.com/49612 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Austin Clements authored
Currently, Windows stacks are either 128kB or 2MB depending on whether the binary uses cgo. This is because we assume that Go system stacks and the small amount of C code invoked by the standard library can operate within smaller stacks, but general Windows C code assumes larger stacks. However, it's easy to call into arbitrary C code using the syscall package on Windows without ever importing cgo into a binary. Such binaries need larger system stacks even though they don't use cgo. Fix this on 64-bit by increasing the system stack size to 2MB always. This only costs address space, which is free enough on 64-bit to not worry about. We keep (for now) the existing heuristic on 32-bit, where address space comes at more of a premium. Updates #20975. Change-Id: Iaaaa9a2fcbadc825cddc797aaaea8d34ef8debf2 Reviewed-on: https://go-review.googlesource.com/49331 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Alex Brainman <alex.brainman@gmail.com>
-
Alexey Palazhchenko authored
Change-Id: Ie6a88b70d7c45c59995ee2f57fb28f9a3cbb404d Reviewed-on: https://go-review.googlesource.com/49470Reviewed-by:
-
Brad Fitzpatrick authored
Add Adam Kisala (individual CLA) Add Aditya Mukerjee (individual CLA) Add Akhil Indurti (individual CLA) Add André Carvalho (individual CLA) Add Andy Walker (individual CLA) Add Awn Umar (individual CLA) Add Bastian Ike (individual CLA) Add Brian Downs (individual CLA) Add Cody Oss (individual CLA) Add Costin Chirvasuta (corporate CLA for Google Inc.) Add Dan Ballard (individual CLA) Add Dong-hee Na (individual CLA) Add Dylan Waits (individual CLA) Add Evan Hicks (individual CLA) Add Fannie Zhang (corporate CLA for ARM Ltd.) Add Francisco Rojas (individual CLA) Add Gabriel Nicolas Avellaneda (individual CLA) Add Gabríel Arthúr Pétursson (individual CLA) Add Greg Poirier (individual CLA) Add Iccha Sethi (individual CLA) Add Ivan Moscoso (individual CLA) Add Jamie Kerr (individual CLA) Add Joe Kyo (individual CLA) Add Joey Geiger (individual CLA) Add John R. Lenton (individual CLA) Add Johnny Luo (individual CLA) Add Josh Roppo (individual CLA) Add Kate Manson (individual CLA) Add Leo Rudberg (corporate CLA for Google Inc.) Add Ma Peiqi (individual CLA) Add Martynas Budriūnas (corporate CLA for Google Inc.) Add Maryan Hratson (individual CLA) Add Michael Edwards (individual CLA) Add Michael Hendricks (individual CLA) Add Pablo Santiago Blum de Aguiar (individual CLA) Add Pat Moroney (individual CLA) Add Shi Han Ng (individual CLA) Add Steven Buss (corporate CLA for Google Inc.) Add Suzy Mueller (corporate CLA for Google Inc.) Add Taro Aoki (individual CLA) Add Tim Heckman (individual CLA) Add Tony Walker (individual CLA) Add Yasha Bubnov (individual CLA) Updates #12042 Change-Id: Iee063dd6c5a39de16907acfb5af87e81a05ab417 Reviewed-on: https://go-review.googlesource.com/49351Reviewed-by:
Andrew Bonventre <andybons@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
- 17 Jul, 2017 7 commits
-
-
Jess Frazelle authored
Fixes #20796 Fixes #16283 Change-Id: Ib11992fbd2bc1fbb3b14ae5a6bf0da2e4c12f641 Reviewed-on: https://go-review.googlesource.com/49311Reviewed-by:
-
Russ Cox authored
Framepointer is the default now. Only print an X: list if the settings are _not_ the default. Before: $ go tool compile -V compile version devel +a5f30d9508 Sun Jul 16 14:43:48 2017 -0400 X:framepointer $ go1.8 tool compile -V compile version go1.8 X:framepointer $ After: $ go tool compile -V compile version devel +a5f30d9508 Sun Jul 16 14:43:48 2017 -0400 $ go1.9 tool compile -V # imagined compile version go1.9 $ Perpetuates #18317. Change-Id: I981ba5c62be32e650a166fc9740703122595639b Reviewed-on: https://go-review.googlesource.com/49252 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
Russ Cox authored
Missed in CL 49253 because I submitted from the Gerrit UI and had not mailed the latest copy. Sigh. Change-Id: I540f960278df43e2eaf1aac188eb124a1ff240dd Reviewed-on: https://go-review.googlesource.com/49256 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Russ Cox <rsc@golang.org>
-
Russ Cox authored
The init func was using testing.Short, but that's not available until after flag parsing. Found by CL 49251. Change-Id: Ia7b871043375260873fa2c7e81e1d43c1c83d33f Reviewed-on: https://go-review.googlesource.com/49253 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
Alberto Donizetti authored
Fixes #21043 Change-Id: I12db4f67ddee80500ff323f84e8fa34511650e63 Reviewed-on: https://go-review.googlesource.com/49230Reviewed-by:
-
Russ Cox authored
Per note at top of doc, we don't use fixed-width spaces in fixed-width phrases like "go doc". Also ASN.1 NULL is not code so it's not <code> at all. Change-Id: I791e4e6030b8b8d42f4621d2f4bf32fef93cf343 Reviewed-on: https://go-review.googlesource.com/47693 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
Russ Cox authored
Change-Id: I55f50e45f8872f063c3b6c9e89261d14689e77ce Reviewed-on: https://go-review.googlesource.com/47692 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
-
- 16 Jul, 2017 3 commits
-
-
gmarik authored
Change-Id: Ia3e351169a4ebe6db5e5f37b668f23dc8c992c78 Reviewed-on: https://go-review.googlesource.com/48877 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Brian Downs authored
Change-Id: I04849883dd2e1f6d083e9f57d2a8c1bd7d258953 Reviewed-on: https://go-review.googlesource.com/48878 Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Bryan Mills <bcmills@google.com>
-
closs authored
Fixes #20450 Change-Id: I2256282a8880e99508e98fefedfb94a7cccacbcf Reviewed-on: https://go-review.googlesource.com/48969 Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 15 Jul, 2017 19 commits
-
-
Vitor De Mario authored
Change-Id: I062ec0606a741c8aa1b74f3f4b4e4fd47f76fed5 Reviewed-on: https://go-review.googlesource.com/48775Reviewed-by:
-
Tony Walker authored
Change-Id: I33f0e2362e85287b493d9279d43b760733e2abcb Reviewed-on: https://go-review.googlesource.com/48831 Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Dylan Waits authored
Change-Id: Ib491d144387a7675af370f7b925fe6e62440d153 Reviewed-on: https://go-review.googlesource.com/48966 Run-TryBot: Kevin Burke <kev@inburke.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Kevin Burke <kev@inburke.com>
-
André Carvalho authored
Change-Id: Ic47198bc8bf5baabfcf4d0599825eab30d7b126c Reviewed-on: https://go-review.googlesource.com/48853Reviewed-by:
-
Iccha Sethi authored
The existing example for Decoder.Decode (Stream) had excessive indentation in the godoc interface for the const jsonStream, making it hard to read. This fixes the indentation in the example_test.go to improve the readability in godoc. Helps #21026. Change-Id: I16f56b82182da1dcc73cca44e535a7f5695e975d Reviewed-on: https://go-review.googlesource.com/48910Reviewed-by:
-
Ross Light authored
Change-Id: Iec9a7bf61566ee08c4d15adb39d43c7a29c79122 Reviewed-on: https://go-review.googlesource.com/48962Reviewed-by:
-
Francisco Rojas authored
Change-Id: I9c0c601ec5957475e949dcc4a8c2116724d01215 Reviewed-on: https://go-review.googlesource.com/48961Reviewed-by:
-
Johnny Luo authored
It had been implemented. Refer to https://golang.org/pkg/archive/zip/#FileHeader.Comment Change-Id: I81572562c3111b58189baa3510b9ba688fe269c9 Reviewed-on: https://go-review.googlesource.com/48857Reviewed-by:
-
Josh Roppo authored
Change-Id: I5ca5a6689f0679154c24820466f5cf0011d0aaa6 Reviewed-on: https://go-review.googlesource.com/48959Reviewed-by:
-
Daniel Morsing authored
kicking off contributing again with a classic Change-Id: Ifb0aed8f1dc854f85751ce0495967a3c4315128d Reviewed-on: https://go-review.googlesource.com/49016Reviewed-by:
-
Pat Moroney authored
Change-Id: I5c32a968303848304cbd6fe1e83bed0af11f6440 Reviewed-on: https://go-review.googlesource.com/48960Reviewed-by:
Caleb Spare <cespare@gmail.com> Reviewed-by:
-
Francisco Rojas authored
Add a example for string.Compare that return the three possible results. Change-Id: I103cf39327c1868fb249538d9e22b11865ba4b70 Reviewed-on: https://go-review.googlesource.com/49011Reviewed-by:
Heschi Kreinick <heschi@google.com>
-
Ivan Moscoso authored
Clarifying that FindString only provides left-most match Change-Id: Ic6ecec12cca759fd4b3565ef5901a110843ffd56 Reviewed-on: https://go-review.googlesource.com/48609Reviewed-by:
-
Pablo Santiago Blum de Aguiar authored
Change-Id: Ib6a59735381ce744553f1ac96eeb65a194c8da10 Reviewed-on: https://go-review.googlesource.com/48860Reviewed-by:
-
Aditya Mukerjee authored
Change-Id: I52efa7aa72a23256e5ca56470ffeba975ed8f739 Reviewed-on: https://go-review.googlesource.com/48760Reviewed-by:
-
Evan Hicks authored
Change-Id: I69d1359d8868d4c5b173e4d831e38cea7dfeb713 Reviewed-on: https://go-review.googlesource.com/48859Reviewed-by:
-
Martynas Budriūnas authored
Change-Id: I259e25b9d0b069912053a250e9739e04fafca54d Reviewed-on: https://go-review.googlesource.com/48892 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Adam Kisala authored
Change-Id: Ibdd57489543d57a24d1e3c41210abd9fbc930b8f Reviewed-on: https://go-review.googlesource.com/48867Reviewed-by:
-
Greg Poirier authored
While there's an example for SectionReader.Seek, if someone is seeking documentation specifically about Seeker.Seek, they may not immediately find the SectionReader example. Offset and whence may not be entirely intuitive to new developers either, so include examples of both positive/negative offsets and SeekStart/SeekEnd. Change-Id: I5b7442ccf683d9706e9261c11bc0ea31a1ac21d4 Reviewed-on: https://go-review.googlesource.com/48873Reviewed-by:
-
