1. 09 Dec, 2011 9 commits
  2. 08 Dec, 2011 12 commits
  3. 07 Dec, 2011 19 commits
    • Andrew Gerrand's avatar
      be587a4d
    • Robert Griesemer's avatar
      strconv: fix documentation · 2e3bd890
      Robert Griesemer authored
      Also: minor performance fix for large precision results.
      
      benchmark                                   old ns/op    new ns/op    delta
      strconv_test.BenchmarkFormatFloatDecimal         2734         2734   +0.00%
      strconv_test.BenchmarkFormatFloat                3141         3139   -0.06%
      strconv_test.BenchmarkFormatFloatExp             8970         8989   +0.21%
      strconv_test.BenchmarkFormatFloatBig             3228         3208   -0.62%
      
      Fixes #2535.
      
      R=rsc
      CC=golang-dev
      https://golang.org/cl/5435089
      2e3bd890
    • Rob Pike's avatar
      doc: skeleton for release note document · bab4dec1
      Rob Pike authored
      No content yet other than titles and an introductory paragraph.
      Once this is in, content can arise as separate manageable CLs.
      
      R=rsc
      CC=golang-dev
      https://golang.org/cl/5435090
      bab4dec1
    • Rémy Oudompheng's avatar
      gc: keep pointer to original node in constant rewrites. · 4349effb
      Rémy Oudompheng authored
      This allows printing meaningful expressions in error messages
      instead of evaluated constants.
      Fixes #2276.
      
      R=golang-dev, rsc
      CC=golang-dev, remy
      https://golang.org/cl/5432082
      4349effb
    • David Symonds's avatar
      exp/sql: simplify some string conversions. · 9d52fe22
      David Symonds authored
      R=bradfitz
      CC=golang-dev
      https://golang.org/cl/5451112
      9d52fe22
    • Russ Cox's avatar
      gc: fix spurious typecheck loop in &composite literal · 5e98505b
      Russ Cox authored
      Fixes #2538.
      
      R=ken2
      CC=golang-dev
      https://golang.org/cl/5449114
      5e98505b
    • Russ Cox's avatar
      bytes: lost edit from earlier CL · 1278c6c0
      Russ Cox authored
      R=iant
      CC=golang-dev
      https://golang.org/cl/5450125
      1278c6c0
    • Russ Cox's avatar
      bytes: faster Count, Index, Equal · 9b875bc0
      Russ Cox authored
      Benchmarks are from GOARCH=amd64 on a MacPro5,1.
      
      benchmark                                    old MB/s     new MB/s  speedup
      bytes_test.BenchmarkEqual32                    452.89       891.07    1.97x
      bytes_test.BenchmarkEqual4K                    852.71      1700.44    1.99x
      bytes_test.BenchmarkEqual4M                    841.53      1587.93    1.89x
      bytes_test.BenchmarkEqual64M                   838.22      1578.14    1.88x
      
      bytes_test.BenchmarkIndex32                     58.02        48.99    0.84x
      bytes_test.BenchmarkIndex4K                     48.26        41.32    0.86x
      bytes_test.BenchmarkIndex4M                     48.20        41.24    0.86x
      bytes_test.BenchmarkIndex64M                    48.08        41.21    0.86x
      bytes_test.BenchmarkIndexEasy32                410.04       546.82    1.33x
      bytes_test.BenchmarkIndexEasy4K                849.26     14257.37   16.79x
      bytes_test.BenchmarkIndexEasy4M                854.54     17222.15   20.15x
      bytes_test.BenchmarkIndexEasy64M               843.57     11060.40   13.11x
      
      bytes_test.BenchmarkCount32                     57.24        50.68    0.89x
      bytes_test.BenchmarkCount4K                     48.19        41.82    0.87x
      bytes_test.BenchmarkCount4M                     48.18        41.74    0.87x
      bytes_test.BenchmarkCount64M                    48.17        41.71    0.87x
      bytes_test.BenchmarkCountEasy32                433.11       547.44    1.26x
      bytes_test.BenchmarkCountEasy4K               1130.59     14194.06   12.55x
      bytes_test.BenchmarkCountEasy4M               1131.23     17231.18   15.23x
      bytes_test.BenchmarkCountEasy64M              1111.40     11068.88    9.96x
      
      The non-easy Count/Index benchmarks are a worst case input.
      
      regexp.BenchmarkMatchEasy0_32                  237.46       221.47    0.93x
      regexp.BenchmarkMatchEasy0_1K                  553.53      1019.72    1.84x
      regexp.BenchmarkMatchEasy0_32K                 693.99      1672.06    2.41x
      regexp.BenchmarkMatchEasy0_1M                  688.72      1611.68    2.34x
      regexp.BenchmarkMatchEasy0_32M                 680.70      1565.05    2.30x
      regexp.BenchmarkMatchEasy1_32                  165.56       243.08    1.47x
      regexp.BenchmarkMatchEasy1_1K                  336.45       496.32    1.48x
      regexp.BenchmarkMatchEasy1_32K                 302.80       425.63    1.41x
      regexp.BenchmarkMatchEasy1_1M                  300.42       414.20    1.38x
      regexp.BenchmarkMatchEasy1_32M                 299.64       413.47    1.38x
      
      R=golang-dev, r, iant
      CC=golang-dev
      https://golang.org/cl/5451116
      9b875bc0
    • Russ Cox's avatar
      regexp: avoid allocation of input interface · 2f2cc24c
      Russ Cox authored
      Matters most for small inputs, because there is no real work
      to amortize the allocation effort against.
      
      benchmark                                old ns/op    new ns/op    delta
      BenchmarkLiteral                               613          473  -22.84%
      BenchmarkNotLiteral                           4981         4931   -1.00%
      BenchmarkMatchClass                           7289         7122   -2.29%
      BenchmarkMatchClass_InRange                   6618         6663   +0.68%
      BenchmarkReplaceAll                           7843         7233   -7.78%
      BenchmarkAnchoredLiteralShortNonMatch          329          228  -30.70%
      BenchmarkAnchoredLiteralLongNonMatch           322          228  -29.19%
      BenchmarkAnchoredShortMatch                    838          715  -14.68%
      BenchmarkAnchoredLongMatch                     824          715  -13.23%
      
      benchmark                                 old MB/s     new MB/s  speedup
      BenchmarkMatchEasy0_32                      119.73       196.61    1.64x
      BenchmarkMatchEasy0_1K                      540.58       538.33    1.00x
      BenchmarkMatchEasy0_32K                     732.57       714.00    0.97x
      BenchmarkMatchEasy0_1M                      726.44       708.36    0.98x
      BenchmarkMatchEasy0_32M                     707.77       691.45    0.98x
      BenchmarkMatchEasy1_32                      102.12       136.11    1.33x
      BenchmarkMatchEasy1_1K                      298.31       307.04    1.03x
      BenchmarkMatchEasy1_32K                     273.56       274.43    1.00x
      BenchmarkMatchEasy1_1M                      268.42       269.23    1.00x
      BenchmarkMatchEasy1_32M                     266.15       267.34    1.00x
      BenchmarkMatchMedium_32                       2.53         3.38    1.34x
      BenchmarkMatchMedium_1K                       9.37         9.57    1.02x
      BenchmarkMatchMedium_32K                      9.29         9.67    1.04x
      BenchmarkMatchMedium_1M                       9.42         9.66    1.03x
      BenchmarkMatchMedium_32M                      9.41         9.62    1.02x
      BenchmarkMatchHard_32                         6.66         6.75    1.01x
      BenchmarkMatchHard_1K                         6.81         6.85    1.01x
      BenchmarkMatchHard_32K                        6.79         6.85    1.01x
      BenchmarkMatchHard_1M                         6.82         6.83    1.00x
      BenchmarkMatchHard_32M                        6.80         6.80    1.00x
      
      R=golang-dev, r
      CC=golang-dev
      https://golang.org/cl/5453076
      2f2cc24c
    • Russ Cox's avatar
      test: make array smaller in nilptr test · 3c56a7b1
      Russ Cox authored
      Fixes #2314.
      
      R=golang-dev, r
      CC=golang-dev
      https://golang.org/cl/5437154
      3c56a7b1
    • Olivier Duperray's avatar
      godoc: <pre> must not occur inside <p> · e97a5581
      Olivier Duperray authored
      Fixes #2532
      
      R=golang-dev, dr.volker.dobler, rsc
      CC=golang-dev
      https://golang.org/cl/5450115
      e97a5581
    • Russ Cox's avatar
      A+C: Olivier Duperray, Taru Karttunen (individual CLA) · c3480878
      Russ Cox authored
      R=golang-dev, bradfitz
      CC=golang-dev
      https://golang.org/cl/5451121
      c3480878
    • Charles L. Dorian's avatar
      math: document special-cases behavior for Dim, Max and Min · e4de2e7f
      Charles L. Dorian authored
      Max returns +Inf if x or y is +Inf; else it returns NaN if either x or y is NaN. Max(-0, -0) returns -0.
      Min returns -Inf if x or y is -Inf; else it returns NaN if either x or y is NaN. Min(+0, -0) returns -0.
      Dim(+Inf, +Inf) = NaN, Dim(-Inf, -Inf) = NaN and Dim(NaN, anything) = NaN.
      Also, change "conditions" to "cases" for Sin (missed it in previous CL).
      
      R=rsc, dave
      CC=golang-dev
      https://golang.org/cl/5437137
      e4de2e7f
    • Peter Mundy's avatar
      time: fix daysIn for December · 69191553
      Peter Mundy authored
      daysBefore[12+1]: index out of range
      time.December and Windows SYSTEMTIME.wMonth
      are 12 for December.
      
      R=rsc, dsymonds
      CC=golang-dev
      https://golang.org/cl/5448130
      69191553
    • Robert Griesemer's avatar
      strconv: faster float conversion · 127b5a66
      Robert Griesemer authored
      - added AppendFloatX benchmarks
      - 2% to 13% better performance
      - check for illegal bitSize
      
      benchmark                                   old ns/op    new ns/op    delta
      strconv_test.BenchmarkFormatFloatDecimal         2993         2733   -8.69%
      strconv_test.BenchmarkFormatFloat                3384         3141   -7.18%
      strconv_test.BenchmarkFormatFloatExp             9192         9010   -1.98%
      strconv_test.BenchmarkFormatFloatBig             3279         3207   -2.20%
      strconv_test.BenchmarkAppendFloatDecimal         2837         2478  -12.65%
      strconv_test.BenchmarkAppendFloat                3196         2928   -8.39%
      strconv_test.BenchmarkAppendFloatExp             9028         8773   -2.82%
      strconv_test.BenchmarkAppendFloatBig             3151         2782  -11.71%
      
      R=rsc, bradfitz
      CC=golang-dev
      https://golang.org/cl/5448122
      127b5a66
    • Robert Griesemer's avatar
      misc/benchcmp: don't require "Benchmark" at beginning of line · b955bbfb
      Robert Griesemer authored
      Output is package_name.BenchmarkXXX.
      
      R=rsc
      CC=golang-dev
      https://golang.org/cl/5440123
      b955bbfb
    • Scott Lawrence's avatar
      ld: fix memory leaks · a2ba34d3
      Scott Lawrence authored
      R=golang-dev, rsc
      CC=golang-dev
      https://golang.org/cl/5434068
      a2ba34d3
    • Rémy Oudompheng's avatar
      gc: more accurate description of -w and -W switches. · 0c64972d
      Rémy Oudompheng authored
      The -w switch actually prints steps of the syntax tree walks
      while -W prints a summary before and after the walk.
      
      R=golang-dev, rsc
      CC=golang-dev, remy
      https://golang.org/cl/5444049
      0c64972d
    • Gustav Paul's avatar
      exp/ssh: Have Wait() return an *ExitError · 50c24bf6
      Gustav Paul authored
      I added the clientChan's msg channel to the list of channels that are closed in mainloop when the server sends a channelCloseMsg.
      
      I added an ExitError type that wraps a Waitmsg similar to that of os/exec. I fill ExitStatus with the data returned in the 'exit-status' channel message and Msg with the data returned in the 'exit-signal' channel message.
      
      Instead of having Wait() return on the first 'exit-status'/'exit-signal' I have it return an ExitError containing the status and signal when the clientChan's msg channel is closed.
      
      I added two tests cases to session_test.go that test for exit status 0 (in which case Wait() returns nil) and exit status 1 (in which case Wait() returns an ExitError with ExitStatus 1)
      
      R=dave, agl, rsc, golang-dev, bradfitz
      CC=golang-dev
      https://golang.org/cl/5452051
      50c24bf6