Skip to content

G
golang
Switch branch/tag
  1. 19 Dec, 2011 10 commits
  3. 18 Dec, 2011 2 commits
  5. 17 Dec, 2011 4 commits
  7. 16 Dec, 2011 19 commits
    • Russ Cox's avatar
      runtime: hg revert -r 6ec0a5c12d75 · 86dcc431
      Russ Cox authored 
      That was the last build that was close to working.
I will try that change again next week.
Make is being very subtle today.

At the reverted-to CL, the ARM traceback appears
to be broken.  I'll look into that next week too.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5492063
      86dcc431
    • Robert Griesemer's avatar
      go/printer, gofmt: fine tuning of line spacing · 541b67d0
      Robert Griesemer authored 
      - no empty lines inside empty structs and interfaces
- top-level declarations are separated by a blank line if
  a) they are of different kind (e.g. const vs type); or
  b) there are documentation comments associated with a
     declaration (this is new)
- applied gofmt -w misc src

The actual changes are in go/printer/nodes.go:397-400 (empty structs/interfaces),
and go/printer/printer.go:307-309 (extra line break). The remaining
changes are cleanups w/o changing the existing functionality.

Fixes issue  2570.

R=rsc
CC=golang-dev
https://golang.org/cl/5493057
      541b67d0
    • Russ Cox's avatar
      runtime: fix build on gri's machine · 72bdd868
      Russ Cox authored 
      Why it was not failing anywhere else I don't know,
but the Makefile was definitely wrong.  The rules
must not run in parallel.

TBR=r
CC=golang-dev
https://golang.org/cl/5489069
      72bdd868
    • Russ Cox's avatar
      runtime: fix build · cfd17a1b
      Russ Cox authored 
      I am looking forward to not supporting two build
systems simultaneously.  Make complains about
a circular dependency still, but I don't understand it
and it's probably not worth the time to figure out.

TBR=r
CC=golang-dev
https://golang.org/cl/5496058
      cfd17a1b
    • Olivier Duperray's avatar
      websocket: fix a trivial example server · 32734f46
      Olivier Duperray authored 
      R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/5491063
      32734f46
    • Russ Cox's avatar
      runtime: separate out auto-generated files · bd9243da
      Russ Cox authored 
      R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5493063
      bd9243da
    • Russ Cox's avatar
      runtime: fix build · 95907c47
      Russ Cox authored 
      TBR=r
CC=golang-dev
https://golang.org/cl/5493061
      95907c47
    • Russ Cox's avatar
      runtime: make more build-friendly · 851f3013
      Russ Cox authored 
      Collapse the arch,os-specific directories into the main directory
by renaming xxx/foo.c to foo_xxx.c, and so on.

There are no substantial edits here, except to the Makefile.
The assumption is that the Go tool will #define GOOS_darwin
and GOARCH_amd64 and will make any file named something
like signals_darwin.h available as signals_GOOS.h during the
build.  This replaces what used to be done with -I$(GOOS).

There is still work to be done to make runtime build with
standard tools, but this is a big step.  After this we will have
to write a script to generate all the generated files so they
can be checked in (instead of generated during the build).

R=r, iant, r, lucio.dere
CC=golang-dev
https://golang.org/cl/5490053
      851f3013
    • Rob Pike's avatar
      encoding/gob: arrays are zero only if their elements are zero · 474d64d2
      Rob Pike authored 
      R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5494059
      474d64d2
    • Rob Pike's avatar
      gob: isZero for struct values · 4fb5f544
      Rob Pike authored 
      Fixes #2577.

R=golang-dev, r, gri
CC=golang-dev
https://golang.org/cl/5492058
      4fb5f544
    • Maxim Pimenov's avatar
      various: use $GCFLAGS and $GCIMPORTS like Make does · bf6dd2db
      Maxim Pimenov authored 
      R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5489065
      bf6dd2db
    • Volker Dobler's avatar
      net/http: Added interface for a cookie jar. · dd694fb1
      Volker Dobler authored 
      Types implementing CookieJar may be used in a Client
to persist cookies.

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5399043
      dd694fb1
    • Miki Tebeka's avatar
      codereview: Initialize "found" in codereview.py. · a3008e23
      Miki Tebeka authored 
      Fixes #2569 (hg undo crashes when CL not found).

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5489052
      a3008e23
    • Mikio Hara's avatar
      syscall: sort Makefile, mkall.sh and mkerrors.sh entries · 055b4f7e
      Mikio Hara authored 
      R=golang-dev, jsing
CC=golang-dev
https://golang.org/cl/5495062
      055b4f7e
    • Mikio Hara's avatar
      net: sort Makefile entries · ecc31764
      Mikio Hara authored 
      R=golang-dev, jsing
CC=golang-dev
https://golang.org/cl/5493058
      ecc31764
    • Alex Brainman's avatar
      go/build: make sure syslist.go is gofmted · 8fa8ebf8
      Alex Brainman authored 
      R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5490051
      8fa8ebf8
    • Russ Cox's avatar
      go: implement test command · 20090df7
      Russ Cox authored 
      Gotest tries to build things, for which it invokes make,
and it was too hard to coordinate go invoking gotest
invoking go to build the test binary, so put all the code
here instead.  Gotest will be deleted once we switch.

The only code that really made sense to copy verbatim
was the flag parsing.

This remains a work in progress.  There are still plenty
of things to clean up and make better, but this is a good
checkpoint.  It can run all the tests in the tree (except
runtime, which it can't build yet).

$ go test all -short
ok  	archive/tar
ok  	archive/zip
ok  	bufio
?   	builtin [no test files]
ok  	bytes
ok  	compress/bzip2
ok  	compress/flate
ok  	compress/gzip
ok  	compress/lzw
ok  	compress/zlib
ok  	container/heap
ok  	container/list
ok  	container/ring
?   	crypto [no test files]
ok  	crypto/aes
ok  	crypto/bcrypt
ok  	crypto/blowfish
ok  	crypto/cast5
ok  	crypto/cipher
ok  	crypto/des
ok  	crypto/dsa
ok  	crypto/ecdsa
ok  	crypto/elliptic
ok  	crypto/hmac
ok  	crypto/md4
ok  	crypto/md5
ok  	crypto/ocsp
ok  	crypto/openpgp
ok  	crypto/openpgp/armor
ok  	crypto/openpgp/elgamal
?   	crypto/openpgp/error [no test files]
ok  	crypto/openpgp/packet
ok  	crypto/openpgp/s2k
ok  	crypto/rand
ok  	crypto/rc4
ok  	crypto/ripemd160
ok  	crypto/rsa
ok  	crypto/sha1
ok  	crypto/sha256
ok  	crypto/sha512
ok  	crypto/subtle
ok  	crypto/tls
ok  	crypto/twofish
ok  	crypto/x509
?   	crypto/x509/pkix [no test files]
ok  	crypto/xtea
ok  	debug/dwarf
ok  	debug/elf
ok  	debug/gosym
ok  	debug/macho
ok  	debug/pe
ok  	encoding/ascii85
ok  	encoding/asn1
ok  	encoding/base32
ok  	encoding/base64
ok  	encoding/binary
ok  	encoding/csv
ok  	encoding/git85
ok  	encoding/gob
ok  	encoding/hex
ok  	encoding/json
ok  	encoding/pem
ok  	encoding/xml
ok  	errors
ok  	exp/ebnf
?   	exp/ebnflint [no test files]
ok  	exp/gotype
ok  	exp/norm
ok  	exp/spdy
ok  	exp/sql
ok  	exp/sql/driver
ok  	exp/ssh
ok  	exp/types
ok  	expvar
ok  	flag
ok  	fmt
ok  	go/ast
ok  	go/build
ok  	go/doc
ok  	go/parser
ok  	go/printer
ok  	go/scanner
ok  	go/token
?   	hash [no test files]
ok  	hash/adler32
ok  	hash/crc32
ok  	hash/crc64
ok  	hash/fnv
ok  	html
ok  	html/template
ok  	image
?   	image/bmp [no test files]
?   	image/color [no test files]
ok  	image/draw
?   	image/gif [no test files]
ok  	image/jpeg
ok  	image/png
ok  	image/tiff
ok  	image/ycbcr
ok  	index/suffixarray
ok  	io
ok  	io/ioutil
ok  	log
ok  	log/syslog
ok  	math
ok  	math/big
ok  	math/cmplx
ok  	math/rand
ok  	mime
ok  	mime/multipart
ok  	net
?   	net/dict [no test files]
ok  	net/http
ok  	net/http/cgi
ok  	net/http/fcgi
?   	net/http/httptest [no test files]
ok  	net/http/httputil
?   	net/http/pprof [no test files]
ok  	net/mail
ok  	net/rpc
ok  	net/rpc/jsonrpc
ok  	net/smtp
ok  	net/textproto
ok  	net/url
ok  	old/netchan
ok  	old/regexp
ok  	old/template
ok  	os
ok  	os/exec
ok  	os/signal
ok  	os/user
ok  	patch
ok  	path
ok  	path/filepath
ok  	reflect
ok  	regexp
ok  	regexp/syntax
# cd /Users/rsc/g/go/src/pkg/runtime; 6g -o /var/folders/mw/qfnx8hhd1_s9mm9wtbng0hw80000gn/T/go-build874847916/runtime_test/_obj/_go_.6 -p runtime_test -I /var/folders/mw/qfnx8hhd1_s9mm9wtbng0hw80000gn/T/go-build874847916 append_test.go chan_test.go closure_test.go gc_test.go mfinal_test.go proc_test.go sema_test.go softfloat64_test.go symtab_test.go
proc_test.go:87: undefined: runtime.Entersyscall
proc_test.go:88: undefined: runtime.Exitsyscall
proc_test.go:111: undefined: runtime.Entersyscall
proc_test.go:116: undefined: runtime.Exitsyscall
softfloat64_test.go:79: undefined: Fadd64
softfloat64_test.go:80: undefined: Fsub64
softfloat64_test.go:82: undefined: Fmul64
softfloat64_test.go:83: undefined: Fdiv64
softfloat64_test.go:94: undefined: F64to32
softfloat64_test.go:99: undefined: F32to64
softfloat64_test.go:99: too many errors

exit status 1
FAIL	runtime [build failed]
?   	runtime/cgo [no test files]
ok  	runtime/debug
ok  	runtime/pprof
ok  	sort
ok  	strconv
ok  	strings
ok  	sync
ok  	sync/atomic
?   	syscall [no test files]
?   	testing [no test files]
?   	testing/iotest [no test files]
ok  	testing/quick
ok  	testing/script
ok  	text/scanner
ok  	text/tabwriter
ok  	text/template
ok  	text/template/parse
ok  	time
ok  	unicode
ok  	unicode/utf16
ok  	unicode/utf8
?   	unsafe [no test files]
ok  	websocket
$

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5495055
      20090df7
    • Andrew Gerrand's avatar
      dashboard: improve key panic message · 1338347b
      Andrew Gerrand authored 
      R=dsymonds
CC=golang-dev
https://golang.org/cl/5495060
      1338347b
    • Russ Cox's avatar
      io/ioutil: remove another reference to _test · 0358c895
      Russ Cox authored 
      R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5492051
      0358c895
  9. 15 Dec, 2011 5 commits