1. 28 Feb, 2013 10 commits
    • Mikio Hara's avatar
      net: fix slow network interface manipulations · 322214cf
      Mikio Hara authored
      This CL reduces unnecessary network facility lookups introduced
      by recent changes below.
      
      changeset: 15798:53a4da6a4f4a
      net: return correct point-to-point interface address on linux
      
      changeset: 15799:a81ef8e0cc05
      net: set up IPv6 scoped addressing zone for network facilities
      
      Also adds a test case for issue	4839.
      
      Benchmark results on linux/amd64, virtual machine:
      benchmark                                 old ns/op    new ns/op    delta
      BenchmarkInterfaces-2                         80487        80382   -0.13%
      BenchmarkInterfaceByIndex-2                   72013        71391   -0.86%
      BenchmarkInterfaceByName-2                    79865        80101   +0.30%
      BenchmarkInterfaceAddrs-2                     42071       829677  +1872.09%
      BenchmarkInterfacesAndAddrs-2                 35016       607622  +1635.27%
      BenchmarkInterfacesAndMulticastAddrs-2       169849       169082   -0.45%
      old: 15797:9c3930413c1b, new: tip
      
      Benchmark results on linux/amd64, virtual machine:
      benchmark                                 old ns/op    new ns/op    delta
      BenchmarkInterfaces-2                         80487        81459   +1.21%
      BenchmarkInterfaceByIndex-2                   72013        71512   -0.70%
      BenchmarkInterfaceByName-2                    79865        80567   +0.88%
      BenchmarkInterfaceAddrs-2                     42071       120108  +185.49%
      BenchmarkInterfacesAndAddrs-2                 35016        33259   -5.02%
      BenchmarkInterfacesAndMulticastAddrs-2       169849        82391  -51.49%
      old: 15797:9c3930413c1b, new: tip+CL7400055
      
      Benchmark results on darwin/amd64:
      benchmark                                 old ns/op    new ns/op    delta
      BenchmarkInterfaces-2                         34402        34231   -0.50%
      BenchmarkInterfaceByIndex-2                   13192        12956   -1.79%
      BenchmarkInterfaceByName-2                    34791        34388   -1.16%
      BenchmarkInterfaceAddrs-2                     36565        63906  +74.77%
      BenchmarkInterfacesAndAddrs-2                 17497        31068  +77.56%
      BenchmarkInterfacesAndMulticastAddrs-2        25276        66711  +163.93%
      old: 15797:9c3930413c1b, new: tip
      
      Benchmark results on darwin/amd64:
      benchmark                                 old ns/op    new ns/op    delta
      BenchmarkInterfaces-2                         34402        31854   -7.41%
      BenchmarkInterfaceByIndex-2                   13192        12950   -1.83%
      BenchmarkInterfaceByName-2                    34791        31926   -8.23%
      BenchmarkInterfaceAddrs-2                     36565        42144  +15.26%
      BenchmarkInterfacesAndAddrs-2                 17497        17329   -0.96%
      BenchmarkInterfacesAndMulticastAddrs-2        25276        24870   -1.61%
      old: 15797:9c3930413c1b, new: tip+CL7400055
      
      Update #4234.
      Fixes #4839 (again).
      Fixes #4866.
      
      R=golang-dev, fullung
      CC=golang-dev
      https://golang.org/cl/7400055
      322214cf
    • Akshat Kumar's avatar
      net, os, syscall: Plan 9: adjust error handling · f0a8b610
      Akshat Kumar authored
      syscall: Use NewError for all system errors and introduce
              some new errors for compatibility with other packages
              and proper error handling in net. Also introduce
              Temporary and Timeout methods on ErrorString.
      
      net: Make errors from dial, accept, listen functions follow the
              OpError standard and discern whether the underlying
              error came from syscall. Since Plan 9 uses a correspondence
              between file and network operations, all system error
              reporting happens through the underlying file operation.
              In Go code, we go through package os for file operations,
              so there is another level of indirection in error types.
              This change allows us to compare the errors with those in
              package syscall, when appropriate.
      
      os: Just use the error string already present in package os,
              instead of calling out to package syscall.
      
      R=rsc, ality, rminnich, bradfitz
      CC=golang-dev
      https://golang.org/cl/7398054
      f0a8b610
    • Akshat Kumar's avatar
      syscall: Plan 9: keep a consistent environment array · 1f62a784
      Akshat Kumar authored
      Map order is non-deterministic. Introduce a new
      environment string array that tracks the env map.
      This allows us to produce identical results for
      Environ() upon successive calls, as expected by the
      TestConsistentEnviron test in package os.
      
      R=rsc, ality, rminnich, bradfitz, r
      CC=golang-dev
      https://golang.org/cl/7411047
      1f62a784
    • Tyler Bunnell's avatar
      misc/dist: handle previous installation · 65983695
      Tyler Bunnell authored
      The installer package will now detect a previous installation and warn the user
      that the previous installation will be deleted. If the user continues, the
      installer will delete the previous installation and install the package as
      usual.
      
      Fixes #4293.
      
      R=adg
      CC=golang-dev
      https://golang.org/cl/7427044
      65983695
    • Andrew Gerrand's avatar
      A+C: Tyler Bunnell (individual CLA) · 91c09649
      Andrew Gerrand authored
      Generated by addca.
      
      R=gobot
      CC=golang-dev
      https://golang.org/cl/7432043
      91c09649
    • Russ Cox's avatar
      cmd/cgo: add implementation comment · 062a2390
      Russ Cox authored
      R=golang-dev, r, bradfitz, iant
      CC=golang-dev
      https://golang.org/cl/7407050
      062a2390
    • Nigel Tao's avatar
      exp/cookiejar: eliminate some "."+str garbage. · 3b69efb0
      Nigel Tao authored
      It's not a big deal, but it's easy to fix.
      
      R=dsymonds
      CC=dr.volker.dobler, golang-dev
      https://golang.org/cl/7425043
      3b69efb0
    • Volker Dobler's avatar
      exp/cookiejar: add some more tests · 1069d25e
      Volker Dobler authored
      New tests added for port handling and IDNA domains.
      A new test case contains several redundant
      tests but provides a nice documentation of the
      implemented rules for domain handling.
      
      R=nigeltao
      CC=golang-dev
      https://golang.org/cl/7393070
      1069d25e
    • Gustavo Niemeyer's avatar
      net/http: don't drop error on request write · 64648986
      Gustavo Niemeyer authored
      R=golang-dev, bradfitz
      CC=golang-dev
      https://golang.org/cl/7230059
      64648986
    • Rob Pike's avatar
      builtin: document appending a string to a byte slice · f12796e9
      Rob Pike authored
      Fixes #4873.
      
      R=golang-dev, bradfitz
      CC=golang-dev
      https://golang.org/cl/7421043
      f12796e9
  2. 27 Feb, 2013 29 commits
  3. 26 Feb, 2013 1 commit