Commits · 33995fe59eddb3f84e537a8d44e39ef93bc764e8 · go / golang

05 Feb, 2013 14 commits

log/syslog: retry once if write fails · 33995fe5

Jeff R. Allen authored Feb 05, 2013

Implements deferred connections + single-attempt automatic
retry. Based on CL 5078042 from kuroneko.

Fixes #2264.

R=mikioh.mikioh, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/6782140

33995fe5

runtime: save LR to stack when panicking to handle leaf function traceback · 7de3d717
Shenghou Ma authored Feb 05, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7289047
```
7de3d717
lib9: fix build for windows · 4360ef8d
Shenghou Ma authored Feb 05, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7311044
```
4360ef8d

exp/inotify: close event channel before file descriptor · da35d425

Ian Lance Taylor authored Feb 05, 2013

Closing the inotify file descriptor can take over a second
when running on Ubuntu Precise in an NFS directory, leading to
the test error in issue 3132.  Closing the event channel first
lets a client that does not care about the error channel move
on.

Fixes #3132.

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/7300045

da35d425

cmd/dist: add -Wstrict-prototypes to CFLAGS and fix all the compiler errors · 255fb521

Shenghou Ma authored Feb 05, 2013

Plan 9 compilers insist this but as we don't have Plan 9
builders, we'd better let gcc check the prototypes.

Inspired by CL 7289050.

R=golang-dev, seed, dave, rsc, lucio.dere
CC=akumar, golang-dev
https://golang.org/cl/7288056

255fb521

container/heap: fix comment typo in example test · dff017ea

Caleb Spare authored Feb 05, 2013

This updates a bad reference to a method name in the example priority queue test.

The error was introduced in the example refactoring in rev. 2ea8f07b2ffe.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/7279045

dff017ea

cmd/gc: add way to specify 'noescape' for extern funcs · fd178d6a

Russ Cox authored Feb 05, 2013

A new comment directive //go:noescape instructs the compiler
that the following external (no body) func declaration should be
treated as if none of its arguments escape to the heap.

Fixes #4099.

R=golang-dev, dave, minux.ma, daniel.morsing, remyoudompheng, adg, agl, iant
CC=golang-dev
https://golang.org/cl/7289048

fd178d6a

misc/dashboard/app: trim old builds from the history · f1c409b9

Dave Cheney authored Feb 05, 2013

The dashboard is currently failing to store results of new builds for some keys, notable the go.codereview sub repository. This is causing the builders to mark the entire triggering commit as failed. With the help of David Symonds we think it is because the results value has breached the 1mb datastore limit on AppEngine.

R=dsymonds, adg
CC=golang-dev
https://golang.org/cl/6858094

f1c409b9

runtime/race: do not include pthread.h · 6b1b613d
Dmitriy Vyukov authored Feb 05, 2013
```
Fixes #4721.

R=alex.brainman, minux.ma
CC=golang-dev
https://golang.org/cl/7275048
```
6b1b613d
archive/tar: small simplification using FileMode. · e7fe1944
David Symonds authored Feb 05, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7305043
```
e7fe1944

net/http: fix Server blocking after a Handler's Write fails · d1e16d06

Brad Fitzpatrick authored Feb 05, 2013

If a Handle's Write to a ResponseWriter fails (e.g. via a
net.Conn WriteDeadline via WriteTimeout on the Server), the
Server was blocking forever waiting for reads on that
net.Conn, even after a Write failed.

Instead, once we see a Write fail, close the connection,
since it's then dead to us anyway.

Fixes #4741

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/7301043

d1e16d06

path/filepath: document that Walk does not follow symlinks · a60ffed9
Russ Cox authored Feb 05, 2013
```
Fixes #4759.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7304043
```
a60ffed9

cmd/gc: fix escape analysis · 572d984e

Russ Cox authored Feb 05, 2013

If the analysis reached a node twice, then the analysis was cut off.
However, if the second arrival is at a lower depth (closer to escaping)
then it is important to repeat the traversal.

The repeating must be cut off at some point to avoid the occasional
infinite recursion. This CL cuts it off as soon as possible while still
passing all tests.

Fixes #4751.

R=ken2
CC=golang-dev, lvd
https://golang.org/cl/7303043

572d984e

syscall: fix marshaling of stat messages on Plan 9 · c56bb1d2

Anthony Martin authored Feb 05, 2013

The order of the Qid fields was reversed. Mea culpa.

R=seed
CC=golang-dev
https://golang.org/cl/7231062

c56bb1d2

04 Feb, 2013 19 commits

net/http: add Next Protocol Negotation upgrade support to the Server · 92e4645f

Brad Fitzpatrick authored Feb 04, 2013

This provides the mechanism to connect SPDY support to the http
package, without pulling SPDY into the standard library.

R=rsc, agl, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/7287045

92e4645f

syscall: regenerate ztype files for linux · 5ae6a237

Mikio Hara authored Feb 04, 2013

This CL adds TCPInfo struct to linux/386,arm.
It's already added to linux/amd64.

Note that not sure the reason but cgo godefs w/ latest gcc
translates a flexible array member in structures correctly,
handles it as a non-incomplete, non-opaque type, on Go 1.
This CL reverts such changes by hand for the Go 1 contract.

R=minux.ma, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/7197046

5ae6a237

net/http: fix when server deadlines get extended · 022504b3

Brad Fitzpatrick authored Feb 04, 2013

Deadlines should be extended at the beginning of
a request, not at the beginning of a connection.

Fixes #4676

R=golang-dev, fullung, patrick.allen.higgins, adg
CC=golang-dev
https://golang.org/cl/7220076

022504b3

cmd/go: update doc.go · 49fe632c
Shenghou Ma authored Feb 04, 2013
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/7279047
```
49fe632c
exp/ssa: (#4 of 5): the SSA builder. · c06a5335
Alan Donovan authored Feb 04, 2013
```
R=iant, gri, iant, rogpeppe
CC=golang-dev
https://golang.org/cl/7196053
```
c06a5335