Commits · 38e7c6b0dbd5f21ef05ce4006133a910eb84895b · go / golang

29 Mar, 2013 15 commits

A+C: Robert Obryk (individual CLA) · 38e7c6b0
Brad Fitzpatrick authored Mar 29, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/8176043
```
38e7c6b0

bytes: document that Buffer.Write grows the buffer · 0359af4f

Rob Pike authored Mar 29, 2013

Do a little reformatting too.
Fixes #5152.

R=golang-dev, bradfitz, gri
CC=golang-dev
https://golang.org/cl/8157044

0359af4f

runtime: additional map benchmarks for repeated lookups · ecdcec1d
Brad Fitzpatrick authored Mar 29, 2013
```
For the future.

Update #5147

R=khr, r
CC=golang-dev
https://golang.org/cl/8165044
```
ecdcec1d

bytes: don't compact Buffer so aggressively · 43e38d5d

Brad Fitzpatrick authored Mar 29, 2013

benchmark                           old ns/op    new ns/op    delta
BenchmarkBufferNotEmptyWriteRead       848416       819983   -3.35%

Update #5154

R=golang-dev, gri, robryk
CC=golang-dev
https://golang.org/cl/8173043

43e38d5d

bytes: don't grow Buffer if capacity is available · 994f5966

Brad Fitzpatrick authored Mar 29, 2013

Also added a new benchmark from the same test:

benchmark                           old ns/op    new ns/op    delta
BenchmarkBufferNotEmptyWriteRead      2643698       709189  -73.17%

Fixes #5154

R=golang-dev, r, gri
CC=golang-dev
https://golang.org/cl/8164043

994f5966

runtime: fix gdb printing of maps · fb3ed166

Keith Randall authored Mar 29, 2013

Fixes #5098

R=minux.ma, bradfitz, khr, rsc
CC=golang-dev
https://golang.org/cl/7746045

fb3ed166

doc: fix typo in effective_go.html · c1786a9e
Elias Naur authored Mar 29, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7548045
```
c1786a9e

net/http: ignore more uninteresting goroutines · df885e70

Brad Fitzpatrick authored Mar 29, 2013

These only show up if GOTRACEBACK=2

Update #5005

R=golang-dev, fullung
CC=golang-dev
https://golang.org/cl/8156044

df885e70

8a/8l: add PCMPEQB and PMOVMSKB to 386. · 871177df

Keith Randall authored Mar 29, 2013

Used by CL 8056043 for fast string equals.

R=bradfitz
CC=golang-dev
https://golang.org/cl/8102044

871177df

api: remove Zone of net.IPNet from next.txt · 47a54ab2

Mikio Hara authored Mar 29, 2013

Update #4234.
Update #4501.

R=golang-dev, dave, bradfitz
CC=golang-dev
https://golang.org/cl/8129043

47a54ab2

net: close TCPListener in example · 66b797a4
Mikio Hara authored Mar 29, 2013
```
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/8073044
```
66b797a4

net: update documentation for ListenTCP, ListenUDP · 245dc62c

Mikio Hara authored Mar 29, 2013

Adds the missing wildcard port assignment description to ListenUDP.
Also updates the wildcard port description on ListenTCP.

R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/8063043

245dc62c

net: update documentation for FileConn, FilePacketConn, FileListener · abccf6b6
Mikio Hara authored Mar 29, 2013
```
Closes the API documentation gap between platforms.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8086043
```
abccf6b6

net: enable IPv6 tests on Windows · 0f9b3059

Mikio Hara authored Mar 29, 2013

Also removes redundant tests that run Go 1.0 non-IPv6 support
Windows code on IPv6 enabled Windows kernels.

R=alex.brainman, golang-dev, bradfitz, dave
CC=golang-dev
https://golang.org/cl/7812052

0f9b3059

net/http: unflake TestTransportConcurrency · 68130a07
Brad Fitzpatrick authored Mar 29, 2013
```
Fixes #5005

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8127043
```
68130a07

28 Mar, 2013 14 commits

go/printer: use strings.Split instead of specialized code · f3881197

Robert Griesemer authored Mar 28, 2013

With the faster strings package, the difference between
the specialized code and strings.Split is in the noise:

benchmark         old ns/op    new ns/op    delta
BenchmarkPrint     16724291     16686729   -0.22%

(Measured on a Mac Pro, 2.8GHz Quad-core Intel Xeon,
4GB 800 MHz DDR2, Mac OS X 10.8.3)

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/8100044

f3881197

cmd/ld: only pass -rdynamic to host linker on ELF target · 47ec6e23
Ian Lance Taylor authored Mar 28, 2013
```
Fixes #5150.

R=golang-dev, franciscossouza
CC=golang-dev
https://golang.org/cl/8120043
```
47ec6e23

net/http: reuse textproto.Readers; remove 2 more allocations · 1b0d04b8

Brad Fitzpatrick authored Mar 28, 2013

Saves both the textproto.Reader allocation, and its internal
scratch buffer growing.

benchmark                                   old ns/op    new ns/op    delta
BenchmarkServerFakeConnWithKeepAliveLite        10324        10149   -1.70%

benchmark                                  old allocs   new allocs    delta
BenchmarkServerFakeConnWithKeepAliveLite           19           17  -10.53%

benchmark                                   old bytes    new bytes    delta
BenchmarkServerFakeConnWithKeepAliveLite         1559         1492   -4.30%

R=golang-dev, r, gri
CC=golang-dev
https://golang.org/cl/8094046

1b0d04b8

cmd/godoc: provide a link from notes to source location · f1b7c140
Robert Griesemer authored Mar 28, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8122043
```
f1b7c140

cmd/ld, runtime: restrict stack root scan to locals and arguments · c676b8b2

Carl Shapiro authored Mar 28, 2013

Updates #5134

R=golang-dev, bradfitz, cshapiro, daniel.morsing, ality, iant
CC=golang-dev
https://golang.org/cl/8022044

c676b8b2

net/http: parse Request-Line in a function, remove an allocation · 7e7f8993

Brad Fitzpatrick authored Mar 28, 2013

Removes another per-request allocation. Also makes the code more
readable, IMO. And more testable.

benchmark                                   old ns/op    new ns/op    delta
BenchmarkServerFakeConnWithKeepAliveLite        10539        10324   -2.04%

benchmark                                  old allocs   new allocs    delta
BenchmarkServerFakeConnWithKeepAliveLite           20           19   -5.00%

benchmark                                   old bytes    new bytes    delta
BenchmarkServerFakeConnWithKeepAliveLite         1609         1559   -3.11%

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/8118044

7e7f8993

net/url: use strings.Index instead of a loop · 731dcb76

Brad Fitzpatrick authored Mar 28, 2013

We already depend on strings in this file, so use it.

Plus strings.Index will be faster than a manual loop
once issue 3751 is finished.

R=golang-dev, khr
CC=golang-dev
https://golang.org/cl/8116043

731dcb76

go/doc: fix typo in comment · cb79b2cf
Robert Griesemer authored Mar 28, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/8113043
```
cb79b2cf

net/http: inline chunkWriter in response · a891484a

Brad Fitzpatrick authored Mar 28, 2013

A chunkWriter and a response are 1:1. Make them contiguous in
memory and save an allocation.

benchmark                                   old ns/op    new ns/op    delta
BenchmarkServerFakeConnWithKeepAliveLite        10715        10539   -1.64%

benchmark                                  old allocs   new allocs    delta
BenchmarkServerFakeConnWithKeepAliveLite           21           20   -4.76%

benchmark                                   old bytes    new bytes    delta
BenchmarkServerFakeConnWithKeepAliveLite         1626         1609   -1.05%

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/8114043

a891484a

net/http: remove two more server allocations per-request · 42a84086

Brad Fitzpatrick authored Mar 28, 2013

benchmark                                   old ns/op    new ns/op    delta
BenchmarkServerFakeConnWithKeepAliveLite        11031        10689   -3.10%

benchmark                                  old allocs   new allocs    delta
BenchmarkServerFakeConnWithKeepAliveLite           23           21   -8.70%

benchmark                                   old bytes    new bytes    delta
BenchmarkServerFakeConnWithKeepAliveLite         1668         1626   -2.52%

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/8110044

42a84086

cmd/godoc: cleanups · 04341b24

Robert Griesemer authored Mar 28, 2013

- removed gratuitous empty lines that creeped into command line output
- changed comment color to a dark green so that links don't visually melt into them
- removed some TODOs
- updated doc.go

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/8108044

04341b24

net/http: more tests, better comments, remove an allocation · 972cb4b4

Brad Fitzpatrick authored Mar 28, 2013

Add more tests around the various orders handlers can access
and flush response headers.

Also clarify the documentation on fields of response and
chunkWriter.

While there, remove an allocation (a header clone) for simple
handlers.

benchmark                                   old ns/op    new ns/op    delta
BenchmarkServerFakeConnWithKeepAliveLite        15245        14966   -1.83%

benchmark                                  old allocs   new allocs    delta
BenchmarkServerFakeConnWithKeepAliveLite           24           23   -4.17%

benchmark                                   old bytes    new bytes    delta
BenchmarkServerFakeConnWithKeepAliveLite         1717         1668   -2.85%

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/8101043

972cb4b4

cmd/ld: when using host linker pass -r option as -rpath · 8877a2df
Ian Lance Taylor authored Mar 28, 2013
```
R=golang-dev, daniel.morsing
CC=golang-dev
https://golang.org/cl/8070043
```
8877a2df

cmd/godoc: don't crash if there's no documentation · 1a427a69

Robert Griesemer authored Mar 28, 2013

Fixes regression introduced by CL 7860049.

R=golang-dev, kamil.kisiel, dave
CC=golang-dev
https://golang.org/cl/8069044

1a427a69

27 Mar, 2013 11 commits

vet: add a progress message to asmdecl.go · ab962c8d

Rob Pike authored Mar 27, 2013

Analogous to the one for .go files, it's for .s only and is protected
by the verbose flag.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/8030046

ab962c8d

text/template: fix bug in evaluating a chain starting with a function. · 99645db9
Rob Pike authored Mar 27, 2013
```
R=golang-dev, alberto.garcia.hierro
CC=golang-dev
https://golang.org/cl/7861046
```
99645db9

vet: fix test_deadcode.go's tests · b06b77b8

Rob Pike authored Mar 27, 2013

This is a totally mechanical change.
Errors are reported for the beginning of the statement, not the end,
so the errchk markers need to be on the opening brace, not the closing
one. It seems this test was never run.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7746050

b06b77b8

cmd/vet: fix assembly test files · f3eaaa62

Rob Pike authored Mar 27, 2013

They should be build-tagged for vet_test not ignore,
and not have a Go package clause.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/8016047

f3eaaa62

runtime: allocate maps' first bucket table lazily · 5b3ff61b

Brad Fitzpatrick authored Mar 27, 2013

Motivated by garbage profiling in HTTP benchmarks. This
changes means new empty maps are just one small allocation
(the HMap) instead the HMap + the relatively larger h->buckets
allocation. This helps maps which remain empty throughout
their life.

benchmark               old ns/op    new ns/op    delta
BenchmarkNewEmptyMap          196          107  -45.41%

benchmark              old allocs   new allocs    delta
BenchmarkNewEmptyMap            2            1  -50.00%

benchmark               old bytes    new bytes    delta
BenchmarkNewEmptyMap          195           50  -74.36%

R=khr, golang-dev, r
CC=golang-dev
https://golang.org/cl/7722046

5b3ff61b

cmd/ld: fix OpenBSD (third try) · b735eeb3

Ian Lance Taylor authored Mar 27, 2013

On OpenBSD don't mark runtime.{g,m} as STT_TLS symbols.

R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/7867046

b735eeb3

faq: update with some links and 1.1-specific details · 48ecfc97
Rob Pike authored Mar 27, 2013
```
R=golang-dev, remyoudompheng, iant
CC=golang-dev
https://golang.org/cl/8038048
```
48ecfc97
cmd/godoc: emit id's for constants and variables · 611e8dbf
Robert Griesemer authored Mar 27, 2013
```
Fixes #5077.

R=r
CC=golang-dev
https://golang.org/cl/8021044
```
611e8dbf

cmd/ld, cmd/8l: Fix OpenBSD build. · 8d4f381f

Ian Lance Taylor authored Mar 27, 2013

Don't generate TLS sections on OpenBSD.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8059043

8d4f381f

cmd/6l: fix OpenBSD build · e7fc9a5c

Ian Lance Taylor authored Mar 27, 2013

Avoid generating TLS relocations on OpenBSD.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7641055

e7fc9a5c

cmd/gc: update runtime.go for new map implementation. · e3b767a5
Rémy Oudompheng authored Mar 27, 2013
```
R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/8051044
```
e3b767a5