Commits · 3a765be98c9667746855f7f46d5a773b13b0084f · go / golang

02 Jan, 2014 3 commits
- A+C: Pavel Zinovkin (individual CLA) · 3a765be9
  Brad Fitzpatrick authored Jan 02, 2014
```
Generated by addca.

R=gobot
CC=golang-codereviews
https://golang.org/cl/39780047
```
  3a765be9
- encoding/hex: add Decode error test case · eaff83b9
  Shawn Smith authored Jan 02, 2014
```
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/46880043
```
  eaff83b9
- time: add tests for Duration.Nanoseconds, Duration.Minutes, and Duration.Hours · b38da05a
  Shawn Smith authored Jan 02, 2014
```
R=golang-codereviews, rsc, dave
CC=golang-codereviews
https://golang.org/cl/42440043
```
  b38da05a
01 Jan, 2014 5 commits
- encoding/json: add tests for InvalidUnmarshalError · 66730120
  Dave Cheney authored Jan 01, 2014
```
R=golang-codereviews, shawn.p.smith
CC=golang-codereviews
https://golang.org/cl/41960047
```
  66730120
- bufio: improve NewReaderSize, Peek, and UnreadByte test coverage · 4d239bce
  Shawn Smith authored Jan 01, 2014
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/42990045
```
  4d239bce
- encoding/json: improve omitempty test coverage · a39f3b29
  Shawn Smith authored Jan 01, 2014
```
R=golang-codereviews, dave, bradfitz
CC=golang-codereviews
https://golang.org/cl/46250043
```
  a39f3b29
- os: improve Readdir and Readdirnames test coverage · 3c7d2e6a
  Shawn Smith authored Jan 01, 2014
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/46450043
```
  3c7d2e6a
- encoding/hex: add Decode test case with uppercase hex characters · 87327137
  Shawn Smith authored Jan 01, 2014
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/46270043
```
  87327137
31 Dec, 2013 8 commits

debug/elf: add C source for testdata executables · 592416a3

Michael Stapelberg authored Dec 31, 2013

This source file, when compiled with gcc 4.4.3 on Ubuntu lucid,
corresponds instruction for instruction to the binaries in the same
directory.

Shipping this source code file resolves http://bugs.debian.org/716853

R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/46780043

592416a3

crypto/sha256: add tests for Size() and BlockSize() · e3040e2b
Shawn Smith authored Dec 31, 2013
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/46470043
```
e3040e2b

2014: Year of the Gopher. · 8f3fc547

David Symonds authored Dec 31, 2013

R=adg, djd, mpvl, nigeltao
CC=golang-codereviews
https://golang.org/cl/46660043

8f3fc547

crypto/sha1: add tests for Size() and BlockSize() · 0333e80d
Shawn Smith authored Dec 31, 2013
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/46400044
```
0333e80d
container/ring: add test for Move with empty Ring · a1731ac0
Shawn Smith authored Dec 31, 2013
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/46630044
```
a1731ac0

net: fix typo · b4571bdf

Mikio Hara authored Dec 31, 2013

R=golang-codereviews, bradfitz, dave
CC=golang-codereviews
https://golang.org/cl/46600043

b4571bdf

crypto/sha512: add tests for Size() and BlockSize() · dcf562df
Shawn Smith authored Dec 31, 2013
```
R=golang-codereviews, bradfitz, dave
CC=golang-codereviews
https://golang.org/cl/43550047
```
dcf562df
text/template: don't panic when using AddParseTree with an unparsed template · ff006982
Josh Bleecher Snyder authored Dec 31, 2013
```
Fixes #7032.

R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/43960045
```
ff006982

30 Dec, 2013 6 commits

spec: example shows wrong value for complex constant · 8183ed19

Mihai Borobocea authored Dec 30, 2013

Looks like a typo.
Fixes #7011.

R=golang-codereviews, r, bradfitz
CC=golang-codereviews
https://golang.org/cl/45350043

8183ed19

A+C: Mihai Borobocea (individual CLA) · 206eff71
Brad Fitzpatrick authored Dec 30, 2013
```
Generated by addca.

R=gobot
CC=golang-codereviews
https://golang.org/cl/46540044
```
206eff71

cmd/6g: inline copies of up to 4 words in length. · 0ea20bc9

Keith Randall authored Dec 30, 2013

This change fixes a serious performance regression
with reflect.Value growing to 4 words instead of 3.
The json benchmark was ~50% slower, with this change
it is ~5% slower (and the binary is 0.5% larger).

Longer term, we probably need to rethink our copy
generation.  Using REP is really expensive time-wise.
But inlining the copy grows the binary.

R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/44990043

0ea20bc9

runtime: use readrange instead of read to check for races · 1cc2ff8f

Keith Randall authored Dec 30, 2013

on map keys and values which are now passed by reference.

R=dvyukov, khr
CC=golang-codereviews
https://golang.org/cl/43490044

1cc2ff8f

reflect: fixed method name in Slice3 error message · 7ff57e2f
Richard Musiol authored Dec 30, 2013
```
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/46500043
```
7ff57e2f
reflect: add DeepEqual slice of slice inequality test · 96ee10fb
Shawn Smith authored Dec 30, 2013
```
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/46510043
```
96ee10fb

29 Dec, 2013 5 commits

doc/contribute: golang-dev -> golang-codereviews · 2f5f1939
Shawn Smith authored Dec 29, 2013
```
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/46320043
```
2f5f1939
reflect: remove length check for arrays in deepValueEqual · c989a0b2
Shawn Smith authored Dec 29, 2013
```
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/39910044
```
c989a0b2
io: add tests for SectionReader ReadAt and Size · 36c8c5f0
Shawn Smith authored Dec 29, 2013
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/39200045
```
36c8c5f0
crypto/hmac: add tests for Size() and BlockSize() · 351caa4b
Shawn Smith authored Dec 29, 2013
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/41320044
```
351caa4b

runtime: load runtime.goarm as a byte, not a word · d2fe44d5

Dave Cheney authored Dec 29, 2013

Fixes #6952.

runtime.asminit was incorrectly loading runtime.goarm as a word, not a uint8 which made it subject to alignment issues on arm5 platforms.

Alignment aside, this also meant that the top 3 bytes in R11 would have been garbage and could not be assumed to be setting up the FPU reliably.

R=iant, minux.ma
CC=golang-codereviews
https://golang.org/cl/46240043

d2fe44d5

28 Dec, 2013 3 commits

net: work around Solaris connect issue when server closes socket · 672525a5

Ian Lance Taylor authored Dec 28, 2013

On Solaris, if you do a in-progress connect, and then the
server accepts and closes the socket, the client's later
attempt to complete the connect will fail with EINVAL.  Handle
this case by assuming that the connect succeeded.  This code
is weird enough that it is implemented as Solaris-only so that
it doesn't hide a real error on a different OS.

Update #6828

R=golang-codereviews, bradfitz, dave
CC=golang-codereviews
https://golang.org/cl/46160043

672525a5

bytes: add test for Contains · 872f5ffa

Shawn Smith authored Dec 28, 2013

R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/46140043

872f5ffa

archive/tar: add test case for passing nil to FileInfoHeader · 42cea1a4
Shawn Smith authored Dec 28, 2013
```
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/44710044
```
42cea1a4

27 Dec, 2013 6 commits

all: fix a few spelling errors in source comments · 5499034a
Martin Olsson authored Dec 27, 2013
```
R=golang-codereviews, dave, iant
CC=golang-codereviews
https://golang.org/cl/45750044
```
5499034a
A+C: Martin Olsson (individual CLA) · 3980aad4
Ian Lance Taylor authored Dec 27, 2013
```
Generated by addca.

R=gobot
CC=golang-codereviews
https://golang.org/cl/46040043
```
3980aad4

net: use DialTimeout in TestSelfConnect · 4aa521a7

Ian Lance Taylor authored Dec 27, 2013

This avoids problems with systems that take a long time to
find out nothing is listening, while still testing for the
self-connect misfeature since a self-connect should be fast.
With this we may be able to remove the test for non-Linux
systems.

Tested (on GNU/Linux) by editing selfConnect in
tcpsock_posix.go to always return false and verifying that
TestSelfConnect then fails with and without this change.

Idea from Uros Bizjak.

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/39200044

4aa521a7

strconv: add tests for FormatBool and AppendBool · d1a91436
Shawn Smith authored Dec 27, 2013
```
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/42480043
```
d1a91436
strconv: remove unused atof32int function · f485e985
Shawn Smith authored Dec 27, 2013
```
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/44200044
```
f485e985
crypto/cipher: remove unused shift1 function · 41334070
Shawn Smith authored Dec 27, 2013
```
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/38990045
```
41334070

26 Dec, 2013 4 commits

net/http: quiet distracting test spam · 2ccc9a96

Brad Fitzpatrick authored Dec 26, 2013

Capture log output (and test it while at it),
and quiet unnecessary t.Logf.

R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/45850043

2ccc9a96

net/http: fix data race in benchmark · 1fa02060

Brad Fitzpatrick authored Dec 26, 2013

Fixes #7006

R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/44940044

1fa02060

net/http: Release reference to chunkWriter's bufio.Writer on hijack · 92b5e161

John Newlin authored Dec 26, 2013

When a connection is hijacked, release the reference to the bufio.Writer
that is used with the chunkWriter.  The chunkWriter is not used after
the connection is hijacked.

Also add a test to check that double Hijack calls do something sensible.

benchmark                old ns/op    new ns/op    delta
BenchmarkServerHijack        24137        20629  -14.53%

benchmark               old allocs   new allocs    delta
BenchmarkServerHijack           21           19   -9.52%

benchmark                old bytes    new bytes    delta
BenchmarkServerHijack        11774         9667  -17.90%

R=bradfitz, dave, chris.cahoon
CC=golang-codereviews
https://golang.org/cl/39440044

92b5e161

C: add John Newlin (Google CLA) · 499d2167
Brad Fitzpatrick authored Dec 26, 2013
```
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/45830043
```
499d2167