Skip to content

G
golang
Switch branch/tag
  1. 31 Aug, 2010 7 commits
  3. 30 Aug, 2010 7 commits
  5. 29 Aug, 2010 3 commits
  7. 27 Aug, 2010 10 commits
  9. 26 Aug, 2010 13 commits
    • Charles L. Dorian's avatar
      math: amd64 version of Sincos · bead166a
      Charles L. Dorian authored 
      R=rsc
CC=golang-dev
https://golang.org/cl/1939042
      bead166a
    • Russ Cox's avatar
      codereview: speed upload · f7d87f35
      Russ Cox authored 
      Cuts time to upload trivial 160-file CL by 5x,
from 250 seconds to 50 seconds.

R=r
CC=golang-dev
https://golang.org/cl/1991047
      f7d87f35
    • Russ Cox's avatar
      build: fix cgo with -j2 · d3a2dcf5
      Russ Cox authored 
      a b: c expands to multiple rules,
which then run in parallel.

R=r, iant
CC=golang-dev
https://golang.org/cl/2007047
      d3a2dcf5
    • Kyle Consalus's avatar
      gc: brace nit from last review · e24910d0
      Kyle Consalus authored 
      R=rsc
CC=golang-dev
https://golang.org/cl/1997045
      e24910d0
    • Ian Lance Taylor's avatar
      netchan: Fix race condition in test. · b279c048
      Ian Lance Taylor authored 
      Two tests start a goroutine which runs exportSend, and then
the tests run importReceive.  exportSend creates an export
channel.  importReceive asks to receive values on that
channel.  Because exportSend runs in a separate goroutine,
it's possible for the export client to receive the request for
values on the channel, from importReceive, before the
goroutine actually creates the export channel.  That causes an
error: "export: no such channel: exportedSend".  This patch
avoids the race by creating the export channel before starting
the goroutine.

There does not seem to be a similar race condition in the
tests which send data in the other direction.

R=r
CC=golang-dev
https://golang.org/cl/2026045
      b279c048
    • Russ Cox's avatar
      codereview: consistent indent, cut dead code · 3b226f98
      Russ Cox authored 
      End the charade (farce?) that we are using upload.py unaltered.
Cut all the unused stuff.
Indent using tabs to match the rest of the file.

Next: rewrite MercurialVCS to use mercurial package,
to avoid overhead of forking off a new hg command
multiple times for every file.  And parallelize upload.

R=gri
CC=golang-dev
https://golang.org/cl/2009046
      3b226f98
    • Robert Griesemer's avatar
      go/typechecker: 2nd step towards augmenting AST with full type information. · c606b964
      Robert Griesemer authored 
      - refine/define Scope, Object, and Type structures
  (note: scope.go has the addition of types, the rest is only re-organized
  for better readability)
- implemented top-level of type checker:
  resolve global type declarations (deal with double decls, cycles, etc.)
- temporary hooks for checking of const/var declarations, function/method bodies
- test harness for fine-grained testing (exact error locations)
  with initial set of tests

This is a subset of the code for easier review.

R=rsc
CC=golang-dev
https://golang.org/cl/1967049
      c606b964
    • Russ Cox's avatar
      codereview: fix hang on standard hg commands · 4ae2b43e
      Russ Cox authored 
      R=gri
CC=golang-dev
https://golang.org/cl/1950045
      4ae2b43e
    • Russ Cox's avatar
      codereview: print status when hung · e3ac0b5d
      Russ Cox authored 
      After 30 seconds, start printing status updates,
so that we can see whether hg is making progress.

$ hg upload 1983051
Thu Aug 26 15:06:15 2010 running gofmt
Thu Aug 26 15:06:30 2010 inspecting src/pkg/big/int_test.go
Thu Aug 26 15:06:45 2010 inspecting src/pkg/cmath/conj.go
Thu Aug 26 15:07:00 2010 inspecting src/pkg/expvar/expvar.go
Thu Aug 26 15:07:15 2010 inspecting src/pkg/os/env_unix.go
Thu Aug 26 15:07:30 2010 inspecting src/pkg/os/sys_bsd.go
Thu Aug 26 15:07:45 2010 inspecting src/pkg/rand/rand_test.go
Thu Aug 26 15:08:00 2010 inspecting src/pkg/runtime/sig.go
Thu Aug 26 15:08:15 2010 inspecting src/pkg/time/time_test.go
Thu Aug 26 15:08:30 2010 inspecting src/pkg/websocket/websocket.go
Thu Aug 26 15:08:45 2010 uploading src/pkg/utf8/utf8.go
Thu Aug 26 15:09:00 2010 uploading src/pkg/unicode/letter_test.go
Thu Aug 26 15:09:15 2010 uploading src/pkg/xml/embed_test.go
Thu Aug 26 15:09:30 2010 uploading src/pkg/time/tick.go
Thu Aug 26 15:09:45 2010 uploading src/pkg/big/rat_test.go
Thu Aug 26 15:10:00 2010 uploading src/pkg/time/sleep_test.go
Thu Aug 26 15:10:15 2010 uploading src/pkg/patch/patch_test.go
Thu Aug 26 15:10:30 2010 uploading src/pkg/rand/rand.go
https://golang.org/cl/1983051

$

R=gri
CC=golang-dev
https://golang.org/cl/2020045
      e3ac0b5d
    • Scott Lawrence's avatar
      misc/emacs: make _ a word symbol · 87229f54
      Scott Lawrence authored 
      Fixes #655.

R=rsc, aclements
CC=golang-dev
https://golang.org/cl/1981041
      87229f54
    • Corey Thomasson's avatar
      net: add LookupMX · ec72f9bf
      Corey Thomasson authored 
      R=rsc
CC=golang-dev
https://golang.org/cl/1976049
      ec72f9bf
    • Kyle Consalus's avatar
      runtime: special case copy, equal for one-word interface values · 4d903504
      Kyle Consalus authored 
      Based on the observation that a great number of the types that
are copied or compared in interfaces, maps, and channels are
word-sized, this uses specialized copy and equality functions
for them that use a word instead of 4 or 8 bytes. Seems to yield
0-6% improvements in performance in the benchmarks I've run.
For example, with the regexp benchmarks:

Before:
regexp.BenchmarkLiteral   500000       3.26 µs/op
regexp.BenchmarkNotLiteral    100000      13.67 µs/op
regexp.BenchmarkMatchClass    100000      18.72 µs/op
regexp.BenchmarkMatchClass_InRange    100000      20.04 µs/op
regexp.BenchmarkReplaceAll    100000      27.85 µs/op

After:
regexp.BenchmarkLiteral   500000       3.11 µs/op
regexp.BenchmarkNotLiteral    200000      13.29 µs/op
regexp.BenchmarkMatchClass    100000      17.65 µs/op
regexp.BenchmarkMatchClass_InRange    100000      18.49 µs/op
regexp.BenchmarkReplaceAll    100000      26.34 µs/op

R=rsc
CC=golang-dev
https://golang.org/cl/1967047
      4d903504
    • Jukka-Pekka Kekkonen's avatar
      crypto/hmac: make Sum idempotent · ba5b09f7
      Jukka-Pekka Kekkonen authored 
      Fixes #978.

R=rsc
CC=golang-dev
https://golang.org/cl/1967045
      ba5b09f7