- 13 Apr, 2011 15 commits
-
-
Robert Griesemer authored
R=rsc CC=golang-dev https://golang.org/cl/4397046
-
Russ Cox authored
This CL is only cut-and-paste, moving code around. Moving it in a separate CL should simplify the diffs in later CLs. There are three patterns here. 1. A function like func (v Value) M() (...) { return v.panicIfNot(K).(*kValue).M() } becomes func (v Value) M() (...) { vv := v.panicIfNot(K).(*kValue) // body of (*kValue).M, s/v./vv./g } 2. A function like func (v Value) M() (...) { return v.panicIfNots(kList).(mer).M() } becomes func (v Value) M() (...) { switch vv := v.panicIfNots(kList).(type) { case *k1Value: // body of (*k1Value).M, s/v./vv./g case *k2Value: // body of (*k2Value).M, s/v./vv./g ... } panic("not reached") } 3. The rewrite of Value.Set follows 2, but each case is built from the bodies of (*kValue).SetValue and (*kValue).Set. func (v *kValue) SetValue(x Value) { v.Set(x.panicIfNot(K).(*kValue) } func (v *kValue) Set(x *kValue) { ... body } becomes, in the switch from 2, case *kValue: xx := x.panicIfNot(K).(*kValue) ... body, s/v./vv./g; s/x./xx./g R=r CC=golang-dev https://golang.org/cl/4398044
-
Rob Pike authored
R=rsc, gri CC=golang-dev https://golang.org/cl/4411044
-
Russ Cox authored
TBR=r CC=golang-dev https://golang.org/cl/4396045
-
Russ Cox authored
This CL changes the behavior of 'make install' and 'make test' in the src/cmd directory and the src/pkg directory to have each recursive make clean up after itself immediately. It does the same in test/run, removing $F.$A and $A.out (the common byproducts) between runs. On machines with slow disks and aggressive kernel caching, cleaning up immediately can mean that the intermediate objects never get written to disk. This change eliminates almost all the disk waiting during all.bash on my laptop (a Thinkpad X201s with an SSD running Linux). 147.50u 19.95s 277.34r before 148.53u 21.64s 179.59r after R=golang-dev, r, iant2 CC=golang-dev https://golang.org/cl/4413042
-
Russ Cox authored
Better to fix the warnings that we find. R=iant CC=golang-dev https://golang.org/cl/4406042
-
Russ Cox authored
R=golang-dev, r, iant2 CC=golang-dev https://golang.org/cl/4408043
-
Adam Langley authored
It matches encoding/line exactly and the tests are copied from there. If we land this, then encoding/line will get marked as deprecated then deleted in time. R=rsc, rog, peterGo CC=golang-dev https://golang.org/cl/4389046
-
Brad Fitzpatrick authored
R=r, mkrautz, r2, rsc CC=golang-dev https://golang.org/cl/4415041
-
Robert Griesemer authored
With the (partial) resolution of identifiers done by the go/parser, ast.Objects point may introduce cycles in the AST. Don't follow *ast.Objects, and replace them with nil instead (they are likely incorrect after a rewrite anyway). - minor manual cleanups after reflect change automatic rewrite - includes fix by rsc related to reflect change Fixes #1667. R=rsc CC=golang-dev https://golang.org/cl/4387044
-
Robert Griesemer authored
- fixed a couple of comments - cleanups after reflect change R=rsc CC=golang-dev https://golang.org/cl/4389041
-
Andrew Gerrand authored
R=rsc CC=golang-dev https://golang.org/cl/4312051
-
Dmitry Chestnykh authored
Fmt command filters the current Go buffer through gofmt. It tries to preserve cursor position and avoids replacing the buffer with stderr output. R=golang-dev, dsymonds, niemeyer CC=golang-dev https://golang.org/cl/4382053
-
David Symonds authored
Fixes #1677. R=r CC=golang-dev https://golang.org/cl/4402042
-
Gustavo Niemeyer authored
The changes were not tested for real in an App Engine environment, so extra care should be taken. That said, some static testing was done with pyflakes, and a few existent problems were fixed on the way. R=adg CC=golang-dev https://golang.org/cl/4378053
-
- 12 Apr, 2011 9 commits
-
-
Fazlul Shahriar authored
'TestReaddir.*' tests now passes. R=golang-dev, lucio, r CC=golang-dev https://golang.org/cl/4381048
-
Lucio De Re authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/4390047
-
Rob Pike authored
Suggested by jan.mercl@nic.cz. R=rsc, jnml CC=golang-dev https://golang.org/cl/4376054
-
Lucio De Re authored
Added "void" inside "()" for two functions. R=golang-dev, r CC=golang-dev https://golang.org/cl/4381056
-
Rob Pike authored
I entered only one of his several addresses, the one that recent CLs use. R=rsc, lucio CC=golang-dev https://golang.org/cl/4368078
-
Brad Fitzpatrick authored
R=adg, rsc, bradfitzwork CC=golang-dev https://golang.org/cl/4389048
-
Gustavo Niemeyer authored
R=golang-dev, agl1, jnml CC=golang-dev https://golang.org/cl/4381058
-
Nigel Tao authored
R=r, rsc, nigeltao_gnome CC=golang-dev, raph https://golang.org/cl/4374043
-
Nigel Tao authored
R=rsc CC=golang-dev https://golang.org/cl/4381050
-
- 11 Apr, 2011 7 commits
-
-
Luuk van Dijk authored
Moved Sym printing to Yconv. Fixed warning in data.c R=rsc CC=golang-dev https://golang.org/cl/4378052
-
Robert Hencke authored
R=golang-dev, bradfitzgo CC=golang-dev https://golang.org/cl/4370053
-
Fazlul Shahriar authored
This makes os_test.TestStartProcess test from os package pass. R=paulzhol, r2, r CC=golang-dev https://golang.org/cl/4385052
-
Mikkel Krautz authored
R=agl1 CC=golang-dev https://golang.org/cl/4376049
-
Luit van Drongelen authored
Fixes #1683 R=agl1 CC=golang-dev, rsc https://golang.org/cl/4367049
-
Russ Cox authored
R=agl1 CC=golang-dev https://golang.org/cl/4367051
-
Dave Cheney authored
Fixes #1649. R=rsc, adg CC=golang-dev https://golang.org/cl/4343056
-
- 10 Apr, 2011 2 commits
-
-
David Symonds authored
R=adg CC=golang-dev https://golang.org/cl/4385051
-
Dmitry Chestnykh authored
Fixes #1678. R=adg, rsc CC=golang-dev https://golang.org/cl/4372047
-
- 09 Apr, 2011 1 commit
-
-
Russ Cox authored
The ld time was dominated by symbol table processing, so * increase hash table size * emit fewer symbols in gc (just 1 per string, 1 per type) * add read-only lookup to avoid creating spurious symbols * add linked list to speed whole-table traversals Breaks dwarf generator (no idea why), so disable dwarf. Reduces time for 6l to link godoc by 25%. R=ken2 CC=golang-dev https://golang.org/cl/4383047
-
- 08 Apr, 2011 6 commits
-
-
Robert Griesemer authored
Note that declarations.golden is not using spaces for alignment (so that the alignment tabs are visible) which is why this change affects the test cases significantly. gofmt uses spaces for alignment (by default) and only tabs for indentation. gofmt -w src misc (no changes) Fixes #1673. R=iant CC=golang-dev https://golang.org/cl/4388044
-
Adam Langley authored
"%#v" of a structure with *big.Int's tends to crash a lot otherwise. R=golang-dev, gri CC=golang-dev https://golang.org/cl/4382044
-
Russ Cox authored
Rewrite MOVB with less expensive instruction when possible. Suggested by atomic symbol. benchmark old ns/op new ns/op delta crc32.BenchmarkCrc32KB 13066 3942 -69.83% crc64.BenchmarkCrc64KB 8780 5949 -32.24% lzw.BenchmarkDecoder1e4 771224 636538 -17.46% lzw.BenchmarkDecoder1e5 7101218 6096634 -14.15% lzw.BenchmarkDecoder1e6 69762020 60789400 -12.86% lzw.BenchmarkEncoder1e4 707968 638812 -9.77% lzw.BenchmarkEncoder1e5 6567122 5965552 -9.16% lzw.BenchmarkEncoder1e6 65006000 58911680 -9.38% utf8_test.BenchmarkRuneCountTenASCIIChars 166 165 -0.60% utf8_test.BenchmarkRuneCountTenJapaneseChars 246 258 +4.88% utf8_test.BenchmarkEncodeASCIIRune 13 10 -23.08% utf8_test.BenchmarkEncodeJapaneseRune 37 16 -56.76% utf8_test.BenchmarkDecodeASCIIRune 23 21 -8.70% utf8_test.BenchmarkDecodeJapaneseRune 58 32 -44.83% R=ken2 CC=golang-dev https://golang.org/cl/4381045
-
Russ Cox authored
Fixes #1670. R=ken2 CC=golang-dev https://golang.org/cl/4386045
-
Robert Hencke authored
R=rsc CC=golang-dev https://golang.org/cl/4271080
-
Russ Cox authored
R=r CC=golang-dev https://golang.org/cl/4380043
-