Commits · 3e52dadfd7b4c43c1d630d510eeb1b289d2ab422 · go / golang

26 Oct, 2011 12 commits

Russ Cox authored Oct 26, 2011

Public API of syntax tree changes.

R=golang-dev, r, gri
CC=golang-dev
https://golang.org/cl/5302046

3e52dadf

govet: update signatures for rune · 81b01481
Russ Cox authored Oct 26, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/5301053
```
81b01481

godoc, exp/ebnf, exp/types, go/scanner, scanner: use rune · 5be33e95

Russ Cox authored Oct 26, 2011

API question: is a scanner token an int or a rune?

Since the rune is the common case and the token values
are the special (negative) case, I chose rune.  But it could
easily go the other way.

R=gri
CC=golang-dev
https://golang.org/cl/5301049

5be33e95

cgo, goyacc, go/build, html, http, path, path/filepath, testing/quick, test: use rune · db339597
Russ Cox authored Oct 26, 2011
```
Nothing terribly interesting here.

R=golang-dev, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/5300043
```
db339597
gc: introduce rune · 6ed3fa65
Russ Cox authored Oct 26, 2011
```
R=ken, r
CC=golang-dev
https://golang.org/cl/5293046
```
6ed3fa65
exp/types: add rune to universe · f4568882
Russ Cox authored Oct 26, 2011
```
R=gri
CC=golang-dev
https://golang.org/cl/5295045
```
f4568882

undo CL 5302057 / dac58d9c9e4a · 5abb29d1

Andrew Gerrand authored Oct 26, 2011

need a clean base from weekly.2011-10-25 for rune change

««« original CL description
http: remove Connection header in ReverseProxy

Fixes #2342

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5302057
»»»

R=rsc
CC=golang-dev
https://golang.org/cl/5294068

5abb29d1

http: remove Connection header in ReverseProxy · 7c5d90df
Brad Fitzpatrick authored Oct 26, 2011
```
Fixes #2342

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5302057
```
7c5d90df
tag weekly.2011-10-25 · 9c012899
Andrew Gerrand authored Oct 26, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5306064
```
9c012899
weekly.2011-10-25 · cdd3d693
Andrew Gerrand authored Oct 26, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5321053
```
cdd3d693

html: improve parsing of lists · 05ed18f4

Andrew Balholm authored Oct 26, 2011

Make a <li> tag close the previous <li> element.
Make a </ul> tag close <li> elements.

Pass tests1.dat, test 33:
<!DOCTYPE html><li>hello<li>world<ul>how<li>do</ul>you</body><!--do-->

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <li>
|       "hello"
|     <li>
|       "world"
|       <ul>
|         "how"
|         <li>
|           "do"
|       "you"
|   <!-- do -->

R=nigeltao
CC=golang-dev
https://golang.org/cl/5321051

05ed18f4

html: improve parsing of tables · 6e318bda

Andrew Balholm authored Oct 26, 2011

When foster parenting, merge adjacent text nodes.
Properly close table row at </tr> tag.

Pass tests1.dat, test 32:
<!-----><font><div>hello<table>excite!<b>me!<th><i>please!</tr><!--X-->

| <!-- - -->
| <html>
|   <head>
|   <body>
|     <font>
|       <div>
|         "helloexcite!"
|         <b>
|           "me!"
|         <table>
|           <tbody>
|             <tr>
|               <th>
|                 <i>
|                   "please!"
|             <!-- X -->

R=nigeltao
CC=golang-dev
https://golang.org/cl/5323048

6e318bda

25 Oct, 2011 5 commits

syscall: correct name of mksyscall script in comment · 7959aeb0
Ian Lance Taylor authored Oct 25, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5310055
```
7959aeb0
runtime: include bootstrap m in mcpu accounting · 2572ca2f
Hector Chu authored Oct 25, 2011
```
R=rsc, dvyukov
CC=golang-dev
https://golang.org/cl/5307052
```
2572ca2f
http: doc typo · d72267ae
Brad Fitzpatrick authored Oct 25, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5303067
```
d72267ae
syscall: use uintptr for Mount flags. · 85b9f357
David Anderson authored Oct 25, 2011
```
R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5308044
```
85b9f357

html: remove the Tokenizer.ReturnComments option. · 18b025d5

Nigel Tao authored Oct 25, 2011

The original intention was to simplify the parser, in making it skip
all comment tokens. However, checking that the Go html package is
100% compatible with the WebKit HTML test suite requires parsing the
comments. There is no longer any real benefit for the option.

R=gri, andybalholm
CC=golang-dev
https://golang.org/cl/5321043

18b025d5

24 Oct, 2011 3 commits

exp/ssh: introduce Session to replace Cmd for interactive commands · 57912334

Dave Cheney authored Oct 24, 2011

This CL replaces the Cmd type with a Session type representing
interactive channels. This lays the foundation for supporting
other kinds of channels like direct-tcpip or x11.

client.go:
* replace chanlist map with slice.
* generalize stdout and stderr into a single type.
* unexport ClientChan to clientChan.

doc.go:
* update ServerConfig/ServerConn documentation.
* update Client example for Session.

message.go:
* make channelExtendedData more like channelData.

session.go:
* added Session which replaces Cmd.

R=agl, rsc, n13m3y3r, gustavo
CC=golang-dev
https://golang.org/cl/5302054

57912334

html: dump attributes when running parser tests. · 2f3f3aa2

Andrew Balholm authored Oct 24, 2011

The WebKit test data shows attributes as though they were child nodes:

<a X>0<b>1<a Y>2
dumps as:
| <html>
|   <head>
|   <body>
|     <a>
|       x=""
|       "0"
|       <b>
|         "1"
|     <b>
|       <a>
|         y=""
|         "2"

So we need to do the same when dumping a tree to compare with it.

R=nigeltao
CC=golang-dev
https://golang.org/cl/5322044

2f3f3aa2

http: add package comment · 2b5aa283
Brad Fitzpatrick authored Oct 24, 2011
```
Fixes #2378

R=rsc
CC=golang-dev
https://golang.org/cl/5312052
```
2b5aa283

23 Oct, 2011 2 commits

net: do not set SO_REUSEADDR for windows · c1d0f0e7
Alex Brainman authored Oct 23, 2011
```
Fixes #2307.

R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5306049
```
c1d0f0e7

html: implement foster parenting · 2aa589c8

Andrew Balholm authored Oct 23, 2011

Implement the foster-parenting algorithm for content that is inside a table
but not in a cell.

Also fix a bug in reconstructing the active formatting elements.

Pass test 30 in tests1.dat:
<a><table><td><a><table></table><a></tr><a></table><b>X</b>C<a>Y

R=nigeltao
CC=golang-dev
https://golang.org/cl/5309052

2aa589c8

22 Oct, 2011 1 commit

html: parse <select> tags. · 2f352ae4

Nigel Tao authored Oct 22, 2011

The additional test case in parse_test.go is:
<select><b><option><select><option></b></select>X

R=andybalholm
CC=golang-dev
https://golang.org/cl/5293051

2f352ae4

21 Oct, 2011 6 commits

big: usable zero Rat values without need for explicit initialization · 696ced50

Robert Griesemer authored Oct 21, 2011

- no explicit API change, but new(big.Rat) now creates a big.Rat value
  of 0 that is immediately usable, in sync. w/ the conventions elsewhere
- various cleanups along the way

R=r
CC=golang-dev
https://golang.org/cl/5301056

696ced50

fmt: simplify the code some more by storing the field in the pp structure. · d481d7c8
Rob Pike authored Oct 21, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5293058
```
d481d7c8

big: implemented Rat.Inv · 4854bd9c

Robert Griesemer authored Oct 21, 2011

Also:
- changed semantics of return values for [Int|Rat].SetString
  if an error occured (returned value is nil); will expose
  hidden errors where return values are not checked
- added more tests
- various cleanups throughout

Fixes #2384.

R=r
CC=golang-dev
https://golang.org/cl/5312044

4854bd9c

gotest: make it easier to get the help string · c6bdef3f

Rob Pike authored Oct 21, 2011

Because gotest's args are mingled with the tests, it's
hard to get the usage message to print. This CL adds
explicit support for -help, spelled several different ways.
Gotest has special flags like -file that are somewhat
hidden otherwise.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5298052

c6bdef3f

http: Transport: with TLS InsecureSkipVerify, skip hostname check · 2cab897c
Brad Fitzpatrick authored Oct 21, 2011
```
Fixes #2386

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5312045
```
2cab897c

exp/ssh: server cleanups · 8bfb2171

Dave Cheney authored Oct 21, 2011

server.go/channel.go:
* rename Server to ServerConfig to match Client.
* rename ServerConnection to ServeConn to match Client.
* add Listen/Listener.
* ServerConn.Handshake(), general cleanups.

client.go:
* fix bug where fmt.Error was not assigned to err

R=rsc, agl
CC=golang-dev
https://golang.org/cl/5265049

8bfb2171

20 Oct, 2011 5 commits

exp/ssh: add experimental ssh client · 792a55f5

Dave Cheney authored Oct 20, 2011

Requires CL 5285044

client.go:
* add Dial, ClientConn, ClientChan, ClientConfig and Cmd.

doc.go:
* add Client documentation.

server.go:
* adjust for readVersion change.

transport.go:
* return an os.Error not a bool from readVersion.

R=rsc, agl, n13m3y3r
CC=golang-dev
https://golang.org/cl/5162047

792a55f5

go/ast: use single-element map in test · e8a426ae

Robert Griesemer authored Oct 20, 2011

Avoids test failure due to undefined map iteration order.

R=rsc, iant, iant
CC=golang-dev
https://golang.org/cl/5297048

e8a426ae

go/ast, go/token: actually run tests; fix go/ast test · 22dd0ba9
Ian Lance Taylor authored Oct 20, 2011
```
R=gri
CC=golang-dev
https://golang.org/cl/5292048
```
22dd0ba9
exp/winfsnotify: fix test · 9e1a2adf
Hector Chu authored Oct 20, 2011
```
R=alex.brainman, mattn.jp
CC=golang-dev
https://golang.org/cl/5311047
```
9e1a2adf

html: parse and render comment nodes. · 64306c9f

Nigel Tao authored Oct 20, 2011

The first additional test case in parse_test.go is:
<!--><div>--<!-->

The second one is unrelated to the comment change, but also passes:
<p><hr></p>

R=andybalholm
CC=golang-dev
https://golang.org/cl/5299047

64306c9f

19 Oct, 2011 6 commits

misc/vim: add highlighting for delete · 57d07e32
Dave Cheney authored Oct 19, 2011
```
R=golang-dev, n13m3y3r
CC=golang-dev
https://golang.org/cl/5303050
```
57d07e32
fmt: don't panic formatting nil interfaces · 526d0818
Gustavo Niemeyer authored Oct 19, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5296044
```
526d0818

govet: check canonical dynamic method signatures · b0ec32db

Russ Cox authored Oct 19, 2011

Adds check that, for example, a Scan method taking
a first argument of type fmt.ScanState has the correct
signature to satisfy fmt.Scanner.

Similarly, a ReadByte should return byte, os.Error.

These are important to check because various pieces
of code (fmt, gob, json, flate) do dynamic checks
for these methods, so code with incorrect signatures
would not be flagged at compile time.

These become even more important to check when
rune is introduced.

R=r
CC=golang-dev
https://golang.org/cl/5305044

b0ec32db

unicode: sort tables.go · b4d6b71e

Russ Cox authored Oct 19, 2011

Makes tables.go output consistent across maketable runs.
(It was already inconsistent across architectures; the new
map iteration order just make it inconsistent across runs.)

R=r
CC=golang-dev
https://golang.org/cl/5303046

b4d6b71e

codereview: show LGTMs in hg p · c0523e1d

Russ Cox authored Oct 19, 2011

Shows first line of any response that the codereview server
has identified as an LGTM.  Example output below.

5305046:
        big: update for fmt interface changes

        Nothing terribly interesting here.

        Reviewer: gri@golang.org
                gri: LGTM
        CC: golang-dev@googlegroups.com
        Files:
                src/pkg/big/int.go
                src/pkg/big/nat.go
                src/pkg/big/nat_test.go
                src/pkg/big/rat.go

5307044:
        exp/template/html: use rune

        Nothing terribly interesting here.

        Reviewer: mikesamuel@gmail.com, nigeltao@golang.org
                mikesamuel: I don't see a type def for rune.  Assuming that's a new intrinsic, LGTM.
        CC: golang-dev@googlegroups.com
        Files:
                src/pkg/exp/template/html/css.go
                src/pkg/exp/template/html/css_test.go
                src/pkg/exp/template/html/html.go
                src/pkg/exp/template/html/js.go

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5297045

c0523e1d

gotest: use $GCFLAGS like make does · 35b2bfc8
Russ Cox authored Oct 19, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5297044
```
35b2bfc8