- 17 Nov, 2011 2 commits
-
-
Alex Brainman authored
R=golang-dev, rsc CC=dave, golang-dev https://golang.org/cl/5364061
-
Russ Cox authored
Making Value opaque means we can drop the interface kludges in favor of a significantly simpler and faster representation. v.Kind() will be a prime candidate for inlining too. On a Thinkpad X201s using -benchtime 10: benchmark old ns/op new ns/op delta json.BenchmarkCodeEncoder 284391780 157415960 -44.65% json.BenchmarkCodeMarshal 286979140 158992020 -44.60% json.BenchmarkCodeDecoder 717175800 388288220 -45.86% json.BenchmarkCodeUnmarshal 734470500 404548520 -44.92% json.BenchmarkCodeUnmarshalReuse 707172280 385258720 -45.52% json.BenchmarkSkipValue 24630036 18557062 -24.66% benchmark old MB/s new MB/s speedup json.BenchmarkCodeEncoder 6.82 12.33 1.81x json.BenchmarkCodeMarshal 6.76 12.20 1.80x json.BenchmarkCodeDecoder 2.71 5.00 1.85x json.BenchmarkCodeUnmarshal 2.64 4.80 1.82x json.BenchmarkCodeUnmarshalReuse 2.74 5.04 1.84x json.BenchmarkSkipValue 77.92 103.42 1.33x I cannot explain why BenchmarkSkipValue gets faster. Maybe it is one of those code alignment things. R=iant, r, gri, r CC=golang-dev https://golang.org/cl/5373101
-
- 16 Nov, 2011 16 commits
-
-
Russ Cox authored
Fix bug377.go to be gofmt-compliant. R=gri, r, r CC=golang-dev https://golang.org/cl/5400045
-
Andrew Balholm authored
Pass tests2.dat, test 35: <!DOCTYPE html><select><optgroup><option></optgroup><option><select><option> | <!DOCTYPE html> | <html> | <head> | <body> | <select> | <optgroup> | <option> | <option> | <option> Also pass tests through test 41: <!DOCTYPE html><!-- XXX - XXX - XXX --> R=nigeltao, rsc CC=golang-dev https://golang.org/cl/5395045
-
Russ Cox authored
Fixes use of c after Dial failure (causes crash). May fix Dial failure by listening to 127.0.0.1:0 instead of 0.0.0.0:0 (tests should only listen on localhost). R=golang-dev, gri CC=golang-dev https://golang.org/cl/5395052
-
Russ Cox authored
Fixes "test.sh" (long test) in src/cmd/gofmt. R=gri CC=golang-dev https://golang.org/cl/5307081
-
Lucio De Re authored
R=rsc, bradfitz CC=golang-dev https://golang.org/cl/5371092
-
Christopher Wedgwood authored
R=rsc, dave CC=golang-dev https://golang.org/cl/5399045
-
Anthony Martin authored
I've modified Plan 9's yacc to work with the grammar in go.y. These are the only changes necessary on the Go side. R=rsc CC=golang-dev https://golang.org/cl/5375104
-
Robert Griesemer authored
R=iant, iant CC=golang-dev https://golang.org/cl/5393047
-
Lucio De Re authored
R=golang-dev CC=golang-dev, rsc https://golang.org/cl/5374086
-
Gustavo Niemeyer authored
http.Response is currently returning 0, nil on EOF. R=golang-dev, bradfitz, bradfitz CC=golang-dev https://golang.org/cl/5394047
-
Brad Fitzpatrick authored
The wrong length was being sent, and two parameters were also transposed. Made the record type be a type and made the constants typed, to prevent that sort of bug in the future. Fixes #2469 R=golang-dev, edsrzf CC=golang-dev https://golang.org/cl/5394046
-
Rob Pike authored
text/template does this (in an entirely different way), so make html/template do the same. Before this fix, the template {{.}} given a pointer to a string prints its address instead of its value. R=mikesamuel, r CC=golang-dev https://golang.org/cl/5370098 -
Dave Cheney authored
Ensure that empty NameLists always return a zero length []string, not nil. In practice NameLists are only used in a few message types and always consumed by a for range function so the difference between nil and []string{} is not significant. Also, add exp/ssh to pkg/Makefile as suggested by rsc. R=rsc, agl CC=golang-dev https://golang.org/cl/5400042 -
Andrew Balholm authored
Pass tests2.dat, test 34: <!DOCTYPE html><select><option><optgroup> | <!DOCTYPE html> | <html> | <head> | <body> | <select> | <option> | <optgroup> R=nigeltao CC=golang-dev https://golang.org/cl/5393045
-
Andrew Balholm authored
Pass tests2.dat, test 33: <!DOCTYPE html><table><caption>test TEST</caption><td>test | <!DOCTYPE html> | <html> | <head> | <body> | <table> | <caption> | "test TEST" | <tbody> | <tr> | <td> | "test" R=nigeltao CC=golang-dev https://golang.org/cl/5371099
-
Yasuhiro Matsumoto authored
Some database driver can't get number of parameters. For example: http://support.microsoft.com/kb/240205/en-us So, added way to ignore checking number of parameters with return -1. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5376091
-
- 15 Nov, 2011 19 commits
-
-
Brad Fitzpatrick authored
This was used in the sql package + tests, but never documented. R=golang-dev, gri CC=golang-dev https://golang.org/cl/5372107
-
Mikio Hara authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5375099
-
Russ Cox authored
Made the edit in the wrong client before submitting. TBR=r CC=golang-dev https://golang.org/cl/5374091
-
Russ Cox authored
TBR=brainman CC=golang-dev https://golang.org/cl/5373105
-
Russ Cox authored
Move scanner allocation out of loop. It's the only allocation in the test so it dominates when it triggers a garbage collection. R=golang-dev, r CC=golang-dev https://golang.org/cl/5369117
-
Bobby Powers authored
R=golang-dev, mpimenov, gri CC=golang-dev https://golang.org/cl/5370101
-
Russ Cox authored
Errors in the code under test go to standard output. Errors in testing or its usage go to standard error. R=r CC=golang-dev https://golang.org/cl/5374090
-
Russ Cox authored
I've been using this since April and posted it on the mailing list, but it seems worth having in the repository. Not sure about the location. R=golang-dev, r, r CC=golang-dev https://golang.org/cl/5371100
-
Alex Brainman authored
R=rsc, mikioh.mikioh CC=golang-dev https://golang.org/cl/5373097
-
Russ Cox authored
An experiment: allow structs to be copied even if they contain unexported fields. This gives packages the ability to return opaque values in their APIs, like reflect does for reflect.Value but without the kludgy hacks reflect resorts to. In general, we trust programmers not to do silly things like *x = *y on a package's struct pointers, just as we trust programmers not to do unicode.Letter = unicode.Digit, but packages that want a harder guarantee can introduce an extra level of indirection, like in the changes to os.File in this CL or by using an interface type. All in one CL so that it can be rolled back more easily if we decide this is a bad idea. Originally discussed in March 2011. https://groups.google.com/group/golang-dev/t/3f5d30938c7c45ef R=golang-dev, adg, dvyukov, r, bradfitz, jan.mercl, gri CC=golang-dev https://golang.org/cl/5372095
-
Russ Cox authored
Make code amenable to escape analysis so that the decimal values do not escape. benchmark old ns/op new ns/op delta strconv_test.BenchmarkAtof64Decimal 229 233 +1.75% strconv_test.BenchmarkAtof64Float 261 263 +0.77% strconv_test.BenchmarkAtof64FloatExp 7760 7757 -0.04% strconv_test.BenchmarkAtof64Big 3086 3053 -1.07% strconv_test.BenchmarkFtoa64Decimal 6866 2629 -61.71% strconv_test.BenchmarkFtoa64Float 7211 3064 -57.51% strconv_test.BenchmarkFtoa64FloatExp 12587 8263 -34.35% strconv_test.BenchmarkFtoa64Big 7058 2825 -59.97% json.BenchmarkCodeEncoder 357355200 276528200 -22.62% json.BenchmarkCodeMarshal 360735200 279646400 -22.48% json.BenchmarkCodeDecoder 731528600 709460600 -3.02% json.BenchmarkCodeUnmarshal 754774400 731051200 -3.14% json.BenchmarkCodeUnmarshalReuse 713379000 704218000 -1.28% json.BenchmarkSkipValue 51594300 51682600 +0.17% benchmark old MB/s new MB/s speedup json.BenchmarkCodeEncoder 5.43 7.02 1.29x json.BenchmarkCodeMarshal 5.38 6.94 1.29x json.BenchmarkCodeDecoder 2.65 2.74 1.03x json.BenchmarkCodeUnmarshal 2.57 2.65 1.03x json.BenchmarkCodeUnmarshalReuse 2.72 2.76 1.01x json.BenchmarkSkipValue 38.61 38.55 1.00x R=golang-dev, r CC=golang-dev https://golang.org/cl/5369111
-
Russ Cox authored
R=gri, iant, iant CC=golang-dev https://golang.org/cl/5375093
-
Russ Cox authored
R=bradfitz CC=golang-dev https://golang.org/cl/5373096
-
Russ Cox authored
R=bradfitz CC=golang-dev https://golang.org/cl/5387041
-
Mikio Hara authored
empty is already not a nil. R=golang-dev, bradfitz, rsc CC=golang-dev https://golang.org/cl/5376099
-
Andrew Balholm authored
Pass tests2.dat, test 26: <!doctypehtml><p><form> | <!DOCTYPE html> | <html> | <head> | <body> | <p> | <form> Also pass tests through test 32: <!DOCTYPE html><!-- X R=nigeltao CC=golang-dev https://golang.org/cl/5369114
-
Mikio Hara authored
empty is already not a nil. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5376098
-
Mikio Hara authored
empty is already not a nil. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5375097
-
Andrew Balholm authored
Pass tests2.dat, test 10: <table><plaintext><td> | <html> | <head> | <body> | <plaintext> | "<td>" | <table> Also pass tests through test 25: <!doctypehtml><p><dd> R=nigeltao CC=golang-dev https://golang.org/cl/5369109
-
- 14 Nov, 2011 3 commits
-
-
Robert Griesemer authored
No need for creating a new nat each time. Per Roger Peppe's suggestion; assuming nat(nil) produces better code than nat{}. R=rsc CC=golang-dev https://golang.org/cl/5375092 -
Brad Fitzpatrick authored
R=rsc CC=golang-dev https://golang.org/cl/5375089
-
Russ Cox authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5373095
-
