Commits · 41453d2ed2a0ddb6c4acf5f1c41323749c0bafce · go / golang

09 Dec, 2011 10 commits
- exp/types: fix linux build · 41453d2e
  Russ Cox authored Dec 09, 2011
```
I don't understand why it was only broken on Linux

TBR=gri
CC=golang-dev
https://golang.org/cl/5479045
```
  41453d2e
- gc: fix export of '\'' and '\\' constants · 2ab9bb6a
  Russ Cox authored Dec 09, 2011
```
Fixes Windows build.

R=ken2
CC=golang-dev
https://golang.org/cl/5472046
```
  2ab9bb6a
- spec: fix typo in example comment · 9a358df9
  Charles L. Dorian authored Dec 09, 2011
```
R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5475046
```
  9a358df9
- update tree for new default type rule · a250f37c
  Russ Cox authored Dec 09, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5448091
```
  a250f37c
- gc: implement character constant type rules · be0ffbfd
  Russ Cox authored Dec 09, 2011
```
R=ken2
CC=golang-dev
https://golang.org/cl/5444054
```
  be0ffbfd
- math: special cases for Pow10; delete BUG · 2065b0a0
  Charles L. Dorian authored Dec 09, 2011
```
R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5477046
```
  2065b0a0
- spec: var x = 'a' defaults to type rune · a9336355
  Russ Cox authored Dec 09, 2011
```
R=gri, r, r, adg, iant, ken
CC=golang-dev
https://golang.org/cl/5444053
```
  a9336355
- doc/go1: most of the simple language changes · 136c04f7
  Rob Pike authored Dec 09, 2011
```
R=rsc, adg, r
CC=golang-dev
https://golang.org/cl/5477044
```
  136c04f7
- syscall: allow for mksyscall_windows.pl to be used outside of syscall · 27cab903
  Alex Brainman authored Dec 09, 2011
```
this change should have been part of fafcd328da73

R=golang-dev, bsiegert
CC=golang-dev
https://golang.org/cl/5462045
```
  27cab903
- misc/cgo/testso: do not leave out file behind · 692c31d6
  Alex Brainman authored Dec 09, 2011
```
R=golang-dev, dvyukov
CC=golang-dev
https://golang.org/cl/5461044
```
  692c31d6
08 Dec, 2011 12 commits

syscall: Remove obsolete Errstr call from commented-out example. · 5d045fb0

Benny Siegert authored Dec 08, 2011

syscall_windows.go contains a small demo, which calls the obsolete
syscall.Errstr function.

R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/5475044

5d045fb0

math: document more special cases · 94b0342f

Charles L. Dorian authored Dec 08, 2011

Acosh, Asinh, Atanh, Ceil, Floor, Trunc, Mod and Remainder affected. These changes add some non-finite arguments and results (and -0.0 results).

R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5469046

94b0342f

crypto/dsa: don't truncate input hashes. · 60f564fc

Adam Langley authored Dec 08, 2011

Although FIPS 186-3 says that we should truncate the hashes, at least
one other library (libgcrypt) doesn't. This means that it's impossible
to interoperate with code using gcrypt if we enforce the truncation
inside of crypto/dsa.

This change shouldn't actually affect anything because nearly
everybody pairs DSA with SHA1, which doesn't need to be truncated in
either case.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5471043

60f564fc

doc/go1: document rearranged package hierarchy · 9d59c40e

Rob Pike authored Dec 08, 2011

Some exciting HTML and CSS here.

R=remyoudompheng, rsc, r
CC=golang-dev
https://golang.org/cl/5460047

9d59c40e

tmpltohtml: put a DO NOT EDIT mark automatically in the output · 1ddedbae
Rob Pike authored Dec 08, 2011
```
R=r, rsc, r
CC=golang-dev
https://golang.org/cl/5469045
```
1ddedbae
html/template: clean up locking for ExecuteTemplate · 0397b28a
Rob Pike authored Dec 08, 2011
```
R=mikesamuel, rogpeppe
CC=golang-dev
https://golang.org/cl/5448137
```
0397b28a

syscall: add constants for flock() system call under Linux. · 83c30f3e

Andrea Spadaccini authored Dec 08, 2011

The values have been generated only for the i386 and amd64 architectures.

R=golang-dev, mikioh.mikioh, dsymonds
CC=bradfitz, dsymonds, golang-dev
https://golang.org/cl/5452060

83c30f3e

CONTRIBUTORS: Andrea Spadaccini (Google CLA) · c526188f
David Symonds authored Dec 08, 2011
```
R=golang-dev, rsc
CC=golang-dev, spadaccio
https://golang.org/cl/5460046
```
c526188f
time: use Duration for AfterFunc. · 2949f3b6
David Symonds authored Dec 08, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5465043
```
2949f3b6

gc: rename %union field name from lint to i · f00340f0

Russ Cox authored Dec 08, 2011

#define lint has special meaning to Bison;
having a field named lint conflicts with that.

R=ken2
CC=golang-dev
https://golang.org/cl/5462044

f00340f0

syscall: return error, not uintptr, when function returns error · ef65feda
Alex Brainman authored Dec 08, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5450119
```
ef65feda

doc/go1: map deletion · 2fa987b6

Rob Pike authored Dec 08, 2011

This CL is in part a proposal for how to write these sections:
- Brief discussion of change
- No attempt to analyze the thinking about it
- Old code
- New code, runnable if possible
- How to update old programs

R=golang-dev, remyoudompheng, gri, adg
CC=golang-dev
https://golang.org/cl/5454044

2fa987b6

07 Dec, 2011 18 commits

gobuilder: goinstall packages after building go tree · be587a4d
Andrew Gerrand authored Dec 07, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5450100
```
be587a4d

strconv: fix documentation · 2e3bd890

Robert Griesemer authored Dec 07, 2011

Also: minor performance fix for large precision results.

benchmark                                   old ns/op    new ns/op    delta
strconv_test.BenchmarkFormatFloatDecimal         2734         2734   +0.00%
strconv_test.BenchmarkFormatFloat                3141         3139   -0.06%
strconv_test.BenchmarkFormatFloatExp             8970         8989   +0.21%
strconv_test.BenchmarkFormatFloatBig             3228         3208   -0.62%

Fixes #2535.

R=rsc
CC=golang-dev
https://golang.org/cl/5435089

2e3bd890

doc: skeleton for release note document · bab4dec1

Rob Pike authored Dec 07, 2011

No content yet other than titles and an introductory paragraph.
Once this is in, content can arise as separate manageable CLs.

R=rsc
CC=golang-dev
https://golang.org/cl/5435090

bab4dec1

gc: keep pointer to original node in constant rewrites. · 4349effb

Rémy Oudompheng authored Dec 07, 2011

This allows printing meaningful expressions in error messages
instead of evaluated constants.
Fixes #2276.

R=golang-dev, rsc
CC=golang-dev, remy
https://golang.org/cl/5432082

4349effb

exp/sql: simplify some string conversions. · 9d52fe22
David Symonds authored Dec 07, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/5451112
```
9d52fe22
gc: fix spurious typecheck loop in &composite literal · 5e98505b
Russ Cox authored Dec 07, 2011
```
Fixes #2538.

R=ken2
CC=golang-dev
https://golang.org/cl/5449114
```
5e98505b
bytes: lost edit from earlier CL · 1278c6c0
Russ Cox authored Dec 07, 2011
```
R=iant
CC=golang-dev
https://golang.org/cl/5450125
```
1278c6c0

bytes: faster Count, Index, Equal · 9b875bc0

Russ Cox authored Dec 07, 2011

Benchmarks are from GOARCH=amd64 on a MacPro5,1.

benchmark old MB/s new MB/s speedup
bytes_test.BenchmarkEqual32 452.89 891.07 1.97x
bytes_test.BenchmarkEqual4K 852.71 1700.44 1.99x
bytes_test.BenchmarkEqual4M 841.53 1587.93 1.89x
bytes_test.BenchmarkEqual64M 838.22 1578.14 1.88x

bytes_test.BenchmarkIndex32 58.02 48.99 0.84x
bytes_test.BenchmarkIndex4K 48.26 41.32 0.86x
bytes_test.BenchmarkIndex4M 48.20 41.24 0.86x
bytes_test.BenchmarkIndex64M 48.08 41.21 0.86x
bytes_test.BenchmarkIndexEasy32 410.04 546.82 1.33x
bytes_test.BenchmarkIndexEasy4K 849.26 14257.37 16.79x
bytes_test.BenchmarkIndexEasy4M 854.54 17222.15 20.15x
bytes_test.BenchmarkIndexEasy64M 843.57 11060.40 13.11x

bytes_test.BenchmarkCount32 57.24 50.68 0.89x
bytes_test.BenchmarkCount4K 48.19 41.82 0.87x
bytes_test.BenchmarkCount4M 48.18 41.74 0.87x
bytes_test.BenchmarkCount64M 48.17 41.71 0.87x
bytes_test.BenchmarkCountEasy32 433.11 547.44 1.26x
bytes_test.BenchmarkCountEasy4K 1130.59 14194.06 12.55x
bytes_test.BenchmarkCountEasy4M 1131.23 17231.18 15.23x
bytes_test.BenchmarkCountEasy64M 1111.40 11068.88 9.96x

The non-easy Count/Index benchmarks are a worst case input.

regexp.BenchmarkMatchEasy0_32 237.46 221.47 0.93x
regexp.BenchmarkMatchEasy0_1K 553.53 1019.72 1.84x
regexp.BenchmarkMatchEasy0_32K 693.99 1672.06 2.41x
regexp.BenchmarkMatchEasy0_1M 688.72 1611.68 2.34x
regexp.BenchmarkMatchEasy0_32M 680.70 1565.05 2.30x
regexp.BenchmarkMatchEasy1_32 165.56 243.08 1.47x
regexp.BenchmarkMatchEasy1_1K 336.45 496.32 1.48x
regexp.BenchmarkMatchEasy1_32K 302.80 425.63 1.41x
regexp.BenchmarkMatchEasy1_1M 300.42 414.20 1.38x
regexp.BenchmarkMatchEasy1_32M 299.64 413.47 1.38x

R=golang-dev, r, iant
CC=golang-dev
https://golang.org/cl/5451116

9b875bc0

regexp: avoid allocation of input interface · 2f2cc24c

Russ Cox authored Dec 07, 2011

Matters most for small inputs, because there is no real work
to amortize the allocation effort against.

benchmark old ns/op new ns/op delta
BenchmarkLiteral 613 473 -22.84%
BenchmarkNotLiteral 4981 4931 -1.00%
BenchmarkMatchClass 7289 7122 -2.29%
BenchmarkMatchClass_InRange 6618 6663 +0.68%
BenchmarkReplaceAll 7843 7233 -7.78%
BenchmarkAnchoredLiteralShortNonMatch 329 228 -30.70%
BenchmarkAnchoredLiteralLongNonMatch 322 228 -29.19%
BenchmarkAnchoredShortMatch 838 715 -14.68%
BenchmarkAnchoredLongMatch 824 715 -13.23%

benchmark old MB/s new MB/s speedup
BenchmarkMatchEasy0_32 119.73 196.61 1.64x
BenchmarkMatchEasy0_1K 540.58 538.33 1.00x
BenchmarkMatchEasy0_32K 732.57 714.00 0.97x
BenchmarkMatchEasy0_1M 726.44 708.36 0.98x
BenchmarkMatchEasy0_32M 707.77 691.45 0.98x
BenchmarkMatchEasy1_32 102.12 136.11 1.33x
BenchmarkMatchEasy1_1K 298.31 307.04 1.03x
BenchmarkMatchEasy1_32K 273.56 274.43 1.00x
BenchmarkMatchEasy1_1M 268.42 269.23 1.00x
BenchmarkMatchEasy1_32M 266.15 267.34 1.00x
BenchmarkMatchMedium_32 2.53 3.38 1.34x
BenchmarkMatchMedium_1K 9.37 9.57 1.02x
BenchmarkMatchMedium_32K 9.29 9.67 1.04x
BenchmarkMatchMedium_1M 9.42 9.66 1.03x
BenchmarkMatchMedium_32M 9.41 9.62 1.02x
BenchmarkMatchHard_32 6.66 6.75 1.01x
BenchmarkMatchHard_1K 6.81 6.85 1.01x
BenchmarkMatchHard_32K 6.79 6.85 1.01x
BenchmarkMatchHard_1M 6.82 6.83 1.00x
BenchmarkMatchHard_32M 6.80 6.80 1.00x

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5453076

2f2cc24c

test: make array smaller in nilptr test · 3c56a7b1
Russ Cox authored Dec 07, 2011
```
Fixes #2314.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5437154
```
3c56a7b1

godoc: <pre> must not occur inside <p> · e97a5581

Olivier Duperray authored Dec 07, 2011

Fixes #2532

R=golang-dev, dr.volker.dobler, rsc
CC=golang-dev
https://golang.org/cl/5450115

e97a5581

A+C: Olivier Duperray, Taru Karttunen (individual CLA) · c3480878
Russ Cox authored Dec 07, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5451121
```
c3480878

math: document special-cases behavior for Dim, Max and Min · e4de2e7f

Charles L. Dorian authored Dec 07, 2011

Max returns +Inf if x or y is +Inf; else it returns NaN if either x or y is NaN. Max(-0, -0) returns -0.
Min returns -Inf if x or y is -Inf; else it returns NaN if either x or y is NaN. Min(+0, -0) returns -0.
Dim(+Inf, +Inf) = NaN, Dim(-Inf, -Inf) = NaN and Dim(NaN, anything) = NaN.
Also, change "conditions" to "cases" for Sin (missed it in previous CL).

R=rsc, dave
CC=golang-dev
https://golang.org/cl/5437137

e4de2e7f

time: fix daysIn for December · 69191553

Peter Mundy authored Dec 07, 2011

daysBefore[12+1]: index out of range
time.December and Windows SYSTEMTIME.wMonth
are 12 for December.

R=rsc, dsymonds
CC=golang-dev
https://golang.org/cl/5448130

69191553

strconv: faster float conversion · 127b5a66

Robert Griesemer authored Dec 07, 2011

- added AppendFloatX benchmarks
- 2% to 13% better performance
- check for illegal bitSize

benchmark                                   old ns/op    new ns/op    delta
strconv_test.BenchmarkFormatFloatDecimal         2993         2733   -8.69%
strconv_test.BenchmarkFormatFloat                3384         3141   -7.18%
strconv_test.BenchmarkFormatFloatExp             9192         9010   -1.98%
strconv_test.BenchmarkFormatFloatBig             3279         3207   -2.20%
strconv_test.BenchmarkAppendFloatDecimal         2837         2478  -12.65%
strconv_test.BenchmarkAppendFloat                3196         2928   -8.39%
strconv_test.BenchmarkAppendFloatExp             9028         8773   -2.82%
strconv_test.BenchmarkAppendFloatBig             3151         2782  -11.71%

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5448122

127b5a66

misc/benchcmp: don't require "Benchmark" at beginning of line · b955bbfb
Robert Griesemer authored Dec 07, 2011
```
Output is package_name.BenchmarkXXX.

R=rsc
CC=golang-dev
https://golang.org/cl/5440123
```
b955bbfb
ld: fix memory leaks · a2ba34d3
Scott Lawrence authored Dec 07, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5434068
```
a2ba34d3

gc: more accurate description of -w and -W switches. · 0c64972d

Rémy Oudompheng authored Dec 07, 2011

The -w switch actually prints steps of the syntax tree walks
while -W prints a summary before and after the walk.

R=golang-dev, rsc
CC=golang-dev, remy
https://golang.org/cl/5444049

0c64972d