- 14 Jun, 2015 8 commits
-
-
Alex Schroeder authored
When reading along the article, the extra code added in the final version is not explained. The main function calls flag.Parse(), for example, which will cause an error, unless the readers looks at the entirety of final.go to see the import added. The file shown to the users no longer has the extra flags. The testing code is now in a patch that gets applied to final.go in order to create final-test.go. This is the file that will be used to test the code, matching final.go as much as possible. Change-Id: I022f5f6c88e107c8ba5623661d74a8d260d05266 Reviewed-on: https://go-review.googlesource.com/11061Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Dmitry Vyukov authored
In generateTrace we check that event timestamp is within the interesting range. Then later in traceContext.time we double check event time. However, for some events (e.g. emitSlice) we convert time of ev.Link (slice end) rather than ev itself (slice begin). Slice end can be outside of the interesting time range, and so traceContext.time crashes. Remove the check in traceContext.time, check in generateTrace loop is sufficient. Change-Id: If94e93b5653c5816c0a8dcdd920f15df97616835 Reviewed-on: https://go-review.googlesource.com/11100Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Dmitry Vyukov authored
Update to tip to fix #11003 (not possible to select events in chromium). Fixed #11003 Change-Id: Ibba5d39ca809cfd5cb79c9e6d152b00899d49e08 Reviewed-on: https://go-review.googlesource.com/11062Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Michael Gehring authored
Return io.ErrUnexpectedEOF instead of io.EOF when reading a truncated data descriptor. Fixes #11146. Change-Id: Ia1905955165fd38af3c557d1fa1703ed8be893e2 Reviewed-on: https://go-review.googlesource.com/11070Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Adam Langley authored
The previous code had a brain fart: it took one of the length prefixes as an element count, not a length. This didn't actually affect anything because the loop stops as soon as it finds a hostname element, and the hostname element is always the first and only element. (No other element types have ever been defined.) This change fixes the parsing in case SNI is ever changed in the future. Fixes #10793. Change-Id: Iafdf3381942bc22b1f33595315c53dc6cc2e9f0f Reviewed-on: https://go-review.googlesource.com/11059Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Michael Matloob authored
s/Backtrace/Backtrack/ Change-Id: I062aab18f23f2bc2110cf7210c2e7264747e02cf Reviewed-on: https://go-review.googlesource.com/11091Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Ian Lance Taylor authored
The test fails on Ubuntu Trusty for some reason, probably because of some set of kernel patches. Change-Id: I52f7ca50b96fea5725817c9e9198860d419f9313 Reviewed-on: https://go-review.googlesource.com/11055Reviewed-by:
Mikio Hara <mikioh.mikioh@gmail.com>
-
Robert Griesemer authored
TBR: bradfitz, adonovan Change-Id: Ifc8574494848503c979d11e2766ba8da0f374068 Reviewed-on: https://go-review.googlesource.com/11043Reviewed-by:
Robert Griesemer <gri@golang.org>
-
- 13 Jun, 2015 4 commits
-
-
Mikio Hara authored
Fixes #10992. Change-Id: Ia376e4de118993b43e5813da57ab25fea8122048 Reviewed-on: https://go-review.googlesource.com/10476Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Kyle Isom authored
This was found while fuzzing another program, triggering a panic in x509.ParseECPrivateKey. Fixes #11154 Change-Id: Ief35ead38adf14caec4d37b9eacf8a92e67cd1e6 Reviewed-on: https://go-review.googlesource.com/10712Reviewed-by:
Adam Langley <agl@golang.org> Run-TryBot: Adam Langley <agl@golang.org>
-
Rob Pike authored
When scanning with a width, as in %5s, C skips leading spaces brefore counting the 5 characters. We should do the same. Reword the documentation about widths to make this clear. Fixes #9444 Change-Id: I443a6441adcf1c834057ef3977f9116a987a79cd Reviewed-on: https://go-review.googlesource.com/10997Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Josh Bleecher Snyder authored
Running -copylocks over a large corpus generates 1507 warnings. Of those, only 3 are from the new anonymous function check, but they are all bugs. Fixes #10927. Change-Id: I2672f6871036bed711beec5f88bc39aa8b3b6a94 Reviewed-on: https://go-review.googlesource.com/11051Reviewed-by:
Rob Pike <r@golang.org>
-
- 12 Jun, 2015 12 commits
-
-
Robert Griesemer authored
This is needed for code that relies on having the correct file set when parsing an expression only. There's currently no other way to get to the file set otherwise or to invoke the parser correctly to work on an expression only with a given file set. Change-Id: I325f174cb34b69284e627f59fe8334efa4eaa45c Reviewed-on: https://go-review.googlesource.com/10998Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Ian Lance Taylor authored
Change-Id: I412621497902fa36f4939df392b10ca7040fc36e Reviewed-on: https://go-review.googlesource.com/11003Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Alexander Morozov authored
Linux 3.19 made a change in the handling of setgroups and the 'gid_map' file to address a security issue. The upshot of the 3.19 changes is that in order to update the 'gid_maps' file, use of the setgroups() system call in this user namespace must first be disabled by writing "deny" to one of the /proc/PID/setgroups files for this namespace. Also added tests for remapping uid_map and gid_map inside new user namespace. Fixes #10626 Change-Id: I4d2539acbab741a37092d277e10f31fc39a8feb7 Reviewed-on: https://go-review.googlesource.com/10670 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Alan Donovan authored
Change-Id: I9d3253b80508d733053789d6cb9645e029bf52e4 Reviewed-on: https://go-review.googlesource.com/10927Reviewed-by:
Robert Griesemer <gri@golang.org>
-
Michael Gehring authored
Sanity check the pax-header size field before using it. Fixes #11167. Change-Id: I9d5d0210c3990e6fb9434c3fe333be0d507d5962 Reviewed-on: https://go-review.googlesource.com/10954Reviewed-by:
David Symonds <dsymonds@golang.org>
-
Brandon Gilmore authored
Change-Id: Ib52854169f3dd18f54d3ae9263c897d3f45ea869 Reviewed-on: https://go-review.googlesource.com/10982Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Rob Pike authored
The documentation says that newlines behave like this: Scan etc.: newlines are spaces. Scanln etc.: newlines terminate the scan. Scanf etc.: newlines must match in input and format. The code did not implement this behavior in all cases, especially for Scanf. Make it behave: - Fix the handling of spaces and newlines in ss.Advance. The code is longer but now behaves as it should. - Delete the reuse of the current ss in newScanState. There is really no need, since it's only used in recursive calls to Scan etc., and the flags are likely wrong. Simpler just to allocate a new one every time, and likelier to be correct. Fixes #10862. Change-Id: If060ac021017346723b0d62de4e5a305da898f68 Reviewed-on: https://go-review.googlesource.com/10991Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Damien Neil authored
Fixes #11050. Change-Id: Ie5d16960a1f829af947d82a63fe414924cd02ff6 Reviewed-on: https://go-review.googlesource.com/10666Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Michael Gehring authored
Change-Id: I22ac23e7e180071de4443291e0a644675200d642 Reviewed-on: https://go-review.googlesource.com/10950Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Alexandre Cesaro authored
The command "go tool pprof help" does not work: $ go tool pprof help open help: no such file or directory The right command is "go tool pprof -h". Change-Id: Icef5d4ab76774905854e46665ac1166d26d35f46 Reviewed-on: https://go-review.googlesource.com/10970Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Alex Brainman authored
I would like to re-apply reverted http://golang.org/cl/8523. Reverted tests still fail in some environments (see issue #10360). It is easier to run tests selectively when in Go. This CL prepares for the changes. Updates #10360 Change-Id: Iefeb1d71cb3d1cfa653a6ccd9f6e35686c0c5b24 Reviewed-on: https://go-review.googlesource.com/10608Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Alex Brainman authored
This CL makes CL 10682 work on windows. Fixes #9645 (again) Change-Id: Ie9b9af8b041c483a236b46adad4a50aa6e598c92 Reviewed-on: https://go-review.googlesource.com/10930Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
- 11 Jun, 2015 11 commits
-
-
Robert Griesemer authored
Suggested by mdempsky (see also issue #11161). Change-Id: I1ab28febe19b7a092029499015073ce8749b4d99 Reviewed-on: https://go-review.googlesource.com/10960Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Ian Lance Taylor authored
As these tests were originally in bash, they are not designed to be particularly hermetic. This CL adds various protective mechanisms to try to catch cases where the tests can not run in parallel. Change-Id: I983bf7b6ffba04eda58b4939eb89b0bdfcda8eff Reviewed-on: https://go-review.googlesource.com/10911Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Ian Lance Taylor authored
Examine the mtime of an existing file to guess a length of time to sleep to ensure a different mtime. Change-Id: I9e8b5c9486f5c3c8bd63125e3ed4763ce1ba767d Reviewed-on: https://go-review.googlesource.com/10932 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Russ Cox authored
This avoids a race with gcmarkwb_m that was leading to faults. Fixes #10212. Change-Id: I6fcf8d09f2692227063ce29152cb57366ea22487 Reviewed-on: https://go-review.googlesource.com/10816 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
Austin Clements <austin@google.com>
-
Brad Fitzpatrick authored
Forgot this one in my previous commit. Change-Id: Ief089e99bdad24b3bcfb075497dc259d06cc727c Reviewed-on: https://go-review.googlesource.com/10913Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Chris Broadfoot authored
Change-Id: Idc4a7fdb561ba5b3b52094d895deaf3fcdf475bf Reviewed-on: https://go-review.googlesource.com/10716Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Brad Fitzpatrick authored
Might get the Android build passing, or at least going further. Change-Id: I08f97156a687abe5a3d95203922f4ffd84fbb212 Reviewed-on: https://go-review.googlesource.com/10924Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Ainar Garipov authored
These were found by grepping the comments from the go code and feeding the output to aspell. Change-Id: Id734d6c8d1938ec3c36bd94a4dbbad577e3ad395 Reviewed-on: https://go-review.googlesource.com/10941Reviewed-by:
Aamir Khan <syst3m.w0rm@gmail.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
David du Colombier authored
This issue was fixed in CL 10900. Change-Id: I88f107cb73c8a515f39e02506ddd2ad1e286b1fb Reviewed-on: https://go-review.googlesource.com/10940 Run-TryBot: David du Colombier <0intro@gmail.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
David du Colombier authored
When the Stat or Fstat system calls return -1, dirstat incorrectly returns ErrShortStat. However, the error returned by Stat or Fstat could be different. For example, when the file doesn't exist, they return "does not exist". Dirstat should return the error returned by the system call. Fixes #10911. Fixes #11132. Change-Id: Icf242d203d256f12366b1e277f99b1458385104a Reviewed-on: https://go-review.googlesource.com/10900 Run-TryBot: David du Colombier <0intro@gmail.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Patrick Mezard authored
Process.handle was accessed without synchronization while wait() and signal() could be called concurrently. A first solution was to add a Mutex in Process but it was probably too invasive given Process.handle is only used on Windows. This version uses atomic operations to read the handle value. There is still a race between isDone() and the value of the handle, but it only leads to slightly incorrect error codes. The caller may get a: errors.New("os: process already finished") instead of: syscall.EINVAL which sounds harmless. Fixes #9382 Change-Id: Iefcc687a1166d5961c8f27154647b9b15a0f748a Reviewed-on: https://go-review.googlesource.com/9904Reviewed-by:
Alex Brainman <alex.brainman@gmail.com> Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 10 Jun, 2015 5 commits
-
-
Ian Lance Taylor authored
Change-Id: I8473e3f7653d5389d5fcd94862f0831049b8266e Reviewed-on: https://go-review.googlesource.com/10809Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Fixes #11144 Change-Id: I1da0b72ef00a84c9b5751be0e72ad07d664bc98b Reviewed-on: https://go-review.googlesource.com/10883Reviewed-by:
Andrew Gerrand <adg@golang.org> Reviewed-by:
Rob Pike <r@golang.org> Reviewed-by:
Dmitry Vyukov <dvyukov@google.com>
-
Ainar Garipov authored
Change-Id: I82edd9364e1b4634006f5e043202a69f383dcdbe Reviewed-on: https://go-review.googlesource.com/10826Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Alex Brainman authored
Update #10254 Change-Id: I3ddd26607813ca629e3ab62abf87dc5ab453e36f Reviewed-on: https://go-review.googlesource.com/10835Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Yongjian Xu authored
Change-Id: Ida4b98aa63e57594fa6fa0b8178106bac9b3cd19 Reviewed-on: https://go-review.googlesource.com/10837Reviewed-by:
Minux Ma <minux@golang.org>
-