1. 17 Nov, 2014 5 commits
  2. 16 Nov, 2014 2 commits
    • Russ Cox's avatar
      runtime: fix sudog leak · b3932bab
      Russ Cox authored
      The SudoG used to sit on the stack, so it was cheap to allocated
      and didn't need to be cleaned up when finished.
      
      For the conversion to Go, we had to move sudog off the stack
      for a few reasons, so we added a cache of recently used sudogs
      to keep allocation cheap. But we didn't add any of the necessary
      cleanup before adding a SudoG to the new cache, and so the cached
      SudoGs had stale pointers inside them that have caused all sorts
      of awful, hard to debug problems.
      
      CL 155760043 made sure SudoG.elem is cleaned up.
      CL 150520043 made sure SudoG.selectdone is cleaned up.
      
      This CL makes sure SudoG.next, SudoG.prev, and SudoG.waitlink
      are cleaned up. I should have done this when I did the other two
      fields; instead I wasted a week tracking down a leak they caused.
      
      A dangling SudoG.waitlink can point into a sudogcache list that
      has been "forgotten" in order to let the GC collect it, but that
      dangling .waitlink keeps the list from being collected.
      And then the list holding the SudoG with the dangling waitlink
      can find itself in the same situation, and so on. We end up
      with lists of lists of unusable SudoGs that are still linked into
      the object graph and never collected (given the right mix of
      non-trivial selects and non-channel synchronization).
      
      More details in golang.org/issue/9110.
      
      Fixes #9110.
      
      LGTM=r
      R=r
      CC=dvyukov, golang-codereviews, iant, khr
      https://golang.org/cl/177870043
      b3932bab
    • Russ Cox's avatar
      runtime: update URL for heap dump format · 6150414c
      Russ Cox authored
      I just created that redirect, so we can change
      it once the wiki moves.
      
      LGTM=bradfitz, khr
      R=khr, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/177780043
      6150414c
  3. 14 Nov, 2014 3 commits
  4. 12 Nov, 2014 4 commits
  5. 11 Nov, 2014 3 commits
    • Robert Griesemer's avatar
      spec: method selectors don't auto-deref named pointer types · 40818cfe
      Robert Griesemer authored
      Language clarification.
      
      The existing rules for selector expressions imply
      automatic dereferencing of pointers to struct fields.
      They also implied automatic dereferencing of selectors
      denoting methods. In almost all cases, such automatic
      dereferencing does indeed take place for methods but the
      reason is not the selector rules but the fact that method
      sets include both methods with T and *T receivers; so for
      a *T actual receiver, a method expecting a formal T
      receiver, also accepts a *T (and the invocation or method
      value expression is the reason for the auto-derefering).
      
      However, the rules as stated so far implied that even in
      case of a variable p of named pointer type P, a selector
      expression p.f would always be shorthand for (*p).f. This
      is true for field selectors f, but cannot be true for
      method selectors since a named pointer type always has an
      empty method set.
      
      Named pointer types may never appear as anonymous field
      types (and method receivers, for that matter), so this
      only applies to variables declared of a named pointer
      type. This is exceedingly rare and perhaps shouldn't be
      permitted in the first place (but we cannot change that).
      
      Amended the selector rules to make auto-deref of values
      of named pointer types an exception to the general rules
      and added corresponding examples with explanations.
      
      Both gc and gccgo have a bug where they do auto-deref
      pointers of named types in method selectors where they
      should not:
      
      See http://play.golang.org/p/c6VhjcIVdM , line 45.
      
      Fixes #5769.
      Fixes #8989.
      
      LGTM=r, rsc
      R=r, rsc, iant, ken
      CC=golang-codereviews
      https://golang.org/cl/168790043
      40818cfe
    • Rob Pike's avatar
      doc/gopher: add jpgs of the 5th anniversary image · 0f8cd143
      Rob Pike authored
      LGTM=adg
      R=golang-codereviews, adg
      CC=golang-codereviews
      https://golang.org/cl/172980043
      0f8cd143
    • Nigel Tao's avatar
      doc: update go1.4.html's minor library changes. · e522a477
      Nigel Tao authored
      LGTM=r
      R=r
      CC=golang-codereviews
      https://golang.org/cl/173920043
      e522a477
  6. 10 Nov, 2014 9 commits
  7. 09 Nov, 2014 7 commits
  8. 08 Nov, 2014 1 commit
  9. 07 Nov, 2014 3 commits
  10. 06 Nov, 2014 3 commits