Commits · 46bce2ac277fc4639fb6b6f6c99f91ac6125ced8 · go / golang

07 Oct, 2012 32 commits

test: convert more tests to rundir/compiledir conventions · 46bce2ac
Rémy Oudompheng authored Oct 07, 2012
```
Update #4139.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6609051
```
46bce2ac
test/testlib: don't forget stderr for rundircmpout. · 5497787d
Rémy Oudompheng authored Oct 07, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6620071
```
5497787d
cmd/8a: add SSE2 instructions · 5da37c09
Russ Cox authored Oct 07, 2012
```
R=ken
CC=golang-dev
https://golang.org/cl/6614063
```
5da37c09
cmd/8l: add SSE2 instructions · c1d06cef
Russ Cox authored Oct 07, 2012
```
R=ken
CC=golang-dev
https://golang.org/cl/6610065
```
c1d06cef

cmd/gc: skip over reported BOMs · d749783f

Russ Cox authored Oct 07, 2012

This keeps the BOM runes from causing other errors.

R=golang-dev, remyoudompheng
CC=golang-dev
https://golang.org/cl/6625062

d749783f

cmd/ld, cmd/5l: support R_ARM_PC24 and R_ARM_JUMP24, fix R_ARM_CALL · 65b782e9

Shenghou Ma authored Oct 07, 2012

1. R_ARM_CALL can also be used to call a PLT entry
2. add support for R_ARM_PC24 and R_ARM_JUMP24
3. refactor, remove D_PLT32 in favor of D_CALL

Fixes #4006.

R=rsc, dave
CC=fullung, golang-dev
https://golang.org/cl/6622057

65b782e9

codereview: more mercurial interface fixes · eca37e1e

Shenghou Ma authored Oct 07, 2012

        Fixes #4131.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6614061

eca37e1e

test: correct type in declbad.go · 9844e4cd

Rémy Oudompheng authored Oct 07, 2012

The test is not about type mismatches and it causes
an extra error to appear.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6614062

9844e4cd

test/bench/shootout: match gcc architecture to GOARCH · c4c4b3b4

Russ Cox authored Oct 07, 2012

If we're benchmarking 8g, use gcc -m32.
If we're benchmarking 6g, use gcc -m64.

R=golang-dev, bradfitz, minux.ma, remyoudompheng
CC=golang-dev
https://golang.org/cl/6625061

c4c4b3b4

cmd/gc: more graceful handling of invalid fields in widstruct. · caff4398

Rémy Oudompheng authored Oct 07, 2012

The protection against segfaults does not completely solve
crashes and breaks test/fixedbugs/bug365.go

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6615058

caff4398

cmd/gc: avoid crash in %N print · 54191126
Russ Cox authored Oct 07, 2012
```
R=ken2
CC=golang-dev
https://golang.org/cl/6609052
```
54191126

io/ioutil: fix data race under the race detector · 373dbcb3

Dmitriy Vyukov authored Oct 07, 2012

See issue 3970 (it's already marked as Fixed).

R=rsc, minux.ma
CC=golang-dev
https://golang.org/cl/6624059

373dbcb3

race: sync/atomic changes · 59b87453

Dmitriy Vyukov authored Oct 07, 2012

This is a part of a bigger change that adds data race detection feature:
https://golang.org/cl/6456044

R=rsc, remyoudompheng
CC=gobot, golang-dev
https://golang.org/cl/6536059

59b87453

race: sync changes · 53390c8f

Dmitriy Vyukov authored Oct 07, 2012

This is a part of a bigger change that adds data race detection feature:
https://golang.org/cl/6456044

R=rsc, minux.ma
CC=gobot, golang-dev
https://golang.org/cl/6529053

53390c8f

race: runtime changes · 2f6cbc74

Dmitriy Vyukov authored Oct 07, 2012

This is a part of a bigger change that adds data race detection feature:
https://golang.org/cl/6456044

R=rsc
CC=gobot, golang-dev
https://golang.org/cl/6535050

2f6cbc74

runtime: disable TestParForParallel for now on 32-bit hosts · f82c59b6

Shenghou Ma authored Oct 07, 2012

Also add call to GC() to make it easier to re-enable the test.

Update #4155.
When we have precise GC merged, re-enable this test.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6622058

f82c59b6

test/run.go: use correct executable filename on Windows, fix build · e8246569
Shenghou Ma authored Oct 07, 2012
```
R=golang-dev, daniel.morsing
CC=golang-dev
https://golang.org/cl/6624060
```
e8246569

os: make TestMkdirAllWithSymlink more robust · 54c109b1

Brad Fitzpatrick authored Oct 07, 2012

Don't assume the test has a clean environment within /tmp.
Use an actual new tempdir for its tests.

Fixes FreeBSD build failure as seen at:
http://build.golang.org/log/396738676356d7fb6bab6eaf1b97cac820f8a90f

--- FAIL: TestMkdirAllWithSymlink (0.00 seconds)
path_test.go:178:                 Mkdir /tmp/dir: mkdir /tmp/dir: file exists
FAIL
FAIL    os      1.091s

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/6615057

54c109b1

net/http/httptest: mimic the normal HTTP server's ResponseWriter more closely · 13576e3b
Brad Fitzpatrick authored Oct 07, 2012
```
Also adds tests, which didn't exist before.

Fixes #4188

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6613062
```
13576e3b
test: use rundir and errorcheckdir for a few more tests. · d9953c9d
Rémy Oudompheng authored Oct 07, 2012
```
Update #4139.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/6620070
```
d9953c9d

testing: fix extra tabs when t.Log("string") · 51310d83

Shenghou Ma authored Oct 07, 2012

t.Log("line 1\nline 2\nline 3")

Old output:
=== RUN TestLine3
--- PASS: TestLine3 (0.00 seconds)
testing_test.go:25: 	line 1
		line 2
		line 3
		PASS

New output:
=== RUN TestLine3
--- PASS: TestLine3 (0.00 seconds)
testing_test.go:24: 	line 1
		line 2
		line 3
PASS

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6613069

51310d83

syscall: fix Statfs and Fstatfs on Linux/ARM · f8485954
Shenghou Ma authored Oct 07, 2012
```
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6615055
```
f8485954

cmd/gc: replace "typechecking loop" by nicer errors in some cases. · 892fa3ae

Rémy Oudompheng authored Oct 07, 2012

For issue 3757:
BEFORE:  test/fixedbugs/bug463.go:12: typechecking loop involving a
             test/fixedbugs/bug463.go:12 a
             test/fixedbugs/bug463.go:12 <node DCLCONST>
AFTER:   test/fixedbugs/bug463.go:12: constant definition loop
             test/fixedbugs/bug463.go:12: a uses a

For issue 3937:
BEFORE: test/fixedbugs/bug464.go:12: typechecking loop involving foo
            test/fixedbugs/bug464.go:12 <T>
            test/fixedbugs/bug464.go:12 foo
            test/fixedbugs/bug464.go:12 <node DCLFUNC>
AFTER:  test/fixedbugs/bug464.go:12: foo is not a type

Fixes #3757.
Fixes #3937.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6614058

892fa3ae

cmd/gc: Don't accept qualified names as literal keys · 87c35d8d
Daniel Morsing authored Oct 07, 2012
```
Fixes #4067.

R=golang-dev, minux.ma, dave, rsc
CC=golang-dev
https://golang.org/cl/6622056
```
87c35d8d

image/jpeg: move the huffman bit decoder state higher up in the · d7b7957d

Nigel Tao authored Oct 07, 2012

decoder struct, inside the unmappedzero limit, to eliminate some
TESTB instructions in the inner decoding loop.

benchmark          old ns/op    new ns/op    delta
BenchmarkDecode      2943204      2746360   -6.69%

R=r, dave
CC=golang-dev
https://golang.org/cl/6625058

d7b7957d

cmd/gc: fix output filename generation on Windows · 9224b4c8
Shenghou Ma authored Oct 07, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6610060
```
9224b4c8

cmd/gc: don't dereference a nil Type pointer in widstruct · 51e8fe5b

Akshat Kumar authored Oct 07, 2012

The nil dereference in the next few lines doesn't seem
to cause a segmentation fault on Unix, but does seem
to halt the Go compiler.

The following is a test case:

>>>
package main

func mine(int b) int {
        return b + 2
}

func main() {
        mine()

        c = mine()
}
<<<

Without this change only the following is caught:

typecheck.go:3: undefined: b
typecheck.go:4: undefined: b

with it, we catch all the errors:

typecheck.go:3: undefined: b
typecheck.go:4: undefined: b
typecheck.go:10: undefined: c
typecheck.go:10: cannot assign to c .

R=rsc, minux.ma
CC=golang-dev
https://golang.org/cl/6542060

51e8fe5b

cmd/gc: Don't export embedded builtins · a45777fe

Daniel Morsing authored Oct 07, 2012

Fixes #4124.

R=golang-dev, dave, minux.ma, remyoudompheng, rsc
CC=golang-dev
https://golang.org/cl/6543057

a45777fe

cmd/5g: avoid temporary in slice bounds check · 01ddc8bd

Dave Cheney authored Oct 07, 2012

before

func addr(s[]int) *int {
        return &s[2]
   10c1c:       e28d0008        add     r0, sp, #8
   10c20:       e5901004        ldr     r1, [r0, #4]
   10c24:       e3a02002        mov     r2, #2
   10c28:       e1510002        cmp     r1, r2
   10c2c:       8a000000        bhi     10c34 <main.addr+0x34>
   10c30:       eb0035e6        bl      1e3d0 <runtime.panicindex>
   10c34:       e5900000        ldr     r0, [r0]
   10c38:       e2800008        add     r0, r0, #8
   10c3c:       e58d0014        str     r0, [sp, #20]
   10c40:       e49df004        pop     {pc}            ; (ldr pc, [sp], #4)

after

func addr(s[]int) *int {
	return &s[2]
   10c1c:       e28d0008        add     r0, sp, #8
   10c20:       e5901004        ldr     r1, [r0, #4]
   10c24:       e3510002        cmp     r1, #2
   10c28:       8a000000        bhi     10c30 <main.addr+0x30>
   10c2c:       eb0035e6        bl      1e3cc <runtime.panicindex>
   10c30:       e5900000        ldr     r0, [r0]
   10c34:       e2800008        add     r0, r0, #8
   10c38:       e58d0014        str     r0, [sp, #20]
   10c3c:       e49df004        pop     {pc}            ; (ldr pc, [sp], #4)

Also, relax gcmp restriction that 2nd operand must be a register. A followup
CL will address the remaining TODO items.

R=rsc, remyoudompheng, minux.ma
CC=golang-dev
https://golang.org/cl/6620064

01ddc8bd

image/jpeg: move the level-shift and clip out of the idct function, · 0b9fe6d2

Nigel Tao authored Oct 07, 2012

to be consistent with the fdct function, and to ease any future
idct rewrites in assembly.

The BenchmarkIDCT delta is obviously just an accounting change and not
a real saving, but it does give an indication of what proportion of
time was spent in the actual IDCT and what proportion was in shift and
clip. The idct time taken is now comparable to fdct.

The BenchmarkFDCT delta is an estimate of benchmark noise.

benchmark                   old ns/op    new ns/op    delta
BenchmarkFDCT                    3842         3837   -0.13%
BenchmarkIDCT                    5611         3478  -38.01%
BenchmarkDecodeRGBOpaque      2932785      2929751   -0.10%

R=r
CC=golang-dev
https://golang.org/cl/6625057

0b9fe6d2

image/jpeg: clean up BenchmarkDecode and BenchmarkEncode to not · f2444f0b

Nigel Tao authored Oct 07, 2012

refer to opacity. Those references were copy/pasted from the
image/png encoding benchmarks, which cares whether or not the
source image is opaque, but the JPEG encoder does not care.

R=r
CC=golang-dev
https://golang.org/cl/6623052

f2444f0b

doc/debugging_with_gdb: fix minor typo (space before comma) · b0c3429a
Robert Hencke authored Oct 07, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6610061
```
b0c3429a

06 Oct, 2012 8 commits

image/jpeg: add DCT tests, do a small optimization (common sub-expression · 12e343f3

Nigel Tao authored Oct 06, 2012

elimination) in idct.go.

benchmark                   old ns/op    new ns/op    delta
BenchmarkIDCT                    5649         5610   -0.69%
BenchmarkDecodeRGBOpaque      2948607      2941051   -0.26%

The "type block" declaration moved so that idct.go is compilable
as a stand-alone file: "go tool 6g -S idct.go" works.

R=r
CC=golang-dev
https://golang.org/cl/6619056

12e343f3

cmd/gc: avoid clobbering the AST in cgen_callmeth. · 0b2ca9e6

Rémy Oudompheng authored Oct 06, 2012

It confused the detection of init loops when involving
method calls.

Fixes #3890.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6620067

0b2ca9e6

cmd/6g: fix out of registers when chaining integer divisions. · 46fcfdaa
Rémy Oudompheng authored Oct 06, 2012
```
Fixes #4201.

R=golang-dev, rsc
CC=golang-dev, remy
https://golang.org/cl/6622055
```
46fcfdaa
cmd/gc: make rnd() more 64-bit-friendly. · 94acfde2
Rémy Oudompheng authored Oct 06, 2012
```
Fixes #4200.

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6619057
```
94acfde2
text/template: fix nil crash on Templates · bcccad40
Rob Pike authored Oct 06, 2012
```
Fixes #3872.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6612060
```
bcccad40

text/template: add an unexported method to Node · 421b75c0

Rob Pike authored Oct 06, 2012

Protects the package a little against undesirable clients.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/6624054

421b75c0

cmd/5g: avoid temporary during constant asop · bbccfddb

Dave Cheney authored Oct 06, 2012

func add() int {
        var a int
        a += 10
        a += 20
        a += 30
        a -= 10
        a -= 20
        a -= 30
        return a
}

before

--- prog list "add" ---
0000 (/home/dfc/src/add.go:5) TEXT      add+0(SB),$0-4
0001 (/home/dfc/src/add.go:6) MOVW      $0,R2
0002 (/home/dfc/src/add.go:7) MOVW      $10,R0
0003 (/home/dfc/src/add.go:7) ADD       R0,R2,R1
0004 (/home/dfc/src/add.go:8) MOVW      $20,R0
0005 (/home/dfc/src/add.go:8) ADD       R0,R1
0006 (/home/dfc/src/add.go:9) MOVW      $30,R0
0007 (/home/dfc/src/add.go:9) ADD       R0,R1
0008 (/home/dfc/src/add.go:10) MOVW     $10,R0
0009 (/home/dfc/src/add.go:10) SUB      R0,R1
0010 (/home/dfc/src/add.go:11) MOVW     $20,R0
0011 (/home/dfc/src/add.go:11) SUB      R0,R1
0012 (/home/dfc/src/add.go:12) MOVW     $30,R0
0013 (/home/dfc/src/add.go:12) SUB      R0,R1,R2
0014 (/home/dfc/src/add.go:12) MOVW     R2,R0
0015 (/home/dfc/src/add.go:13) MOVW     R2,R1
0016 (/home/dfc/src/add.go:13) MOVW     R2,.noname+0(FP)
0017 (/home/dfc/src/add.go:13) RET      ,

after

--- prog list "add" ---
0000 (/home/dfc/src/add.go:5) TEXT      add+0(SB),$0-4
0001 (/home/dfc/src/add.go:6) MOVW      $0,R0
0002 (/home/dfc/src/add.go:7) ADD       $10,R0
0003 (/home/dfc/src/add.go:8) ADD       $20,R0
0004 (/home/dfc/src/add.go:9) ADD       $30,R0
0005 (/home/dfc/src/add.go:10) SUB      $10,R0
0006 (/home/dfc/src/add.go:11) SUB      $20,R0
0007 (/home/dfc/src/add.go:12) SUB      $30,R0,R2
0008 (/home/dfc/src/add.go:13) MOVW     R2,R0
0009 (/home/dfc/src/add.go:13) MOVW     R2,.noname+0(FP)
0010 (/home/dfc/src/add.go:13) RET      ,

R=rsc, minux.ma, remyoudompheng
CC=golang-dev
https://golang.org/cl/6584056

bbccfddb

runtime: fix a panic when growing zero-width-element slices. · 782464ae
Rémy Oudompheng authored Oct 06, 2012
```
Fixes #4197.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6611056
```
782464ae