Commits · 4c129c083bd74dcd3192582551e168cde02e7914 · go / golang

27 Apr, 2014 3 commits

net: Remove an unmatched unlock of ForkLock · 4c129c08

Robert Obryk authored Apr 27, 2014

Remove an RUnlock of syscall.ForkLock with no matching RLock.
Holding ForkLock in netFD.dup is unnecessary: dupCloseOnExecOld
locks and unlocks the lock on its own and dupCloseOnExec doesn't
need the ForkLock to be held.

LGTM=iant
R=golang-codereviews, bradfitz, iant
CC=golang-codereviews
https://golang.org/cl/99800044

4c129c08

encoding/ascii85: handle non-data bytes correctly · 9d7b9fb7

Rui Ueyama authored Apr 27, 2014

Previously Read wouldn't return once its internal input buffer
is filled with non-data bytes.
Fixes #7875.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/90820043

9d7b9fb7

src: fix issues found by go vet std · d4613483

Robert Hencke authored Apr 27, 2014

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/96850043

d4613483

26 Apr, 2014 4 commits

os: cap reads and writes to 2GB on Darwin and FreeBSD · 8409dea8

Brad Fitzpatrick authored Apr 26, 2014

Fixes #7812

LGTM=josharian, iant
R=rsc, iant, adg, ruiu, minux.ma, josharian
CC=golang-codereviews
https://golang.org/cl/89900044

8409dea8

encoding/gob: handle interface types in isZero() by returning true for nil interfaces. · 7faf72bd
Jonathan Allie authored Apr 26, 2014
```
Fixes #7741.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/96830044
```
7faf72bd

doc/debugging_with_gdb.html: add introductory disclaimer · 2674efbd

Rob Pike authored Apr 26, 2014

The instructions in this document are useful but not reliable.
Explain the situation up top.

Fixes #7471.

LGTM=josharian, iant
R=golang-codereviews, josharian, iant
CC=golang-codereviews
https://golang.org/cl/96830045

2674efbd

doc/contribute.html: link to wiki for more code review information · 75ba1818

Robert Hencke authored Apr 26, 2014

(from the discussions on CL 89650044)

LGTM=minux.ma, iant
R=iant, minux.ma
CC=golang-codereviews
https://golang.org/cl/97770043

75ba1818

25 Apr, 2014 4 commits

net/http/httputil: don't leak goroutines in DumpRequestOut · d0402cb4

Brad Fitzpatrick authored Apr 25, 2014

Fixes #7869

LGTM=dsymonds
R=golang-codereviews
CC=adg, dsymonds, golang-codereviews, rsc
https://golang.org/cl/91770048

d0402cb4

net: make WriteMsg{IP,UDP,Unix} return the correct number of bytes transferred · e419ab64
Mikio Hara authored Apr 25, 2014
```
Fixes #7645

LGTM=iant, bradfitz
R=iant, bradfitz
CC=golang-codereviews
https://golang.org/cl/90170046
```
e419ab64

bufio: make all read functions UnreadByte-friendly · 9144d875

Robert Griesemer authored Apr 25, 2014

Fixes #7844.

LGTM=crawshaw
R=golang-codereviews, crawshaw
CC=golang-codereviews
https://golang.org/cl/90620045

9144d875

net/http, strings, bytes: fix http race, revert part of Reader behavior change · 13ea1fd2

Brad Fitzpatrick authored Apr 25, 2014

I fixed this data race regression in two ways: in net/http itself, and also
partially reverting the change from https://golang.org/cl/77580046 .
Previously a Read from a strings.Reader or bytes.Reader returning 0 bytes
would not be a memory write. After 77580046 it was. This reverts that back
in case others depended on that. Also adds tests.

Fixes #7856

LGTM=ruiu, iant
R=iant, ruiu
CC=golang-codereviews, gri
https://golang.org/cl/94740044

13ea1fd2

24 Apr, 2014 1 commit

net: fix confusing typo in comment · f40e574d

Rui Ueyama authored Apr 24, 2014

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/93750043

f40e574d

23 Apr, 2014 2 commits

math/cmpx: change space to tab in the Pow docs for better formatting · 59d7aa32

Rob Pike authored Apr 23, 2014

Godoc makes it look better this way; before, it all ran together into nonsense.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/90400045

59d7aa32

os/exec: deflake a test on Linux · 56005722

Brad Fitzpatrick authored Apr 23, 2014

Work around buggy(?) Linux /proc filesystem.

Fixes #7808

LGTM=iant
R=golang-codereviews, iant
CC=adg, golang-codereviews
https://golang.org/cl/90400044

56005722

22 Apr, 2014 1 commit

strings: fix off-by-one error in test · 7ff8e90e

Rui Ueyama authored Apr 22, 2014

Previously it would panic because of out-of-bound access
if s1 is longer than s2.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/90110043

7ff8e90e

21 Apr, 2014 11 commits

math/big: fix Int.Exp · 2653386c

Robert Griesemer authored Apr 21, 2014

Fixes #7814.

LGTM=agl, adonovan
R=agl, adonovan
CC=golang-codereviews
https://golang.org/cl/90080043

2653386c

net: extend TestVariousDeadlines1Proc timeout · 9cddb60d

Josh Bleecher Snyder authored Apr 21, 2014

TestVariousDeadlines1Proc was flaky on my system,
failing on about 5% of runs.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/89830045

9cddb60d

runtime: fix typo in error message · 800d8adf

Mark Zavislak authored Apr 21, 2014

LGTM=robert.hencke, iant
R=golang-codereviews, robert.hencke, iant
CC=golang-codereviews
https://golang.org/cl/89760043

800d8adf

runtime/race: add test for issue 7561. · 1332eb5b
Rémy Oudompheng authored Apr 21, 2014
```
LGTM=dvyukov
R=rsc, iant, khr, dvyukov
CC=golang-codereviews
https://golang.org/cl/76520045
```
1332eb5b
cmd/nm: do not fail TestNM if symbol has less then 3 columns in nm output · 296eeaa7
Alex Brainman authored Apr 21, 2014
```
Fixes #7829

LGTM=dave
R=golang-codereviews, aram, dave
CC=golang-codereviews
https://golang.org/cl/89830043
```
296eeaa7

cmd/nm: disable TestNM on darwin, linux and solaris · 6a40d549

Alex Brainman authored Apr 21, 2014

Update #7829

LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/89810043

6a40d549

cmd/ld: correct addresses in windows pe symbol table · 80e7f972

Alex Brainman authored Apr 21, 2014

This should have been part of 36eb4a62fbb6,
but I later discovered that addresses are all wrong.
Appropriate test added now.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/89470043

80e7f972

runtime, go/build: re-enable cgo on FreeBSD. · 1bb4f37f

Shenghou Ma authored Apr 21, 2014

Fixes #7331.

LGTM=dave, iant
R=golang-codereviews, dave, gobot, iant
CC=golang-codereviews
https://golang.org/cl/89150043

1bb4f37f

runtime, cmd/ld, cmd/5l, run.bash: enable external linking on FreeBSD/ARM. · d31d1976
Shenghou Ma authored Apr 21, 2014
```
Update #7331

LGTM=dave, iant
R=golang-codereviews, dave, gobot, iant
CC=golang-codereviews
https://golang.org/cl/89520043
```
d31d1976

lib9: restore argv0 initialization code. · 9ba153e3

Shenghou Ma authored Apr 21, 2014

`GOARCH=arm go tool 6c` used to give "<prog>: cannot use 6c with GOARCH=arm"

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/89330043

9ba153e3

cmd/go: handle -ccflags in 'go test' · 0a8f5177

Shenghou Ma authored Apr 21, 2014

CL 89050043 only allows -ccflags for 'go test', this
CL really handles the flag like the other -??flags.
Many thanks to Dobrosław Żybort for pointing this out.
Fixes #7810 (again).

LGTM=iant, matrixik
R=golang-codereviews, iant, matrixik
CC=golang-codereviews
https://golang.org/cl/89230044

0a8f5177

20 Apr, 2014 2 commits

doc/go1.3.html: fix Goexit link · f1876750
David du Colombier authored Apr 20, 2014
```
LGTM=minux.ma
R=r, minux.ma
CC=golang-codereviews
https://golang.org/cl/89710043
```
f1876750

cmd/gc: avoid %L in error message · 943dc2cb

Jan Ziak authored Apr 20, 2014

Fixes #7783

LGTM=minux.ma
R=rsc, minux.ma
CC=golang-codereviews
https://golang.org/cl/89290043

943dc2cb

19 Apr, 2014 2 commits

include/plan9: make mklibc.rc compatible with 9atom · 09aeca5c

David du Colombier authored Apr 19, 2014

Since there is no Runemask constant in UTF-8 enum in
9atom, removing the other constants leads to an empty
enum, which is illegal. Thus, we remove enum entirely.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/82660044

09aeca5c

cmd/nm: print symbol sizes for windows pe executables · 6e8c7f5b
Alex Brainman authored Apr 19, 2014
```
Fixes #6973

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/88820043
```
6e8c7f5b

18 Apr, 2014 7 commits

cmd/ld: don't delete output binary if not "ordinary" file (redux). · 7c7aaa41

Mike Andrews authored Apr 18, 2014

following on CL https://golang.org/cl/76810045 and
issue 7563, i now see there's another "remove(outfile)" a few
dozen lines down that also needs fixing.

LGTM=iant
R=golang-codereviews, iant
CC=0intro, golang-codereviews, r
https://golang.org/cl/89030043

7c7aaa41

doc/go1.3.html: Plan 9 support · 75b74ea8

David du Colombier authored Apr 18, 2014

LGTM=aram, r
R=r, aram, bradfitz
CC=golang-codereviews, rsc
https://golang.org/cl/89130045

75b74ea8

doc/go1.3.html: go test always builds · 0d612a85

Rob Pike authored Apr 18, 2014

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/89370043

0d612a85

pkg/reflect/value.go: Correction in comment, the argument is "typ", not "t". · cd4c1f18
Lucio De Re authored Apr 18, 2014
```
LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/89270043
```
cd4c1f18
doc/go1.3.html: new package debug/plan9obj · ba593757
David du Colombier authored Apr 18, 2014
```
LGTM=r
R=r
CC=golang-codereviews, rsc
https://golang.org/cl/86180046
```
ba593757

os: change return variable name for Getwd to avoid confusion · 4b9ab7dd

Shenghou Ma authored Apr 18, 2014

changed (pwd string) to (dir string), as some think pwd means passwd.
Fixes #7811.

LGTM=iant
R=golang-codereviews, iant, bradfitz
CC=golang-codereviews
https://golang.org/cl/89100043

4b9ab7dd

cmd/go: support -ccflags in 'go test' · c7d864c4

Shenghou Ma authored Apr 18, 2014

Fixes #7810.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/89050043

c7d864c4

17 Apr, 2014 3 commits

net/http/httputil: include Content-Length in DumpResponse output · 8f766412
Brad Fitzpatrick authored Apr 17, 2014
```
Fixes #5357

LGTM=nigeltao
R=nigeltao
CC=golang-codereviews
https://golang.org/cl/87910050
```
8f766412

net: fix probabilities in DNS SRV shuffleByWeight · c45392ba

Brad Fitzpatrick authored Apr 17, 2014

Patch from msolo. Just moving it to a CL.
The test fails before and passes with the fix.

Fixes #7098

LGTM=msolo, rsc
R=rsc, iant, msolo
CC=golang-codereviews
https://golang.org/cl/88900044

c45392ba

cmd/pack: avoid ./ import in test (fix Windows build) · 576318c7

Russ Cox authored Apr 17, 2014

It is possible to use ./ imports on Windows but it
requires some extra command-line work
('go build' does this automatically, but we can't use 'go build' here).

Instead, use an ordinary import and -I/-L, which are easier to use.

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/89040043

576318c7