Skip to content

G
golang
Switch branch/tag
  1. 26 Sep, 2011 14 commits
  3. 25 Sep, 2011 2 commits
  5. 24 Sep, 2011 2 commits
  7. 23 Sep, 2011 9 commits
  9. 22 Sep, 2011 8 commits
    • Paul Sbarra's avatar
      vim: Send GoFmt errors to a location list · 3dc3fa0d
      Paul Sbarra authored 
      R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5043046
      3dc3fa0d
    • Andrew Gerrand's avatar
      doc: link to image blog post · 76d82dbc
      Andrew Gerrand authored 
      R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5086048
      76d82dbc
    • Andrew Gerrand's avatar
      tag weekly.2011-09-21 · 5c1f2bcf
      Andrew Gerrand authored 
      R=dsymonds
CC=golang-dev
https://golang.org/cl/5086049
      5c1f2bcf
    • Andrew Gerrand's avatar
      weekly.2011-09-21 · e4ac43b7
      Andrew Gerrand authored 
      R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5075050
      e4ac43b7
    • Mike Samuel's avatar
      exp/template/html: elide comments in template source. · 35819729
      Mike Samuel authored 
      When templates are stored in external files, developers often embed
comments to explain&|disable code.

  <!-- Oblique reference to project code name here -->
  {{if .C}}...{{else}}<!-- commented out default -->{{end}}

This unnecessarily increases the size of shipped HTML and can leak
information.

This change elides all comments of the following types:
1. <!-- ... --> comments found in source.
2. /*...*/ and // comments found in <script> elements.
3. /*...*/ and // comments found in <style> elements.

It does not elide /*...*/ or // comments found in HTML attributes:
4. <button onclick="/*...*/">
5. <div style="/*...*/">

I can find no examples of comments in attributes in Closure Templates
code and doing so would require keeping track of character positions
post decode in

  <button onclick="/&#42;...*/">

To prevent token joining, /*comments*/ are JS and CSS comments are
replaced with a whitespace char.
HTML comments are not, but to prevent token joining we could try to
detect cases like
   <<!---->b>
   </<!---->b>
which has a well defined meaning in HTML but will cause a validator
to barf.  This is difficult, and this is a very minor case.
I have punted for now, but if we need to address this case, the best
way would be to normalize '<' in stateText to '&lt;' consistently.

The whitespace to replace a JS /*comment*/ with depends on whether
there is an embedded line terminator since
    break/*
    */foo
    ...
is equivalent to
    break;
    foo
    ...
while
    break/**/foo
    ...
is equivalent to
    break foo;
    ...

Comment eliding can interfere with IE conditional comments.
http://en.wikipedia.org/wiki/Conditional_comment

<!--[if IE 6]>
<p>You are using Internet Explorer 6.</p>
<![endif]-->

/*@cc_on
  document.write("You are using IE4 or higher");
@*/

I have not encountered these in production template code, and
the typed content change in CL 4962067 provides an escape-hatch
if conditional comments are needed.

R=nigeltao
CC=golang-dev
https://golang.org/cl/4999042
      35819729
    • David Symonds's avatar
      A&C: Add Paul Sbarra. · 7eab0c2b
      David Symonds authored 
      R=golang-dev, adg
CC=golang-dev, sbarra.paul
https://golang.org/cl/5044045
      7eab0c2b
    • Mike Samuel's avatar
      exp/template/html: simplify transition functions · 1f577d26
      Mike Samuel authored 
      This simplifies transition functions to make it easier to reliably
elide comments in a later CL.

Before:
- transition functions are responsible for detecting special end tags.
After:
- the code to detect special end tags is done in one place.

We were relying on end tags being skipped which meant we were
not noticing comments inside script/style elements that contain no
substitutions.
This change means we will notice all such comments where necessary,
but stripTags will notice none since it does not need to.  This speeds
up stripTags.

R=nigeltao
CC=golang-dev
https://golang.org/cl/5074041
      1f577d26
    • Ian Lance Taylor's avatar
      test: match gccgo error messages · 9169c27e
      Ian Lance Taylor authored 
      bug363.go:13:12: error: invalid context-determined non-integer type for shift operand
bug363.go:16:12: error: invalid context-determined non-integer type for shift operand

pointer.go:34:6: error: incompatible type in initialization (pointer to interface type has no methods)
pointer.go:36:6: error: incompatible type in initialization

method2.go:15:1: error: invalid pointer or interface receiver type
method2.go:16:1: error: invalid pointer or interface receiver type
method2.go:21:1: error: invalid pointer or interface receiver type
method2.go:22:1: error: invalid pointer or interface receiver type
method2.go:28:15: error: type ‘*Val’ has no method ‘val’
method2.go:33:11: error: reference to undefined field or method ‘val’

shift1.go:19:16: error: invalid context-determined non-integer type for shift operand
shift1.go:24:19: error: invalid context-determined non-integer type for shift operand
shift1.go:25:17: error: invalid context-determined non-integer type for shift operand
shift1.go:18:18: error: shift of non-integer operand
shift1.go:26:13: error: floating point constant truncated to integer
shift1.go:33:15: error: integer constant overflow
shift1.go:34:15: error: integer constant overflow
shift1.go:35:17: error: integer constant overflow

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5081051
      9169c27e
  11. 21 Sep, 2011 5 commits