Commits · 4fb89c9d6a686780037ad9e49998fe8e46402b80 · go / golang

08 Oct, 2012 13 commits

godoc: support Playground examples on App Engine · 4fb89c9d

Andrew Gerrand authored Oct 08, 2012

Updates setup-godoc-app.bash to produce a working godoc app
by substituting the go1.0.x go/... packages with those from tip.

R=gri
CC=golang-dev
https://golang.org/cl/6587080

4fb89c9d

testing: change -test.benchtime to a flag.Duration. · f8b58381
David Symonds authored Oct 08, 2012
```
Fixes #3902.

R=golang-dev, minux.ma, rsc, r
CC=golang-dev
https://golang.org/cl/6611059
```
f8b58381
encoding/base{32,64}: add examples. · 05e4e805
David Symonds authored Oct 08, 2012
```
Fixes #4136.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6615061
```
05e4e805
net/url: report first error from ParseQuery. · c7cc894e
David Symonds authored Oct 08, 2012
```
Fixes #4175.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6610068
```
c7cc894e

test: Make run.go's errorcheck behave like testlib. · c81293ad

Daniel Morsing authored Oct 08, 2012

testlib will complain about any unmatched errors left in errorchecks while run.go will not.

Fixes #4141.

R=golang-dev, minux.ma, remyoudompheng, rsc
CC=golang-dev
https://golang.org/cl/6614060

c81293ad

doc: update text about hgrc and environment variables. · 156d85c3

David Symonds authored Oct 08, 2012

Mercurial has supported environment variables in hgrc files since
version 1.4 (released November 2009).

R=golang-dev, dave, minux.ma
CC=golang-dev
https://golang.org/cl/6619067

156d85c3

fix build: use temporary variable to avoid compiler error · d5b570cd
Robert Griesemer authored Oct 08, 2012
```
R=r
CC=golang-dev
https://golang.org/cl/6612066
```
d5b570cd

exp/types/staging: more flexible API, cleanups · 0d947420

Robert Griesemer authored Oct 08, 2012

- Changed Check signature to take function parameters for
  more flexibility: Now a client can interrupt type checking
  early (via panic in one the upcalls) once the desired
  type information or number of errors is reached. Default
  use is still simple.

- Cleaned up main typechecking loops. Now does not neglect
  _ declarations anymore.

- Various other cleanups.

R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/6612049

0d947420

/exp/types/staging: expression and statement type checking · 52248750

Robert Griesemer authored Oct 08, 2012

Still lots of pieces missing, but basic framework working.
Lots of tests.

R=rsc
CC=golang-dev
https://golang.org/cl/6594054

52248750

exp/types/staging: test drivers · 328f0e7f

Robert Griesemer authored Oct 08, 2012

This code has been reviewed before. The most significant
change is to check_test which now can handle more than
one error at the same error position (due to spurious
errors - should not happen in praxis once error handling
has been fine-tuned). This change makes check_test easier
to use during development.

R=rsc
CC=golang-dev
https://golang.org/cl/6584057

328f0e7f

exp/locale/collate: use gofmt -w -s (rather than just gofmt -w) · 7f710c2d
Robert Griesemer authored Oct 08, 2012
```
Also: apply gofmt -w -s to existing tables.

R=mpvl, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6611051
```
7f710c2d

go/parser: fix object kind · 05fc42ab

Robert Griesemer authored Oct 08, 2012

Bug introduced with CL 6624047.

R=r
CC=golang-dev
https://golang.org/cl/6620073

05fc42ab

gophertool: make work with latest Chrome extension security restrictions · 9e811683
Brad Fitzpatrick authored Oct 08, 2012
```
No JavaScript in HTML anymore.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6619066
```
9e811683

07 Oct, 2012 27 commits

godoc: fetch jQuery via https · 236e79ca
Andrew Gerrand authored Oct 07, 2012
```
R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/6614064
```
236e79ca

cmd/5g: avoid temporaries during gcmp(reg, constant) · 905e8dfa

Dave Cheney authored Oct 07, 2012

Address several instances of unneeded temporaries when using gcmp.

func M(m map[int]bool) int {
        return len(m)
}

--- prog list "M" ---
0000 (/home/dfc/src/map.go:3) TEXT      M+0(SB),$0-8
0001 (/home/dfc/src/map.go:4) MOVW      m+0(FP),R0
0002 (/home/dfc/src/map.go:4) MOVW      $0,R1
0003 (/home/dfc/src/map.go:4) CMP       R1,R0,
0004 (/home/dfc/src/map.go:4) BEQ       ,6(APC)
0005 (/home/dfc/src/map.go:4) MOVW      0(R0),R0
0006 (/home/dfc/src/map.go:4) MOVW      R0,.noname+4(FP)
0007 (/home/dfc/src/map.go:4) RET       ,

after:

--- prog list "M" ---
0000 (/home/dfc/src/map.go:3) TEXT      M+0(SB),$0-8
0001 (/home/dfc/src/map.go:4) MOVW      m+0(FP),R0
0002 (/home/dfc/src/map.go:4) CMP       $0,R0,
0003 (/home/dfc/src/map.go:4) BEQ       ,5(APC)
0004 (/home/dfc/src/map.go:4) MOVW      0(R0),R0
0005 (/home/dfc/src/map.go:4) MOVW      R0,.noname+4(FP)
0006 (/home/dfc/src/map.go:4) RET       ,

func C(c chan int) int {
        return cap(c)
}

--- prog list "C" ---
0000 (/home/dfc/src/map.go:3) TEXT      C+0(SB),$0-8
0001 (/home/dfc/src/map.go:4) MOVW      c+0(FP),R0
0002 (/home/dfc/src/map.go:4) MOVW      $0,R1
0003 (/home/dfc/src/map.go:4) CMP       R1,R0,
0004 (/home/dfc/src/map.go:4) BEQ       ,6(APC)
0005 (/home/dfc/src/map.go:4) MOVW      4(R0),R0
0006 (/home/dfc/src/map.go:4) MOVW      R0,.noname+4(FP)
0007 (/home/dfc/src/map.go:4) RET       ,

after:

--- prog list "C" ---
0000 (/home/dfc/src/map.go:3) TEXT      C+0(SB),$0-8
0001 (/home/dfc/src/map.go:4) MOVW      c+0(FP),R0
0002 (/home/dfc/src/map.go:4) CMP       $0,R0,
0003 (/home/dfc/src/map.go:4) BEQ       ,5(APC)
0004 (/home/dfc/src/map.go:4) MOVW      4(R0),R0
0005 (/home/dfc/src/map.go:4) MOVW      R0,.noname+4(FP)
0006 (/home/dfc/src/map.go:4) RET       ,

R=rsc, minux.ma, remyoudompheng
CC=golang-dev
https://golang.org/cl/6618054

905e8dfa

test: convert more tests to rundir/compiledir conventions · 46bce2ac
Rémy Oudompheng authored Oct 07, 2012
```
Update #4139.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6609051
```
46bce2ac
test/testlib: don't forget stderr for rundircmpout. · 5497787d
Rémy Oudompheng authored Oct 07, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6620071
```
5497787d
cmd/8a: add SSE2 instructions · 5da37c09
Russ Cox authored Oct 07, 2012
```
R=ken
CC=golang-dev
https://golang.org/cl/6614063
```
5da37c09
cmd/8l: add SSE2 instructions · c1d06cef
Russ Cox authored Oct 07, 2012
```
R=ken
CC=golang-dev
https://golang.org/cl/6610065
```
c1d06cef

cmd/gc: skip over reported BOMs · d749783f

Russ Cox authored Oct 07, 2012

This keeps the BOM runes from causing other errors.

R=golang-dev, remyoudompheng
CC=golang-dev
https://golang.org/cl/6625062

d749783f

cmd/ld, cmd/5l: support R_ARM_PC24 and R_ARM_JUMP24, fix R_ARM_CALL · 65b782e9

Shenghou Ma authored Oct 07, 2012

1. R_ARM_CALL can also be used to call a PLT entry
2. add support for R_ARM_PC24 and R_ARM_JUMP24
3. refactor, remove D_PLT32 in favor of D_CALL

Fixes #4006.

R=rsc, dave
CC=fullung, golang-dev
https://golang.org/cl/6622057

65b782e9

codereview: more mercurial interface fixes · eca37e1e

Shenghou Ma authored Oct 07, 2012

        Fixes #4131.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6614061

eca37e1e

test: correct type in declbad.go · 9844e4cd

Rémy Oudompheng authored Oct 07, 2012

The test is not about type mismatches and it causes
an extra error to appear.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6614062

9844e4cd

test/bench/shootout: match gcc architecture to GOARCH · c4c4b3b4

Russ Cox authored Oct 07, 2012

If we're benchmarking 8g, use gcc -m32.
If we're benchmarking 6g, use gcc -m64.

R=golang-dev, bradfitz, minux.ma, remyoudompheng
CC=golang-dev
https://golang.org/cl/6625061

c4c4b3b4

cmd/gc: more graceful handling of invalid fields in widstruct. · caff4398

Rémy Oudompheng authored Oct 07, 2012

The protection against segfaults does not completely solve
crashes and breaks test/fixedbugs/bug365.go

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6615058

caff4398

cmd/gc: avoid crash in %N print · 54191126
Russ Cox authored Oct 07, 2012
```
R=ken2
CC=golang-dev
https://golang.org/cl/6609052
```
54191126

io/ioutil: fix data race under the race detector · 373dbcb3

Dmitriy Vyukov authored Oct 07, 2012

See issue 3970 (it's already marked as Fixed).

R=rsc, minux.ma
CC=golang-dev
https://golang.org/cl/6624059

373dbcb3

race: sync/atomic changes · 59b87453

Dmitriy Vyukov authored Oct 07, 2012

This is a part of a bigger change that adds data race detection feature:
https://golang.org/cl/6456044

R=rsc, remyoudompheng
CC=gobot, golang-dev
https://golang.org/cl/6536059

59b87453

race: sync changes · 53390c8f

Dmitriy Vyukov authored Oct 07, 2012

This is a part of a bigger change that adds data race detection feature:
https://golang.org/cl/6456044

R=rsc, minux.ma
CC=gobot, golang-dev
https://golang.org/cl/6529053

53390c8f

race: runtime changes · 2f6cbc74

Dmitriy Vyukov authored Oct 07, 2012

This is a part of a bigger change that adds data race detection feature:
https://golang.org/cl/6456044

R=rsc
CC=gobot, golang-dev
https://golang.org/cl/6535050

2f6cbc74

runtime: disable TestParForParallel for now on 32-bit hosts · f82c59b6

Shenghou Ma authored Oct 07, 2012

Also add call to GC() to make it easier to re-enable the test.

Update #4155.
When we have precise GC merged, re-enable this test.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6622058

f82c59b6

test/run.go: use correct executable filename on Windows, fix build · e8246569
Shenghou Ma authored Oct 07, 2012
```
R=golang-dev, daniel.morsing
CC=golang-dev
https://golang.org/cl/6624060
```
e8246569

os: make TestMkdirAllWithSymlink more robust · 54c109b1

Brad Fitzpatrick authored Oct 07, 2012

Don't assume the test has a clean environment within /tmp.
Use an actual new tempdir for its tests.

Fixes FreeBSD build failure as seen at:
http://build.golang.org/log/396738676356d7fb6bab6eaf1b97cac820f8a90f

--- FAIL: TestMkdirAllWithSymlink (0.00 seconds)
path_test.go:178:                 Mkdir /tmp/dir: mkdir /tmp/dir: file exists
FAIL
FAIL    os      1.091s

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/6615057

54c109b1

net/http/httptest: mimic the normal HTTP server's ResponseWriter more closely · 13576e3b
Brad Fitzpatrick authored Oct 07, 2012
```
Also adds tests, which didn't exist before.

Fixes #4188

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6613062
```
13576e3b
test: use rundir and errorcheckdir for a few more tests. · d9953c9d
Rémy Oudompheng authored Oct 07, 2012
```
Update #4139.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/6620070
```
d9953c9d

testing: fix extra tabs when t.Log("string") · 51310d83

Shenghou Ma authored Oct 07, 2012

t.Log("line 1\nline 2\nline 3")

Old output:
=== RUN TestLine3
--- PASS: TestLine3 (0.00 seconds)
testing_test.go:25: 	line 1
		line 2
		line 3
		PASS

New output:
=== RUN TestLine3
--- PASS: TestLine3 (0.00 seconds)
testing_test.go:24: 	line 1
		line 2
		line 3
PASS

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6613069

51310d83

syscall: fix Statfs and Fstatfs on Linux/ARM · f8485954
Shenghou Ma authored Oct 07, 2012
```
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6615055
```
f8485954

cmd/gc: replace "typechecking loop" by nicer errors in some cases. · 892fa3ae

Rémy Oudompheng authored Oct 07, 2012

For issue 3757:
BEFORE:  test/fixedbugs/bug463.go:12: typechecking loop involving a
             test/fixedbugs/bug463.go:12 a
             test/fixedbugs/bug463.go:12 <node DCLCONST>
AFTER:   test/fixedbugs/bug463.go:12: constant definition loop
             test/fixedbugs/bug463.go:12: a uses a

For issue 3937:
BEFORE: test/fixedbugs/bug464.go:12: typechecking loop involving foo
            test/fixedbugs/bug464.go:12 <T>
            test/fixedbugs/bug464.go:12 foo
            test/fixedbugs/bug464.go:12 <node DCLFUNC>
AFTER:  test/fixedbugs/bug464.go:12: foo is not a type

Fixes #3757.
Fixes #3937.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6614058

892fa3ae

cmd/gc: Don't accept qualified names as literal keys · 87c35d8d
Daniel Morsing authored Oct 07, 2012
```
Fixes #4067.

R=golang-dev, minux.ma, dave, rsc
CC=golang-dev
https://golang.org/cl/6622056
```
87c35d8d

image/jpeg: move the huffman bit decoder state higher up in the · d7b7957d

Nigel Tao authored Oct 07, 2012

decoder struct, inside the unmappedzero limit, to eliminate some
TESTB instructions in the inner decoding loop.

benchmark          old ns/op    new ns/op    delta
BenchmarkDecode      2943204      2746360   -6.69%

R=r, dave
CC=golang-dev
https://golang.org/cl/6625058

d7b7957d