- 01 Sep, 2014 14 commits
-
-
Russ Cox authored
The exported Go definitions appearing in mprof.go are copied verbatim from debug.go. The unexported Go funcs and types are new. The C Bucket type used a union and was not a line-for-line translation. LGTM=remyoudompheng R=golang-codereviews, remyoudompheng CC=dvyukov, golang-codereviews, iant, khr, r https://golang.org/cl/137040043
-
Russ Cox authored
#ifdef'ed out code wasn't updated for argp change. TBR=iant CC=golang-codereviews https://golang.org/cl/139040043
-
Russ Cox authored
It was a throw originally; it was converted incorrectly. LGTM=dave R=khr, dave CC=golang-codereviews https://golang.org/cl/139000043
-
Russ Cox authored
Adding the #include to defs.c makes it get processed by cmd/dist, which writes out Go equivalent for all the C data structures defined in defs.c. This in turn makes it necessary to define the Plink type, used in os_plan9.h, in os_plan9.go. Rename it to _Plink to avoid being exported. LGTM=0intro, iant R=golang-codereviews, iant, 0intro CC=golang-codereviews, r https://golang.org/cl/132490043
-
Russ Cox authored
uintptr is better when translating to Go, and in a few places it's better in C too. LGTM=r R=golang-codereviews, r CC=golang-codereviews, iant, khr https://golang.org/cl/138980043
-
Dmitriy Vyukov authored
This change fixes the last known false negative of the race detector -- detection of races between mutating atomic operations and non-atomic operations. Race runtime already has functions for precise modelling of various atomic operations, so this change just forwards all atomic ops to race runtime instead of poor man modeling in sync/atomic package. Performance is also improved -- full sync/atomic tests run in 60s instead of 85s now. LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, rsc https://golang.org/cl/111310044
-
Rui Ueyama authored
benchmark old ns/op new ns/op delta BenchmarkSingleMatch 49443 52275 +5.73% BenchmarkIndex 28.8 27.4 -4.86% BenchmarkLastIndex 14.5 14.0 -3.45% BenchmarkLastIndexHard1 3982782 2309200 -42.02% BenchmarkLastIndexHard2 3985562 2287715 -42.60% BenchmarkLastIndexHard3 3555259 2282866 -35.79% LGTM=josharian, nigeltao R=golang-codereviews, ality, josharian, bradfitz, dave, nigeltao, gobot, nightlyone CC=golang-codereviews https://golang.org/cl/102560043
-
Russ Cox authored
These haven't been run in ages. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews, iant, khr, r https://golang.org/cl/134170043
-
Brad Fitzpatrick authored
This is needed for callers to be able to keep track of the writing position within a zip file. Otherwise it's not possible to compute the size of headers, and the TOC isn't written until the very end. LGTM=adg R=adg CC=golang-codereviews https://golang.org/cl/134210043
-
Russ Cox authored
NO CODE CHANGES HERE The first conversion was not complete. This CL doesn't make any actual changes, but it inserts the missing mprof.goc code as comments so that the next CL will have useful diffs. To make the diffs a bit more useful, removed all semicolons, ->, and runtime· prefixes as well. Also corrected order of a few functions in mprof.go to match original order in mprof.goc. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews, iant, khr, r https://golang.org/cl/134200043
-
Ian Lance Taylor authored
The [568]c compilers no longer support packed structs, so using them with -cdefs no longer works. Just commenting out the test, rather than removing it, in case this needs to be handled. It may be that -cdefs can go away entirely in the future, in which case so can this directory. LGTM=mdempsky R=rsc, mdempsky CC=golang-codereviews https://golang.org/cl/136030043
-
Russ Cox authored
For example: go build -ldflags -C cmd/go 2>&1 | awk '{print $NF}' | sort | uniq -c | sort -nr LGTM=khr R=khr, josharian CC=golang-codereviews https://golang.org/cl/135170044
-
Dmitri Shuralyov authored
LGTM=adg R=golang-codereviews, adg CC=golang-codereviews https://golang.org/cl/138960043
-
Nigel Tao authored
positive numbers to mean a numeric zlib compression level. LGTM=bradfitz, ruiu R=bradfitz, ruiu CC=golang-codereviews, jeff.allen https://golang.org/cl/138860043
-
- 31 Aug, 2014 1 commit
-
-
Ian Lance Taylor authored
Make the definition of the EpollEvent data field consistent across architectures, adapt the other use of it in netpoll_epoll for the new definition, and use uint64 rather than uintptr. LGTM=dave R=rsc, dave CC=golang-codereviews https://golang.org/cl/137890043
-
- 30 Aug, 2014 16 commits
-
-
Russ Cox authored
We can't translate misaligned things to Go, so start rejecting them in C. The only one in any build appears to be EpollEvent on linux/amd64. Fix that. LGTM=r R=golang-codereviews, r, dvyukov CC=golang-codereviews, iant https://golang.org/cl/137020043
-
Russ Cox authored
In an earlier CL I wrote a separate Go-only version, but that broke Plan 9, because the Go-only version assumed a non-Plan 9 system. Translate the real ones instead. LGTM=r R=golang-codereviews, r CC=0intro, golang-codereviews, iant, khr https://golang.org/cl/140050044
-
Dmitriy Vyukov authored
Under the race detector most of the samples go into race runtime, because of that freebsd race builder constantly fails on this test. LGTM=bradfitz, rsc R=golang-codereviews, bradfitz, rsc CC=golang-codereviews, minux https://golang.org/cl/133370043
-
Russ Cox authored
This avoids allocating at the panic sites. LGTM=r, khr R=golang-codereviews, r, khr CC=dvyukov, golang-codereviews, iant, khr https://golang.org/cl/136020043
-
Keith Randall authored
LGTM=rsc, dvyukov R=golang-codereviews, bradfitz, rsc, dvyukov CC=golang-codereviews https://golang.org/cl/136980044
-
Evan Kroske authored
See RFC 3986 §3.2.1. Fixes #6573. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/126560043
-
Evan Kroske authored
Fixes script used to sanity-check the heading-detection heuristic of go/doc. Fixes #8467. LGTM=gri R=golang-codereviews, gobot, gri CC=golang-codereviews https://golang.org/cl/128720043
-
Robin Eklind authored
LGTM=gri R=golang-codereviews, bradfitz, gri CC=golang-codereviews https://golang.org/cl/133330043
-
Matthew Dempsky authored
Tested on linux/amd64 too this time. LGTM=bradfitz R=golang-codereviews, bradfitz CC=dave, golang-codereviews, iant, rsc https://golang.org/cl/140050043
-
Kelsey Hightower authored
The net/http package supports setting the HTTP Authorization header using the Basic Authentication Scheme as defined in RFC 2617, but does not provide support for extracting the username and password from an authenticated request using the Basic Authentication Scheme. Add BasicAuth method to *http.Request that returns the username and password from authenticated requests using the Basic Authentication Scheme. Fixes #6779. LGTM=bradfitz R=golang-codereviews, josharian, bradfitz, alberto.garcia.hierro, blakesgentry CC=golang-codereviews https://golang.org/cl/76540043
-
Russ Cox authored
In CL 131450043, which raised it to 160, I'd raise it to 192 if necessary. Apparently it is necessary on windows/amd64. One note for those concerned about the growth: in the old segmented stack world, we wasted this much space at the bottom of every stack segment. In the new contiguous stack world, each goroutine has only one stack segment, so we only waste this much space once per goroutine. So even raising the limit further might still be a net savings. Fixes windows/amd64 build. TBR=r CC=golang-codereviews https://golang.org/cl/132480043
-
Russ Cox authored
Renaming the C SysAlloc will let Go define a prototype without exporting it. For use in cpuprof.goc's translation to Go. LGTM=mdempsky R=golang-codereviews, mdempsky CC=golang-codereviews, iant https://golang.org/cl/140060043
-
Dmitriy Vyukov authored
Actually it mostly deletes code -- alg.print and alg.copy go away. There was only one usage of alg.print for debug purposes. Alg.copy is used in chan.goc, but Keith replaces them with memcopy during conversion, so alg.copy is not needed as well. Converting them would be significant amount of work for no visible benefit. LGTM=crawshaw, rsc, khr R=golang-codereviews, crawshaw, khr CC=golang-codereviews, rsc https://golang.org/cl/139930044
-
Russ Cox authored
broke api check everywhere ««« original CL description runtime: fix openbsd build LGTM=iant R=iant, minux CC=golang-codereviews, jsing https://golang.org/cl/135230043 »»» TBR=mdempsky CC=golang-codereviews https://golang.org/cl/137010043
-
Alex A Skinner authored
Speed improvements via code cleanup, and changes to make go dns behave more like glibc resolver. See https://groups.google.com/forum/#!topic/golang-dev/lV-0aHqxVeo Fixes #6579. Benchmark results on linux/amd64 benchmark old ns/op new ns/op delta BenchmarkGoLookupIP 4831903 2572937 -46.75% BenchmarkGoLookupIPNoSuchHost 10114105 2419641 -76.08% BenchmarkGoLookupIPWithBrokenNameServer 20007735624 5004490730 -74.99% benchmark old allocs new allocs delta BenchmarkGoLookupIP 287 288 0.35% BenchmarkGoLookupIPNoSuchHost 204 102 -50.00% BenchmarkGoLookupIPWithBrokenNameServer 410 358 -12.68% benchmark old bytes new bytes delta BenchmarkGoLookupIP 13181 13271 0.68% BenchmarkGoLookupIPNoSuchHost 17260 8714 -49.51% BenchmarkGoLookupIPWithBrokenNameServer 28160 22432 -20.34% LGTM=mikioh.mikioh R=golang-codereviews, mikioh.mikioh, bradfitz, josharian, abursavich CC=golang-codereviews https://golang.org/cl/128820043
-
Matthew Dempsky authored
LGTM=iant R=iant, minux CC=golang-codereviews, jsing https://golang.org/cl/135230043
-
- 29 Aug, 2014 9 commits
-
-
Ian Lance Taylor authored
Avoids a conflict between the type and function sigaltstack. LGTM=crawshaw R=rsc, crawshaw CC=golang-codereviews https://golang.org/cl/138920043
-
Mikio Hara authored
preparing for the syscall package freeze. the change for issue 8218 is only applied to go.sys/unix. ««« original CL description syscall: implement setresuid(2) and setresgid(2) on OpenBSD/FreeBSD/DragonflyBSD Fixes #8218. LGTM=iant R=golang-codereviews, iant, minux CC=golang-codereviews https://golang.org/cl/107150043 »»» LGTM=r R=r, iant, golang-codereviews CC=golang-codereviews https://golang.org/cl/138840044
-
Alex A Skinner authored
Prevents non-rooted queries with > ndots dots from being tried twice on error. Fixes #8616. Benchmark results on linux/amd64 benchmark old ns/op new ns/op delta BenchmarkGoLookupIPNoSuchHost 8212394 4413293 -46.26% benchmark old allocs new allocs delta BenchmarkGoLookupIPNoSuchHost 216 108 -50.00% benchmark old bytes new bytes delta BenchmarkGoLookupIPNoSuchHost 17460 8726 -50.02% LGTM=iant, mikioh.mikioh R=golang-codereviews, iant, mikioh.mikioh CC=golang-codereviews https://golang.org/cl/137870043
-
Russ Cox authored
It is anyway, just an allocated one. Giving it a sized type makes Go access nicer. LGTM=iant R=dvyukov, iant CC=golang-codereviews https://golang.org/cl/139960043
-
Russ Cox authored
LGTM=r, iant R=golang-codereviews, r, iant CC=dvyukov, golang-codereviews, khr https://golang.org/cl/139930043
-
Russ Cox authored
I had to rename Kevent and Sigaction to avoid the functions of the same (lowercase) name. LGTM=iant, r R=golang-codereviews, r, iant, aram.h CC=dvyukov, golang-codereviews, khr https://golang.org/cl/140740043
-
Adam Langley authored
Signer is an interface to support opaque private keys. These keys typically result from being kept in special hardware (i.e. a TPM) although sometimes operating systems provide a similar interface using process isolation for security rather than hardware boundaries. This changes provides interfaces for representing them and alters crypto/tls so that client certificates can use opaque keys. LGTM=bradfitz R=bradfitz CC=golang-codereviews, jdeprez https://golang.org/cl/114680043
-
Rob Pike authored
Needless except that the api tool complains. We could fix that issue instead. TBR=bradfitz R=golang-codereviews CC=golang-codereviews https://golang.org/cl/133290043
-
Russ Cox authored
Run it right before main.init. There is still some runtime initialization that happens before runtime.init, and some of that may call into Go code (for example to acquire locks) so this timing is not perfect, but I believe it is the best we can do. This came up because global variables intialized to func values are done in the generated init code, not in the linker. LGTM=dvyukov R=dvyukov CC=golang-codereviews, iant, khr, r https://golang.org/cl/135210043
-