Commits · 548e3d0342cfa31dc552ad45e683fc780c75a153 · go / golang

06 Jun, 2011 12 commits

Alex Brainman authored Jun 06, 2011

1) runLog to return err==nil if program runs, but returns exitcode!=0;
2) runLog to return err!=nil when fails to create log file;
3) print failed program name, not just "all.bash".

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4532117

548e3d03

gc: enable building under clang/2.9 · 60a4b5e4

Dave Cheney authored Jun 06, 2011

To build under clang, pass the path to clang in CC when
calling ./make.bash

CC=/opt/llvm/llvm-2.9/bin/clang ./make.bash

Credit goes to jmhodges for suggestions.

R=jeff, r, ality
CC=golang-dev
https://golang.org/cl/4527098

60a4b5e4

os: add Process.Kill and Process.Signal · 94b974a2

Evan Shaw authored Jun 06, 2011

R=alex.brainman, r, rsc, krasin, iant, rsc, r
CC=golang-dev
https://golang.org/cl/4437091

94b974a2

libmach: use the standardized format for designated initializers. · 7dd47326

Jeffrey M Hodges authored Jun 06, 2011

The brace style in these files are a little inconsistent so I rolled with
it on a per-file basis.

R=dave, r
CC=golang-dev
https://golang.org/cl/4515194

7dd47326

netchan: added drain method to importer. · ce877acf
David Jakob Fritz authored Jun 06, 2011
```
Fixes #1868.

R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/4550093
```
ce877acf
CONTRIBUTORS: C+A for David Jakob Fritz and Jeffrey M Hodges · b4ddef3c
Rob Pike authored Jun 06, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4572043
```
b4ddef3c
mail: address list parsing. · ff0198b7
David Symonds authored Jun 06, 2011
```
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/4547084
```
ff0198b7
crypto/twofish: fix Reset index overflow bug. · a028a023
Andrew Gerrand authored Jun 06, 2011
```
Fixes #1919.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4530110
```
a028a023

image/tiff: support for bit depths other than 8. · d01b260e

Benny Siegert authored Jun 06, 2011

At the moment, 16-bit samples are reduced to 8 bits, this will
be changed in a separate CL.

R=nigeltao
CC=golang-dev
https://golang.org/cl/4552057

d01b260e

doc: don't insert paragraphs inside pre blocks · 79eded50
Andrew Gerrand authored Jun 06, 2011
```
doc: update go_tutorial

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4568056
```
79eded50
dashboard: bug fix · 3b938f7d
Andrew Gerrand authored Jun 06, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4535104
```
3b938f7d
go/build: fix windows build by commenting out references to stdout and stderr in cgotest · 4c2123e5
Alex Brainman authored Jun 06, 2011
```
R=golang-dev, r, adg
CC=golang-dev
https://golang.org/cl/4561062
```
4c2123e5

05 Jun, 2011 2 commits

go/build: exclude cgo test from arm · eb72403b

Andrew Gerrand authored Jun 05, 2011

go/build: include command output in error values
go/build: add syslist.go to .hgignore

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4550118

eb72403b

image/draw: move exp/draw to image/draw and exp/gui. · b47a38de
Nigel Tao authored Jun 05, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4515191
```
b47a38de

04 Jun, 2011 1 commit
- go/build: new package for building go programs · c2cea441
  Andrew Gerrand authored Jun 04, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4433047
```
  c2cea441
03 Jun, 2011 16 commits

unicode: for consistency with MaxRune, s/Latin1Max/MaxLatin1/ and · 7a92287a
Rob Pike authored Jun 03, 2011
```
s/ASCIIMax/MaxASCII/

R=golang-dev, r, gri
CC=golang-dev
https://golang.org/cl/4539109
```
7a92287a

unicode: add the first few property tests for printing. · 8d64e73f

Rob Pike authored Jun 03, 2011

The long-term goal is that %q will use IsPrint to decide
what to show natively vs. as hexadecimal.

R=rsc, r
CC=golang-dev
https://golang.org/cl/4526095

8d64e73f

ebnf: update comment · 86b3577a

Robert Griesemer authored Jun 03, 2011

(pointed out by jan.mercl@nic.cz)

R=iant, jan.mercl, rsc
CC=golang-dev
https://golang.org/cl/4515189

86b3577a

http: don't fail on accept hitting EMFILE · 26557579
Brad Fitzpatrick authored Jun 03, 2011
```
Fixes #1891

R=rsc
CC=golang-dev
https://golang.org/cl/4550112
```
26557579
net: fix windows build · 0015e8eb
Mikio Hara authored Jun 03, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4539108
```
0015e8eb

net: add network interface identification API · 518331df

Mikio Hara authored Jun 03, 2011

This CL introduces new API into package net to identify the network
interface.  A functionality of new API is very similar to RFC3493 -
"Interface Identification".

R=r, gri, bradfitz, robert.hencke, fullung, rsc
CC=golang-dev
https://golang.org/cl/4437087

518331df

8g: compute register liveness during regopt · 84f291b1

Russ Cox authored Jun 03, 2011

Input code like

0000 (x.go:2) TEXT    main+0(SB),$36-0
0001 (x.go:3) MOVL    $5,i+-8(SP)
0002 (x.go:3) MOVL    $0,i+-4(SP)
0003 (x.go:4) MOVL    $1,BX
0004 (x.go:4) MOVL    i+-8(SP),AX
0005 (x.go:4) MOVL    i+-4(SP),DX
0006 (x.go:4) MOVL    AX,autotmp_0000+-20(SP)
0007 (x.go:4) MOVL    DX,autotmp_0000+-16(SP)
0008 (x.go:4) MOVL    autotmp_0000+-20(SP),CX
0009 (x.go:4) CMPL    autotmp_0000+-16(SP),$0
0010 (x.go:4) JNE     ,13
0011 (x.go:4) CMPL    CX,$32
0012 (x.go:4) JCS     ,14
0013 (x.go:4) MOVL    $0,BX
0014 (x.go:4) SHLL    CX,BX
0015 (x.go:4) MOVL    BX,x+-12(SP)
0016 (x.go:5) MOVL    x+-12(SP),AX
0017 (x.go:5) CDQ     ,
0018 (x.go:5) MOVL    AX,autotmp_0001+-28(SP)
0019 (x.go:5) MOVL    DX,autotmp_0001+-24(SP)
0020 (x.go:5) MOVL    autotmp_0001+-28(SP),AX
0021 (x.go:5) MOVL    autotmp_0001+-24(SP),DX
0022 (x.go:5) MOVL    AX,(SP)
0023 (x.go:5) MOVL    DX,4(SP)
0024 (x.go:5) CALL    ,runtime.printint+0(SB)
0025 (x.go:5) CALL    ,runtime.printnl+0(SB)
0026 (x.go:6) RET     ,

is problematic because the liveness range for
autotmp_0000 (0006-0009) is nested completely
inside a span where BX holds a live value (0003-0015).
Because the register allocator only looks at 0006-0009
to see which registers are used, it misses the fact that
BX is unavailable and uses it anyway.

The n->pun = anyregalloc() check in tempname is
a workaround for this bug, but I hit it again because
I did the tempname call before allocating BX, even
though I then used the temporary after storing in BX.
This should fix the real bug, and then we can remove
the workaround in tempname.

The code creates pseudo-variables for each register
and includes that information in the liveness propagation.
Then the regu fields can be populated using that more
complete information.  With that approach, BX is marked
as in use on every line in the whole span 0003-0015,
so that the decision about autotmp_0000
(using only 0006-0009) still has all the information
it needs.

This is not specific to the 386, but it only happens in
generated code of the form

        load R1
        ...
        load var into R2
        ...
        store R2 back into var
        ...
        use R1

and for the most part the other compilers generate
the loads for a given compiled line before any of
the stores.  Even so, this may not be the case everywhere,
so the change is worth making in all three.

R=ken2, ken, ken
CC=golang-dev
https://golang.org/cl/4529106

84f291b1

testing: check that tests and benchmarks do not affect GOMAXPROCS · 79b397b2

Dmitriy Vyukov authored Jun 03, 2011

Plus fix spoiling of GOMAXPROCS in 2 existing rwmutex tests.
Plus fix benchmark output to stdout (now it outputs to stderr like all other output).

R=rsc
CC=golang-dev
https://golang.org/cl/4529111

79b397b2

8l, ld: Initial adjustments for Plan 9 native compilation of 8l · 9baaa6f7

Lucio De Re authored Jun 03, 2011

These changes are not particularly invasive and have been tested
as broadly as possible.

8l/l.h:
  -	#pragma varargck: added some, removed duplicates.

ld/dwarf.c:
  -	As Plan 9 has no NULL, changed all occurrences to nil.
  -	Added USED(size); where necessary.
  -	Added (void) argument in definition of finddebugruntimepath().
  -	Plan 9 compiler was complaining about multiple
        assignments, repeaired by breaking up the commands.
  -	Correction: havedynamic = 1; restored.

ld/go.c:
  -	Needed USED(file); in two functions.
  -	Removed unused assignments flagged by the Plan 9 compiler.

ld/lib.c:
  -	Replaced unlink() with remove() which seems available everywhere.
  -	Removed USED(c4); and USED(magic) no longer required.
  -	Removed code flagged as unused by the Plan 9 compiler.
  -	Added attributes to a number of format strings.

R=rsc
CC=golang-dev
https://golang.org/cl/4435047

9baaa6f7

gc: renamed walkdef to typecheckdef and moved from walk to typedef. · ab8ed7f8
Luuk van Dijk authored Jun 03, 2011
```
also inlined a typechecking function in dcl away.

R=rsc
CC=golang-dev
https://golang.org/cl/4550115
```
ab8ed7f8
dashboard: add favicon.ico · f4f58368
Andrew Gerrand authored Jun 03, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4547082
```
f4f58368
image: rename Contains and ContainsRectangle to In. · f531ef32
Nigel Tao authored Jun 03, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4539104
```
f531ef32

gc: allow tags on parameters in export section of object files. · 56668283

Luuk van Dijk authored Jun 03, 2011

This is in preparation of escape analysis; function parameters
can now be tagged with interesting bits by the compiler by
assigning to n->note.

tested by having typecheck put a fake tag on all parameters of
pointer type and compiling the tree.

R=rsc
CC=golang-dev
https://golang.org/cl/4524092

56668283

exp/draw: fix clipping bug where sp/mp were not shifted when r.Min was. · ae5a972d
Nigel Tao authored Jun 03, 2011
```
image: add Rectangle.ContainsRectangle method.

R=r, rsc
CC=golang-dev
https://golang.org/cl/4517130
```
ae5a972d
tag weekly.2011-06-02 · f628f741
Andrew Gerrand authored Jun 03, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4551092
```
f628f741
weekly.2011-06-02 · 897ad0c0
Andrew Gerrand authored Jun 03, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4548091
```
897ad0c0

02 Jun, 2011 9 commits

doc: add Belarusian FAQ translation · 6c2b4348
Andrew Gerrand authored Jun 02, 2011
```
R=golang-dev, dchest
CC=golang-dev
https://golang.org/cl/4564057
```
6c2b4348

fmt: fix bug in UnreadRune: must clear memory of previous · ce5c1cf0

Rob Pike authored Jun 02, 2011

rune if input implements UnreadRune; otherwise the lookahead
will lie.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4548082

ce5c1cf0

exec: change exec.PathError to exec.Error · 4e9e9250

Rob Pike authored Jun 02, 2011

There were two issues:
1) It might not be a path error, it might be 'permission denied'.
2) The concept of $PATH is Unix-specific.

R=alex.brainman, rsc, r, mattn.jp
CC=golang-dev
https://golang.org/cl/4530096

4e9e9250

http: ServeFile shouldn't send Content-Length when Content-Encoding is set · 31c79c4e
Brad Fitzpatrick authored Jun 02, 2011
```
Fixes #1905

R=rsc
CC=golang-dev
https://golang.org/cl/4538111
```
31c79c4e
big: remove some unnecessary conversions · 5bf57c1b
Robert Griesemer authored Jun 02, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4529110
```
5bf57c1b
http: catch panics · 2a8ea0d1
Brad Fitzpatrick authored Jun 02, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4559067
```
2a8ea0d1
big: do not modify divisor · 191a6bfc
Robert Griesemer authored Jun 02, 2011
```
Fixes #1907.

R=rsc
CC=golang-dev
https://golang.org/cl/4527096
```
191a6bfc

exec: add Cmd methods StdinPipe, StdoutPipe, StderrPipe · 4d155777

Brad Fitzpatrick authored Jun 02, 2011

It gets annoying to do this in caller code otherwise,
especially having to remember to Close one side.

R=rsc
CC=golang-dev
https://golang.org/cl/4517134

4d155777

sync/atomic: fix check64 · 69cb8fef

Russ Cox authored Jun 02, 2011

The LDREXD and STREXD instructions require
aligned addresses, and the ARM stack is not
guaranteed to be aligned during the check.
This may cause other problems later (on the ARM
not all 64-bit pointers may be 64-bit aligned)
but at least the check is correct now.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4564053

69cb8fef