Commits · 5791233461d9eaef94f8a29cee7a1933a5c015d2 · go / golang

24 Oct, 2011 3 commits

exp/ssh: introduce Session to replace Cmd for interactive commands · 57912334

Dave Cheney authored Oct 24, 2011

This CL replaces the Cmd type with a Session type representing
interactive channels. This lays the foundation for supporting
other kinds of channels like direct-tcpip or x11.

client.go:
* replace chanlist map with slice.
* generalize stdout and stderr into a single type.
* unexport ClientChan to clientChan.

doc.go:
* update ServerConfig/ServerConn documentation.
* update Client example for Session.

message.go:
* make channelExtendedData more like channelData.

session.go:
* added Session which replaces Cmd.

R=agl, rsc, n13m3y3r, gustavo
CC=golang-dev
https://golang.org/cl/5302054

57912334

html: dump attributes when running parser tests. · 2f3f3aa2

Andrew Balholm authored Oct 24, 2011

The WebKit test data shows attributes as though they were child nodes:

<a X>0<b>1<a Y>2
dumps as:
| <html>
|   <head>
|   <body>
|     <a>
|       x=""
|       "0"
|       <b>
|         "1"
|     <b>
|       <a>
|         y=""
|         "2"

So we need to do the same when dumping a tree to compare with it.

R=nigeltao
CC=golang-dev
https://golang.org/cl/5322044

2f3f3aa2

http: add package comment · 2b5aa283
Brad Fitzpatrick authored Oct 24, 2011
```
Fixes #2378

R=rsc
CC=golang-dev
https://golang.org/cl/5312052
```
2b5aa283

23 Oct, 2011 2 commits

net: do not set SO_REUSEADDR for windows · c1d0f0e7
Alex Brainman authored Oct 23, 2011
```
Fixes #2307.

R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5306049
```
c1d0f0e7

html: implement foster parenting · 2aa589c8

Andrew Balholm authored Oct 23, 2011

Implement the foster-parenting algorithm for content that is inside a table
but not in a cell.

Also fix a bug in reconstructing the active formatting elements.

Pass test 30 in tests1.dat:
<a><table><td><a><table></table><a></tr><a></table><b>X</b>C<a>Y

R=nigeltao
CC=golang-dev
https://golang.org/cl/5309052

2aa589c8

22 Oct, 2011 1 commit

html: parse <select> tags. · 2f352ae4

Nigel Tao authored Oct 22, 2011

The additional test case in parse_test.go is:
<select><b><option><select><option></b></select>X

R=andybalholm
CC=golang-dev
https://golang.org/cl/5293051

2f352ae4

21 Oct, 2011 6 commits

big: usable zero Rat values without need for explicit initialization · 696ced50

Robert Griesemer authored Oct 21, 2011

- no explicit API change, but new(big.Rat) now creates a big.Rat value
  of 0 that is immediately usable, in sync. w/ the conventions elsewhere
- various cleanups along the way

R=r
CC=golang-dev
https://golang.org/cl/5301056

696ced50

fmt: simplify the code some more by storing the field in the pp structure. · d481d7c8
Rob Pike authored Oct 21, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5293058
```
d481d7c8

big: implemented Rat.Inv · 4854bd9c

Robert Griesemer authored Oct 21, 2011

Also:
- changed semantics of return values for [Int|Rat].SetString
  if an error occured (returned value is nil); will expose
  hidden errors where return values are not checked
- added more tests
- various cleanups throughout

Fixes #2384.

R=r
CC=golang-dev
https://golang.org/cl/5312044

4854bd9c

gotest: make it easier to get the help string · c6bdef3f

Rob Pike authored Oct 21, 2011

Because gotest's args are mingled with the tests, it's
hard to get the usage message to print. This CL adds
explicit support for -help, spelled several different ways.
Gotest has special flags like -file that are somewhat
hidden otherwise.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5298052

c6bdef3f

http: Transport: with TLS InsecureSkipVerify, skip hostname check · 2cab897c
Brad Fitzpatrick authored Oct 21, 2011
```
Fixes #2386

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5312045
```
2cab897c

exp/ssh: server cleanups · 8bfb2171

Dave Cheney authored Oct 21, 2011

server.go/channel.go:
* rename Server to ServerConfig to match Client.
* rename ServerConnection to ServeConn to match Client.
* add Listen/Listener.
* ServerConn.Handshake(), general cleanups.

client.go:
* fix bug where fmt.Error was not assigned to err

R=rsc, agl
CC=golang-dev
https://golang.org/cl/5265049

8bfb2171

20 Oct, 2011 5 commits

exp/ssh: add experimental ssh client · 792a55f5

Dave Cheney authored Oct 20, 2011

Requires CL 5285044

client.go:
* add Dial, ClientConn, ClientChan, ClientConfig and Cmd.

doc.go:
* add Client documentation.

server.go:
* adjust for readVersion change.

transport.go:
* return an os.Error not a bool from readVersion.

R=rsc, agl, n13m3y3r
CC=golang-dev
https://golang.org/cl/5162047

792a55f5

go/ast: use single-element map in test · e8a426ae

Robert Griesemer authored Oct 20, 2011

Avoids test failure due to undefined map iteration order.

R=rsc, iant, iant
CC=golang-dev
https://golang.org/cl/5297048

e8a426ae

go/ast, go/token: actually run tests; fix go/ast test · 22dd0ba9
Ian Lance Taylor authored Oct 20, 2011
```
R=gri
CC=golang-dev
https://golang.org/cl/5292048
```
22dd0ba9
exp/winfsnotify: fix test · 9e1a2adf
Hector Chu authored Oct 20, 2011
```
R=alex.brainman, mattn.jp
CC=golang-dev
https://golang.org/cl/5311047
```
9e1a2adf

html: parse and render comment nodes. · 64306c9f

Nigel Tao authored Oct 20, 2011

The first additional test case in parse_test.go is:
<!--><div>--<!-->

The second one is unrelated to the comment change, but also passes:
<p><hr></p>

R=andybalholm
CC=golang-dev
https://golang.org/cl/5299047

64306c9f

19 Oct, 2011 14 commits

misc/vim: add highlighting for delete · 57d07e32
Dave Cheney authored Oct 19, 2011
```
R=golang-dev, n13m3y3r
CC=golang-dev
https://golang.org/cl/5303050
```
57d07e32
fmt: don't panic formatting nil interfaces · 526d0818
Gustavo Niemeyer authored Oct 19, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5296044
```
526d0818

govet: check canonical dynamic method signatures · b0ec32db

Russ Cox authored Oct 19, 2011

Adds check that, for example, a Scan method taking
a first argument of type fmt.ScanState has the correct
signature to satisfy fmt.Scanner.

Similarly, a ReadByte should return byte, os.Error.

These are important to check because various pieces
of code (fmt, gob, json, flate) do dynamic checks
for these methods, so code with incorrect signatures
would not be flagged at compile time.

These become even more important to check when
rune is introduced.

R=r
CC=golang-dev
https://golang.org/cl/5305044

b0ec32db

unicode: sort tables.go · b4d6b71e

Russ Cox authored Oct 19, 2011

Makes tables.go output consistent across maketable runs.
(It was already inconsistent across architectures; the new
map iteration order just make it inconsistent across runs.)

R=r
CC=golang-dev
https://golang.org/cl/5303046

b4d6b71e

codereview: show LGTMs in hg p · c0523e1d

Russ Cox authored Oct 19, 2011

Shows first line of any response that the codereview server
has identified as an LGTM.  Example output below.

5305046:
        big: update for fmt interface changes

        Nothing terribly interesting here.

        Reviewer: gri@golang.org
                gri: LGTM
        CC: golang-dev@googlegroups.com
        Files:
                src/pkg/big/int.go
                src/pkg/big/nat.go
                src/pkg/big/nat_test.go
                src/pkg/big/rat.go

5307044:
        exp/template/html: use rune

        Nothing terribly interesting here.

        Reviewer: mikesamuel@gmail.com, nigeltao@golang.org
                mikesamuel: I don't see a type def for rune.  Assuming that's a new intrinsic, LGTM.
        CC: golang-dev@googlegroups.com
        Files:
                src/pkg/exp/template/html/css.go
                src/pkg/exp/template/html/css_test.go
                src/pkg/exp/template/html/html.go
                src/pkg/exp/template/html/js.go

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5297045

c0523e1d

gotest: use $GCFLAGS like make does · 35b2bfc8
Russ Cox authored Oct 19, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5297044
```
35b2bfc8
exp/types: fix crash in parseBasicType on unknown type · bb8c4ed2
Russ Cox authored Oct 19, 2011
```
R=gri
CC=golang-dev
https://golang.org/cl/5302044
```
bb8c4ed2

crypto/x509: fix names in certificate generation. · ec0b5533

Adam Langley authored Oct 19, 2011

I had a brain fart in af84b15fbae2 and messed up the names in
generated certificates.

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5315046

ec0b5533

http: comment tweaks · 314afb41

Brad Fitzpatrick authored Oct 19, 2011

It hasn't been primitive in a while.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5287041

314afb41

syscall: update ztypes_linux_386 for terminal changes · cf0952d3
Brad Fitzpatrick authored Oct 19, 2011
```
R=golang-dev, dave, iant
CC=golang-dev
https://golang.org/cl/5299045
```
cf0952d3
syscall: update ztypes_linux_arm for terminal changes · ec80beb9
Dave Cheney authored Oct 19, 2011
```
regenerated on a debian sid arm5 host.

R=bradfitz, iant
CC=golang-dev
https://golang.org/cl/5298046
```
ec80beb9
os/inotify: move to exp/inotify · e13635c1
Mikio Hara authored Oct 19, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5295044
```
e13635c1
tag weekly.2011-10-18 · da356dc3
Andrew Gerrand authored Oct 19, 2011
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5292045
```
da356dc3
weekly.2011-10-18 · ac21766c
Andrew Gerrand authored Oct 19, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5302041
```
ac21766c

18 Oct, 2011 9 commits

html: fix escape_test.go for CSS escaper change 5306042. · 98e723ed
Nigel Tao authored Oct 18, 2011
```
R=mikesamuel
CC=golang-dev
https://golang.org/cl/5313044
```
98e723ed

fmt: clean up after reflect.Interface change. · 811d334a

Rob Pike authored Oct 18, 2011

Store the reflect.Value in the internal print state. Code is simpler, cleaner,
and a little faster - back to what it was before the change.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5299046

811d334a

rpc: don't panic on write error. · 4c56c30b

Rob Pike authored Oct 18, 2011

The mechanism to record the error in the call is already in place.
Fixes #2382.

R=golang-dev, dsymonds, bradfitz, r
CC=golang-dev
https://golang.org/cl/5307043

4c56c30b

exp/template/html: fix bug in cssEscaper · fc3ce349

Mike Samuel authored Oct 18, 2011

cssEscaper escapes using the CSS convention: `\` + hex + optional-space

It outputs the space when the escape could be followed by
a hex digit to distinguish a "\na" from "\u00aa".

It did not output a space when the escape is followed by a space
character so did not distinguish "\n " from "\n".

Currently when doing lookahead, it does not distinguish spaces that
will be escaped later by the same function from ones that will not.
This is correct but suboptimal.

R=nigeltao
CC=golang-dev
https://golang.org/cl/5306042

fc3ce349

http: add test for panic inside hijacked request · aa42881e
Andrew Gerrand authored Oct 18, 2011
```
R=golang-dev, rsc, rsc
CC=golang-dev
https://golang.org/cl/5283052
```
aa42881e

html: parse raw text and RCDATA elements, such as <script> and <title>. · b1fd528d

Nigel Tao authored Oct 18, 2011

Pass tests1.dat, test 26:
#data
<script><div></script></div><title><p></title><p><p>
#document
| <html>
|   <head>
|     <script>
|       "<div>"
|     <title>
|       "<p>"
|   <body>
|     <p>
|     <p>

Thanks to Andy Balholm for driving this change.

R=andybalholm
CC=golang-dev
https://golang.org/cl/5301042

b1fd528d

ld: modify macho linkedit segment to enable OS X code signing · 78ad19f2

Mikkel Krautz authored Oct 18, 2011

Move string table to the end of the __LINKEDIT segment.

This change allows Apple's codesign(1) utility to successfully sign
Go binaries, as long as they don't contain DWARF data (-w flag to
8l/6l).  This is because codesign(1) expects the string table to be
the last part of the file.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5271050

78ad19f2

godoc: generate package toc in template, not in JavaScript · cb2f6cb0

Russ Cox authored Oct 18, 2011

1. Generate TOC for package pages using template,
instead of using JavaScript magic.  This makes the
pages generated by godoc -html easier to export
to other systems.

2. Make TOC one column.  It's hard to do two columns
portably without invoking JavaScript.

3. Since the TOC is only one column, show full type
signatures for functions and methods.  Many times
that's all you need to see anyway.

4. Name the section after the TOC "Overview".
Naming it something is important, to set it off
from the TOC and so that there's a quick link to
it in the TOC.

For now, some illustrative examples:

http://swtch.com:6060/pkg/io/
http://swtch.com:6060/pkg/strings/
http://swtch.com:6060/pkg/tabwriter/
http://swtch.com:6060/pkg/unicode/

Fixes #1982.

R=gri, bradfitz, r
CC=golang-dev
https://golang.org/cl/5303044

cb2f6cb0

exp/winfsnotify: filesystem watcher for Windows · 7ecf6c99

Hector Chu authored Oct 18, 2011

R=rsc, alex.brainman, bradfitz
CC=bsiegert, go.peter.90, golang-dev
https://golang.org/cl/4188047

7ecf6c99