- 31 Oct, 2011 3 commits
-
-
Fazlul Shahriar authored
Makes all tests pass. R=rsc CC=golang-dev https://golang.org/cl/5320041
-
Jan Newmarch authored
If a frame has multiple windows then the windows must all be restored after gofmt has finished and the old windows must be restored. Before this fix, only the Go code edit window would be left. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5280050
-
Marcel van Lohuizen authored
regexp, which caused the last line of a test block to be ignored. R=r, rsc CC=golang-dev https://golang.org/cl/5177052
-
- 29 Oct, 2011 1 commit
-
-
Dave Cheney authored
The payload of a data message is defined as an SSH string type, which uses the first four bytes to encode its length. When channelData and channelExtendedData were added I defined Payload as []byte to be able to use it directly without a string to []byte conversion. This resulted in the length data leaking into the payload data. This CL fixes the bug, and restores agl's original fast path code. Additionally, a bug whereby s.lock was not released if a packet arrived for an invalid channel has been fixed. Finally, as they were no longer used, I have removed the channelData and channelExtedendData structs. R=agl, rsc CC=golang-dev https://golang.org/cl/5330053
-
- 28 Oct, 2011 17 commits
-
-
Andrew Balholm authored
In the adoption agency algorithm, the formatting element is sometimes removed from the list of active formatting elements and reinserted at a later index. In that case, the bookmark showing where it is to be reinserted needs to be moved, so that its position relative to its neighbors remains the same (and also so that it doesn't become out of bounds). Pass tests1.dat, test 70: <DIV> abc <B> def <I> ghi <P> jkl </B> | <html> | <head> | <body> | <div> | " abc " | <b> | " def " | <i> | " ghi " | <i> | <p> | <b> | " jkl " Also pass tests through test 76: <test attribute----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------> R=nigeltao CC=golang-dev https://golang.org/cl/5322052
-
Andrew Balholm authored
Pass tests1.dat, test 55: <!DOCTYPE html><font><table></font></table></font> | <!DOCTYPE html> | <html> | <head> | <body> | <font> | <table> Also pass tests through test 69: <DIV> abc <B> def <I> ghi <P> jkl R=nigeltao CC=golang-dev https://golang.org/cl/5309074
-
Russ Cox authored
Handling os.Error is no different than handling fmt.Stringer here, so the code is redundant now, but it will be necessary once error goes in. Adding it now will make gofix fix it. R=r CC=golang-dev https://golang.org/cl/5331045
-
Russ Cox authored
R=r CC=golang-dev https://golang.org/cl/5305069
-
Russ Cox authored
Will make gofix for error run more smoothly. The overloading of gobError appears to be unintentional. R=r CC=golang-dev https://golang.org/cl/5308060
-
Russ Cox authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/5327052
-
Russ Cox authored
alerts get used as both values and errors. Rather than introduce an alertError wrapper, this CL just adds an Error method, which will satisfy the error interface when the time comes. R=agl, bradfitz CC=golang-dev https://golang.org/cl/5294073
-
Russ Cox authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5328051
-
Russ Cox authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/5320051
-
Russ Cox authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/5308061
-
Russ Cox authored
It will be obsolete when error happens. Submitting this now will make the error transition earlier, at the cost of making a locally-built godoc viewing /pkg/syscall or /pkg/os have some functions appear under the Error type as constructors. R=golang-dev, adg CC=golang-dev https://golang.org/cl/5305067
-
Russ Cox authored
Was working only accidentally. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5303082
-
Russ Cox authored
Will make gofix for error work better. There is no other indication in this file that these are actually error implementations. (They are only used elsewhere.) R=bradfitz CC=golang-dev https://golang.org/cl/5305068
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5318058
-
Russ Cox authored
R=nigeltao CC=golang-dev https://golang.org/cl/5302069
-
Russ Cox authored
We only guarantee that the main goroutine runs on the main OS thread for initialization. Programs that wish to preserve that property for main.main can call runtime.LockOSThread. This is what programs used to do before we unleashed goroutines during init, so it is both a simple fix and keeps existing programs working. R=iant, r, dave, dvyukov CC=golang-dev https://golang.org/cl/5309070
-
Russ Cox authored
I found these by adding a check to govet, but the check produces far too many false positives to be useful. Even so, these few seem worth cleaning up. R=golang-dev, bradfitz, iant CC=golang-dev https://golang.org/cl/5311067
-
- 27 Oct, 2011 6 commits
-
-
Andrew Balholm authored
Pass tests1.dat, test 50: <!DOCTYPE html><script> <!-- </script> --> </script> EOF | <!DOCTYPE html> | <html> | <head> | <script> | " <!-- " | " " | <body> | "--> EOF" Also pass tests through test 54: <!DOCTYPE html><title>U-test</title><body><div><p>Test<u></p></div></body> R=nigeltao CC=golang-dev https://golang.org/cl/5311066
-
Alex Brainman authored
R=jdpoirier CC=golang-dev https://golang.org/cl/5305048
-
Russ Cox authored
This is true of the existing implementations, and I think it is an important property to guarantee. R=golang-dev, r, borman, r CC=golang-dev https://golang.org/cl/5321058
-
Russ Cox authored
R=iant CC=golang-dev, gri https://golang.org/cl/5327048
-
Julian Phillips authored
goinstall has built in support for a few common code hosting sites. The identification of which vcs tool should be used was based purely on a regex match against the provided import path. The problem with this approach is that it requires distinct import paths for different vcs tools on the same site. Since bitbucket has recently starting hosting Git repositories under the same bitbucket.org/user/project scheme as it already hosts Mercurial repositories, now would seem a good time to take a more flexible approach. We still match the import path against a list of regexes, but now the match is purely to distinguish the different hosting sites. Once the site is identified, the specified function is called with the repo and path matched out of the import string. This function is responsible for creating the vcsMatch structure that tells us what we need to download the code. For github and launchpad, only one vcs tool is currently supported, so these functions can simply return a vcsMatch structure. For googlecode, we retain the behaviour of determing the vcs from the import path - but now it is done by the function instead of the regex. For bitbucket, we use api.bitbucket.org to find out what sort of repository the specified import path corresponds to - and then construct the appropriate vcsMatch structure. R=golang-dev, adg CC=golang-dev, rsc https://golang.org/cl/5306069
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5306070
-
- 26 Oct, 2011 13 commits
-
-
Andrew Balholm authored
Also correctly handle EOF inside a <style> element. Pass tests1.dat, test 49: <!DOCTYPE html><style> EOF | <!DOCTYPE html> | <html> | <head> | <style> | " EOF" | <body> R=nigeltao CC=golang-dev https://golang.org/cl/5321057
-
Andrew Balholm authored
Pass tests1.dat, test 34: <!DOCTYPE html>A<option>B<optgroup>C<select>D</option>E | <!DOCTYPE html> | <html> | <head> | <body> | "A" | <option> | "B" | <optgroup> | "C" | <select> | "DE" Also passes tests 35-48. Test 48 is: </ COM--MENT > R=nigeltao CC=golang-dev https://golang.org/cl/5311063
-
Russ Cox authored
Emitting ELF symbol table is the default behavior now and cannot be disabled. R=golang-dev, iant CC=golang-dev https://golang.org/cl/5319050
-
Ron Minnich authored
Change the name of cas() in cc to newcase() to avoid a NIX conflict. cas() is used in cc to create a new Case struct. There is a name conflict in that cas() is a commonly-used name for compare and swap. Since cas() is only used internally in the compiler in 3 places, change the name to avoid a wider conflict with the NIX runtime. This issue might well come up on other OSes in the future anyway, as the name is fairly common. R=rsc CC=golang-dev https://golang.org/cl/5294071
-
Russ Cox authored
R=ken2 CC=golang-dev https://golang.org/cl/5327045
-
Jongmin Kim authored
According to adding rune type R=adg, dsymonds CC=golang-dev https://golang.org/cl/5319048
-
Russ Cox authored
Small change to go/ast, go/parser, go/printer so that gofix can delete the blank line left from deleting an import. R=golang-dev, bradfitz, adg CC=golang-dev https://golang.org/cl/5321046
-
Russ Cox authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/5308057
-
Russ Cox authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/5305062
-
Brad Fitzpatrick authored
R=golang-dev, rsc, iant CC=golang-dev https://golang.org/cl/5312057
-
Adam Langley authored
Although there's still no concrete security reason not to use 3, I think Bleichenbacher has convinced me that it's a useful defense and it's what everyone else does. R=bradfitz, rsc CC=golang-dev https://golang.org/cl/5307060
-
Alex Brainman authored
R=rsc, adg CC=golang-dev https://golang.org/cl/5302058
-
Alex Brainman authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/5294060
-