Commits · 58b97a29fd5d8ad219a34b3c859842cc29d46666 · go / golang

14 Dec, 2011 26 commits

net/smtp: add CRAM-MD5 authentication · 58b97a29
Vadim Vygonets authored Dec 14, 2011
```
R=golang-dev, edsrzf, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5451087
```
58b97a29
A+C: Vadim Vygonets (individual CLA) · f454dee4
Russ Cox authored Dec 14, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5482073
```
f454dee4
misc/osx: Rename profile.go to profile_go to avoid confusing scripts · 4e066e41
Scott Lawrence authored Dec 14, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5472043
```
4e066e41

html/template: define the FuncMap type locally · 1402d1a6

Rob Pike authored Dec 14, 2011

This redefinition means that the public signature of html/template
does not refer to text/template.

Fixes #2546.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5487083

1402d1a6

gotest: use build.DefaultContext.GOARCH · 78821616

Robert Hencke authored Dec 14, 2011

Fixes https://golang.org/cl/5480060/#msg4

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5485051

78821616

http: fix failing Transport HEAD request with gzip-looking response · 22dafc9b

Brad Fitzpatrick authored Dec 14, 2011

We only want to attempt to un-gzip if there's a body (not in
response to a HEAD)

This was accidentally passing before, but revealed to be broken
when c3c6e72d7cc went in.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5477093

22dafc9b

strconv: slightly faster int conversion for GOARCH=386 · 6890afd9

Robert Griesemer authored Dec 14, 2011

benchmark                           old ns/op    new ns/op    delta
strconv_test.BenchmarkFormatInt         12198        12031   -1.37%
strconv_test.BenchmarkAppendInt          9268         9153   -1.24%
strconv_test.BenchmarkFormatUint         3538         3429   -3.08%
strconv_test.BenchmarkAppendUint         3133         3062   -2.27%

No performance difference for GOARCH=amd64.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5488089

6890afd9

json: treat renamed byte slices the same as []byte · 34c7765f
Rob Pike authored Dec 14, 2011
```
Fixes #2163.

R=rsc
CC=golang-dev
https://golang.org/cl/5488068
```
34c7765f

strconv: even faster int conversion · 465aba66

Robert Griesemer authored Dec 14, 2011

benchmark                           old ns/op    new ns/op    delta
strconv_test.BenchmarkFormatInt         10038         8217  -18.14%
strconv_test.BenchmarkAppendInt          6822         4969  -27.16%
strconv_test.BenchmarkFormatUint         2811         1814  -35.47%
strconv_test.BenchmarkAppendUint         2349         1360  -42.10%

R=rsc
CC=golang-dev
https://golang.org/cl/5488083

465aba66

undo CL 5477092 / c3c6e72d7cc5 · 25e94154

Robert Griesemer authored Dec 14, 2011

The obvious fix is breaking the build in non-obvious ways.
Reverting while waiting for the correct fix, if any is needed.

««« original CL description
net/http: fix bug in error checking

Thanks to josef86@gmail.com for pointing this out.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5477092
»»»

R=iant
CC=golang-dev
https://golang.org/cl/5488085

25e94154

net/http: fix bug in error checking · c0421d92

Robert Griesemer authored Dec 14, 2011

Thanks to josef86@gmail.com for pointing this out.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5477092

c0421d92

gc: use inferred type rather than original one when reporting non-assignability. · e14d1d7e
Luuk van Dijk authored Dec 14, 2011
```
Fixes #2451

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5372105
```
e14d1d7e
crypto/tls: make compatible with go/build · d842acd5
Russ Cox authored Dec 14, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5484073
```
d842acd5
hash/crc32: make compatible with go/build · 23cd4064
Russ Cox authored Dec 14, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5486060
```
23cd4064
go/build: make compatible with go/build · 576311d7
Russ Cox authored Dec 14, 2011
```
The irony!

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5482062
```
576311d7
gc: add forgotten typecheck in a lonely corner of sinit · 1f6d130b
Luuk van Dijk authored Dec 14, 2011
```
Fixes #2549

R=rsc
CC=golang-dev
https://golang.org/cl/5484060
```
1f6d130b

gc: inlining (disabled without -l) · a62722bb

Luuk van Dijk authored Dec 14, 2011

Cross- and intra package inlining of single assignments or return <expression>.
Minus some hairy cases, currently including other calls, expressions with closures and ... arguments.

R=rsc, rogpeppe, adg, gri
CC=golang-dev
https://golang.org/cl/5400043

a62722bb

html: close <button> element before opening a new one · e25a83d0

Andrew Balholm authored Dec 14, 2011

Pass tests6.dat, test 13:
<button><button>

| <html>
|   <head>
|   <body>
|     <button>
|     <button>

Also pass tests through test 25:
<table><colgroup>foo

R=nigeltao
CC=golang-dev
https://golang.org/cl/5487072

e25a83d0

gc: Use %#F in error messages instead of %F. · 3c638f28
Luuk van Dijk authored Dec 14, 2011
```
Fixes #2520

R=rsc
CC=golang-dev
https://golang.org/cl/5482056
```
3c638f28
gc: suppress non-root cause message for bad receivers. · 6a401339
Luuk van Dijk authored Dec 14, 2011
```
Fixed issue 2500

R=rsc
CC=golang-dev
https://golang.org/cl/5485053
```
6a401339

undo CL 5485063 / 21595dc0395a · c8a5f884

Russ Cox authored Dec 14, 2011

breaks 64-bit build

««« original CL description
8c: handle 64-bit switch value
Cases must still be 32-bit values, but one thing at a time.

R=ality, ken2, ken
CC=golang-dev
https://golang.org/cl/5485063
»»»

R=ken2
CC=golang-dev
https://golang.org/cl/5488075

c8a5f884

runtime: bump gc 'extra bytes' check · 1e63a4e4

Christopher Wedgwood authored Dec 14, 2011

(needed for non-zero GOMAXPROCS)

R=iant, rsc
CC=go.peter.90, golang-dev
https://golang.org/cl/5486059

1e63a4e4

8c: handle 64-bit switch value · 6481e37d

Russ Cox authored Dec 14, 2011

Cases must still be 32-bit values, but one thing at a time.

R=ality, ken2, ken
CC=golang-dev
https://golang.org/cl/5485063

6481e37d

encoding/gob: better error messages when types mismatch · ba576b2b

Rob Pike authored Dec 14, 2011

The transmitter must encode an interface value if it is to be decoded
into an interface value, but it's a common and confusing error to
encode a concrete value and attempt to decode it into an interface,
particularly *interface{}. This CL attempts to explain things better.

Fixes #2367.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5485072

ba576b2b

exp/winfsnotify: fix build. · 1c50c32a
Yasuhiro Matsumoto authored Dec 14, 2011
```
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/5483057
```
1c50c32a
spec: values of underlying type uintptr can be converted to unsafe.Pointer · 599c18fa
Robert Griesemer authored Dec 14, 2011
```
Not a language change, just stating the facts.

Fixes #1793.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5488071
```
599c18fa

13 Dec, 2011 14 commits

syscall: regenerate z-files for openbsd · 7b5ae29a
Joel Sing authored Dec 13, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5414053
```
7b5ae29a

runtime: Make gc_test test extra allocated space, not total space. · 26239417

Ian Lance Taylor authored Dec 13, 2011

Testing total space fails for gccgo when not using split
stacks, because then each goroutine has a large stack, and so
the total memory usage is large.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5487068

26239417

bufio: make the minimum read buffer size 16 bytes. · 64776da4
Rob Pike authored Dec 13, 2011
```
R=gri, rsc
CC=golang-dev
https://golang.org/cl/5485067
```
64776da4

test/garbage: move to test/bench/garbage · 5fe96c64

Russ Cox authored Dec 13, 2011

(These are benchmarks for the garbage collector, not tests.)

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5484070

5fe96c64

fix build, sorry · 1161e117
Russ Cox authored Dec 13, 2011
```
TBR=r
CC=golang-dev
https://golang.org/cl/5488066
```
1161e117
strconv: some allocation tests · 39213c1f
Brad Fitzpatrick authored Dec 13, 2011
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/5477084
```
39213c1f
test/bench: move to test/bench/shootout · bcbb2f93
Russ Cox authored Dec 13, 2011
```
R=golang-dev, r, gri, bradfitz
CC=golang-dev
https://golang.org/cl/5487067
```
bcbb2f93

contribute.html: do not fill in the reviewer field · b1175beb

Florian Weimer authored Dec 13, 2011

The golang-dev mailing list is added automatically.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5482060

b1175beb

A+C: Florian Weimer (individual CLA) · f4b430c9
Russ Cox authored Dec 13, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5486056
```
f4b430c9

math: delete non-Sqrt-based Hypot · 25728038

Russ Cox authored Dec 13, 2011

I was confused by the existence of two portable Hypot
routines in the tree when I cleaned things up, and I made
ARM use the wrong (imprecise) one.  Use the right one,
and delete the wrong one.

Fixes arm build.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5485065

25728038

undo CL 5414048 / f6b994f33cf4 · 2c6d3eaf

Russ Cox authored Dec 13, 2011

breaks build

««« original CL description
http: close connection after printing panic stack trace
In a testing situation, it's possible for a local http
server to panic and the test exit without the stack trace
ever being printed.
Fixes #2480.

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5414048

»»»

R=bradfitz
CC=golang-dev
https://golang.org/cl/5482061

2c6d3eaf

go/printer, godoc: print comments in example code · 5fb7e5b4

Robert Griesemer authored Dec 13, 2011

- go/printer: support for printing CommentedNodes
- go/doc: collect comments from examples

Fixes #2429.

R=adg, rsc
CC=golang-dev
https://golang.org/cl/5482052

5fb7e5b4

gofmt: simplify flags · fe746335

Robert Griesemer authored Dec 13, 2011

-tabs replaces -tabindent
-spaces has been removed

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/5487066

fe746335

gofix: add googlecode module for rewriting Google Code imports · 0b0a6ec7
Andrew Gerrand authored Dec 13, 2011
```
goinstall: disallow googlecode.com import paths

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5421049
```
0b0a6ec7