Commits · 58ce655fd2efe2270ee852790eede952e179735e · go / golang

17 Jul, 2013 7 commits

misc/emacs: Add godef-jump-other-window · 58ce655f

Dominik Honnef authored Jul 17, 2013

This will behave like similar "*-other-window" functions in Emacs.

Default key bind is C-x 4 C-c C-j – while awkward, it follows both
the convention for other-window functions and the convention for
not using user- or emacs-reserved keys.

R=golang-dev, adonovan
CC=golang-dev
https://golang.org/cl/10707045

58ce655f

runtime: re-enable preemption · b913cf84

Russ Cox authored Jul 17, 2013

Update #543

I believe the runtime is strong enough now to reenable
preemption during the function prologue.
Assuming this is or can be made stable, it will be in Go 1.2.
More aggressive preemption is not planned for Go 1.2.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/11433045

b913cf84

runtime: more reliable preemption · 5887f142

Dmitriy Vyukov authored Jul 17, 2013

Currently preemption signal g->stackguard0==StackPreempt
can be lost if it is received when preemption is disabled
(e.g. m->lock!=0). This change duplicates the preemption
signal in g->preempt and restores g->stackguard0
when preemption is enabled.
Update #543.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/10792043

5887f142

runtime: use new frame argument size information · a8374859

Russ Cox authored Jul 17, 2013

With this CL, I believe the runtime always knows
the frame size during the gc walk. There is no fallback
to "assume entire stack frame of caller" anymore.

R=golang-dev, khr, cshapiro, dvyukov
CC=golang-dev
https://golang.org/cl/11374044

a8374859

crypto/tls: Add support for ECDHE-ECDSA · 7b7dac5e

Joel Sing authored Jul 17, 2013

Add support for ECDHE-ECDSA (RFC4492), which uses an ephemeral server
key pair to perform ECDH with ECDSA signatures. Like ECDHE-RSA,
ECDHE-ECDSA also provides PFS.

R=agl
CC=golang-dev
https://golang.org/cl/7006047

7b7dac5e

cmd/8g: Make clearfat non-interleaved with pointer calculations. · 85a7c090

Daniel Morsing authored Jul 17, 2013

clearfat (used to zero initialize structures) will use AX for x86 block ops. If we write to AX while calculating the dest pointer, we will fill the structure with incorrect values.
Since 64-bit arithmetic uses AX to synthesize a 64-bit register, getting an adress by indexing with 64-bit ops can clobber the register.

Fixes #5820.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/11383043

85a7c090

doc/effective_go: stamp out stray GOROOT reference · deee03f1

Dave Cheney authored Jul 17, 2013

Replaced with something more appropriate.

R=adg, r, minux.ma
CC=golang-dev
https://golang.org/cl/11421043

deee03f1

16 Jul, 2013 20 commits

runtime: print g0 stack if we throw on it and GOTRACEBACK>=2. · cc841761
Keith Randall authored Jul 16, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/11385045
```
cc841761

crypto/rsa: remove obsolete TODO. · ad477e4e

Adam Langley authored Jul 16, 2013

(PSS support is complete.)

Thanks to Frithjof Schulze for noting this.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/10871046

ad477e4e

test: add a compilation test that gccgo failed to compile · 29d27671
Ian Lance Taylor authored Jul 16, 2013
```
R=golang-dev, remyoudompheng
CC=golang-dev
https://golang.org/cl/11379044
```
29d27671
CONTRIBUTORS: add Drew Hintz (Google CLA) · 549802c7
Adam Langley authored Jul 16, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/11386043
```
549802c7

cmd/5g, cmd/6g, cmd/8g: insert arg size annotations on runtime calls · 7b3c8b7a

Russ Cox authored Jul 16, 2013

If calling a function in package runtime, emit argument size
information around the call in case the call is to a variadic C function.

R=ken2
CC=golang-dev
https://golang.org/cl/11371043

7b3c8b7a

cmd/5c, cmd/6c, cmd/8c: record arg size for every call · 4e141145
Russ Cox authored Jul 16, 2013
```
R=ken2
CC=golang-dev
https://golang.org/cl/11364043
```
4e141145

runtime: record argument size in assembly functions · 9ddfb643

Russ Cox authored Jul 16, 2013

I have not done the system call stubs in sys_*.s.
I hope to avoid that, because those do not block, so those
frames will not appear in stack traces during garbage
collection.

R=golang-dev, dvyukov, khr
CC=golang-dev
https://golang.org/cl/11360043

9ddfb643

syscall: record argument size for all assembly functions · e69082ff

Russ Cox authored Jul 16, 2013

While we're here, fix Syscall9 on NetBSD and OpenBSD:
it was storing the results into the wrong memory locations.
I guess no one uses that function's results on those systems.

Part of cleaning up stack traces and argument frame information.

R=golang-dev, dvyukov
CC=golang-dev
https://golang.org/cl/11355044

e69082ff

cmd/5a, cmd/6a, cmd/8a: parse PCDATA · 47b89a37

Russ Cox authored Jul 16, 2013

In cmd/5a, also add support for argument size in TEXT instruction.

R=ken2
CC=golang-dev
https://golang.org/cl/11357044

47b89a37

cmd/5l, cmd/6l, cmd/8l: accept PCDATA instruction in input · 56781822

Russ Cox authored Jul 16, 2013

The portable code in cmd/ld already knows how to process it,
we just have to ignore it during code generation.

R=ken2
CC=golang-dev
https://golang.org/cl/11363043

56781822

test: invert incorrect condition. · 8fb6c3ac
Alan Donovan authored Jul 16, 2013
```
R=gri
CC=golang-dev
https://golang.org/cl/11359043
```
8fb6c3ac
runtime: minor cleanup of hashmap code · 1d55685e
Dmitriy Vyukov authored Jul 16, 2013
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/11357043
```
1d55685e

net: fix setsockopt for openbsd · 9bd32b48

Joel Sing authored Jul 16, 2013

s/TCP_KEEPALIVE/SO_KEEPALIVE/ to unbreak build on OpenBSD.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/11345044

9bd32b48

cmd/ld, runtime: new in-memory symbol table format · 5d363c63

Russ Cox authored Jul 16, 2013

Design at http://golang.org/s/go12symtab.

This enables some cleanup of the garbage collector metadata
that will be done in future CLs.

This CL does not move the old symtab and pclntab back into
an unmapped section of the file. That's a bit tricky and will be
done separately.

Fixes #4020.

R=golang-dev, dave, cshapiro, iant, r
CC=golang-dev, nigeltao
https://golang.org/cl/11085043

5d363c63

cmd/gc: do not race instrument syscall.forkAndExecInChild · 63e0ddc7

Dmitriy Vyukov authored Jul 16, 2013

Race instrumentation can allocate, switch stacks, preempt, etc.
All that is not allowed in between fork and exec.
Fixes #4840.

R=golang-dev, daniel.morsing, dave
CC=golang-dev
https://golang.org/cl/11324044

63e0ddc7

cmd/gc: fix incorrect error when using f(g()) form on ... args · 7e270cf6
Daniel Morsing authored Jul 16, 2013
```
Fixes #5358.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/11282044
```
7e270cf6
cmd/gc: complex types don't contain pointers · 4949dcb2
Evan Shaw authored Jul 16, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/11334043
```
4949dcb2

cmd/gc: fix race detector instrumentation of type switches. · a15074c4

Rémy Oudompheng authored Jul 16, 2013

A type switch on a value with map index expressions,
could get a spurious instrumentation from a OTYPESW node.
These nodes do not need instrumentation because after
walk the type switch has been turned into a sequence
of ifs.

Fixes #5890.

R=golang-dev, dvyukov
CC=golang-dev
https://golang.org/cl/11308043

a15074c4

runtime: switch to os stack in windows osyield and usleep · 45cff655
Alex Brainman authored Jul 16, 2013
```
Fixes #5831

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/11266043
```
45cff655

cmd/gc: tweak interface satisfaction error message · 2254785c

Russ Cox authored Jul 16, 2013

"M requires pointer receiver" can be misinterpreted to
mean that method M should have a pointer receiver but
does not. In fact the message means "M has a pointer
receiver" (and you don't have a pointer).

Fixes #5891.

R=ken2
CC=golang-dev
https://golang.org/cl/11313043

2254785c

15 Jul, 2013 8 commits

net: add SetKeepAlivePeriod · 918922cf

David Presotto authored Jul 15, 2013

Sets both the duration from the last data packet to the first
keep alive packet and the duration between keep alive packets to be
the passed duration.

I've tested the function on both Darwin (10.8.4) and 4.2 Linux.
I've compiled (make.bash) for all the OS's and tested (all.bash)
on Darwin and Linux.

R=golang-dev, dave, rsc, dvyukov, presotto+facebook, nick
CC=golang-dev, veyron-team
https://golang.org/cl/11130044

918922cf

CONTRIBUTORS: add David Presotto (Google CLA) · 4e3051c6
Russ Cox authored Jul 15, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/11299043
```
4e3051c6
runtime: minor test cleanup · 0a86b4da
Dmitriy Vyukov authored Jul 15, 2013
```
R=golang-dev, khr, rsc
CC=golang-dev
https://golang.org/cl/11280043
```
0a86b4da
misc/cgo/test: skip test for issue 3250, the runtime isn't ready yet. · 3d236aed
Shenghou Ma authored Jul 15, 2013
```
see issue 5885.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/10914045
```
3d236aed
image/gif: add writer implementation · 9ebc5be3
Andrew Bonventre authored Jul 15, 2013
```
R=r, nigeltao
CC=golang-dev
https://golang.org/cl/10896043
```
9ebc5be3

dist: fix postinstall script for Darwin · bbb51ae3

Alexandre Normand authored Jul 15, 2013

The postinstall script causes the installation to fail because the last
step that copies files for Xcode is broken. Two details can cause the
command to fail:
  1. The XCODE_MISC_DIR value has a space. Without quotes in the cp
     command, cp will just complain that this is an invalid syntax.
  2. The source of the cp is a directory with two subdirectories.
     We actually want the files for either Xcode 3 or Xcode 4 to be copied.
     Using xcodebuild -version, we check for the Xcode version and
     select which of xcode/3/* or xcode/4/* should be the source
     of the copy.

Fixes #5874.

R=golang-dev, minux.ma, adg
CC=golang-dev
https://golang.org/cl/10893044

bbb51ae3

A+C: Alexandre Normand (individual CLA) · 9653e282
Andrew Gerrand authored Jul 15, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/11257043
```
9653e282
A+C: Andrew Bonventre (individual CLA). · 33b0e3c0
Nigel Tao authored Jul 15, 2013
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/11256043
```
33b0e3c0

14 Jul, 2013 2 commits
- log/syslog: fix typo: change Wanring to Warning · 69c92420
  Joseph Holsten authored Jul 14, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/11220044
```
  69c92420
- A+C: Joseph Holsten (individual CLA) · 01bdeda8
  Rob Pike authored Jul 14, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/11245043
```
  01bdeda8
13 Jul, 2013 3 commits

cmd/6l, cmd/8l: use one-byte XCHG forms when possible · aad4720b
Russ Cox authored Jul 13, 2013
```
Pointed out by khr.

R=ken2
CC=golang-dev
https://golang.org/cl/11145044
```
aad4720b

encoding/json: add more tests for UTF-8 coercion · 4274d074

Russ Cox authored Jul 13, 2013

Suggested by Rob in CL 11211045, but the mail arrived
moments after hg submit completed.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/11138045

4274d074

cmd/go, testing: streamline direct use of test binaries · ccc45534

Russ Cox authored Jul 13, 2013

Before:

        $ go test -c -cover fmt
        $ ./fmt.test -test.covermode=set
        PASS
        coverage: 65.1% of statements in strconv
        $

After:

        $ go test -c -cover fmt
        $ ./fmt.test
        PASS
        coverage: 65.1% of statements in strconv
        $

In addition to being cumbersome, the old flag didn't make sense:
the cover mode cannot be changed after the binary has been built.

Another useful effect of this CL is that if you happen to do

        $ go test -c -covermode=atomic fmt

and then forget you did that and run benchmarks,
the final line of the output (the coverage summary) reminds you
that you are benchmarking with coverage enabled, which might
not be what you want.

        $ ./fmt.test -test.bench .
        PASS
        BenchmarkSprintfEmpty	10000000	       217 ns/op
        BenchmarkSprintfString	 2000000	       755 ns/op
        BenchmarkSprintfInt	 2000000	       774 ns/op
        BenchmarkSprintfIntInt	 1000000	      1363 ns/op
        BenchmarkSprintfPrefixedInt	 1000000	      1501 ns/op
        BenchmarkSprintfFloat	 1000000	      1257 ns/op
        BenchmarkManyArgs	  500000	      5346 ns/op
        BenchmarkScanInts	    1000	   2562402 ns/op
        BenchmarkScanRecursiveInt	     500	   3189457 ns/op
        coverage: 91.4% of statements
        $

As part of passing the new mode setting in via _testmain.go, merge
the two registration mechanisms into one extensible mechanism
(a struct).

R=r
CC=golang-dev
https://golang.org/cl/11219043

ccc45534