Commits · 5ad5b7a551b30d27d7af00e3e981014f4acd8bd4 · go / golang

12 Dec, 2013 4 commits

fmt: Fix signed zero-padding for positive floats · 5ad5b7a5

Felix Geisendörfer authored Dec 12, 2013

Space padding still has the same issue, I will send a separate patch for that
if this one gets accepted.
Fixes #6856.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/35660043

5ad5b7a5

A+C: Felix Geisendörfer (individual CLA) · 1d08fc44
Rob Pike authored Dec 12, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/40870048
```
1d08fc44

net, text/tabwriter: use cap arg to make · 563d0b62

Josh Bleecher Snyder authored Dec 12, 2013

Changes generated by:

gofmt -w -r 'make(a, b)[0:0] -> make(a, 0, b)' src/pkg

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/24820045

563d0b62

net: don't leave hostsPath unrestored on error in TestLookupStaticHost · cf51702b

Josh Bleecher Snyder authored Dec 12, 2013

If the return was reached, then hostsPath would not be properly restored
to its original value. See the (lengthy) discussion at
https://golang.org/cl/15960047/

I assume that this is not for Go 1.2; mailing now since I promised to do so.
I will plan to ping once Go 1.2 is out.

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/16200043

cf51702b

11 Dec, 2013 6 commits

crypto/x509: fix typo in comment. · 2f43ce7f
Adam Langley authored Dec 11, 2013
```
Fixes #6633.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/40720046
```
2f43ce7f

crypto/cipher: speed up xor operations in CBC, CFB, OBF, CTR · 5744be9f

Han-Wen Nienhuys authored Dec 11, 2013

and GCM on 386 and amd64

Intel(R) Core(TM) i5-2540M CPU @ 2.60GHz:

benchmark                    old MB/s     new MB/s  speedup
BenchmarkAESGCMSeal1K           82.39        92.05    1.12x
BenchmarkAESGCMOpen1K           82.28        91.88    1.12x
BenchmarkAESCFBEncrypt1K       141.54       277.59    1.96x
BenchmarkAESCFBDecrypt1K       133.06       278.07    2.09x
BenchmarkAESOFB1K              160.51       380.24    2.37x
BenchmarkAESCTR1K              164.07       429.25    2.62x
BenchmarkAESCBCEncrypt1K       170.99       263.74    1.54x
BenchmarkAESCBCDecrypt1K       124.96       249.14    1.99x

Fixes #6741.

R=agl, dave, agl
CC=golang-dev
https://golang.org/cl/24250044

5744be9f

cmd/5a, cmd/6a, cmd/8a: fix .y files to match y.tab.[ch] · 426b48a7

Russ Cox authored Dec 11, 2013

When I renamed LAddr back to Addr (before sending the
original linker CLs), I missed the .y files in my global substitute.
Since the .y files are only processed when running make in
one of those directories (not during all.bash), they were
behind the generated files.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/40770044

426b48a7

crypto/sha256: block implementation in amd64 assembly · 75800a9a

Joel Sing authored Dec 11, 2013

Benchmark on Intel(R) Xeon(R) CPU X5650  @ 2.67GHz

benchmark              old ns/op    new ns/op    delta
BenchmarkHash8Bytes         1259          677  -46.23%
BenchmarkHash1K            14387         6749  -53.09%
BenchmarkHash8K           106006        50107  -52.73%

benchmark               old MB/s     new MB/s  speedup
BenchmarkHash8Bytes         6.35        11.81    1.86x
BenchmarkHash1K            71.17       151.72    2.13x
BenchmarkHash8K            77.28       163.49    2.12x

R=agl
CC=golang-dev
https://golang.org/cl/28460043

75800a9a

net/http: document that body is closed after (*Request).Write. · 77fe6bef
Shenghou Ma authored Dec 11, 2013
```
Fixes #6911.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/38690043
```
77fe6bef

misc/dist: rename to makerelease · dba08e06

Andrew Gerrand authored Dec 11, 2013

The ambiguity has gone on too long.

R=golang-dev, minux.ma, r, dsymonds
CC=golang-dev
https://golang.org/cl/39920043

dba08e06

10 Dec, 2013 19 commits

doc/effective_go.html: close some tags. · b349477e
Oling Cat authored Dec 10, 2013
```
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/37700043
```
b349477e

test: don't rely on order of unrelated imports in bug191 · 6ae37805

Ian Lance Taylor authored Dec 10, 2013

There is no necessary relationship between the imports of the
packages a and b, and gccgo happens to import them in a
different order, leading to different output.  This ordering
is not the purpose of the test in any case.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/40400043

6ae37805

runtime: remove outdated comment and related indentation · c69402d8
Carl Shapiro authored Dec 10, 2013
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/39810043
```
c69402d8

crypto/x509: fix behaviour of KeyUsageAny. · ddbad5ef

Adam Langley authored Dec 10, 2013

(Reporter wasn't able to provide a certificate chain that uses this
feature for testing.)

Fixes #6831

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/40340043

ddbad5ef

test/run: make -v output look like go test output · de8549df

Russ Cox authored Dec 10, 2013

Among other things, it makes it easier to scan to
see what is slow.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/40040044

de8549df

test: add some test cases that were miscompiled by gccgo · 9bea6f3b
Ian Lance Taylor authored Dec 10, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/40310043
```
9bea6f3b
liblink, cmd/gc: fix incompatible type signatures on Plan 9 · 4321beba
David du Colombier authored Dec 10, 2013
```
R=ality, golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/39640043
```
4321beba

syscall: skip routing messages with mismatched version · 517e49eb

Joel Sing authored Dec 10, 2013

Skip routing messages with a mismatched version, rather than failing
and returning EINVAL. Only return EINVAL if we were unable to parse
any of the routing messages (presumably due to a version mismatch).

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/30340043

517e49eb

database/sql: Remove redundant condition in if · c8869e9c

Alberto García Hierro authored Dec 10, 2013

The final condition (db.maxIdleConnsLocked() > db.freeConn.Len()) can
only be true iff db.maxIdleConnsLocked() is greater than 0, so previously
checking if it's greater than 0 is a waste, specially when that involves
a method call which (ATM) can't be inlined and includes a switch.

Dissasembly follows (test for err == nil has been omitted for clarity):

Before:
43c357: cmp    $0x0,%bl
43c35a: jne    43c3ce <database/sql.(*DB).putConnDBLocked+0x1ce>
43c35c: mov    %rax,(%rsp)
43c360: callq  43aec0 <database/sql.(*DB).maxIdleConnsLocked>
43c365: mov    0x8(%rsp),%rbx
43c36a: cmp    $0x0,%rbx
43c36e: jle    43c3ce <database/sql.(*DB).putConnDBLocked+0x1ce>
43c370: mov    0x30(%rsp),%rbx
43c375: mov    %rbx,(%rsp)
43c379: callq  43aec0 <database/sql.(*DB).maxIdleConnsLocked>
43c37e: mov    0x30(%rsp),%rdx
43c383: mov    0x8(%rsp),%rcx
43c388: mov    0x28(%rdx),%rbp
43c38c: mov    0x28(%rbp),%rbx
43c390: cmp    %rcx,%rbx
43c393: jge    43c3ce <database/sql.(*DB).putConnDBLocked+0x1ce>
43c395: mov    0x28(%rdx),%rbp
43c399: mov    %rbp,(%rsp)
43c39d: mov    0x38(%rsp),%rcx
43c3a2: mov    $0x556c60,%eax
43c3a7: mov    %rax,0x8(%rsp)
43c3ac: mov    %rcx,0x10(%rsp)
43c3b1: callq  4db5b0 <container/list.(*List).PushFront>

After:
43c357: cmp    $0x0,%bl
43c35a: jne    43c3b5 <database/sql.(*DB).putConnDBLocked+0x1b5>
43c35c: mov    %rax,(%rsp)
43c360: callq  43aec0 <database/sql.(*DB).maxIdleConnsLocked>
43c365: mov    0x30(%rsp),%rdx
43c36a: mov    0x8(%rsp),%rcx
43c36f: mov    0x28(%rdx),%rbp
43c373: mov    0x28(%rbp),%rbx
43c377: cmp    %rcx,%rbx
43c37a: jge    43c3b5 <database/sql.(*DB).putConnDBLocked+0x1b5>
43c37c: mov    0x28(%rdx),%rbp
43c380: mov    %rbp,(%rsp)
43c384: mov    0x38(%rsp),%rcx
43c389: mov    $0x556c60,%eax
43c38e: mov    %rax,0x8(%rsp)
43c393: mov    %rcx,0x10(%rsp)
43c398: callq  4db590 <container/list.(*List).PushFront>

R=golang-dev, bradfitz, iant
CC=golang-dev
https://golang.org/cl/14656044

c8869e9c

net: fix nits found by go tool vet · e5a7ab85
Mikio Hara authored Dec 10, 2013
```
R=golang-dev, dave, adg
CC=golang-dev
https://golang.org/cl/27430043
```
e5a7ab85

os: fix build. · a4b66b77

Shenghou Ma authored Dec 10, 2013

CL 36800043 and CL 36930044 have a merge conflict that I overlooked.

R=golang-dev
CC=golang-dev
https://golang.org/cl/39850043

a4b66b77

crypto/rand: support generation of 2-5 bit primes, also document the error return for Prime · 4f2cfdc7
Shenghou Ma authored Dec 10, 2013
```
Fixes #6849.
Fixes #6867.

R=golang-dev, agl
CC=golang-dev
https://golang.org/cl/35870043
```
4f2cfdc7

os: clarify docs for Rename. · aa0ae755

Shenghou Ma authored Dec 10, 2013

Three changes:
1. mention "move" to clarify things up.
2. use {old,new}path instead of {old,new}name, which makes it clear what
   relative path would do here.
3. mention "OS-specific restrictions might apply".

Fixes #6887.

R=golang-dev, alex.brainman, iant, r
CC=golang-dev
https://golang.org/cl/36930044

aa0ae755

strconv: add example for Unquote. · 46d1461a
Shenghou Ma authored Dec 10, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/38920043
```
46d1461a

runtime: check for signed zero in printfloat · f574726f

Carl Shapiro authored Dec 10, 2013

Fixes #6899

R=golang-dev, r, cshapiro, iant, rsc
CC=golang-dev
https://golang.org/cl/38120043

f574726f

misc/cgo/testcdefs: rm correct file in test.bash · 6ede9349
Alex Brainman authored Dec 10, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/39780043
```
6ede9349

cmd/pack: stop parsing object files to generate __.SYMDEF · 4c01a23c

Russ Cox authored Dec 10, 2013

Nothing looks at __.SYMDEF, and the object file format is changing.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/39580044

4c01a23c

runtime: remove non-extern decls of runtime.goarm · 4230044b

Russ Cox authored Dec 10, 2013

The linker is in charge of providing the one true declaration.

R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/39560043

4230044b

cmd/cgo: use __gcc_struct__ for go exported functions · 67956874
Alex Brainman authored Dec 10, 2013
```
Fixes #6833

R=minux.ma, iant
CC=golang-dev
https://golang.org/cl/35790045
```
67956874

09 Dec, 2013 11 commits

liblink: fix extern register accesses on Plan 9 (386) · 52ee63f5
Anthony Martin authored Dec 09, 2013
```
R=golang-dev, 0intro, rsc
CC=golang-dev
https://golang.org/cl/39680044
```
52ee63f5

cmd/8c, cmd/8g, cmd/8l: fix Plan 9 warnings · 58005207

David du Colombier authored Dec 09, 2013

warning: src/cmd/8c/list.c:124 format mismatch d VLONG, arg 3
warning: src/cmd/8c/list.c:134 format mismatch d VLONG, arg 3
warning: src/cmd/8c/list.c:142 format mismatch d VLONG, arg 3
warning: src/cmd/8c/list.c:152 format mismatch d VLONG, arg 3
warning: src/cmd/8c/list.c:156 format mismatch d VLONG, arg 4
warning: src/cmd/8c/list.c:160 format mismatch d VLONG, arg 4
warning: src/cmd/8c/list.c:165 format mismatch d VLONG, arg 4
warning: src/cmd/8c/list.c:167 format mismatch d VLONG, arg 3
warning: src/cmd/8c/list.c:172 format mismatch d VLONG, arg 4
warning: src/cmd/8c/list.c:174 format mismatch d VLONG, arg 3
warning: src/cmd/8c/list.c:178 format mismatch d VLONG, arg 3
warning: src/cmd/8c/list.c:184 format mismatch d VLONG, arg 3

warning: src/cmd/8g/list.c:91 format mismatch d VLONG, arg 4
warning: src/cmd/8g/list.c:100 format mismatch d VLONG, arg 4
warning: src/cmd/8g/list.c:114 format mismatch d VLONG, arg 5
warning: src/cmd/8g/list.c:118 format mismatch d VLONG, arg 5
warning: src/cmd/8g/list.c:122 format mismatch d VLONG, arg 5
warning: src/cmd/8g/list.c:126 format mismatch d VLONG, arg 5
warning: src/cmd/8g/list.c:136 format mismatch d VLONG, arg 4

warning: src/cmd/8l/list.c:107 format mismatch d VLONG, arg 4
warning: src/cmd/8l/list.c:125 format mismatch ux VLONG, arg 4
warning: src/cmd/8l/list.c:128 format mismatch ux VLONG, arg 4
warning: src/cmd/8l/list.c:130 format mismatch d VLONG, arg 4
warning: src/cmd/8l/list.c:134 format mismatch d VLONG, arg 5
warning: src/cmd/8l/list.c:138 format mismatch d VLONG, arg 6
warning: src/cmd/8l/list.c:143 format mismatch d VLONG, arg 5
warning: src/cmd/8l/list.c:148 format mismatch d VLONG, arg 5
warning: src/cmd/8l/list.c:150 format mismatch d VLONG, arg 4
warning: src/cmd/8l/list.c:154 format mismatch d VLONG, arg 4
warning: src/cmd/8l/list.c:158 format mismatch d VLONG, arg 4
warning: src/cmd/8l/obj.c:132 format mismatch ux VLONG, arg 2

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/39710043

58005207

runtime: do not use memmove in the Plan 9 signal handler · 274a8e3f

Anthony Martin authored Dec 09, 2013

Fixes a regression introduced in revision 4cb93e2900d0.

That revision changed runtime·memmove to use SSE MOVOU
instructions for sizes between 17 and 256 bytes. We were
using memmove to save a copy of the note string during
the note handler. The Plan 9 kernel does not allow the
use of floating point in note handlers (which includes
MOVOU since it touches the XMM registers).

Arguably, runtime·memmove should not be using MOVOU when
GO386=387 but that wouldn't help us on amd64. It's very
important that we guard against any future changes so we
use a simple copy loop instead.

This change is extracted from CL 9796043 (since that CL
is still being ironed out).

R=rsc
CC=golang-dev
https://golang.org/cl/34640045

274a8e3f

.hgignore: ignore liblink/anames?.c · dba4d11e
Russ Cox authored Dec 09, 2013
```
R=golang-dev, minux.ma, iant
CC=golang-dev
https://golang.org/cl/36300045
```
dba4d11e
build: do not use the host's libbio on Plan 9 · 66c32384
Anthony Martin authored Dec 09, 2013
```
R=jas, lucio.dere, rsc
CC=golang-dev
https://golang.org/cl/14604047
```
66c32384

cmd/gc, runtime: correct a misnomer regarding dead value maps · bc9691c4

Carl Shapiro authored Dec 09, 2013

The funcdata symbol incorrectly named the dead value map the
dead pointer map.  The dead value map identifies all dead
values, including pointers and non-pointers, in a stack frame.
The purpose of this map is to allow the runtime to poison
locations of dead data to catch lost invariants.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/38670043

bc9691c4

cmd/gc: fix windows build, probably · 9a53fb57
Russ Cox authored Dec 09, 2013
```
TBR=iant
CC=golang-dev
https://golang.org/cl/39540043
```
9a53fb57
cmd/6l: fix linux/amd64 · 1eac128d
Russ Cox authored Dec 09, 2013
```
TBR=iant
CC=golang-dev
https://golang.org/cl/39530043
```
1eac128d
cmd/dist, cmd/go: pass -fmessage-length always · 65a643ba
Russ Cox authored Dec 09, 2013
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/36300044
```
65a643ba
cmd/gc: print more information for windows failure · 295e73e1
Russ Cox authored Dec 09, 2013
```
TBR=iant
CC=golang-dev
https://golang.org/cl/39510043
```
295e73e1
cmd/ld: fix linux/386 build · 0c0589ec
Russ Cox authored Dec 09, 2013
```
TBR=iant
CC=golang-dev
https://golang.org/cl/39400044
```
0c0589ec