- 29 May, 2018 3 commits
-
-
Aarti Parikh authored
This is a simple but everyday use case in image libraries. Currently, there is one example in this library and it is lengthy and involved. This PR will be imported into Gerrit with the title and first comment (this text) used to generate the subject and body of the Gerrit change. Change-Id: Idca527d97c095af88755446e1548fa2b8ace7eb0 GitHub-Last-Rev: f5743c8ef337a8b7a5126db21d784593f4f53c8a GitHub-Pull-Request: golang/go#25616 Reviewed-on: https://go-review.googlesource.com/114939 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Josh Bleecher Snyder authored
Change-Id: I04880d87e317a1140ec12da6ec5e788991719760 Reviewed-on: https://go-review.googlesource.com/114936Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Josh Bleecher Snyder authored
Change-Id: I8b462e20064658120afc8eb1cbac926254d1e24e Reviewed-on: https://go-review.googlesource.com/114937 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 28 May, 2018 4 commits
-
-
Ian Lance Taylor authored
Fixes #25611 Change-Id: I487463584e4d9d99cf5d8db0c9a4b4e66464ecd8 Reviewed-on: https://go-review.googlesource.com/114935 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Alexander F Rødseth authored
* Fix typos in the comments in the assembly code for the crypto package. Change-Id: Iac146a7d8bee4a680a8d4d3af533fbc1b259482d GitHub-Last-Rev: 65090a38956df4c14bf55df4881c76e8c3d32447 GitHub-Pull-Request: golang/go#25606 Reviewed-on: https://go-review.googlesource.com/114803Reviewed-by:
-
Yury Smolsky authored
This change uses errorCheck and wantedErrors functions copied from the test/run.go to eliminate use of the test/errchk perl script. Tests' error messages that contained full filenames were changed to have base filenames because the errorCheck function processes output from "go vet" in the same way. Fixes #20032. Change-Id: Ieb7be67c2d7281b9648171c698398449b7e2d4dd Reviewed-on: https://go-review.googlesource.com/114176 Run-TryBot: Yury Smolsky <yury@smolsky.by> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Alan Donovan <adonovan@google.com>
-
David Symonds authored
If a span of coverable code is empty (e.g. an empty select clause) then there will be two Boundary values with the same offset. In that case, the starting Boundary needs to come first so that the generated HTML output will open the <span> tag before it tries to close it. Change-Id: Ib44a8b7c36ae57757c18b6cceb7a88ffa4e95394 Reviewed-on: https://go-review.googlesource.com/114855Reviewed-by:
Rob Pike <r@golang.org> Run-TryBot: Rob Pike <r@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 27 May, 2018 1 commit
-
-
Ian Lance Taylor authored
We look for "-o /dev/null", and, if found, pretend that there was no "-o" option and don't generate an action to create the final executable. We look for "go build x.go", and, if found, and if -o was not used, pretend that the user specified "-o x". Unfortunately, we were doing those in the wrong order, so that "go build -o /dev/null x.go" would first clear the "-o" option and then set it to "-o x". This CL flips the order so that the right thing happens. Fixes #25579 Change-Id: Ic9556ac0a57f7b45b685951bc96ba5ea4633b860 Reviewed-on: https://go-review.googlesource.com/114715 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 26 May, 2018 5 commits
-
-
Elias Naur authored
I don't know why these files were not formatted. Perhaps because their changes came from Github PRs? Change-Id: Ida8d7b9a36f0d1064caf74ca1911696a247a9bbe Reviewed-on: https://go-review.googlesource.com/114824 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Yuval Pavel Zholkover authored
In golang.org/cl/102355 I mistakenly used 26 instead of 25 as the AT_HWCAP value. 26 is AT_HWCAP2. While experimenting with FreeBSD-11.2-BETA3 (where both values are being supplied in the auxv), the AT_HWCAP2 value read is 0 which triggers the error again: runtime: this CPU has no floating point hardware, so it cannot run this GOARM=7 binary. Recompile using GOARM=5. Updates #24507. Change-Id: Ide04b7365d8f10e4650edf4e188dd58bdf42cc26 Reviewed-on: https://go-review.googlesource.com/114822Reviewed-by:
-
Yury Smolsky authored
This change enables bug248 to be tested with Go code. For that, it adds a flag -1 to error check and run directory with one package failing compilation prior the last package which should be run. Specifically, the "p" package in bug1.go file was renamed into "q" to compile them in separate steps, bug2.go and bug3.go files were reordered, bug2.go was changed into non-main package. Updates #25586. Change-Id: Ie47aacd56ebb2ce4eac66c792d1a53e1e30e637c Reviewed-on: https://go-review.googlesource.com/114818 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Alex Brainman authored
go build command is short for go build . and it builds . package. When command above is executed from directory inside of GOPATH, it uses GOPATH to calculate package source directory. So . package uses GOPATH as part of package source directory. On the other hand go build -ldflags=abc only passes flag to the linker for packages that are listed on the command line. The command above assumes . package again, and that package source path is compared with current directory. Current code compares result of os.Getwd with what GOPATH environment variable contains. But these values might differ in letter case on Windows. For example, one might return c:\gopath\..., while the other might contain C:\GOPATH. Fixes #24750 Fixes #24232 Fixes #25046 Change-Id: I03d8c7a9b73e847f88ae61c88cd41efa546c6d0e Reviewed-on: https://go-review.googlesource.com/109235 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Alex Brainman authored
Updates #6751 Change-Id: Ibb176a17e67c67f855bc4f3e5462dddaedaa8a58 Reviewed-on: https://go-review.googlesource.com/114755 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 25 May, 2018 6 commits
-
-
Than McIntosh authored
Fix a problem in DWARF inline debug generation relating to handling of statically unreachable local variables. For a function such as: const always = true func HasDeadLocal() int { if always { return 9 } x := new(Something) ... return x.y } the variable "x" is placed onto the Dcl list for the function during parsing, but the actual declaration node is deleted later on when gc.Main invokes "deadcode". Later in the compile the DWARF code emits an abstract function with "x" (since "x" was on the Dcl list at the point of the inline), but the export data emitted does not contain "x". This then creates clashing/inconsistant DWARF abstract function DIEs later on if HasDeadLocal is inlined in somewhere else. As a fix, the inliner now pruned away variables such as "x" when creating a copy of the Dcl list as part of the inlining; this means that both the export data generator and the DWARF emitter wind up seeing a consistent picture. Fixes #25459 Change-Id: I753dc4e9f9ec694340adba5f43c907ba8cc9badc Reviewed-on: https://go-review.googlesource.com/114090 Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:Heschi Kreinick <heschi@google.com>
-
Tobias Klauser authored
While fixing some failing tests, CL 114416 also picked up the newly added TestXattr from golang.org/x/sys/unix which fails on android. Pick up CL 114535 to fix it as well. Also pick up CL 114616 to fix TestStatx occasionally failing on linux. Change-Id: I6ebebd7761fa7a086d96ee0447dbbc5c6b94131d Reviewed-on: https://go-review.googlesource.com/114575 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Martin Möhrmann authored
This also allows the GODEBUGCPU options to change the support_* runtime cpu feature variable values. Change-Id: I884c5f03993afc7e3344ff2fd471a2c6cfde43d4 Reviewed-on: https://go-review.googlesource.com/114615 Run-TryBot: Martin Möhrmann <moehrmann@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Josh Bleecher Snyder authored
-W and -w turn on printing of Nodes for both order and walk. I have found their output mildly incomprehensible for years. Improve it, at long last. Change-Id: Ia05d77e59aa741c2dfc9fcca07f45019420b655e Reviewed-on: https://go-review.googlesource.com/114520 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by:
-
Josh Bleecher Snyder authored
Comment changes only. Change-Id: I3f9c1c38ae6b4989f02b62fff09265e4bcb934f7 Reviewed-on: https://go-review.googlesource.com/114519 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Zhou Peng authored
This file was checked in CL 103535. Change-Id: I03e36ba36e30444c4f8e394caef9224ecd6dd728 GitHub-Last-Rev: 6b7fb62f824c5c68be800aa98cf10241b48b1cc4 GitHub-Pull-Request: golang/go#25559 Reviewed-on: https://go-review.googlesource.com/114521Reviewed-by:
Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 24 May, 2018 10 commits
-
-
Ian Lance Taylor authored
When using gccgo/GoLLVM, there is no package file for a standard library package. Since it is impossible for the go tool to rebuild the package, and since the package file exists only in the form of a .gox file, this seems like the best choice. Unfortunately it was confusing vet, which wanted to see a real file. This caused vet to report errors about missing package files for standard library packages. The gccgoimporter knows how to correctly handle this case. Fix this by 1) telling vet which packages are standard; 2) letting vet skip those packages; 3) letting the gccgoimporter handle this case. As a separate required fix, gccgo/GoLLVM has no runtime/cgo package, so don't try to depend on it (as it happens, this fixes #25324). The result is that the cmd/go vet tests pass when using -compiler=gccgo. Fixes #25324 Change-Id: Iba8f948fe944da5dc674f580bd3321929ee50fa0 Reviewed-on: https://go-review.googlesource.com/113716 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
Bryan C. Mills <bcmills@google.com> Reviewed-by:
Than McIntosh <thanm@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Jonathan Chen authored
Change-Id: I6eb182968a8e00fe359d812f1eefc9bda896395b GitHub-Last-Rev: a354b4d2168ed4f1f1744c99c36ece276a24e046 GitHub-Pull-Request: golang/go#25540 Reviewed-on: https://go-review.googlesource.com/114318Reviewed-by:
-
Tobias Klauser authored
Pick up the changes from CL 114395, CL 114396 and CL 114415. By re-running govendor in the latest version, some files from golang.org/x/sys/unix which are ignored for the build also got removed from the vendored copy. Updates #25528 Updates #25535 Change-Id: I5c0002fc3a37d6abaafed2e15cc3e2ade803ad7b Reviewed-on: https://go-review.googlesource.com/114416 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by:
-
Hana Kim authored
TestMutexProfile and TestEmptyCallStack couldn't run multiple times because they mutate state in runtime (mutex profile counters and a user-defined profile type) and test whether the state matches what it is supposed to be after the very first run. We fix TestMutexProfile by relaxing the expected state condition. We fix TestEmptyCallStack by creating a new profile with a different name every time the test runs. For #25520 Change-Id: I8e50cd9526eb650c8989457495ff90a24ce07863 Reviewed-on: https://go-review.googlesource.com/114495 Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #25546 Change-Id: I00457b370ed6dcd7ee9efcae3fd914e4c384b12c Reviewed-on: https://go-review.googlesource.com/114475 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Andrew Bonventre <andybons@golang.org>
-
Brad Fitzpatrick authored
This changes the http.Transport to flush the bufio.Writer between writing the request headers and the body. That wasn't done in the past to minimize the number of TCP packets on the wire, but that's just an optimization, and it causes problems when servers are waiting for the headers and the client is blocked on something before reading the body. Instead, only do the don't-flush optimization if we know we're not going to block, whitelisting a set of common in-memory Request.Body types. (the same set of types special-cased by http.NewRequest) Fixes #22088 Change-Id: I7717750aa6df32dd3eb92d181b45bc7af24b1144 Reviewed-on: https://go-review.googlesource.com/114316 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Peter Weinberger authored
This reverts commit 1764609b. Reason for revert: It breaks the dragonfly trybot, in which there are sometimes (non-deterministically) Events with the same timestamp that have to occur in a specific order. Change-Id: I714e640c6ab5ccb23d5577e8aa98c7716ede7ad2 Reviewed-on: https://go-review.googlesource.com/114356Reviewed-by:
-
Richard Musiol authored
This commit fixes a regression with wasm caused by a367f44c. It adds optimizations to the lowering rules of wasm to ensure that the lowered version of the code generated for write barriers is simple enough so it can be processed by Liveness.markUnsafePoints. Change-Id: Ic98f0dd3791fe1df23dcb34d2457fbde7ffce441 Reviewed-on: https://go-review.googlesource.com/114375 Run-TryBot: Cherry Zhang <cherryyz@google.com> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Robert Griesemer authored
Embedded interfaces in interfaces must take the form of a (possibly qualified) type name. Before alias types, a type name always denoted a defined (formerly "named") type. The introduction of alias types enabled embedding of non-defined types via alias type names, as in: type T interface { E } type E interface { m() } Both cmd/compile and gccgo accept this kind of code, and the spec does not prohibit it. There may be code in the wild that makes use of this. go/types was written under the assumption that embedded interfaces were always defined types; and that assumption was even reflected in the go/types API. This change removes this restriction in the implementation (which happens to make it simpler), and in the API (by adding additional functions and deprecating the corresponding older versions). It also replaces uses of NewInterface and Embedded (old API) by NewInterface2 and EmbeddedType (new API) in dependent packages (importers). The old API remains in place for backward compatibility and is marked as deprecated. Fixes #25301. Change-Id: I272acd498754179efaf0590ca49d3eb4eee4348e Reviewed-on: https://go-review.googlesource.com/114317Reviewed-by: -
Austin Clements authored
TestDebugCall* uses atomic spin loops and hence can deadlock if the garbage collector is enabled (because of #10958; ironically, implementing debugger call injection is closely related to fixing this exact issue, but we're not there yet). Fix this by disabling the garbage collector during these tests. Updates #25519 (might fix it, though I suspect not) Change-Id: If1e454b9cdea8e4b1cd82509b762c75b6acd8476 Reviewed-on: https://go-review.googlesource.com/114086 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Keith Randall <khr@golang.org>
-
- 23 May, 2018 11 commits
-
-
Heschi Kreinick authored
Apparently a LoadReg can take a Phi as its argument. The Phi has names in the NamedValue table, so just read the Load's names from the Phi. The example given, XORKeyStream in chacha20, is pretty complicated so I didn't try to actually debug it and verify that the results are right. But the debug logging looks reasonable, with the right names in the right registers at the right times. Fixes #25404 Change-Id: I2c3183dcfb033948556d6805bd66c22c0b45625c Reviewed-on: https://go-review.googlesource.com/114008 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
David Chase <drchase@google.com>
-
Heschi Kreinick authored
Remove the unexpected function, which is a lot less relevant now that the generation basically can't detect invalid states, and make sure no logging appears without -d locationlists=2. Updates #25404 Change-Id: If3522df5a7397f2e7b43cb808936e319132132b6 Reviewed-on: https://go-review.googlesource.com/114007 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Alexander Döring authored
For #23221. Change-Id: If55dcf2e0706d6658f4a0863e3740437e008706c Reviewed-on: https://go-review.googlesource.com/114335 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Robert Griesemer <gri@golang.org>
-
Anit Gandhi authored
When the internal/cpu package was introduced, the AES package still used the custom crypto/internal/cipherhw package for amd64 and s390x. This change removes that package entirely in favor of directly referencing the cpu feature flags set and exposed by the internal/cpu package. In addition, 5 new flags have been added to the internal/cpu s390x struct for detecting various cipher message (KM) features. Change-Id: I77cdd8bc1b04ab0e483b21bf1879b5801a4ba5f4 GitHub-Last-Rev: a611e3ecb1f480dcbfce3cb0c8c9e4058f56c1a4 GitHub-Pull-Request: golang/go#24766 Reviewed-on: https://go-review.googlesource.com/105695Reviewed-by:
-
Richard Musiol authored
Go's SSA instructions only operate on registers. For example, an add instruction would read two registers, do the addition and then write to a register. WebAssembly's instructions, on the other hand, operate on the stack. The add instruction first pops two values from the stack, does the addition, then pushes the result to the stack. To fulfill Go's semantics, one needs to map Go's single add instruction to 4 WebAssembly instructions: - Push the value of local variable A to the stack - Push the value of local variable B to the stack - Do addition - Write value from stack to local variable C Now consider that B was set to the constant 42 before the addition: - Push constant 42 to the stack - Write value from stack to local variable B This works, but is inefficient. Instead, the stack is used directly by inlining instructions if possible. With inlining it becomes: - Push the value of local variable A to the stack (add) - Push constant 42 to the stack (constant) - Do addition (add) - Write value from stack to local variable C (add) Note that the two SSA instructions can not be generated sequentially anymore, because their WebAssembly instructions are interleaved. Design doc: https://docs.google.com/document/d/131vjr4DH6JFnb-blm_uRdaC0_Nv3OUwjEY5qVCxCup4 Updates #18892 Change-Id: Ie35e1c0bebf4985fddda0d6330eb2066f9ad6dec Reviewed-on: https://go-review.googlesource.com/103535 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Hana Kim authored
Update golang/go#25528 Update golang/go#25529 Change-Id: I47ec282e76eb7740547e220ac00d6a7992e17b9e Reviewed-on: https://go-review.googlesource.com/114094Reviewed-by:
-
Alexander Döring authored
Currently we use three different algorithms for squaring: 1. basic multiplication for small numbers 2. basic squaring for medium numbers 3. Karatsuba multiplication for large numbers Change 3. to a version of Karatsuba multiplication specialized for x == y. Increasing the performance of 3. lets us lower the threshold between 2. and 3. Adapt TestCalibrate to the change that 3. isn't independent of the threshold between 1. and 2. any more. Fixes #23221. benchstat old.txt new.txt name old time/op new time/op delta NatSqr/1-4 29.6ns ± 7% 29.5ns ± 5% ~ (p=0.103 n=50+50) NatSqr/2-4 51.9ns ± 1% 51.9ns ± 1% ~ (p=0.693 n=42+49) NatSqr/3-4 64.3ns ± 1% 64.1ns ± 0% -0.26% (p=0.000 n=46+43) NatSqr/5-4 93.5ns ± 2% 93.1ns ± 1% -0.39% (p=0.000 n=48+49) NatSqr/8-4 131ns ± 1% 131ns ± 1% ~ (p=0.870 n=46+49) NatSqr/10-4 175ns ± 1% 175ns ± 1% +0.38% (p=0.000 n=49+47) NatSqr/20-4 426ns ± 1% 429ns ± 1% +0.84% (p=0.000 n=46+48) NatSqr/30-4 702ns ± 2% 699ns ± 1% -0.38% (p=0.011 n=46+44) NatSqr/50-4 1.44µs ± 2% 1.43µs ± 1% -0.54% (p=0.010 n=48+48) NatSqr/80-4 2.85µs ± 1% 2.87µs ± 1% +0.68% (p=0.000 n=47+47) NatSqr/100-4 4.06µs ± 1% 4.07µs ± 1% +0.29% (p=0.000 n=46+45) NatSqr/200-4 13.4µs ± 1% 13.5µs ± 1% +0.73% (p=0.000 n=48+48) NatSqr/300-4 28.5µs ± 1% 28.2µs ± 1% -1.22% (p=0.000 n=46+48) NatSqr/500-4 81.9µs ± 1% 67.0µs ± 1% -18.25% (p=0.000 n=48+48) NatSqr/800-4 161µs ± 1% 140µs ± 1% -13.29% (p=0.000 n=47+48) NatSqr/1000-4 245µs ± 1% 207µs ± 1% -15.17% (p=0.000 n=49+49) go test -v -calibrate --run TestCalibrate ... Calibrating threshold between basicSqr(x) and karatsubaSqr(x) Looking for a timing difference for x between 200 - 500 words by 10 step words = 200 deltaT = -980ns ( -7%) is karatsubaSqr(x) better: false words = 210 deltaT = -773ns ( -5%) is karatsubaSqr(x) better: false words = 220 deltaT = -695ns ( -4%) is karatsubaSqr(x) better: false words = 230 deltaT = -570ns ( -3%) is karatsubaSqr(x) better: false words = 240 deltaT = -458ns ( -2%) is karatsubaSqr(x) better: false words = 250 deltaT = -63ns ( 0%) is karatsubaSqr(x) better: false words = 260 deltaT = 118ns ( 0%) is karatsubaSqr(x) better: true threshold found words = 270 deltaT = 377ns ( 1%) is karatsubaSqr(x) better: true words = 280 deltaT = 765ns ( 3%) is karatsubaSqr(x) better: true words = 290 deltaT = 673ns ( 2%) is karatsubaSqr(x) better: true words = 300 deltaT = 502ns ( 1%) is karatsubaSqr(x) better: true words = 310 deltaT = 629ns ( 2%) is karatsubaSqr(x) better: true words = 320 deltaT = 1.011µs ( 3%) is karatsubaSqr(x) better: true words = 330 deltaT = 1.36µs ( 4%) is karatsubaSqr(x) better: true words = 340 deltaT = 3.001µs ( 8%) is karatsubaSqr(x) better: true words = 350 deltaT = 3.178µs ( 8%) is karatsubaSqr(x) better: true ... Change-Id: I6f13c23d94d042539ac28e77fd2618cdc37a429e Reviewed-on: https://go-review.googlesource.com/105075 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Andrew Bonventre authored
Change-Id: I82c03dd026bb797a49b7361389373924acf6366c Reviewed-on: https://go-review.googlesource.com/114085Reviewed-by:
Russ Cox <rsc@golang.org>
-
Hana (Hyang-Ah) Kim authored
The upstream pprof implements the readline feature using the github.com/chzyer/readline package in its pprof.go main. It would be ideal to use the same readline support package as the upstream for better user experience and code maintenance. However, bringing in third-party packages requires more work than I envisioned (e.g. clean up the vendored code to meet the expected standard - iow don't break builders). As a result, this change implements the similar feature for the pprof command included in the go distribution (cmd/pprof/pprof.go) using golang.org/x/crypto/ssh/terminal for now. Auto-completion is not yet supported (same in the upstream). The feature is enabled only in linux, windows, darwin, and only when terminal support is available. This change brings in new vendored packages, golang.org/x/crypto/ssh/terminal and golang.org/x/sys/{unix,windows}. For #14041 Change-Id: If4a790796acf2ab20f7e81268b9d9354c5a5cd2b Reviewed-on: https://go-review.googlesource.com/112436 Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: -
Richard Musiol authored
This partially reverts commit 3bdbb5df. The latest CL of js/wasm's file system support does not use file descriptor mapping any more. Change-Id: Iaec9c84b392366282cddc69acc75c8a3eb556824 Reviewed-on: https://go-review.googlesource.com/114195Reviewed-by:
-
Adam Medzinski authored
The current documentation of the WriteTo function is very poor and it is difficult to deduce how to use it correctly. A good example will make things much easier. Fixes #25456 Change-Id: Ibf0c0e153afae8f3e0d7d765d0dc9bcbfd69bfb1 Reviewed-on: https://go-review.googlesource.com/113775 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
