Commits · 5d2cfc2faa193a81f4a03aee03c60ef26ba8ed19 · go / golang

19 Jun, 2012 6 commits

doc/articles/slices_usage_and_internals: fix typo · 5d2cfc2f
Shenghou Ma authored Jun 19, 2012
```
        Fixes #3753.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6304097
```
5d2cfc2f

runtime: fix struct Sigaction for Linux/ARM · d4c4f4d2

Shenghou Ma authored Jun 19, 2012

        if we were to use sizeof(sa.sa_mask) instead of 8 as the last argument
        to rt_sigaction, we would have already fixed this bug, so also updated
        Linux/386 and Linux/amd64 files to use that; also test the return value
        of rt_sigaction.

R=dave, rsc
CC=golang-dev
https://golang.org/cl/6297087

d4c4f4d2

net/http: make client await response concurrently with writing request · a5aa91b9

Brad Fitzpatrick authored Jun 19, 2012

If the server replies with an HTTP response before we're done
writing our body (for instance "401 Unauthorized" response), we
were previously ignoring that, since we returned our write
error ("broken pipe", etc) before ever reading the response.
Now we read and write at the same time.

Fixes #3595

R=rsc, adg
CC=golang-dev
https://golang.org/cl/6238043

a5aa91b9

net/http: clarify client return values in docs · e1d9fcd2

Brad Fitzpatrick authored Jun 19, 2012

Also, fixes one violation found during testing where both
response and error could be non-nil when a CheckRedirect test
failed.  This is arguably a minor API (behavior, not
signature) change, but it wasn't documented either way and was
inconsistent & non-Go like.  Any code depending on the old
behavior was wrong anyway.

R=adg, rsc
CC=golang-dev
https://golang.org/cl/6307088

e1d9fcd2

go/ast: multiple "blank" imports are permitted · ca2ae27d
Robert Griesemer authored Jun 19, 2012
```
R=rsc, dsymonds
CC=golang-dev
https://golang.org/cl/6303099
```
ca2ae27d
bytes: fixed typo. · 9c975440
Marcel van Lohuizen authored Jun 19, 2012
```
R=r
CC=golang-dev
https://golang.org/cl/6301096
```
9c975440

18 Jun, 2012 2 commits
- net/url: sort keys in Encode; don't enumerate map randomly · 61809cd1
  Brad Fitzpatrick authored Jun 18, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6303098
```
  61809cd1
- A+C: Christine Hansmann (individual CLA) · f3474890
  Adam Langley authored Jun 18, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6312045
```
  f3474890
15 Jun, 2012 3 commits

go/ast: Walk: do not walk comment list · 417a7f80

Robert Griesemer authored Jun 15, 2012

A comment to that effect was introduced
with rev d332f4b9cef5 but the respective
code wasn't deleted.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6304086

417a7f80

doc: delete Mercurial Queues doc · 18b28197

Shenghou Ma authored Jun 15, 2012

        Fixes #3716.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6310044

18b28197

exp/html/atom: add some more atoms. · 834edc42
Nigel Tao authored Jun 15, 2012
```
R=r, dsymonds
CC=golang-dev
https://golang.org/cl/6298085
```
834edc42

14 Jun, 2012 5 commits

exp/types: clean up objects after test · 98526142

Shenghou Ma authored Jun 14, 2012

        Fixes #3739.

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/6295083

98526142

crypto/elliptic: fix doc typo · a11e74da

Shenghou Ma authored Jun 14, 2012

        Fixes #3735.

R=golang-dev, agl
CC=golang-dev
https://golang.org/cl/6301083

a11e74da

tag go1.0.2 · 71a1673c

Andrew Gerrand authored Jun 14, 2012

R=golang-dev, rsc, dsymonds, minux.ma
CC=golang-dev
https://golang.org/cl/6305089

71a1673c

doc: document go1.0.2 · 00e8a3ae
Andrew Gerrand authored Jun 14, 2012
```
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6298079
```
00e8a3ae

cmd/gc: inline convT2E when T is uintptr-shaped. · 8f84328f

Nigel Tao authored Jun 14, 2012

GOARCH=amd64 benchmarks

src/pkg/runtime
benchmark                  old ns/op    new ns/op    delta
BenchmarkConvT2ESmall             10           10   +1.00%
BenchmarkConvT2EUintptr            9            0  -92.07%
BenchmarkConvT2EBig               74           74   -0.27%
BenchmarkConvT2I                  27           26   -3.62%
BenchmarkConvI2E                   4            4   -7.05%
BenchmarkConvI2I                  20           19   -2.99%

test/bench/go1
benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17    5930908000   5937260000   +0.11%
BenchmarkFannkuch11      3927057000   3933556000   +0.17%
BenchmarkGobDecode         21998090     21870620   -0.58%
BenchmarkGobEncode         12725310     12734480   +0.07%
BenchmarkGzip             567617600    567892800   +0.05%
BenchmarkGunzip           178284100    178706900   +0.24%
BenchmarkJSONEncode        87693550     86794300   -1.03%
BenchmarkJSONDecode       314212600    324115000   +3.15%
BenchmarkMandelbrot200      7016640      7073766   +0.81%
BenchmarkParse              7852100      7892085   +0.51%
BenchmarkRevcomp         1285663000   1286147000   +0.04%
BenchmarkTemplate         566823800    567606200   +0.14%

I'm not entirely sure why the JSON* numbers have changed, but
eyeballing the profile suggests that it could be spending less
and more time in runtime.{new,old}stack, so it could simply be
stack-split boundary noise.

R=rsc, dave, bsiegert, dsymonds
CC=golang-dev
https://golang.org/cl/6280049

8f84328f

13 Jun, 2012 16 commits

encoding/gob: don't cache broken encoding engines. · 733ee917

Rob Pike authored Jun 13, 2012

Fixes a situation where a nested bad type would still
permit the outer type to install a working engine, leading
to inconsistent behavior.

Fixes #3273.

R=bsiegert, rsc
CC=golang-dev
https://golang.org/cl/6294067

733ee917

net/http: use index.html modtime (not directory) for If-Modified-Since · 45969825
Brad Fitzpatrick authored Jun 13, 2012
```
Thanks to Håvid Falch for finding the problem.

Fixes #3414

R=r, rsc
CC=golang-dev
https://golang.org/cl/6300081
```
45969825

strconv: extend fast parsing algorithm to ParseFloat(s, 32) · 5468d164

Rémy Oudompheng authored Jun 13, 2012

benchmark                  old ns/op    new ns/op    delta
BenchmarkAtof32Decimal           215           73  -65.72%
BenchmarkAtof32Float             233           83  -64.21%
BenchmarkAtof32FloatExp         3351          209  -93.76%
BenchmarkAtof32Random           1939          260  -86.59%

R=rsc
CC=golang-dev, remy
https://golang.org/cl/6294071

5468d164

math/big: correctly test for positive inputs in Int.GCD · 10b88888
Robert Griesemer authored Jun 13, 2012
```
Also: better GCD tests.

R=rsc
CC=golang-dev
https://golang.org/cl/6295076
```
10b88888
syscall: fix windows copyFindData · 1c4e2074
Russ Cox authored Jun 13, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6301076
```
1c4e2074
godoc: show comments in various filtered views · 8140cd91
Robert Griesemer authored Jun 13, 2012
```
Fixes #3454.

R=rsc
CC=golang-dev
https://golang.org/cl/6305069
```
8140cd91

go/ast: comment map implementation · f5f23e07

Robert Griesemer authored Jun 13, 2012

A comment map associates comments with AST nodes
and permits correct updating of the AST's comment
list when the AST is manipulated.

R=rsc
CC=golang-dev
https://golang.org/cl/6281044

f5f23e07

go/build: fix boolean negation · 503aa650

Russ Cox authored Jun 13, 2012

!(linux&cgo | darwin&cgo)
= (!linux|!cgo) & (!darwin|!cgo)
= (!linux&!darwin) | !cgo  // new comment
≠ !linux | !darwin | !cgo  // old comment

Fixes #3726.

R=golang-dev, bsiegert
CC=golang-dev
https://golang.org/cl/6306076

503aa650

runtime: improved continuity in hash computation · 51fe5444
Jan Ziak authored Jun 13, 2012
```
Fixes #3695.

R=r, dave, rsc
CC=golang-dev
https://golang.org/cl/6304062
```
51fe5444
math/big: fix binaryGCD · f4240666
Robert Griesemer authored Jun 13, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/6297085
```
f4240666
math/big: various cleanups · b7c5e23d
Robert Griesemer authored Jun 13, 2012
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/6295072
```
b7c5e23d

math/big: Implemented binary GCD algorithm · 38735b95

Christopher Swenson authored Jun 13, 2012

benchmark                    old ns/op    new ns/op    delta
BenchmarkGCD10x10                 4383         2126  -51.49%
BenchmarkGCD10x100                5612         2124  -62.15%
BenchmarkGCD10x1000               8843         2622  -70.35%
BenchmarkGCD10x10000             17025         6576  -61.37%
BenchmarkGCD10x100000           118985        48130  -59.55%
BenchmarkGCD100x100              45328        11683  -74.23%
BenchmarkGCD100x1000             50141        12678  -74.72%
BenchmarkGCD100x10000           110314        26719  -75.78%
BenchmarkGCD100x100000          630000       156041  -75.23%
BenchmarkGCD1000x1000           654809       137973  -78.93%
BenchmarkGCD1000x10000          985683       159951  -83.77%
BenchmarkGCD1000x100000        4920792       366399  -92.55%
BenchmarkGCD10000x10000       16848950      3732062  -77.85%
BenchmarkGCD10000x100000      55401500      4675876  -91.56%
BenchmarkGCD100000x100000   1126775000    258951800  -77.02%

R=gri, rsc, bradfitz, remyoudompheng, mtj
CC=golang-dev
https://golang.org/cl/6305065

38735b95

misc/emacs: Fix a failure when /tmp/<file>.go exists. · 44a3a58e
Jean-Marc Eurin authored Jun 13, 2012
```
R=sameer
CC=golang-dev
https://golang.org/cl/6296060
```
44a3a58e
CONTRIBUTORS: added Christopher Swenson (Google CLA) · bb3af755
Robert Griesemer authored Jun 13, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6302069
```
bb3af755
doc/install: mention GOPATH and point to code.html · 9115a8bc
Andrew Gerrand authored Jun 13, 2012
```
Fixes #3469.

R=golang-dev, kevlar, rsc, r
CC=golang-dev
https://golang.org/cl/6304049
```
9115a8bc

exp/html: simplify some of the parser's internal methods. · 66429dcf

Nigel Tao authored Jun 13, 2012

benchmark          old ns/op    new ns/op    delta
BenchmarkParser      4006888      3950604   -1.40%

R=r, andybalholm
CC=golang-dev
https://golang.org/cl/6301070

66429dcf

12 Jun, 2012 2 commits

math/big: optimize common case of Int.Bit(0) · 008c62b2
Robert Griesemer authored Jun 12, 2012
```
R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/6306069
```
008c62b2

encoding/gob: better handling of nil pointers · ea3c3bb3

Rob Pike authored Jun 12, 2012

- better message for top-level nil
- nil inside interface yields error, not panic

Fixes #3704.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6304064

ea3c3bb3

11 Jun, 2012 3 commits

fmt.Fscanf: don't read past newline · 2a0fdf6e

Rob Pike authored Jun 11, 2012

Makes interactive uses work line-by-line.
Fixes #3481.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/6297075

2a0fdf6e

exp/types: testing resolution of qualified identifiers · 49d6e490
Robert Griesemer authored Jun 11, 2012
```
Also: fix a bug with exp/types/GcImport.

R=rsc, r
CC=golang-dev
https://golang.org/cl/6302060
```
49d6e490

misc/emacs: Fix the automatic gofmt when creating a new file. · d608b15d

Jean-Marc Eurin authored Jun 11, 2012

Patching the buffer with the output from gofmt -d only works if
the file already exists. If it doesn't, replace the content with
the output of gofmt.

R=sameer
CC=golang-dev
https://golang.org/cl/6302063

d608b15d

10 Jun, 2012 1 commit
- encoding/gob: fix doc typo · 1d609f9b
  Brad Fitzpatrick authored Jun 10, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6300078
```
  1d609f9b
08 Jun, 2012 2 commits

runtime: use uintptr where possible in malloc stats · 0b09425b

Dave Cheney authored Jun 08, 2012

linux/arm OMAP4 pandaboard

benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17   68723297000  37026214000  -46.12%
BenchmarkFannkuch11     34962402000  35958435000   +2.85%
BenchmarkGobDecode        137298600    124182150   -9.55%
BenchmarkGobEncode         60717160     60006700   -1.17%
BenchmarkGzip            5647156000   5550873000   -1.70%
BenchmarkGunzip          1196350000   1198670000   +0.19%
BenchmarkJSONEncode       863012800    782898000   -9.28%
BenchmarkJSONDecode      3312989000   2781800000  -16.03%
BenchmarkMandelbrot200     45727540     45703120   -0.05%
BenchmarkParse             74781800     59990840  -19.78%
BenchmarkRevcomp          140043650    139462300   -0.42%
BenchmarkTemplate        6467682000   5832153000   -9.83%

benchmark                  old MB/s     new MB/s  speedup
BenchmarkGobDecode             5.59         6.18    1.11x
BenchmarkGobEncode            12.64        12.79    1.01x
BenchmarkGzip                  3.44         3.50    1.02x
BenchmarkGunzip               16.22        16.19    1.00x
BenchmarkJSONEncode            2.25         2.48    1.10x
BenchmarkJSONDecode            0.59         0.70    1.19x
BenchmarkParse                 0.77         0.97    1.26x
BenchmarkRevcomp              18.15        18.23    1.00x
BenchmarkTemplate              0.30         0.33    1.10x

darwin/386 core duo

benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17   10591616577   9678245733   -8.62%
BenchmarkFannkuch11     10758473315  10749303846   -0.09%
BenchmarkGobDecode         34379785     34121250   -0.75%
BenchmarkGobEncode         23523721     23475750   -0.20%
BenchmarkGzip            2486191492   2446539568   -1.59%
BenchmarkGunzip           444179328    444250293   +0.02%
BenchmarkJSONEncode       221138507    219757826   -0.62%
BenchmarkJSONDecode      1056034428   1048975133   -0.67%
BenchmarkMandelbrot200     19862516     19868346   +0.03%
BenchmarkRevcomp         3742610872   3724821662   -0.48%
BenchmarkTemplate         960283112    944791517   -1.61%

benchmark                  old MB/s     new MB/s  speedup
BenchmarkGobDecode            22.33        22.49    1.01x
BenchmarkGobEncode            32.63        32.69    1.00x
BenchmarkGzip                  7.80         7.93    1.02x
BenchmarkGunzip               43.69        43.68    1.00x
BenchmarkJSONEncode            8.77         8.83    1.01x
BenchmarkJSONDecode            1.84         1.85    1.01x
BenchmarkRevcomp              67.91        68.24    1.00x
BenchmarkTemplate              2.02         2.05    1.01x

R=rsc, 0xe2.0x9a.0x9b, mirtchovski
CC=golang-dev, minux.ma
https://golang.org/cl/6297047

0b09425b

math/big: added nat.trailingZeroBits, simplified some code · 014d036d
Robert Griesemer authored Jun 08, 2012
```
Will simplify implementation of binaryGCD.

R=rsc, cswenson
CC=golang-dev
https://golang.org/cl/6299064
```
014d036d