Commits · 5ddc6bd84d44639f7775abf2ba9606b684dc8f53 · go / golang

13 Dec, 2013 6 commits

test: match gccgo error messages · 5ddc6bd8

Ian Lance Taylor authored Dec 13, 2013

fixedbugs/issue4510.dir/f2.go:7: error: 'fmt' defined as both imported name and global name
f1.go:7: note: 'fmt' imported here

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/41530044

5ddc6bd8

test: match gccgo error messages · 161a45af

Ian Lance Taylor authored Dec 13, 2013

const1.go:33: error: integer constant overflow
<similar errors omitted>
const1.go:64: error: division by zero
const1.go:67: error: floating point constant overflow
const1.go:68: error: floating point constant overflow
const1.go:69: error: floating point constant overflow
const1.go:70: error: division by zero
const1.go:71: error: expected integer type
const1.go:77: error: argument 1 has incompatible type (cannot use type int8 as type int)
const1.go:78: error: argument 1 has incompatible type (cannot use type int8 as type int)
const1.go:79: error: argument 1 has incompatible type (cannot use type uint8 as type int)
const1.go:81: error: argument 1 has incompatible type (cannot use type float32 as type int)
const1.go:82: error: argument 1 has incompatible type (cannot use type float64 as type int)
const1.go:83: error: floating point constant truncated to integer
const1.go:85: error: argument 1 has incompatible type (cannot use type float64 as type int)
const1.go:86: error: argument 1 has incompatible type (cannot use type string as type int)
const1.go:87: error: argument 1 has incompatible type (cannot use type bool as type int)
const1.go:90: error: const initializer cannot be nil
const1.go:91: error: expression is not constant
const1.go:92: error: expression is not constant
const1.go:93: error: invalid constant type
const1.go:94: error: invalid constant type
fixedbugs/bug462.go:17: error: unknown field 'os.File' in 'T'
fixedbugs/issue3705.go:9: error: cannot declare init - must be func
fixedbugs/issue4251.go:12: error: inverted slice range
fixedbugs/issue4251.go:16: error: inverted slice range
fixedbugs/issue4251.go:20: error: inverted slice range
fixedbugs/issue4405.go:11: error: invalid character 0x7 in identifier
fixedbugs/issue4405.go:12: error: invalid character 0x8 in identifier
fixedbugs/issue4405.go:13: error: invalid character 0xb in identifier
fixedbugs/issue4405.go:14: error: invalid character 0xc in identifier
fixedbugs/issue4429.go:15: error: expected pointer
fixedbugs/issue4517d.go:9: error: cannot import package as init
fixedbugs/issue4545.go:17: error: invalid context-determined non-integer type for left operand of shift
fixedbugs/issue4545.go:16: error: incompatible types in binary expression
fixedbugs/issue4610.go:15: error: expected ';' or '}' or newline
fixedbugs/issue4610.go:16: error: expected declaration
fixedbugs/issue4654.go:15: error: value computed is not used
<similar errors omitted>
fixedbugs/issue4776.go:9: error: program must start with package clause
fixedbugs/issue4776.go:9: error: expected ';' or newline after package clause
fixedbugs/issue4813.go:31: error: index must be integer
<similar errors omitted>
fixedbugs/issue4847.go:22: error: initialization expression for 'matchAny' depends upon itself
fixedbugs/issue5089.go:13: error: redefinition of 'bufio.Buffered': receiver name changed
fixedbugs/issue5089.go:11: note: previous definition of 'bufio.Buffered' was here
fixedbugs/issue5172.go:17: error: reference to undefined field or method 'bar'
fixedbugs/issue5172.go:18: error: reference to undefined field or method 'bar'
fixedbugs/issue5172.go:12: error: use of undefined type 'bar'
fixedbugs/issue5358.go:16: error: argument 2 has incompatible type
fixedbugs/issue5581.go:29: error: use of undefined type 'Blah'
funcdup.go:10: error: redefinition of 'i'
funcdup.go:10: note: previous definition of 'i' was here
<similar errors omitted>
funcdup2.go:10: error: redefinition of 'i'
funcdup2.go:10: note: previous definition of 'i' was here
<similar errors omitted>
slice3err.go:20: error: middle index required in 3-index slice
<similar errors omitted>
slice3err.go:20: error: final index required in 3-index slice
<similar errors omitted>
slice3err.go:21: error: final index required in 3-index slice
slice3err.go:46: error: invalid 3-index slice of string
<similar errors omitted>
slice3err.go:57: error: inverted slice range
<similar errors omitted>
slice3err.go:62: error: invalid slice index: capacity less than length
slice3err.go:64: error: invalid slice index: capacity less than start
slice3err.go:65: error: invalid slice index: capacity less than start
slice3err.go:66: error: invalid slice index: capacity less than start
slice3err.go:68: error: invalid slice index: capacity less than length
slice3err.go:70: error: invalid slice index: capacity less than start
slice3err.go:80: error: invalid slice index: capacity less than length
slice3err.go:82: error: invalid slice index: capacity less than start
slice3err.go:83: error: invalid slice index: capacity less than start
slice3err.go:84: error: invalid slice index: capacity less than start
slice3err.go:86: error: invalid slice index: capacity less than length
slice3err.go:88: error: invalid slice index: capacity less than start
slice3err.go:99: error: array index out of bounds
<similar errors omitted>
slice3err.go:106: error: invalid slice index: capacity less than length
slice3err.go:107: error: invalid slice index: capacity less than start
slice3err.go:118: error: invalid slice index: capacity less than length
slice3err.go:119: error: invalid slice index: capacity less than start
syntax/semi1.go:10: error: missing '{' after if clause
syntax/semi1.go:10: error: reference to undefined name 'x'
syntax/semi1.go:10: error: reference to undefined name 'y'
syntax/semi1.go:12: error: reference to undefined name 'z'
syntax/semi2.go:10: error: missing '{' after switch clause
syntax/semi2.go:10: error: reference to undefined name 'x'
syntax/semi3.go:10: error: missing '{' after for clause
syntax/semi3.go:10: error: reference to undefined name 'x'
syntax/semi3.go:10: error: reference to undefined name 'y'
syntax/semi3.go:10: error: reference to undefined name 'z'
syntax/semi3.go:12: error: reference to undefined name 'z'
syntax/semi4.go:11: error: missing '{' after for clause
syntax/semi4.go:10: error: reference to undefined name 'x'
syntax/semi4.go:12: error: reference to undefined name 'z'
typecheck.go:12: error: reference to undefined name 'b'
typecheck.go:17: error: reference to undefined name 'c'
typecheck.go:11: error: use of undefined type 'b'
typecheck.go:16: error: not enough arguments
typecheck.go:17: error: not enough arguments

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/41520044

161a45af

test: add []rune case to string_lit.go · 936665f6

Ian Lance Taylor authored Dec 13, 2013

Gccgo managed to get this case wrong.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/41490044

936665f6

test: adjust issue4618 for gccgo allocation behaviour · bbf76258
Ian Lance Taylor authored Dec 13, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/41550044
```
bbf76258
test: disable large type/stack frame tests for gccgo · 3ddd2eae
Ian Lance Taylor authored Dec 13, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/40370052
```
3ddd2eae
test: disable a couple of precise GC tests for gccgo · d12b08d2
Ian Lance Taylor authored Dec 13, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/41610043
```
d12b08d2

12 Dec, 2013 10 commits

doc: add Go 1.2 to release history page · e8a1de72
Andrew Gerrand authored Dec 12, 2013
```
Fixes #6939.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/41540043
```
e8a1de72
crypto/rc4: fix type errors in pure Go implementation · 9394629b
Richard Musiol authored Dec 12, 2013
```
R=golang-dev, agl
CC=golang-dev
https://golang.org/cl/40540049
```
9394629b

crypto/sha1: Optimise FUNC1 with alternate formulation · 107d1829

Nick Craig-Wood authored Dec 12, 2013

According to Wikipedia: http://en.wikipedia.org/wiki/SHA-1
there is an alternate formulation for the FUNC1 transform,
namely

f1 = d xor (b and (c xor d))

instead of

f1 = (b and c) or ((not b) and d)

This reduces the instruction count of FUNC1 from 6 to 4 and
makes about 5% speed improvement on amd64 and suprisingly 17%
on 386.

amd64 Intel(R) Core(TM) i7 CPU Q 820 @ 1.73GHz:

benchmark              old ns/op    new ns/op    delta
BenchmarkHash8Bytes          506          499   -1.38%
BenchmarkHash1K             3099         2961   -4.45%
BenchmarkHash8K            22292        21243   -4.71%

benchmark               old MB/s     new MB/s  speedup
BenchmarkHash8Bytes        15.80        16.00    1.01x
BenchmarkHash1K           330.40       345.82    1.05x
BenchmarkHash8K           367.48       385.63    1.05x

i386 Intel(R) Core(TM) i7 CPU Q 820 @ 1.73GHz:

benchmark              old ns/op    new ns/op    delta
BenchmarkHash8Bytes          647          615   -4.95%
BenchmarkHash1K             3673         3161  -13.94%
BenchmarkHash8K            26141        22374  -14.41%

benchmark               old MB/s     new MB/s  speedup
BenchmarkHash8Bytes        12.35        13.01    1.05x
BenchmarkHash1K           278.74       323.94    1.16x
BenchmarkHash8K           313.37       366.13    1.17x

The improvements on an Intel(R) Core(TM) i7-4770K CPU @
3.50GHz were almost identical.

R=golang-dev, r, hanwen
CC=golang-dev, rsc
https://golang.org/cl/19910043

107d1829

image: add RGB and RGB48 · e5902fc7
ChaiShushan authored Dec 12, 2013
```
R=golang-dev, r, nigeltao
CC=golang-dev
https://golang.org/cl/13239051
```
e5902fc7
doc/go1.3.txt: first checkins: makerelease, liblink · 0d624e18
Rob Pike authored Dec 12, 2013
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/40650047
```
0d624e18

crypto/cipher: speed up gcmInc32. · b2a198ce

Han-Wen Nienhuys authored Dec 12, 2013

The counter is not secret, so the code does not need to be
constant time.

benchmark                    old MB/s     new MB/s  speedup
BenchmarkAESGCMSeal1K           89.90        92.84    1.03x
BenchmarkAESGCMOpen1K           89.16        92.30    1.04x

R=agl
CC=golang-dev
https://golang.org/cl/40690046

b2a198ce

fmt: Fix signed zero-padding for positive floats · 5ad5b7a5

Felix Geisendörfer authored Dec 12, 2013

Space padding still has the same issue, I will send a separate patch for that
if this one gets accepted.
Fixes #6856.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/35660043

5ad5b7a5

A+C: Felix Geisendörfer (individual CLA) · 1d08fc44
Rob Pike authored Dec 12, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/40870048
```
1d08fc44

net, text/tabwriter: use cap arg to make · 563d0b62

Josh Bleecher Snyder authored Dec 12, 2013

Changes generated by:

gofmt -w -r 'make(a, b)[0:0] -> make(a, 0, b)' src/pkg

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/24820045

563d0b62

net: don't leave hostsPath unrestored on error in TestLookupStaticHost · cf51702b

Josh Bleecher Snyder authored Dec 12, 2013

If the return was reached, then hostsPath would not be properly restored
to its original value. See the (lengthy) discussion at
https://golang.org/cl/15960047/

I assume that this is not for Go 1.2; mailing now since I promised to do so.
I will plan to ping once Go 1.2 is out.

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/16200043

cf51702b

11 Dec, 2013 6 commits

crypto/x509: fix typo in comment. · 2f43ce7f
Adam Langley authored Dec 11, 2013
```
Fixes #6633.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/40720046
```
2f43ce7f

crypto/cipher: speed up xor operations in CBC, CFB, OBF, CTR · 5744be9f

Han-Wen Nienhuys authored Dec 11, 2013

and GCM on 386 and amd64

Intel(R) Core(TM) i5-2540M CPU @ 2.60GHz:

benchmark                    old MB/s     new MB/s  speedup
BenchmarkAESGCMSeal1K           82.39        92.05    1.12x
BenchmarkAESGCMOpen1K           82.28        91.88    1.12x
BenchmarkAESCFBEncrypt1K       141.54       277.59    1.96x
BenchmarkAESCFBDecrypt1K       133.06       278.07    2.09x
BenchmarkAESOFB1K              160.51       380.24    2.37x
BenchmarkAESCTR1K              164.07       429.25    2.62x
BenchmarkAESCBCEncrypt1K       170.99       263.74    1.54x
BenchmarkAESCBCDecrypt1K       124.96       249.14    1.99x

Fixes #6741.

R=agl, dave, agl
CC=golang-dev
https://golang.org/cl/24250044

5744be9f

cmd/5a, cmd/6a, cmd/8a: fix .y files to match y.tab.[ch] · 426b48a7

Russ Cox authored Dec 11, 2013

When I renamed LAddr back to Addr (before sending the
original linker CLs), I missed the .y files in my global substitute.
Since the .y files are only processed when running make in
one of those directories (not during all.bash), they were
behind the generated files.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/40770044

426b48a7

crypto/sha256: block implementation in amd64 assembly · 75800a9a

Joel Sing authored Dec 11, 2013

Benchmark on Intel(R) Xeon(R) CPU X5650  @ 2.67GHz

benchmark              old ns/op    new ns/op    delta
BenchmarkHash8Bytes         1259          677  -46.23%
BenchmarkHash1K            14387         6749  -53.09%
BenchmarkHash8K           106006        50107  -52.73%

benchmark               old MB/s     new MB/s  speedup
BenchmarkHash8Bytes         6.35        11.81    1.86x
BenchmarkHash1K            71.17       151.72    2.13x
BenchmarkHash8K            77.28       163.49    2.12x

R=agl
CC=golang-dev
https://golang.org/cl/28460043

75800a9a

net/http: document that body is closed after (*Request).Write. · 77fe6bef
Shenghou Ma authored Dec 11, 2013
```
Fixes #6911.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/38690043
```
77fe6bef

misc/dist: rename to makerelease · dba08e06

Andrew Gerrand authored Dec 11, 2013

The ambiguity has gone on too long.

R=golang-dev, minux.ma, r, dsymonds
CC=golang-dev
https://golang.org/cl/39920043

dba08e06

10 Dec, 2013 18 commits

doc/effective_go.html: close some tags. · b349477e
Oling Cat authored Dec 10, 2013
```
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/37700043
```
b349477e

test: don't rely on order of unrelated imports in bug191 · 6ae37805

Ian Lance Taylor authored Dec 10, 2013

There is no necessary relationship between the imports of the
packages a and b, and gccgo happens to import them in a
different order, leading to different output.  This ordering
is not the purpose of the test in any case.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/40400043

6ae37805

runtime: remove outdated comment and related indentation · c69402d8
Carl Shapiro authored Dec 10, 2013
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/39810043
```
c69402d8

crypto/x509: fix behaviour of KeyUsageAny. · ddbad5ef

Adam Langley authored Dec 10, 2013

(Reporter wasn't able to provide a certificate chain that uses this
feature for testing.)

Fixes #6831

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/40340043

ddbad5ef

test/run: make -v output look like go test output · de8549df

Russ Cox authored Dec 10, 2013

Among other things, it makes it easier to scan to
see what is slow.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/40040044

de8549df

test: add some test cases that were miscompiled by gccgo · 9bea6f3b
Ian Lance Taylor authored Dec 10, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/40310043
```
9bea6f3b
liblink, cmd/gc: fix incompatible type signatures on Plan 9 · 4321beba
David du Colombier authored Dec 10, 2013
```
R=ality, golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/39640043
```
4321beba

syscall: skip routing messages with mismatched version · 517e49eb

Joel Sing authored Dec 10, 2013

Skip routing messages with a mismatched version, rather than failing
and returning EINVAL. Only return EINVAL if we were unable to parse
any of the routing messages (presumably due to a version mismatch).

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/30340043

517e49eb

database/sql: Remove redundant condition in if · c8869e9c

Alberto García Hierro authored Dec 10, 2013

The final condition (db.maxIdleConnsLocked() > db.freeConn.Len()) can
only be true iff db.maxIdleConnsLocked() is greater than 0, so previously
checking if it's greater than 0 is a waste, specially when that involves
a method call which (ATM) can't be inlined and includes a switch.

Dissasembly follows (test for err == nil has been omitted for clarity):

Before:
43c357: cmp    $0x0,%bl
43c35a: jne    43c3ce <database/sql.(*DB).putConnDBLocked+0x1ce>
43c35c: mov    %rax,(%rsp)
43c360: callq  43aec0 <database/sql.(*DB).maxIdleConnsLocked>
43c365: mov    0x8(%rsp),%rbx
43c36a: cmp    $0x0,%rbx
43c36e: jle    43c3ce <database/sql.(*DB).putConnDBLocked+0x1ce>
43c370: mov    0x30(%rsp),%rbx
43c375: mov    %rbx,(%rsp)
43c379: callq  43aec0 <database/sql.(*DB).maxIdleConnsLocked>
43c37e: mov    0x30(%rsp),%rdx
43c383: mov    0x8(%rsp),%rcx
43c388: mov    0x28(%rdx),%rbp
43c38c: mov    0x28(%rbp),%rbx
43c390: cmp    %rcx,%rbx
43c393: jge    43c3ce <database/sql.(*DB).putConnDBLocked+0x1ce>
43c395: mov    0x28(%rdx),%rbp
43c399: mov    %rbp,(%rsp)
43c39d: mov    0x38(%rsp),%rcx
43c3a2: mov    $0x556c60,%eax
43c3a7: mov    %rax,0x8(%rsp)
43c3ac: mov    %rcx,0x10(%rsp)
43c3b1: callq  4db5b0 <container/list.(*List).PushFront>

After:
43c357: cmp    $0x0,%bl
43c35a: jne    43c3b5 <database/sql.(*DB).putConnDBLocked+0x1b5>
43c35c: mov    %rax,(%rsp)
43c360: callq  43aec0 <database/sql.(*DB).maxIdleConnsLocked>
43c365: mov    0x30(%rsp),%rdx
43c36a: mov    0x8(%rsp),%rcx
43c36f: mov    0x28(%rdx),%rbp
43c373: mov    0x28(%rbp),%rbx
43c377: cmp    %rcx,%rbx
43c37a: jge    43c3b5 <database/sql.(*DB).putConnDBLocked+0x1b5>
43c37c: mov    0x28(%rdx),%rbp
43c380: mov    %rbp,(%rsp)
43c384: mov    0x38(%rsp),%rcx
43c389: mov    $0x556c60,%eax
43c38e: mov    %rax,0x8(%rsp)
43c393: mov    %rcx,0x10(%rsp)
43c398: callq  4db590 <container/list.(*List).PushFront>

R=golang-dev, bradfitz, iant
CC=golang-dev
https://golang.org/cl/14656044

c8869e9c

net: fix nits found by go tool vet · e5a7ab85
Mikio Hara authored Dec 10, 2013
```
R=golang-dev, dave, adg
CC=golang-dev
https://golang.org/cl/27430043
```
e5a7ab85

os: fix build. · a4b66b77

Shenghou Ma authored Dec 10, 2013

CL 36800043 and CL 36930044 have a merge conflict that I overlooked.

R=golang-dev
CC=golang-dev
https://golang.org/cl/39850043

a4b66b77

crypto/rand: support generation of 2-5 bit primes, also document the error return for Prime · 4f2cfdc7
Shenghou Ma authored Dec 10, 2013
```
Fixes #6849.
Fixes #6867.

R=golang-dev, agl
CC=golang-dev
https://golang.org/cl/35870043
```
4f2cfdc7

os: clarify docs for Rename. · aa0ae755

Shenghou Ma authored Dec 10, 2013

Three changes:
1. mention "move" to clarify things up.
2. use {old,new}path instead of {old,new}name, which makes it clear what
   relative path would do here.
3. mention "OS-specific restrictions might apply".

Fixes #6887.

R=golang-dev, alex.brainman, iant, r
CC=golang-dev
https://golang.org/cl/36930044

aa0ae755

strconv: add example for Unquote. · 46d1461a
Shenghou Ma authored Dec 10, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/38920043
```
46d1461a

runtime: check for signed zero in printfloat · f574726f

Carl Shapiro authored Dec 10, 2013

Fixes #6899

R=golang-dev, r, cshapiro, iant, rsc
CC=golang-dev
https://golang.org/cl/38120043

f574726f

misc/cgo/testcdefs: rm correct file in test.bash · 6ede9349
Alex Brainman authored Dec 10, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/39780043
```
6ede9349

cmd/pack: stop parsing object files to generate __.SYMDEF · 4c01a23c

Russ Cox authored Dec 10, 2013

Nothing looks at __.SYMDEF, and the object file format is changing.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/39580044

4c01a23c

runtime: remove non-extern decls of runtime.goarm · 4230044b

Russ Cox authored Dec 10, 2013

The linker is in charge of providing the one true declaration.

R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/39560043

4230044b