Commits · 6044dbdf1b627fc1f30422add87216137b709bae · go / golang

03 Jul, 2012 8 commits

reflect: reflect.Zero results are neither addressable nor settable · 6044dbdf

Robert Griesemer authored Jul 03, 2012

This could be deduced from "The Laws of Reflection" but it seems
worthwhile highlighting it.

R=r
CC=golang-dev
https://golang.org/cl/6350073

6044dbdf

math/rand: avoid use of math.Pow in tests. · 1a0a09da

Rémy Oudompheng authored Jul 03, 2012

The use of math.Pow for mere squaring can be extremely
slow on soft-float ARM. Even on systems with hardware
floating-point, a speedup in test duration is observed.

On amd64
Before: ok      math/rand       2.009s
After:  ok      math/rand       0.340s

Fixes #3740.

R=dave, golang-dev, r, r
CC=golang-dev
https://golang.org/cl/6348061

1a0a09da

net/http: clean up fs tests a bit · 55cc1ff7

Brad Fitzpatrick authored Jul 03, 2012

And fix some govet-caught format arg issues.

R=r
CC=golang-dev
https://golang.org/cl/6354068

55cc1ff7

encoding/gob: fix bug in Register · b04bf388

Rob Pike authored Jul 03, 2012

The old code added a star but did not indirect the reflect.Type.

R=bradfitz
CC=golang-dev
https://golang.org/cl/6348067

b04bf388

doc/debugging_with_gdb: mention how to disable gc optimization · d9c4cef6
Shenghou Ma authored Jul 03, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6353055
```
d9c4cef6

syscall: fix FreeBSD 386 sendfile · 7b6541a5

David G. Andersen authored Jul 03, 2012

The previous version was not handling an off_t (64 bit)
parameter on 32 bit i386 systems.  This patch splits sendfile
into two implementations in their respective arch-specific files.
Tested on FreeBSD amd64 and i386.

R=bradfitz
CC=golang-dev
https://golang.org/cl/6356048

7b6541a5

runtime: refactor proc.c · a0c68833

Dmitriy Vyukov authored Jul 03, 2012

1. Rename 'g' and 'm' local vars to 'gp' and 'mp' (convention already used in some functions)
'g' and 'm' are global vars that mean current goroutine and current machine,
when they are shadowed by local vars, it's confusing, no ability to debug log both, etc.
2. White-space shuffling.
No semantic changes.
In preparation to bigger changes.

R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/6355061

a0c68833

syscall: use 32 bits structure for Getrlimit/Setrlimit on 386/ARM. · 8b7d39e7
Han-Wen Nienhuys authored Jul 03, 2012
```
Fixes #2492

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/6295073
```
8b7d39e7

02 Jul, 2012 6 commits

cmd/gc: cache itab lookup in convT2I. · 18e86644

Nigel Tao authored Jul 02, 2012

There may be further savings if convT2I can avoid the function call
if the cache is good and T is uintptr-shaped, a la convT2E, but that
will be a follow-up CL.

src/pkg/runtime:
benchmark                  old ns/op    new ns/op    delta
BenchmarkConvT2ISmall             43           15  -64.01%
BenchmarkConvT2IUintptr           45           14  -67.48%
BenchmarkConvT2ILarge            130          101  -22.31%

test/bench/go1:
benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17    8588997000   8499058000   -1.05%
BenchmarkFannkuch11      5300392000   5358093000   +1.09%
BenchmarkGobDecode         30295580     31040190   +2.46%
BenchmarkGobEncode         18102070     17675650   -2.36%
BenchmarkGzip             774191400    771591400   -0.34%
BenchmarkGunzip           245915100    247464100   +0.63%
BenchmarkJSONEncode       123577000    121423050   -1.74%
BenchmarkJSONDecode       451969800    596256200  +31.92%
BenchmarkMandelbrot200     10060050     10072880   +0.13%
BenchmarkParse             10989840     11037710   +0.44%
BenchmarkRevcomp         1782666000   1716864000   -3.69%
BenchmarkTemplate         798286600    723234400   -9.40%

R=rsc, bradfitz, go.peter.90, daniel.morsing, dave, uriel
CC=golang-dev
https://golang.org/cl/6337058

18e86644

math/big: Remove unnecessary test from nat.go multiplication · 917f7643

David G. Andersen authored Jul 02, 2012

The switch at the beginning of the function already ensures n > 1,
so testing for n < 2 is redundant.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/6350051

917f7643

reflect: set GOMAXPROCS=1 in the malloc test · 21de1ab3

Dmitriy Vyukov authored Jul 02, 2012

Occasionally I see:
--- FAIL: TestAllocations-15 (0.00 seconds)
        all_test.go:1575: 6 mallocs after 100 iterations
Tested:
$ go test -cpu=1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20 reflect

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/6354063

21de1ab3

net/http: fix comment · 804e562a
Dmitriy Vyukov authored Jul 02, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6348062
```
804e562a

image: fix doc typo · 435a001d

Shenghou Ma authored Jul 02, 2012

     Fixes #3789.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6357058

435a001d

cmd/gc: add missing case for OCOM in defaultlit() · a732cbb5
Shenghou Ma authored Jul 02, 2012
```
        Fixes #3765.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6349064
```
a732cbb5

01 Jul, 2012 2 commits

test: enforce 1 proc in the test · 91e56e64

Dmitriy Vyukov authored Jul 01, 2012

otherwise it fails spuriously with "newfunc allocated unexpectedly" message
when run with GOMAXPROCS>1 (other goroutine allocates).

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6347056

91e56e64

runtime: add freemcache() function · ed516df4

Dmitriy Vyukov authored Jul 01, 2012

It will be required for scheduler that maintains
GOMAXPROCS MCache's.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6350062

ed516df4

30 Jun, 2012 6 commits

cmd/go: httpGet function does not use global variable httpClient · 35030a99
Amir Mohammad Saied authored Jun 30, 2012
```
No change, just for consistency.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6346048
```
35030a99
net/http: ignore malicious or dumb Range requests · f06b12f0
Brad Fitzpatrick authored Jun 30, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6356050
```
f06b12f0

api: update next.txt · ccbac5a4

Brad Fitzpatrick authored Jun 30, 2012

Some accumulated changes from the past few weeks.

Just cleans up all.bash output.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6354056

ccbac5a4

cmd/dist: Make windows.c's fatal() print to stderr · 735780c2

Pieter Droogendijk authored Jun 30, 2012

Generating env.bat using dist env -wp > env.bat failed silently
if case of an error, because the message was redirected to env.bat.
Verbose messages still go to stdout, causing problems, but that's
a seperate change.
Made errprintf() identical to xprintf(), except for the output handle.
Yes, it's duplicate code, but most of the function is unpacking
the argument list and preparing it for WriteFile(), which has to be
done anyway.

R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/6343047

735780c2

path/filepath: avoid allocation in Clean of cleaned path even on windows (fix build) · c644a4dd
Alex Brainman authored Jun 30, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6344049
```
c644a4dd

cmd/cgo: generate definitions for GoSlice · 33d2b495

Shenghou Ma authored Jun 30, 2012

        Fixes #3741.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6308076

33d2b495

29 Jun, 2012 2 commits

misc/emacs: Fix the gofmt patching when the TMPDIR is not the default. · 11cafa3a

Jean-Marc Eurin authored Jun 29, 2012

The previous code assumed the gofmt output referred to /tmp but
that's not true if TMPDIR points somewhere else (like on Macs).
Fixes #3782.

R=sameer
CC=golang-dev
https://golang.org/cl/6346050

11cafa3a

net/http: support multiple byte ranges in ServeContent · fa6f9b4a
Brad Fitzpatrick authored Jun 29, 2012
```
Fixes #3784

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6351052
```
fa6f9b4a

28 Jun, 2012 4 commits

net/http: Fix a verb-tense mismatch and a typo in documentation. · 4c3dc1ba
Andrey Mirtchovski authored Jun 28, 2012
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/6357049
```
4c3dc1ba
go/parser: minor internal cleanups · 72a2abf8
Robert Griesemer authored Jun 28, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6356046
```
72a2abf8

go spec: clean up section on selectors · 71de83b7

Robert Griesemer authored Jun 28, 2012

- point out difference between selectors and qualified identifiers
- differentiate between illegal selectors and run-time panics
- use "indirect" as opposed to "dereference" consistently
- add extra links

Fixes #3779.

R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/6326059

71de83b7

path/filepath: add test case for rooted ".." · 8907f94a
Han-Wen Nienhuys authored Jun 28, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6350047
```
8907f94a

27 Jun, 2012 7 commits

syscall: add missing argument type · 8357dc90

Joe Poirier authored Jun 27, 2012

And update implementation location comment.

R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/6352046

8357dc90

image/jpeg: support for reading 4:4:0 subsampling. · b6cc39d0
Mathieu Lonjaret authored Jun 27, 2012
```
Updates #2362.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6326057
```
b6cc39d0
runtime: fix string optimization · 71643b2f
Russ Cox authored Jun 27, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6354048
```
71643b2f
runtime: avoid allocation for "" + x + "" · 8744d35d
Russ Cox authored Jun 27, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6359043
```
8744d35d
net: fix build (FreeBSD sendfile) · f009fefd
Russ Cox authored Jun 27, 2012
```
TBR=bradfitz
CC=golang-dev
https://golang.org/cl/6358043
```
f009fefd

path/filepath: avoid allocation in Clean of cleaned path · 9525372e

Russ Cox authored Jun 27, 2012

Alternative to https://golang.org/cl/6330044.

Fixes #3681.

R=golang-dev, r, hanwen, iant
CC=golang-dev
https://golang.org/cl/6335056

9525372e

runtime: add goroutine creation benchmark · 5a5e698c

Dmitriy Vyukov authored Jun 27, 2012

Current results on 2 core darwin/amd64:
BenchmarkGoroutineChain		351 ns/op
BenchmarkGoroutineChain-2	3840 ns/op
BenchmarkGoroutineChain-4	4040 ns/op
BenchmarkConcGoroutineChain	350 ns/op
BenchmarkConcGoroutineChain-2	875 ns/op
BenchmarkConcGoroutineChain-4	2027 ns/op

R=r, rsc
CC=golang-dev
https://golang.org/cl/6332054

5a5e698c

26 Jun, 2012 5 commits

go spec: clean up use of QualifiedIdent production. · 809e06ba
Robert Griesemer authored Jun 26, 2012
```
Fixes #3763.

R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/6333066
```
809e06ba

syscall: fix build · 596762e9

Russ Cox authored Jun 26, 2012

I missed the API change in the last FreeBSD CL, but the tool caught it.

TBR=bradfitz
CC=golang-dev
https://golang.org/cl/6331063

596762e9

net/http: provide access to POST-only form values · abb3c061
Patrick Mylund Nielsen authored Jun 26, 2012
```
Fixes #3630.

R=rsc
CC=bradfitz, dsymonds, golang-dev, rodrigo.moraes
https://golang.org/cl/6210067
```
abb3c061

syscall, net: sendfile for FreeBSD · a9a8d7b5

L Campbell authored Jun 26, 2012

R=golang-dev, rsc, bradfitz, devon.odell
CC=golang-dev
https://golang.org/cl/6221054

a9a8d7b5

A+C: L Campbell (individual CLA) · ab148887

Russ Cox authored Jun 26, 2012

Guess I was wrong about being done for the day.

R=golang-dev, r
CC=golang-dev, unpantsu
https://golang.org/cl/6325060

ab148887