Commits · 60abc6b577895e88f8e029772ff27f9e6917d23b · go / golang

11 Jan, 2013 3 commits

encoding/json: improve performance of Unmarshal on primitive types · 60abc6b5

Rick Arnold authored Jan 11, 2013

Skip most of the scanning and parsing logic for simple (non-object/array) JSON values.

benchmark                   old ns/op    new ns/op    delta
BenchmarkUnmarshalInt             948          436  -54.01%
BenchmarkUnmarshalUint            930          427  -54.09%
BenchmarkUnmarshalString         1407          715  -49.18%
BenchmarkUnmarshalFloat          1114          536  -51.89%
BenchmarkUnmarshalBool            759          266  -64.95%
BenchmarkUnmarshalStruct         8165         8181   +0.20%

No significant effects on the go1 benchmarks:

benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17    9647362752   9596196417   -0.53%
BenchmarkFannkuch11      5623613048   5518694872   -1.87%
BenchmarkGobDecode         32944041     33165434   +0.67%
BenchmarkGobEncode         21237482     21080554   -0.74%
BenchmarkGzip             750955920    749861980   -0.15%
BenchmarkGunzip           197369742    197886192   +0.26%
BenchmarkJSONEncode        79274091     78891137   -0.48%
BenchmarkJSONDecode       180257802    175280358   -2.76%
BenchmarkMandelbrot200      7396666      7388266   -0.11%
BenchmarkParse             11446460     11386550   -0.52%
BenchmarkRevcomp         1605152523   1599512029   -0.35%
BenchmarkTemplate         204538247    207765574   +1.58%

benchmark                  old MB/s     new MB/s  speedup
BenchmarkGobDecode            23.30        23.14    0.99x
BenchmarkGobEncode            36.14        36.41    1.01x
BenchmarkGzip                 25.84        25.88    1.00x
BenchmarkGunzip               98.32        98.06    1.00x
BenchmarkJSONEncode           24.48        24.60    1.00x
BenchmarkJSONDecode           10.76        11.07    1.03x
BenchmarkParse                 5.06         5.09    1.01x
BenchmarkRevcomp             158.34       158.90    1.00x
BenchmarkTemplate              9.49         9.34    0.98x

Fixes #3949.

R=golang-dev, dave, bradfitz, timo
CC=golang-dev
https://golang.org/cl/7068043

60abc6b5

net: use windows ConnectEx to dial (when possible) · 810e4398
Alex Brainman authored Jan 11, 2013
```
Update #2631.
Update #3097.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7061060
```
810e4398
syscall: implement Pipe2 on Linux and use it in ForkExec · e32d1154
Georg Reinke authored Jan 11, 2013
```
Fixes #2656.

R=golang-dev, bradfitz, iant, minux.ma
CC=golang-dev
https://golang.org/cl/7062057
```
e32d1154

10 Jan, 2013 6 commits

runtime: work around 5c bug in GC code. · 6e981c18

Rémy Oudompheng authored Jan 10, 2013

5c miscompiles *p++ = struct_literal.

R=dave, golang-dev
CC=golang-dev
https://golang.org/cl/7065069

6e981c18

runtime: interpret type information during garbage collection · 9204eb4d
Jan Ziak authored Jan 10, 2013
```
R=rsc, dvyukov, remyoudompheng, dave, minux.ma, bradfitz
CC=golang-dev
https://golang.org/cl/6945069
```
9204eb4d
A+C: Georg Reinke (individual CLA) · dd1c3714
Ian Lance Taylor authored Jan 10, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/7057067
```
dd1c3714

runtime: faster segmented stacks · 7847f328

Dmitriy Vyukov authored Jan 10, 2013

benchmark                      old ns/op    new ns/op    delta
BenchmarkStackGrowth                 665          548  -17.59%
BenchmarkStackGrowth-2               333          274  -17.72%
BenchmarkStackGrowth-4               224          168  -25.00%
BenchmarkStackGrowth-8               124           91  -26.21%
BenchmarkStackGrowth-16               82           70  -14.55%
BenchmarkStackGrowth-32               73           59  -19.49%

R=nigeltao, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/7026044

7847f328

runtime: less aggressive per-thread stack segment caching · f82db7d9

Dmitriy Vyukov authored Jan 10, 2013

Introduce global stack segment cache and limit per-thread cache size.
This greatly reduces StackSys memory on workloads that create lots of threads.

benchmark                      old ns/op    new ns/op    delta
BenchmarkStackGrowth                 665          656   -1.35%
BenchmarkStackGrowth-2               333          328   -1.50%
BenchmarkStackGrowth-4               224          172  -23.21%
BenchmarkStackGrowth-8               124           91  -26.13%
BenchmarkStackGrowth-16               82           47  -41.94%
BenchmarkStackGrowth-32               73           40  -44.79%

BenchmarkStackGrowthDeep           97231        94391   -2.92%
BenchmarkStackGrowthDeep-2         47230        58562  +23.99%
BenchmarkStackGrowthDeep-4         24993        49356  +97.48%
BenchmarkStackGrowthDeep-8         15105        30072  +99.09%
BenchmarkStackGrowthDeep-16        10005        15623  +56.15%
BenchmarkStackGrowthDeep-32        12517        13069   +4.41%

TestStackMem#1,MB                  310          12       -96.13%
TestStackMem#2,MB                  296          14       -95.27%
TestStackMem#3,MB                  479          14       -97.08%

TestStackMem#1,sec                 3.22         2.26     -29.81%
TestStackMem#2,sec                 2.43         2.15     -11.52%
TestStackMem#3,sec                 2.50         2.38      -4.80%

R=sougou, no.smile.face, rsc
CC=golang-dev, msolomon
https://golang.org/cl/7029044

f82db7d9

doc/contribute: Link to IssueTracker docs for more "special sentences" · 7d403871
Matthew Dempsky authored Jan 10, 2013
```
Update #4582.

R=nigeltao, dave, adg
CC=golang-dev
https://golang.org/cl/7070065
```
7d403871

09 Jan, 2013 15 commits

cmd/cgo: for gccgo: use intgo, don't use slice as void return type · eee3dd12
Ian Lance Taylor authored Jan 09, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7057064
```
eee3dd12
container/list: avoid memory leaks · ecb75486
Robert Griesemer authored Jan 09, 2013
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/7065067
```
ecb75486

cmd/ld: fix incompatible type signatures on Plan 9 · 74c03cb8

Anthony Martin authored Jan 09, 2013

Changeset f483bfe81114 moved ELF generation to the architecture
independent code and in doing so added a Section* to the Sym
type and an Elf64_Shdr* to the Section type.

This caused the Plan 9 compilers to complain about incompatible
type signatures in the many files that reference the Sym type.

R=rsc, dave
CC=golang-dev
https://golang.org/cl/7057058

74c03cb8

cmd/go: remove $GOROOT as a go get target · 593d8b0c

Dave Cheney authored Jan 09, 2013

Fixes #4186.

Back in the day, before the Go 1.0 release, $GOROOT was mandatory for building from source. Fast forward to now and $GOPATH is mandatory and $GOROOT is optional, and mainly used by those who use the binary distribution in uncommon places.

For example, most novices at least know about `sudo` as they would have used it to install the binary tarball into /usr/local. It is logical they would use the `sudo` hammer to `go get` other Go packages when faced with a permission error talking about the path they just had to use `sudo` on last time.

Even if they had read the documentation and set $GOPATH, go get will not work as expected as `sudo` masks most environment variables.

llucky(~) % ~/go/bin/go env | grep GOPATH
GOPATH="/home/dfc"
lucky(~) % sudo ~/go/bin/go env | grep GOPATH
GOPATH=""

This CL therefore proposes to remove support for using `go get` to download source into $GOROOT.

This CL also proposes an error when GOPATH=$GOROOT, as this is another place where new Go users can get stuck.

Further discussion: https://groups.google.com/d/topic/golang-nuts/VIg3fjHiHRI/discussion

R=rsc, adg, minux.ma
CC=golang-dev
https://golang.org/cl/6941058

593d8b0c

cmd/go: get -m options from GOARCH when using gccgo · 5ca4f5e4
Ian Lance Taylor authored Jan 09, 2013
```
R=golang-dev, bradfitz, minux.ma
CC=golang-dev
https://golang.org/cl/7057063
```
5ca4f5e4
go/types: don't parse imported packages multiple times. · e0bf0374
Rémy Oudompheng authored Jan 09, 2013
```
R=dave, golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7068044
```
e0bf0374

cmd/gc: add space to export data to match linker expectations · 8fff2525

Rémy Oudompheng authored Jan 09, 2013

The linker split PKGDEF into (prefix, name, def) pairs,
and defines def to begin after a space following the identifier.
This is totally wrong for the following export data:

        func "".FunctionName()
        var SomethingCompletelyUnrelated int

The linker would parse
    name=`"".FunctionName()\n\tvar`
    def=`SomethingCompletelyUnrelated int`
since there is no space after FunctionName.

R=minux.ma, rsc
CC=golang-dev
https://golang.org/cl/7068051

8fff2525

cmd/dist: drop unneeded clang flags · 4ba27df6

Dave Cheney authored Jan 09, 2013

Our source no longer needs these flags set to build cleanly using clang.

Tested with

* Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0) on i386
* clang version 3.2 (tags/RELEASE_32/final) on amd64 cross compiling all platforms

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7058053

4ba27df6

go/printer, gofmt: don't print unneeded parentheses around parameter types · 0141c92a
Robert Griesemer authored Jan 09, 2013
```
Fixes #4624.

R=rsc
CC=golang-dev
https://golang.org/cl/7058052
```
0141c92a
go/parser: better error message for declaration error · 82accf44
Robert Griesemer authored Jan 09, 2013
```
Fixes #4616.

R=rsc
CC=golang-dev
https://golang.org/cl/7069049
```
82accf44
spec: clarify short variable declaration corner cases · f1cc0f44
Robert Griesemer authored Jan 09, 2013
```
Fixes #4612.

R=rsc, iant, ken, r
CC=golang-dev
https://golang.org/cl/7076043
```
f1cc0f44
utf8: fix typo. · be36ab33
Andrey Mirtchovski authored Jan 09, 2013
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/7063056
```
be36ab33

net/http: don't buffer request writing if dest is already buffered · f38df4e8

Brad Fitzpatrick authored Jan 09, 2013

The old code made it impossible to implement a reverse proxy
with anything less than 4k write granularity to the backends.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/7060059

f38df4e8

doc: Mention godoc's handling of example functions. · a6e4aa3e
Matthew Dempsky authored Jan 09, 2013
```
Fixes #4625.

R=iant, adg
CC=golang-dev
https://golang.org/cl/7064052
```
a6e4aa3e
misc/emacs: update go-mode syntax table and comment handling as · f14f4586
Sameer Ajmani authored Jan 09, 2013
```
suggested by pkleiweg.

Fixes #3471.

R=adonovan, pkleiweg, rsc
CC=golang-dev
https://golang.org/cl/7060056
```
f14f4586

08 Jan, 2013 7 commits
- go/types: "inherit" type in constant declarations w/o initialization expressions (bug fix) · 65cb1904
  Robert Griesemer authored Jan 08, 2013
```
R=adonovan
CC=golang-dev
https://golang.org/cl/7060054
```
  65cb1904
- all: use io.ByteWriter now that it exists · 89a7c87e
  Brad Fitzpatrick authored Jan 08, 2013
```
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/7079043
```
  89a7c87e
- doc/articles/go_command: remove an extra word. · bc776f6c
  Oling Cat authored Jan 08, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7061051
```
  bc776f6c
- net/http/cgi: make it work without REQUEST_URI environment variable · 548e5878
  Alex Brainman authored Jan 08, 2013
```
Fixes #4367.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7062052
```
  548e5878
- cmd/vet: fix doc typo. · f7320bf8
  Jason Travis authored Jan 08, 2013
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/7061050
```
  f7320bf8
- A+C: Jason Travis (individual CLA) · 02f7049b
  David Symonds authored Jan 08, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/7064054
```
  02f7049b
- spec: s/char_lit/rune_lit/ · c863db4e
  Robert Griesemer authored Jan 08, 2013
```
The spec talks explicitly about rune literals but the
respective production is still called char_lit for
historic reasons. Updated the two occurences.

Fixes #4602.

R=rsc, iant, r, ken
CC=golang-dev
https://golang.org/cl/7070048
```
  c863db4e
07 Jan, 2013 9 commits

cmd/gc: fix uintptr(nil) issues. · fba96e91

Rémy Oudompheng authored Jan 07, 2013

A constant node of type uintptr with a nil literal could
happen in two cases: []int(nil)[1:] and
uintptr(unsafe.Pointer(nil)).

Fixes #4614.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7059043

fba96e91

cmd/go: use filepath.SplitList when inspecting GOPATH · 77c34332

Dave Cheney authored Jan 07, 2013

There exists a test case for this condition, but it only runs on unix systems, which neatly dovetails into the code always using ':' as the list separator.

R=adg, iant
CC=golang-dev
https://golang.org/cl/7057052

77c34332

go/doc: recursively inspect selector expressions · 60544b69

Andrew Gerrand authored Jan 07, 2013

Also adds a couple of simple tests for doc.Examples.

Fixes #4561.

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/7067048

60544b69

image/jpeg: handle those (unusual) grayscale images whose sampling · 30ff0636

Nigel Tao authored Jan 07, 2013

ratio isn't 1x1.

Fixes #4259.

The test data was generated by
cjpeg -quality 50 -sample 2x2 video-005.gray.pgm > video-005.gray.q50.2x2.jpeg
cjpeg -quality 50 -sample 2x2 -progressive video-005.gray.pgm > video-005.gray.q50.2x2.progressive.jpeg

similarly to video-005.gray.q50.* from
http://code.google.com/p/go/source/detail?r=51f26e36ba98
the key difference being the "-sample 2x2".

R=rsc
CC=golang-dev
https://golang.org/cl/7069045

30ff0636

cmd/vet: %#q is a valid format (uses raw quotes). · 86aad668
David Symonds authored Jan 07, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7057051
```
86aad668

cmd/gc, cmd/ld: rename -b to -race · a091d2e6

Russ Cox authored Jan 07, 2013

There's no b in race detector.
The new flag matches the one in the go command
(go test -race math).

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/7072043

a091d2e6

os: document that Exit does not run deferred calls · 0f64a6ef
Andrew Gerrand authored Jan 07, 2013
```
Fixes #4101.

R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/7065048
```
0f64a6ef

doc: two minor edits to contribute.html · 41f32e0d

Caleb Spare authored Jan 07, 2013

- Missing parenthesis
- Fix bad phrasing

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7063048

41f32e0d

bytes: Fix missing godoc punctuation. · 2e24a737
Matthew Dempsky authored Jan 07, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7067047
```
2e24a737