Commits · 69a91663d25df694ec3a85d32b77c37444f1dac6 · go / golang

10 May, 2011 2 commits

runtime: add newline to "finalizer already set" error · 69a91663
Albert Strasheim authored May 10, 2011
```
R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/4523047
```
69a91663

image/jpeg: speed up decoding by inlining the clip function and · 4c1e1b81

Nigel Tao authored May 10, 2011

writing the idct result directly to the image buffer instead of
storing it in an intermediate d.blocks field.

Writing to d.blocks was necessary when decoding to an image.RGBA image,
but now that we decode to a ycbcr.YCbCr we can write each component
directly to the image buffer.

Crude "time ./6.out" scores to decode a specific 2592x1944 JPEG 20
times show a 16% speed-up:

BEFORE

user	0m10.410s
user	0m10.400s
user	0m10.480s
user	0m10.480s
user	0m10.460s

AFTER

user	0m9.050s
user	0m9.050s
user	0m9.050s
user	0m9.070s
user	0m9.020s

R=r
CC=golang-dev
https://golang.org/cl/4523052

4c1e1b81

09 May, 2011 4 commits

go/printer, gofmt: fix alignment of "=" in const/var declarations · 499ad944
Robert Griesemer authored May 09, 2011
```
gofmt -w src misc

Fixes #1414.

R=rsc, r
CC=golang-dev
https://golang.org/cl/4456054
```
499ad944

go/parser: always introduce an ast.Object when declaring an identifier · 447db23c

Robert Griesemer authored May 09, 2011

When traversing parameter lists (e.g. for type checking), we want the
invariant that all identifers have associated objects (even _ idents),
so that we can associate a type with each object.

R=rsc
CC=golang-dev
https://golang.org/cl/4490042

447db23c

gif: fix build · 45ea5874

Rob Pike authored May 09, 2011

Had bit test wrong on transparency; no excuses.

R=nigeltao
CC=golang-dev
https://golang.org/cl/4526044

45ea5874

image/gif: implement transparency. · a54dca83

Rob Pike authored May 09, 2011

At least, as I understand it. The spec is unclear about what happens
with a local color map.

R=nigeltao, r2
CC=golang-dev
https://golang.org/cl/4515045

a54dca83

08 May, 2011 6 commits

go spec: fix up HTML glitches. · 38d7bcf5
Rob Pike authored May 08, 2011
```
Fixes #1786.

R=gri, adg
CC=golang-dev
https://golang.org/cl/4517043
```
38d7bcf5
effective go: update to new Open signature. · 121b428a
Rob Pike authored May 08, 2011
```
Fixes #1788.

R=rsc, adg
CC=golang-dev
https://golang.org/cl/4519042
```
121b428a
syscall: change Overlapped.HEvent type, it is a handle · 8bf15158
Alex Brainman authored May 08, 2011
```
R=golang-dev, r, r2
CC=golang-dev
https://golang.org/cl/4471046
```
8bf15158

syscall: fix bug in mksyscall_windows.pl · b191155a

Alex Brainman authored May 08, 2011

This change fixes generation of "shadow" variables for bool parameters.
Before the change, it was naming all bool variables with the same name of _p0.
Now it calls them _p0, _p1, ... So the code could compile.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4479047

b191155a

image/gif: GIF decoder · 92834d35

Rob Pike authored May 08, 2011

It's incomplete but sufficient to decode 8-bit GIFs without interlacing
or transparency.   More to come.

I'll put in more tests as the feature set grows.

R=nigeltao, r2
CC=golang-dev
https://golang.org/cl/4522041

92834d35

compress/lzw: silently drop implied codes that are too large, · f467803d

Nigel Tao authored May 08, 2011

instead of returning an error.

For example, http://www.w3.org/Graphics/GIF/spec-gif89a.txt
explicitly says that GIF encoders can use a full table as is,
without needing to send a clear code.

R=r, dsymonds, nigeltao_gnome, r2
CC=golang-dev
https://golang.org/cl/4518041

f467803d

07 May, 2011 2 commits
- gob: Doc typo fix · a4dee3a7
  Anschel Schaffer-Cohen authored May 07, 2011
```
Fixes #1785.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4496042
```
  a4dee3a7
- windows: reset command var to sh for correct error output messages · 733fde58
  Joe Poirier authored May 07, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4492043
```
  733fde58
06 May, 2011 5 commits
- cgo: put CFLAGS before filename argument · 1dc914bc
  Roger Peppe authored May 06, 2011
```
This means that the -x flag can work, which could enable
support for other languages (e.g. objective-C).

R=iant, rsc
CC=golang-dev
https://golang.org/cl/4476049
```
  1dc914bc
- doc: remove left and right padding in H2 headings. · be99859d
  Dmitry Chestnykh authored May 06, 2011
```
R=adg, rsc1, rsc
CC=golang-dev
https://golang.org/cl/4491041
```
  be99859d
- runtime: handle out-of-threads on Linux gracefully · 0629354b
  Albert Strasheim authored May 06, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4396050
```
  0629354b
- http: fix typo in URL.String doc comment. · 606e12f9
  David Symonds authored May 06, 2011
```
R=adg
CC=golang-dev
https://golang.org/cl/4485046
```
  606e12f9
- wingui: fix Makefile after rename · 8253edcb
  Alex Brainman authored May 06, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4477046
```
  8253edcb
05 May, 2011 6 commits

crypto/tls: export the verified chains. · ffd55045

Adam Langley authored May 05, 2011

The verified chains are the chains that were actually verified.

R=bradfitz
CC=golang-dev
https://golang.org/cl/4462046

ffd55045

crypto/x509: export raw SubjectPublicKeyInfo. · e1bf165b

Adam Langley authored May 05, 2011

The SPKI will probably be used for identifying public keys in future
HSTS specs.

R=bradfitz
CC=golang-dev
https://golang.org/cl/4485044

e1bf165b

image: make AlphaColor.Set conform to usual signature · da39008a
Roger Peppe authored May 05, 2011
```
R=nigeltao, r
CC=golang-dev
https://golang.org/cl/4471045
```
da39008a
go spec: newlines cannot be used inside a char or "" string literal · 0e8032ca
Robert Griesemer authored May 05, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4462043
```
0e8032ca

image/tiff: implement a decoder. · d97b8a81

Benny Siegert authored May 05, 2011

The current iteration can decode 8-bit images in
grayscale, paletted, RGB, RGBA and NRGBA mode. LZW compression
is implemented but does not work on my test images.
Deflate (i.e. zlib) compression with or without a horizontal
predictor is supported.

R=nigeltao, nigeltao_gnome
CC=golang-dev, mpl
https://golang.org/cl/4240051

d97b8a81

image/png: support encoding of paletted images with alpha channel. · 737e96c7

Dmitry Chestnykh authored May 05, 2011

Encoder now writes tRNS chunk for non-opaque paletted images.
CL includes new test images (basn3a08-trns.[ps]ng).

R=nigeltao, rsc, r
CC=golang-dev
https://golang.org/cl/4432078

737e96c7

04 May, 2011 7 commits

http/spdy: add type to FlagClearPreviouslyPersistedSettings constant · bcf3bfe2
Ross Light authored May 04, 2011
```
R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/4436074
```
bcf3bfe2

exp/draw: fast paths for drawing a YCbCr or an NRGBA onto an RGBA. · 13f08cd8

Nigel Tao authored May 04, 2011

On my laptop, I had an 800x600 jpeg and an 800x600 png (with
transparency). I timed how long it took to draw each image onto an
equivalently sized, zeroed RGBA image.

Previously, the jpeg took 75ms and the png took 70ms, going through
the medium-fast path, i.e. func drawRGBA in draw.go.

After this CL, the jpeg took 14ms, and the png took 21ms with the
Over operator and 12ms with the Src operator.

It's only a rough estimate basd on one image file, but it should
give an idea of the order of magnitude of improvement.

R=rsc, r
CC=adg, golang-dev
https://golang.org/cl/4468044

13f08cd8

tag release.r57.1 · e31272aa
Russ Cox authored May 04, 2011
```
R=adg
CC=golang-dev
https://golang.org/cl/4468043
```
e31272aa
doc: document r57.1 · f0bcb6dd
Russ Cox authored May 04, 2011
```
R=adg
CC=golang-dev
https://golang.org/cl/4471041
```
f0bcb6dd
http: fix FormFile nil pointer dereference on missing multipart form · 73f4b847
Andrew Gerrand authored May 04, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4463042
```
73f4b847
net: disable dnsmsg_test on windows · 684e065d
Alex Brainman authored May 04, 2011
```
R=golang-dev, bradfitzwork
CC=golang-dev
https://golang.org/cl/4466041
```
684e065d
make.bash: remove old bash version of gotest on Windows · 37dca9d4
Alex Brainman authored May 04, 2011
```
The file is called gotest.exe now.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4444090
```
37dca9d4

03 May, 2011 8 commits

http: improve a test · 4b30d7ce

Brad Fitzpatrick authored May 03, 2011

Should prevent failures on slow machines, such as:
http://godashboard.appspot.com/log/47b5cae591b7ad8908704e327f3b9b41945d7d5fecfc0c8c945d5545ece1a813

Verified the change (on a fast machine) by removing the
existing sleep, in which case the race happens ~50% of the
time with GOMAXPROCS > 1, but recovers gracefully with
retries.

R=rsc
CC=golang-dev
https://golang.org/cl/4441089

4b30d7ce

tag release.r57 step 2 · 54422c77
Russ Cox authored May 03, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4431088
```
54422c77
tag release.r57 · 8ace46c6
Russ Cox authored May 03, 2011
```
R=r, r2
CC=golang-dev
https://golang.org/cl/4435083
```
8ace46c6

doc: release.r57 · d6dd80b6

Russ Cox authored May 03, 2011

R=golang-dev, r, adg, r2
CC=golang-dev
https://golang.org/cl/4457049

d6dd80b6

gofmt: update test.sh (exclude a file w/ incorrect syntax) · e49d50e2
Robert Griesemer authored May 03, 2011
```
R=iant, iant2
CC=golang-dev
https://golang.org/cl/4453058
```
e49d50e2

codereview: add release branch support · 35a37f17

Russ Cox authored May 03, 2011

Note that if you are working on the upcoming release
branch you have to point your extension path to a
copy of lib/codereview/codereview.py that won't change
as the repository flips between release-branch and default branch.
This warning should only apply to this one branch and only to rsc,
but you never know.

R=adg
CC=golang-dev
https://golang.org/cl/4446076

35a37f17

reflect: allow unexported key in Value.MapIndex · 86e6a441
Russ Cox authored May 03, 2011
```
Fixes #1748.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4444087
```
86e6a441
net: don't crash on unexpected DNS SRV responses · 8ef56f7e
Brad Fitzpatrick authored May 03, 2011
```
Fixes #1350

R=rsc, bradfitzwork
CC=golang-dev
https://golang.org/cl/4432089
```
8ef56f7e