Commits · 6c7acdfbdbfd5c8a3b60d6b796041257360a19c3 · go / golang

22 Jul, 2015 1 commit

doc: add a clause about embedded methods to go1compat · 6c7acdfb

Rob Pike authored Jul 21, 2015

This is a corner case but it is suggested we call it out.

Fixes #11798.

Change-Id: I2ddb5b363cd2921666dbf03bbf98107697ca40e5
Reviewed-on: https://go-review.googlesource.com/12460Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

6c7acdfb

21 Jul, 2015 13 commits

cmd/dist: remove prints during test registration · fc7f6d30

Brad Fitzpatrick authored Jul 21, 2015

dist test should not print (especially to stdout) during test
registration.  This confuses other tools interacting with dist using
dist test --list, etc.

Change-Id: Ie4f82c13e49590c23a7a235d90ddbc4f5ed81e0b
Reviewed-on: https://go-review.googlesource.com/12487Reviewed-by: Ian Lance Taylor <iant@golang.org>

fc7f6d30

cmd/go: fix typo in comment · c97b4997

Ian Lance Taylor authored Jul 21, 2015

Change-Id: I3d5e46d376953fbdd21ce8c161214eaed6378d84
Reviewed-on: https://go-review.googlesource.com/12490Reviewed-by: Andrew Gerrand <adg@golang.org>

c97b4997

cmd/go: pass an unmodified environment to a go run program · 419a6c07

Ian Lance Taylor authored Jul 21, 2015

Fixes #11709.
Fixed #11449.

Change-Id: If8fdb27d3dc25fb7017226d143a29cbebc1374c5
Reviewed-on: https://go-review.googlesource.com/12483Reviewed-by: David Crawshaw <crawshaw@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

419a6c07

go/types: make types.Typ a slice, unexport UniverseByte/Rune · 0505dfc6

Robert Griesemer authored Jul 21, 2015

In lieu of the more invasive https://go-review.googlesource.com/#/c/12373/ .

Change-Id: I0221783fcaa8af04520c80cd2993d7d542d2c431
Reviewed-on: https://go-review.googlesource.com/12486Reviewed-by: Alan Donovan <adonovan@google.com>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

0505dfc6

cmd/go: skip TestGoInstallErrorOnCrossCompileToBin in short mode · 72921c66

Ian Lance Taylor authored Jul 21, 2015

That test will install cmd/pack for linux_386; we don't want to change
GOROOT in short mode.

Change-Id: I4b00c578a99779a13c558208bfd4115f8f0513fa
Reviewed-on: https://go-review.googlesource.com/12481
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

72921c66

misc/cgo/testsovar: needs the `extern` keyword to export variables on non-windows platforms · 2e38b351

Ingo Krabbe authored Jul 21, 2015

Change-Id: I87fa25214fbf24469148a63f4e1e61e261105c16
Reviewed-on: https://go-review.googlesource.com/12470
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

2e38b351

cmd/link: if -B option was used, pass it to the external linker · e9fcd6ed

Ian Lance Taylor authored Jul 15, 2015

Fixes #10607.

Change-Id: Ib294cf65b07103b60f62b86b21ff2d07b25136fe
Reviewed-on: https://go-review.googlesource.com/12242Reviewed-by: Russ Cox <rsc@golang.org>

e9fcd6ed

doc: add missing preposition in go1.5.html · aee4f42a

Brad Fitzpatrick authored Jul 21, 2015

Change-Id: I2f855b9ad1676b3c4efedd764ce99e21c104a4ec
Reviewed-on: https://go-review.googlesource.com/12446Reviewed-by: Rob Pike <r@golang.org>

aee4f42a

doc/go1.5.html: update the net.Dial release notes. · abf943aa

Paul Marks authored Jul 17, 2015

Change-Id: Ie02426b2b726170d858de96fdd8c51bfdf20d7dc
Reviewed-on: https://go-review.googlesource.com/12376Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

abf943aa

api: add go1.5.txt API file, reset next.txt · 852f383c

Brad Fitzpatrick authored Jul 17, 2015

Fixes #11752

Change-Id: If4196b4bbba4f1485608bfafa98fa54781177273
Reviewed-on: https://go-review.googlesource.com/12325Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

852f383c

doc: remove mention of default GOMAXPROCS(1) in Effective Go · aa5118b1

Brad Fitzpatrick authored Jul 18, 2015

Fixes #11781

Change-Id: Idc46a6a4fb5bf1c4d394eadf2d860d7ef75c8ccf
Reviewed-on: https://go-review.googlesource.com/12390Reviewed-by: Rob Pike <r@golang.org>

aa5118b1

syscall: warn not to use FormatMessage · 7ebcf5ea

Alex Brainman authored Jul 13, 2015

Fixes #11147

Change-Id: Ib31160946a53f6f9b11daea211ff04d186b51b3f
Reviewed-on: https://go-review.googlesource.com/12067Reviewed-by: Ian Lance Taylor <iant@golang.org>

7ebcf5ea

go/internal/gccgoimporter: fix handling of "byte" and "rune" alias types · af8297da

Matthew Dempsky authored Jul 21, 2015

Fixes #11762.

Change-Id: I0c7797a2dfdbbcf137bb287f854037a4a697c6e4
Reviewed-on: https://go-review.googlesource.com/12443Reviewed-by: Robert Griesemer <gri@golang.org>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>

af8297da

20 Jul, 2015 10 commits

doc: document net/http.Request.Cancel in go1.5.html · e28ff1f3

Brad Fitzpatrick authored Jul 20, 2015

Change-Id: If1c12b43ef467c3ef2cbbaaba1bda4ea98032c7e
Reviewed-on: https://go-review.googlesource.com/12430Reviewed-by: Rob Pike <r@golang.org>

e28ff1f3

doc: add crypto/sha512 additions to go1.5.html · 1b5eaa43

Brad Fitzpatrick authored Jul 20, 2015

Change-Id: I805bb7ba40c8ed579c4ca796e408995586d219b3
Reviewed-on: https://go-review.googlesource.com/12434Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Rob Pike <r@golang.org>

1b5eaa43

go/types: remove non-existing mention of MethodSetCache from comment · 3051ab2c

Robert Griesemer authored Jul 20, 2015

Fixes #11800.

Change-Id: I5eb178331f4ae80821f188e19c0c6fadeb330278
Reviewed-on: https://go-review.googlesource.com/12433Reviewed-by: Alan Donovan <adonovan@google.com>

3051ab2c

cmd/dist: increase timeout for standard tests · 1a0818a4

Ian Lance Taylor authored Jul 20, 2015

The cmd/go tests run too long on a Raspberry Pi.  I've cut times as
much as I can see without more serious steps like not running tests.

Fixes #11779.

Change-Id: Ice5da052902decea2e6ac32d0f2ce084c39ea1ab
Reviewed-on: https://go-review.googlesource.com/12368
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

1a0818a4

cmd/go: build errors rather than fmt in a couple of tests · 510f1dba

Ian Lance Taylor authored Jul 20, 2015

The errors package is smaller and builds faster.

Update #11779.

Change-Id: Iaf2d43734ec4b0aa325590eb5d38522306b608cb
Reviewed-on: https://go-review.googlesource.com/12366Reviewed-by: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

510f1dba

cmd/go: build errors rather than strings in some tests · b9a3e597

Ian Lance Taylor authored Jul 20, 2015

Speed up the test suite by building the errors package rather than the
strings package in some cases where the specific package we are
building doesn't matter.  The errors package is smaller, and doesn't
have any assembler code.

Also make a couple of tests run in parallel.

Update #11779.

Change-Id: I62e47f8655f9d85bf93c70ae6e6121276d96aee0
Reviewed-on: https://go-review.googlesource.com/12365
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

b9a3e597

cmd/go: don't run TestInstalls in short mode · f35868a4

Ian Lance Taylor authored Jul 20, 2015

It changes GOROOT, so we shouldn't run it in short mode.  Also, it's
fairly slow.

Update #11779.

Change-Id: I3d3344954cf9b2ac70070c878a67cb65ac8fd85c
Reviewed-on: https://go-review.googlesource.com/12364
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>

f35868a4

cmd/go: rewrite TestNoteReading to use test harness · f7e7719f

Ian Lance Taylor authored Jul 20, 2015

On my laptop reduces time required for test from 22 seconds to 0.14
seconds.

Update #11779.

Change-Id: I715d85bd9c6f7683c6915eedd2539813aa5efc58
Reviewed-on: https://go-review.googlesource.com/12363Reviewed-by: David Crawshaw <crawshaw@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>

f7e7719f

cmd/compile: define func value symbols at declaration · 1125cd49

Michael Hudson-Doyle authored Jul 14, 2015

This is mostly Russ's https://golang.org/cl/12145 but with some extra fixes to
account for the fact that function declarations without implementations now
break shared libraries, and including my test case.

Fixes #11480.

Change-Id: Iabdc2934a0378e5025e4e7affadb535eaef2c8f1
Reviewed-on: https://go-review.googlesource.com/12340Reviewed-by: Ian Lance Taylor <iant@golang.org>

1125cd49

net/http: add example for setting trailers in an Handler · 4db07463

Brad Fitzpatrick authored Jul 17, 2015

Change-Id: I6a8bb853a538c80d95589321d3226784bc017eef
Reviewed-on: https://go-review.googlesource.com/12327Reviewed-by: Andrew Gerrand <adg@golang.org>

4db07463

19 Jul, 2015 1 commit

runtime: clarify runtime.GC blocking behavior · 1942e381

Austin Clements authored Jul 19, 2015

The runtime.GC documentation was rewritten in df2809f0 to make it clear
that it blocks until GC is complete, but the re-rewrite in ed9a4c91 and
e28a6792 lost this property when clarifying that it may also block the
entire program and not just the caller.

Try to arrive at wording that conveys both of these properties.

Change-Id: I1e255322aa28a21a548556ecf2a44d8d8ac524ef
Reviewed-on: https://go-review.googlesource.com/12392Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Rob Pike <r@golang.org>

1942e381

18 Jul, 2015 9 commits

runtime: check for findmoduledatap returning nil · 692054e7

Ian Lance Taylor authored Jul 18, 2015

The findmoduledatap function will not return nil in ordinary use, but
check for nil to try to avoid crashing when we are already crashing.

Update #11783.

Change-Id: If7b1adb51efab13b4c1a37b6f3c9ad22641a0b56
Reviewed-on: https://go-review.googlesource.com/12391
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

692054e7

internal/trace: fix fuzzer crashers · e1ee3140

Dmitry Vyukov authored Jul 18, 2015

Fixes #11766
Fixes #11769
Fixes #11767
Fixes #11770

Change-Id: I441382af58f60deb46dcdd70076763b2c47738d4
Reviewed-on: https://go-review.googlesource.com/12378Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Dmitry Vyukov <dvyukov@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

e1ee3140

bufio: Remove unneeded error initialization · c4bfd2de

Silvan Jegen authored Jan 13, 2015

The default value for error is nil so there is no need to assign this
value here.

Change-Id: I4714ef7607996ccbf91b704390e1d1d39ee3847b
Reviewed-on: https://go-review.googlesource.com/12355Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

c4bfd2de

cmd/compile: ignore carriage return in magic comments · dabb2681

Ian Lance Taylor authored Jul 18, 2015

Update #11771.

Change-Id: I3bb3262619765d3ca79652817e17e8f260f41907
Reviewed-on: https://go-review.googlesource.com/12379Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

dabb2681

net: classify site-local unicast in address selection · aadd84e0

Mikio Hara authored Jul 17, 2015

This change adds site-local unicast classification for users still using
the deprecated addresses internally.

Change-Id: If50870c6d4a85fe471c002b161eec59efcebe2f4
Reviewed-on: https://go-review.googlesource.com/12344
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

aadd84e0

os: remove stuttering return value names · 90c668d1

Brad Fitzpatrick authored Jul 17, 2015

Old style. Make it compliant with our code review comments document.

Also, make WriteString's return parameter named 'n', not 'ret', for
consistency.

Noticed during another documentation review.

Change-Id: Ie88910c5841f8353bc5c0152e2168b497578e15e
Reviewed-on: https://go-review.googlesource.com/12324Reviewed-by: Rob Pike <r@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

90c668d1

runtime: skip TestReturnAfterStackGrowInCallback if gcc is not found · 4a0d9587

Alex Brainman authored Jul 18, 2015

Fixes #11754

Change-Id: Ifa423ca6eea46d1500278db290498724a9559d14
Reviewed-on: https://go-review.googlesource.com/12347Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

4a0d9587

doc: document GODEBUG=netdns=X and netcgo in go1.5.txt · 60315002

Brad Fitzpatrick authored Jul 17, 2015

Change-Id: I720aeb1511e407750617e23c4cba1edcddf745bb
Reviewed-on: https://go-review.googlesource.com/12326Reviewed-by: Rob Pike <r@golang.org>

60315002

runtime: make the GC message less committal. · e28a6792

Rob Pike authored Jul 17, 2015

We shouldn't guarantee this behavior, but suggest it's possible.

Change-Id: I4c2afb48b99be4d91537306d3337171a13c9990a
Reviewed-on: https://go-review.googlesource.com/12346Reviewed-by: David Crawshaw <crawshaw@golang.org>

e28a6792

17 Jul, 2015 6 commits

cmd/go: ignore import of "C" when fetching dependencies · c4f18d53

Ian Lance Taylor authored Jul 16, 2015

The change https://golang.org/cl/12192 changed the get code to use the
list of package imports, not the computed list of dependencies, as the
computed list could be out of date if the package changed when using
go get -u.  Computing the dependency list would skip an import of "C",
but that would still be on the package import list.  This changes the
code to skip "C" when walking the import list.

No test--the best test would be to add an import of "C" to
github.com/rsc/go-get-issue-9224-cmd for TestGoGetUpdate.

Fixes #11738.

Change-Id: Id89ddafeade2391d15688bfd142fafd67844a941
Reviewed-on: https://go-review.googlesource.com/12322
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>

c4f18d53

os: add test to ensure Rename returns *LinkError · 955c0fd2

Dave Cheney authored Jul 17, 2015

Updates #10061

CL 12353 updated the documentation for os.Rename to stipulate the function will
return errors of type *os.LinkError. This CL adds a test to ensure that the
implementations continue to obey this contract.

Change-Id: I41beb8c9d8356c737de251fdc6f652caab3ee636
Reviewed-on: https://go-review.googlesource.com/12329Reviewed-by: Ian Lance Taylor <iant@golang.org>

955c0fd2

runtime: document that GC blocks the whole program · ed9a4c91

Rob Pike authored Jul 17, 2015

No code changes. Just make it clear that runtime.GC is not concurrent.

Change-Id: I00a99ebd26402817c665c9a128978cef19f037be
Reviewed-on: https://go-review.googlesource.com/12345Reviewed-by: Dave Cheney <dave@cheney.net>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

ed9a4c91

doc: fix typo · 3549178e

Paolo Martini authored Jul 17, 2015

The document `doc/go_spec.html` uses "preceeding" instead of the word
"preceding" in one place.

Fixed another occurrence in `src/go/types/typexpr.go`.

Change-Id: Ic67f62026b5c9d002c5c5632299f14ecac8b02ae
Reviewed-on: https://go-review.googlesource.com/12354Reviewed-by: Ian Lance Taylor <iant@golang.org>

3549178e

androidtest.bash: robust cleanup in case of failure. · a81c6563

Hyang-Ah (Hana) Kim authored Jul 17, 2015

Change-Id: I69ed001bca4987e08b46a8288f6feae2aca6a142
Reviewed-on: https://go-review.googlesource.com/12380Reviewed-by: David Crawshaw <crawshaw@golang.org>

a81c6563

doc: document ios build tag for crypto/x509 · ebb67836

David Crawshaw authored Jul 16, 2015

Change-Id: I6e6d38ae347b4f5a33dff609b89785a038bc384c
Reviewed-on: https://go-review.googlesource.com/12304Reviewed-by: Andrew Gerrand <adg@golang.org>

ebb67836